tomhughes left a comment (openstreetmap/openstreetmap-website#5906)
I honestly don't know where to start with this but it seems to me that it takes
us from using a third party component with some reasonably simple configuration
to writing a vast amount of code to take over much of the work which
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5906)
I also do not like the amount of code.
But having 0-30 "wrong" day icons is ugly, too.
Perhaps this could be added upstream as an option...
On the other hand: the calendar lib has no updates since a long time... :-(
--
Repl
nertc left a comment (openstreetmap/openstreetmap-website#5987)
@tomhughes generally, users are responsible for the correctness of their
information on the web and validation of the information of others. Even now,
anyone can claim anything in the description field. If someone finds any
incorre
nertc left a comment (openstreetmap/openstreetmap-website#5439)
@tomhughes sorry for the delay on this PR. Yes, I am currently focused on this
one and will push as soon as possible.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull
wolfy1339 left a comment (openstreetmap/openstreetmap-website#5983)
I really don't know what happened, or why, but it works fine now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5983#issuecomment-2868236703
You are receiving
Closed #5983 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5983#event-17599474043
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@rkoeze pushed 1 commit.
d8423e8e10091dfe6ce9b3fd78105b92f7c23ee3 Bump ClassLength rubocop_todo
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5988/files/8fe268d7e1eaedc4b7c1028a2043b062b83ffe74..d8423e8e10091dfe6ce9b3fd78105b92f7c23ee3
You are receiving this
quinncnl left a comment (openstreetmap/openstreetmap-website#5996)
Hi @tomhughes I updated leaflet-osm. Please take a look there.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5996#issuecomment-2867989582
You are receiving this
@hlfan pushed 1 commit.
c731d72a67781d6d72f3f369a9705b58011c98d8 Style link like a underpadded button
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752/files/68fae56b9dfcaec172b282fc09c7e4521267b8ae..c731d72a67781d6d72f3f369a9705b58011c98d8
You are receiving
tomhughes left a comment (openstreetmap/openstreetmap-website#5988)
Please just update rubocop_todo for the purposes of this PR and if you want to
try and address those metrics warnings then we can do so in separate PRs.
I'm somewhat dubious about some of the class length metrics personally - su
@tomhughes commented on this pull request.
> +#
+# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z},
LaPingvino left a comment (openstreetmap/openstreetmap-website#1807)
@ppKrauss please don't, we went over this before.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1807#issuecomment-2867116409
You are receiving this because y
@1ec5 commented on this pull request.
> +#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesk
@1ec5 commented on this pull request.
> +#
+# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :mess
1ec5 left a comment (openstreetmap/openstreetmap-website#1807)
> My suggestion for next steps is to adopt the syntax `geo:$x,$y;u=$u` as a
> Latitude/Longitude input. For example, `geo:-23.55,-46.63;u=15`.
#1123 tracks accepting a geo: URI as search input.
The topic of standing up a companion w
@tomhughes requested changes on this pull request.
I think this is almost there so I'd like to get it merged.
Can you rebase it please and also give some consideration to the suggestions
@1ec5 made about additional sites and also about a more general recognition of
mastodon handles?
--
Repl
Merged #5985 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5985#event-17593348947
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5985)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5985#issuecomment-2867064751
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5997)
Not sure why the current code would fail - it should amount to the same thing
really.
If we're going to change this script then we should probably change
`script/deliver-message` and `script/update-spam-blocks` as well.
--
Re
gravitystorm left a comment (openstreetmap/openstreetmap-website#5979)
> I think, as long as API clients don't implement the new way, you can't make
> any progress on the deprecation
My original plan, fwiw, was to keep the /api/capabilities call as returning the
same response as /api/0.6/capabi
@AntonKhorev commented on this pull request.
> + :note_icon => (link_to new_note_path(:anchor => map_hash(params)),
> :title => t("javascripts.site.createnote_tooltip") do
+ tag.svg :width => 20, :height => 20, :class =>
"align-top" do
This probably looks bett
@AntonKhorev commented on this pull request.
> + :note_icon => (link_to new_note_path(:anchor => map_hash(params)),
> :title => t("javascripts.site.createnote_tooltip") do
+ tag.svg :width => 20, :height => 20, :class =>
"align-top" do
We can change the backgr
@hlfan commented on this pull request.
> + :note_icon => (link_to new_note_path(:anchor => map_hash(params)),
> :title => t("javascripts.site.createnote_tooltip") do
+ tag.svg :width => 20, :height => 20, :class =>
"align-top" do
so how about `:class => "align
@AntonKhorev commented on this pull request.
> + :note_icon => (link_to new_note_path(:anchor => map_hash(params)),
> :title => t("javascripts.site.createnote_tooltip") do
+ tag.svg :width => 20, :height => 20, :class =>
"align-top" do
It's still roughly the s
@hlfan commented on this pull request.
> + :note_icon => (link_to new_note_path(:anchor => map_hash(params)),
> :title => t("javascripts.site.createnote_tooltip") do
+ tag.svg :width => 20, :height => 20, :class =>
"align-top" do
It already doesn't look like a
@AntonKhorev commented on this pull request.
> + :note_icon => (link_to new_note_path(:anchor => map_hash(params)),
> :title => t("javascripts.site.createnote_tooltip") do
+ tag.svg :width => 20, :height => 20, :class =>
"align-top" do
If the link doesn't have
@hlfan commented on this pull request.
> + :note_icon => (link_to new_note_path(:anchor => map_hash(params)),
> :title => t("javascripts.site.createnote_tooltip") do
+ tag.svg :width => 20, :height => 20, :class =>
"align-top" do
The box was only necessary bec
ppKrauss left a comment (openstreetmap/openstreetmap-website#1807)
@erik55 You're on the right track when you say, "We just need interoperability
and standards". We also need infrastructure to demonstrate usage, enable
testing, and build an ecosystem. In this context we need to:
1. Discuss here
@AntonKhorev commented on this pull request.
> + :note_icon => (link_to new_note_path(:anchor => map_hash(params)),
> :title => t("javascripts.site.createnote_tooltip") do
+ tag.svg :width => 20, :height => 20, :class =>
"align-top" do
This changes how the ico
@vjik pushed 1 commit.
6c38e24c3d2eab65f96df0f7fd370385f7f5b979 Improve numbers format on statistics
page
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5994/files/21358c4a5e46bb859ddf55031f7d68ac2e3cfab4..6c38e24c3d2eab65f96df0f7fd370385f7f5b979
You are rece
vjik left a comment (openstreetmap/openstreetmap-website#5994)
> Can you please squash your commits into one and remove empty parentheses when
> calling `format()`?
done
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5994#issue
I tried running the statistics script because of #5994:
```
ruby script/statistics
```
and it didn't work until I made this change. `config/environment.rb`
already uses `require_relative`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstr
32 matches
Mail list logo
