HarelM left a comment (openstreetmap/openstreetmap-website#5779)
Ahh, interesting, was not aware of this endpoint...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5779#issuecomment-2813792066
You are receiving this because you a
@tomhughes commented on this pull request.
> @@ -157,7 +157,11 @@ def search_osm_nominatim_reverse
:type => object_type, :id => object_id)
end
-render :action => "results"
+respond_to do |format|
+ format.html { render :action => "results" }
+ format
hlfan left a comment (openstreetmap/openstreetmap-website#5880)
**@AntonKhorev** seems to have quite a preference for mixing multiple
languages and concerns within a single file. Take a look at this
[comment](https://github.com/openstreetmap/openstreetmap-website/pull/5352#issuecomment-24959307
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5779)
> Is there a way I can push this forward? I'd like to use this feature, so I'll
> be happy to help out. I don't mind opening a new PR with the same changes if
> that's what's needed (to solve the merge commits), but I'm not su
1ec5 left a comment (openstreetmap/openstreetmap-website#5880)
Conceivably the project could have SVGs that aren’t just paths, for example the
larger decorative image on the login screen or the occasional banner
advertisement on the homepage, in order to make it scalable or more easily
translat
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5880)
If anyone wants to edit svg paths, there are tools just for that, for example
https://github.com/Yqnn/svg-path-editor . Moving paths from one file to another
won't help you to understand their syntax.
--
Reply to this email
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5938)
Do you want both optimizing svg by micromanaging their attributes and
externalizing them *as effectively "binary" data*? How is that supposed to work
at the same time?
--
Reply to this email directly or view it on GitHub:
ht
### Description
Using a basic helper module, this PR resolves most of #5880. To fully conclude
that:
- The changeset icons should be extracted too, but the definitions should also
be put outside the list.
#5884 aims to do part of this without the helper.
- The directions sprite could benefit fr
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5924)
> selected list-group-item
Selected how? There's no selection mechanism as of right now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5924#issuecomment-2812
kcne left a comment (openstreetmap/openstreetmap-website#5882)
This would probably be useful to a portion of users using browsers supporting
this feature, and support will probably only grow from here.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openst
@nertc pushed 1 commit.
491091b70e618b5c49df7a62f28738ae658a0fa6 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/4e5217d0cae2cbc977090f60b879d8fa17016ac5..491091b70e618b5c49df7a62f28738ae658a0fa6
You are receiving this because yo
@kcne approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5882#pullrequestreview-2774929732
You are receiving this because you are subscribed to this thread.
Message ID:
___
nertc left a comment (openstreetmap/openstreetmap-website#5302)
PR was updated. Merge conflicts were resolved.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2812062046
You are receiving this because you are sub
13 matches
Mail list logo
