### Description Using a basic helper module, this PR resolves most of #5880. To fully conclude that: - The changeset icons should be extracted too, but the definitions should also be put outside the list. #5884 aims to do part of this without the helper. - The directions sprite could benefit from another method `InlineSvg.define` that is outside this PR's scope
### How has this been tested? Verifying that the local Rails output matches You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5938 -- Commit Summary -- * Add InlineSvg module * Inline search icons with helper * Inline about icons with helper * Inline welcome icons with helper * Inline more icons with helper -- File Changes -- A app/assets/icons/about/community.svg (4) A app/assets/icons/about/legal.svg (5) A app/assets/icons/about/local.svg (4) A app/assets/icons/about/open.svg (4) A app/assets/icons/about/partners.svg (5) A app/assets/icons/feed.svg (4) A app/assets/icons/new.svg (3) A app/assets/icons/search/bicycle.svg (3) A app/assets/icons/search/car.svg (3) A app/assets/icons/search/directions.svg (4) A app/assets/icons/search/foot.svg (3) A app/assets/icons/search/magnifying_glass.svg (8) A app/assets/icons/search/reverse_directions.svg (4) A app/assets/icons/welcome/check.svg (4) A app/assets/icons/welcome/cross.svg (4) A app/assets/icons/welcome/editor.svg (4) A app/assets/icons/welcome/node.svg (4) A app/assets/icons/welcome/question.svg (4) A app/assets/icons/welcome/rules.svg (4) A app/assets/icons/welcome/tag.svg (4) A app/assets/icons/welcome/way.svg (7) M app/views/diary_entries/index.html.erb (4) M app/views/layouts/_search.html.erb (31) M app/views/site/_any_questions.html.erb (5) M app/views/site/about.html.erb (33) M app/views/site/welcome.html.erb (38) M app/views/traces/index.html.erb (8) A lib/inline_svg.rb (13) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5938.patch https://github.com/openstreetmap/openstreetmap-website/pull/5938.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5938 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
