[openstreetmap/openstreetmap-website] Add message deletion warning (Issue #5891)
jidanni created an issue (openstreetmap/openstreetmap-website#5891) On https://www.openstreetmap.org/messages/outbox there are big red Delete buttons on the messages we sent. There needs to be a dialog, or mouseover at least, that says: - Warning: This message will only be deleted from your mai
Re: [openstreetmap/openstreetmap-website] Add dir=auto to user generated content (PR #3429)
@tomhughes pushed 2 commits. 33870d09dbefb0ad3302183ecdc9577e24ef6fb3 Add dir=auto to user generated content b5ed10168ac6c31d6e6d1f404d749a4a521a4020 Add dir=auto to usernames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3429/files/4c46fcbb0fc300c82333f7353
Re: [openstreetmap/openstreetmap-website] Migration run failed saying To use retry middleware with Faraday v2.0+, install `faraday-retry` gem (Issue #5845)
tomhughes left a comment (openstreetmap/openstreetmap-website#5845) I really don't believe that the second screenshot is the output of running `db:migrate` it looks more like a web page to me? Please post the full output of running `db:migrate` preferably as text rather than a screenshot. --
Re: [openstreetmap/openstreetmap-website] Deduplicate note adding instructions (PR #5870)
@hlfan pushed 1 commit. fe88593fef131392f0e2279fc7e5c9182d8aab57 Deduplicate note adding instructions -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/b3caec837df5f2a31c5d4eb982abcae938d62fb2..fe88593fef131392f0e2279fc7e5c9182d8aab57 You are receiving
Re: [openstreetmap/openstreetmap-website] Incorrect translation choice time_ago for 21 hours ago (Issue #5878)
gravitystorm left a comment (openstreetmap/openstreetmap-website#5878) > Can `%{count}` be anything other that 1 in "less than %{count} second ago"? https://github.com/rails/rails/blob/3235827585d87661942c91bc81f64f56d710f0b2/actionview/lib/action_view/helpers/date_helper.rb#L114-L116 For `:less
Re: [openstreetmap/openstreetmap-website] Enable native share if available (PR #5882)
@AntonKhorev pushed 1 commit. 0a104644208239bfccb8a3c0a952d2144fb85a42 Enable share button to do native share -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5882/files/5b50f6a6ebc3bfc4fa8a078a4d5be1ae1847d1c6..0a104644208239bfccb8a3c0a952d2144fb85a42 You are r
Re: [openstreetmap/openstreetmap-website] hyperlink the words "OpenStreetMap Blog". (Issue #5875)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5875) https://github.com/osmfoundation/osmblog-wp-theme/blob/54653549127a2f04f06971d7dfb4837df34c329b/sidebar.php#L17 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issue
[openstreetmap/openstreetmap-website] Bump eslint from 9.23.0 to 9.24.0 (PR #5890)
Bumps [eslint](https://github.com/eslint/eslint) from 9.23.0 to 9.24.0.@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5886#pullrequestreview-2744159542 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Update Gemfile (PR #5789)
Closed #5789. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5789#event-17098210229 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing
Re: [openstreetmap/openstreetmap-website] Get current locale without function (PR #5822)
hlfan left a comment (openstreetmap/openstreetmap-website#5822) Yeah, I noticed just after I created the PR. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5822#issuecomment-2737521288 You are receiving this because you are subsc
Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)
@hlfan pushed 2 commits. fb9b7fe68899306cdd4b06a13283b7289d1ae131 Update and inline markers cb0e3d3575da000e9dbbde31bc85efc7a7f66a5d Clean up old markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/efa51b2d8cbdeb180fd658fcf57fc7d44d18c603..cb0e3
Re: [openstreetmap/openstreetmap-website] Add viewbox param to Nominatim link in search results (PR #5863)
@AntonKhorev commented on this pull request. > @@ -18,9 +21,14 @@ OSM.Search = function (map) { $(".search_form").on("submit", function (e) { e.preventDefault(); $("header").addClass("closed"); -const query = $(this).find("input[name=query]").val(); -let search = "/"; -i
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
@nertc commented on this pull request. > @@ -65,6 +65,42 @@ def description protected +def truncate_html(html_doc, max_length = nil, img_length = 1000) + return html_doc if max_length.nil? + + doc = Nokogiri::HTML::DocumentFragment.parse(html_doc) + keep_or_discards =
Re: [openstreetmap/openstreetmap-website] Cannot calculate any directions in Firefox – Uncaught TypeError: OSM.i18n.currentLocale is not a function (Issue #5821)
tomhughes left a comment (openstreetmap/openstreetmap-website#5821) Ah no I can reproduce this, but it's specific to direct entry to the routing page by the looks of it. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5821#issu
[openstreetmap/openstreetmap-website] Can we avoid inlining svgs into erb templates? (Issue #5880)
gravitystorm created an issue (openstreetmap/openstreetmap-website#5880) I've seen a lot of PRs recently where we are inlining SVGs into the output html, rather than having them as sprites or standalone images. I can see the benefit of doing so, particularly for the ability to set `stroke="curr
Re: [openstreetmap/openstreetmap-website] Add dir="auto" to Markdown content for bidi (PR #5840)
tomhughes left a comment (openstreetmap/openstreetmap-website#5840) It's probably my fault as much as anything for not paying close enough attention to what the previous PR was doing. I wonder if this would this be better done with a sanitize transformer that would work on the HTML regardless o
Re: [openstreetmap/openstreetmap-website] Remove SVG symbol tags (PR #5776)
Closed #5776. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5776#event-16919338360 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
@AntonKhorev commented on this pull request. > @@ -65,6 +65,42 @@ def description protected +def truncate_html(html_doc, max_length = nil, img_length = 1000) + return html_doc if max_length.nil? + + doc = Nokogiri::HTML::DocumentFragment.parse(html_doc) + keep_or_disc
Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)
@hlfan pushed 2 commits. 65505f7749c224a47d9b1ce61b72e86faab46e38 Update and inline markers 20e655b294bd428ea814ebb63b7f35d4d8da2f61 Clean up old markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/20f1ebbac52747210892c9e194f737825d536673..20e65
Re: [openstreetmap/openstreetmap-website] Migration run failed saying To use retry middleware with Faraday v2.0+, install `faraday-retry` gem (Issue #5845)
tomhughes left a comment (openstreetmap/openstreetmap-website#5845) Oh that message isn't from migrate, it's telling you to run migrate, so what command were you running when you got that? If you were running the test then it's telling you the test database has pending migrations and you need t
Re: [openstreetmap/openstreetmap-website] Enable native share if available (PR #5882)
@HolgerJeromin approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5882#pullrequestreview-2740240635 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Incorrect translation choice time_ago for 21 hours ago (Issue #5878)
deevroman left a comment (openstreetmap/openstreetmap-website#5878) > около 21 часа назад > Can you confirm this would work grammatically? Yes, that's right -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5878#issuecomment-27
Re: [openstreetmap/openstreetmap-website] Update to rails 8 (PR #5430)
tomhughes left a comment (openstreetmap/openstreetmap-website#5430) I think this is probably ready for review - the only real annoyance is having to use an unreleased version of `active_record_union` but I don't think there's much point waiting any longer on that. -- Reply to this email direct
Re: [openstreetmap/openstreetmap-website] add dir="auto" to paragraphs in rich_text.rb (PR #5835)
NeatNit left a comment (openstreetmap/openstreetmap-website#5835) If you have the option to squash and merge through GitHub, that would mean I made a successful PR without ever cloning the repository to my machine. Can you? -- Reply to this email directly or view it on GitHub: https://github.co
Re: [openstreetmap/openstreetmap-website] Overhaul markers (PR #5764)
@hlfan pushed 1 commit. aa6f26b947e1dcc1e1450ade9f724744e59f17e3 Convert leaflet markers to SVG -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5764/files/278a0c41365a3d5e5cb5a124e1f4583ad952d9ca..aa6f26b947e1dcc1e1450ade9f724744e59f17e3 You are receiving this
Re: [openstreetmap/openstreetmap-website] Set dir="auto" on changeset comment bodies (Issue #5785)
NeatNit left a comment (openstreetmap/openstreetmap-website#5785) > It would be ideal if we can find ways to fix this issue, so that it is fixed > by default when developers add new pages or add features to existing pages. > That might be hard to achieve though. Perhaps you'd be able to answer
Re: [openstreetmap/openstreetmap-website] Add 'Load more' button + extras (PR #5808)
@AntonKhorev pushed 1 commit. 636604a7f34324dedbe01c79150ff5ff3b178426 WIP load more as links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5808/files/39d065f0ad943d849372ef024622b6ca9a7fd66b..636604a7f34324dedbe01c79150ff5ff3b178426 You are receiving this be
Re: [openstreetmap/openstreetmap-website] Show heatmap only to logged in users (PR #5829)
Firefishy left a comment (openstreetmap/openstreetmap-website#5829) > We don't have: > > * private profiles > * private contributions The "Make [...] and **hide activity**" is the relevant portion. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstree
Re: [openstreetmap/openstreetmap-website] add dir="auto" to paragraphs in rich_text.rb (PR #5835)
tomhughes left a comment (openstreetmap/openstreetmap-website#5835) I've done a rebase and will merge this now - thanks for all the work. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5835#issuecomment-2746293249 You are receivi
[openstreetmap/openstreetmap-website] Reuse mirrored turn icons (PR #5828)
There's a pull request #5776 that claims to *reuse mirrored turn icons*, however most of the changes there are not related to mirroring. This pull request keeps only the mirroring changes from #5776. You can see all of the directions icons by adding the following test to `test/system/directions
Re: [openstreetmap/openstreetmap-website] Change heatmap color to linear from 0 to max changes (PR #5833)
@HolgerJeromin pushed 1 commit. 85076bd6f336e25140b97f84bbd59350ca4322c5 Change heatmap color to linear from 0 to max changes -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5833/files/b40020b11101d6ee3fb5f546c6e9e0deb7c1f61c..85076bd6f336e25140b97f84bbd59350c
Re: [openstreetmap/openstreetmap-website] Deduplicate note adding instructions (PR #5870)
@HolgerJeromin commented on this pull request. > + <%= t "notes.guide.title" %> + <%= t "notes.guide.para_1" %> + <%= t "notes.guide.para_2", :note_icon => tag.a(:href => new_note_path, :class => "icon note bg-dark rounded-1") %> > but where did the red outline come from? I would guess fr
Re: [openstreetmap/openstreetmap-website] Add dir="auto" to Markdown content for bidi (PR #5840)
@NeatNit commented on this pull request. > @@ -96,7 +136,7 @@ def to_text class Markdown < Base def to_html - linkify(sanitize(document.to_html), :all) + linkify(sanitize(document.to_html_bidi), :all) https://kramdown.gettalong.org/rdoc/Kramdown/Parser/Base.html > Implement
Re: [openstreetmap/openstreetmap-website] add dir="auto" to paragraphs in rich_text.rb (PR #5835)
Merged #5835 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5835#event-16944907016 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Update to rails 8 (PR #5430)
@tomhughes pushed 4 commits. e52d4c2d8cb616d573a2fe49965e9079b7160eda Update to rails 8.0.2 05423504d7e560c258d5c7f34010b4051f4ebb06 Replace permit/require with expect for parameter validation 53467d87752f0414903bb7738e20345661e4cf4f Avoid parsing of XML requests with ; in the body 5096e1b733
Re: [openstreetmap/openstreetmap-website] Add dir="auto" to Markdown content for bidi (PR #5840)
@NeatNit pushed 1 commit. 16168bb4d7bd1bdfbc984af1301a0900ae84806f make markdown bidirectional with dir="auto" -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5840/files/8284a308c4bfa880720367e6665e4cb66e48cfba..16168bb4d7bd1bdfbc984af1301a0900ae84806f You are
Re: [openstreetmap/openstreetmap-website] Add dir="auto" to Markdown content for bidi (PR #5840)
@NeatNit pushed 1 commit. 280a4cf451a90ad4a127bdfdf2e42f82d2f3d256 add dir="auto" to linkified links and replicate #5850 in ApplicationHelper -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5840/files/f4972db233c2d08a8494086c5ab935ad38685668..280a4cf451a90ad4a
Re: [openstreetmap/openstreetmap-website] Fix copy-pasting breaking links in shorten_host (PR #5861)
@hlfan pushed 1 commit. 7c72b894789fac7e5c7782972fd7d0099956ef24 Linkify known plain hosts -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5861/files/9f16fdaad39ea8680f791d2b5f77ae48514ab3d3..7c72b894789fac7e5c7782972fd7d0099956ef24 You are receiving this becau
Re: [openstreetmap/openstreetmap-website] Fix GitHub badges in readme (PR #5849)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5849) You can see that Coveralls is down by looking at its badge which wasn't changed by this PR. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5849#issuecomment-2
Re: [openstreetmap/openstreetmap-website] Update Gemfile (PR #5789)
gravitystorm left a comment (openstreetmap/openstreetmap-website#5789) I'm going to close this now, since we haven't had a response from @Artyom10-Pt . Please feel free to get in touch when you have time to respond. -- Reply to this email directly or view it on GitHub: https://github.com/openst
[openstreetmap/openstreetmap-website] Change "add a note" background to secondary on welcome page (PR #5886)
`/welcome` page has this section at the bottom:  Notice *the map* link. Now look at it in dark mode:  You can't see the
Re: [openstreetmap/openstreetmap-website] Add dir="auto" to Markdown content for bidi (PR #5840)
@NeatNit pushed 1 commit. 9feb1f4b404bf2c7d9b659b281e470e6f04bba51 add dir="auto" to linkified links and replicate openstreetmap#5850 in ApplicationHelper -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5840/files/9f9ad0a9ed9156c7b0146fb61789bae1e1ce1b8f..9feb
Re: [openstreetmap/openstreetmap-website] Add dir="auto" to Markdown content for bidi (PR #5840)
NeatNit left a comment (openstreetmap/openstreetmap-website#5840) Added `dir="auto"` to the other `linkify` (see #5883), ready for review again. As an aside, I noticed that none of my changes in `rich_text.rb` affected any tests, perhaps tests should be written for it. I could try to do that, bu
Re: [openstreetmap/openstreetmap-website] Adds version to notes table and creates note_versions table (PR #5815)
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5815) @tomhughes @AntonKhorev Do you think this is OK and we can continue with it, or we need some additional changes (or `simpler architecture` allowing only updating note-tags)? Our [current solution](https://github.com/nenad-v
Re: [openstreetmap/openstreetmap-website] Add dir="auto" to Markdown content for bidi (PR #5840)
@NeatNit pushed 1 commit. 9f9ad0a9ed9156c7b0146fb61789bae1e1ce1b8f add dir="auto" to linkified links and replicate openstreetmap#5850 in ApplicationHelper -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5840/files/280a4cf451a90ad4a127bdfdf2e42f82d2f3d256..9f9a
Re: [openstreetmap/openstreetmap-website] Change "add a note" background to secondary on welcome page (PR #5886)
@nenad-vujicic approved this pull request. This works and looks great on my side in both Dark and Light modes. Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5886#pullrequestreview-2742881547 You are receiving this beca
Re: [openstreetmap/openstreetmap-website] linkify ambiguity (Issue #5883)
NeatNit left a comment (openstreetmap/openstreetmap-website#5883) Okay, seems like I was looking in the wrong places. Those rich text linkify calls do call the function in the parent class. The linkify defined in ApplicationHelper is called from other places. In that case, is it really a good i
[openstreetmap/openstreetmap-website] Use flex+justify instead of floats on export page (PR #5889)
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5889 -- Commit Summary -- * Use flex+justify instead of floats on export page -- File Changes -- M app/assets/stylesheets/common.scss (6) M app/views/site/ex
Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)
nertc left a comment (openstreetmap/openstreetmap-website#5121) PR was updated. `master` was merged and merge conflicts were fixed. PR was changed according to reviews. @tomhughes to indicate if an entry has been truncated, as @AntonKhorev suggested, `See full entry` will not be shown on entrie
[openstreetmap/openstreetmap-website] Clean OSM.formatHash calls (PR #5887)
There is not just a `formatHash` call in `fixthemap` but also one in `welcome` that can be written in the template. Looked through all `formatHash` calls and cleaned up another call. Builds on the commit from #5752 that fixes gravitystorm#257. See also #5869. You can view, comment on, or merge thi
Re: [openstreetmap/openstreetmap-website] Use L.OSM.locate control in user.js (PR #5872)
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5872#pullrequestreview-2742228212 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Use L.OSM.locate control in user.js (PR #5872)
@AntonKhorev pushed 1 commit. 4950c04d5f95f6c95aa8f9bdc2b21dd6ad3dc5d5 Include L.Control.Locate from L.OSM.locate -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5872/files/0ab82a7a50d2b70085c9bcf07f265452aed2fd95..4950c04d5f95f6c95aa8f9bdc2b21dd6ad3dc5d5 You
Re: [openstreetmap/openstreetmap-website] Incorrect translation choice time_ago for 21 hours ago (Issue #5878)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5878) "yesterday" is still wrong because you need to take timezones into account. Unless it's very close to -24 hours, but that's better described as "about 1 day ago", which is what the system tries to do. -- Reply to this email
Re: [openstreetmap/openstreetmap-website] Remove manual edit after 4-second timeout on welcome page (PR #5885)
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5885#pullrequestreview-2742056636 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Remove manual edit after 4-second timeout on welcome page (PR #5885)
@HolgerJeromin approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5885#pullrequestreview-2742011665 You are receiving this because you are subscribed to this thread. Message ID: __
