@AntonKhorev commented on this pull request.
> @@ -65,6 +65,42 @@ def description
protected
+ def truncate_html(html_doc, max_length = nil, img_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ keep_or_discards = %w[p h1 h2 h3 h4 h5 h6 pre a table ul ol dl]
+ accumulated_length = 0
+ parent = nil
If you had to describe the possible values of `parent`, what would you say?
It's not a parent of every traversed node.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121#pullrequestreview-2708013338
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5121/review/2708013...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
