Re: [openstreetmap/openstreetmap-website] Changeset history view drafts and plans (PR #5808)

2025-04-01 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 2 commits. c6ec10ef2cf6cc186b2177542f0bde6e83b98305 Remove unnecessary css classes 882e4056dc96f7179f5b9064f2b81606f66be137 Adjust css selectors for changeset lists -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5808/files/d743b1dbf402150

Re: [openstreetmap/openstreetmap-website] hyperlink the words "OpenStreetMap Blog". (Issue #5875)

2025-04-01 Thread Tom Hughes via rails-dev
Closed #5875 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5875#event-17087104857 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Make "Load more" button on history pages work as a link to the next page (PR #3829)

2025-04-01 Thread Anton Khorev via rails-dev
Closed #3829. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3829#event-17086950690 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Add 'Load more' button + extras (PR #5808)

2025-04-01 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. d743b1dbf40215029bd895b9ae66f65279b9245b Set map hashes on place history pagination links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5808/files/b13daa248b27c3918fd71958e1e1c9d56ed27232..d743b1dbf40215029bd895b9ae66f65279b9245

Re: [openstreetmap/openstreetmap-website] Bump leaflet.locatecontrol from 0.83.1 to 0.84.1 (PR #5874)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5874) And all thanks to the broken clip path in #5752, which made me look at that repo, see https://github.com/domoritz/leaflet-locatecontrol/issues/363 and do https://github.com/domoritz/leaflet-locatecontrol/pull/364. -- Reply to this

Re: [openstreetmap/openstreetmap-website] Add 'Load more' button + extras (PR #5808)

2025-04-01 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 6 commits. d4676c884f814bdf59ed9b5b92916aa2169bd71d Use fetch when loading more changesets in history 2f0181e327a004afa21df57d85a766679be128db Make 'Load more' button behave as link on history pages 5dd68bf90046a1044f0c11520d84a68a9ff8e29a Reset sidebar scroll position on

Re: [openstreetmap/openstreetmap-website] Deduplicate note adding instructions (PR #5870)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan commented on this pull request. > + <%= t "notes.guide.title" %> + <%= t "notes.guide.para_1" %> + <%= t "notes.guide.para_2", :note_icon => tag.a(:href => new_note_path, :class => "icon note bg-dark rounded-1") %> Ok, I added back the `_html` suffix, but where did the red outline co

Re: [openstreetmap/openstreetmap-website] Deduplicate note adding instructions (PR #5870)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. c7aa5d713bec17445fdff5c98c636536b5828233 Deduplicate note adding instructions -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/fe88593fef131392f0e2279fc7e5c9182d8aab57..c7aa5d713bec17445fdff5c98c636536b5828233 You are receiving

Re: [openstreetmap/openstreetmap-website] hyperlink the words "OpenStreetMap Blog". (Issue #5875)

2025-04-01 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5875) OSM Blog is not in this repository. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5875#issuecomment-2771208069 You are receiving this because you are subscr

Re: [openstreetmap/openstreetmap-website] Bump leaflet.locatecontrol from 0.83.1 to 0.84.1 (PR #5874)

2025-04-01 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5874) Fixes locate control marker not rendering because of CSP. Before: ![image](https://github.com/user-attachments/assets/b502d67d-84a3-4223-b85e-eca443f53815) After: ![image](https://github.com/user-attachments/assets/36e8a174-de

Re: [openstreetmap/openstreetmap-website] Bump leaflet.locatecontrol from 0.83.1 to 0.84.1 (PR #5874)

2025-04-01 Thread Anton Khorev via rails-dev
Merged #5874 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5874#event-17085509127 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

[openstreetmap/openstreetmap-website] hyperlink the words "OpenStreetMap Blog". (Issue #5875)

2025-04-01 Thread 積丹尼 Dan Jacobson via rails-dev
jidanni created an issue (openstreetmap/openstreetmap-website#5875) Visit https://blog.openstreetmap.org/2025/03/10/the-philippines-welcomes-us-to-their-shores-for-state-of-the-map-2025-on-3-5-october/ Now wish to see the blog homepage. We see ![Image](https://github.com/user-attachments/asset

Re: [openstreetmap/openstreetmap-website] Add 'Load more' button + extras (PR #5808)

2025-04-01 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 2 commits. 83d3923037436d0d0c8fa063cd6e40f35e992b09 Use fetch when loading more changesets in history ceff763149f97ba707c0f1eceba4194bf3c05363 Make 'Load more' button behave as link on history pages -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-webs

[openstreetmap/openstreetmap-website] Bump leaflet.locatecontrol from 0.83.1 to 0.84.1 (PR #5874)

2025-04-01 Thread dependabot[bot] via rails-dev
Bumps [leaflet.locatecontrol](https://github.com/domoritz/leaflet-locatecontrol) from 0.83.1 to 0.84.1.
Commits

Re: [openstreetmap/openstreetmap-website] Deduplicate note adding instructions (PR #5870)

2025-04-01 Thread Nenad Vujicic via rails-dev
@nenad-vujicic commented on this pull request. > + <%= t "notes.guide.title" %> + <%= t "notes.guide.para_1" %> + <%= t "notes.guide.para_2", :note_icon => tag.a(:href => new_note_path, :class => "icon note bg-dark rounded-1") %> Here is how this renders on my side: ![image](https://github

Re: [openstreetmap/openstreetmap-website] Fix http links to OSMF-run domains in translations (#2392)

2025-04-01 Thread Andy Allan via rails-dev
Closed #2392 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2392#event-17075960544 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan commented on this pull request. >mapParams = {}; +[geoURI.coordstring, ...geoURI.params] = geoURI.pathname.split(";"); +geoURI.params = Object.fromEntries([...geoURI.searchParams, ...geoURI.params.flatMap(l => [...new URLSearchParams(l)])]); `URLSearchParams.getAll

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. a25f39f36d3c6294d45843fe2c1a2455a286f765 Remove controls sprite -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5752/files/04d56efc85e60b0a9836d5f7d253a683e992c5e2..a25f39f36d3c6294d45843fe2c1a2455a286f765 You are receiving this because

Re: [openstreetmap/openstreetmap-website] Fix fixthemap note link (PR #5869)

2025-04-01 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > @@ -0,0 +1,11 @@ +require "application_system_test_case" + +class FixthemapTest < ApplicationSystemTestCase + test "should have 'create a note' link with correct map hash" do +visit fixthemap_path(:lat => 60, :lon => 30, :zoom => 10) + +wit

Re: [openstreetmap/openstreetmap-website] Shorten options of map controls (PR #5873)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5873#pullrequestreview-2733454371 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Fix fixthemap note link (PR #5869)

2025-04-01 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 7b2d020d37f0be749890001ee499faaf549f80b7 Convert zoom to number in OSM.formatHash -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5869/files/28a1360ff1a91abb9f945ce06dd90c44e3704282..7b2d020d37f0be749890001ee499faaf549f80b7 You ar

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 04d56efc85e60b0a9836d5f7d253a683e992c5e2 Remove controls sprite -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5752/files/abdb44aeb29ca3c54ad284a54b3a0edfb16d013c..04d56efc85e60b0a9836d5f7d253a683e992c5e2 You are receiving this because

Re: [openstreetmap/openstreetmap-website] Fix fixthemap note link (PR #5869)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan commented on this pull request. > @@ -0,0 +1,11 @@ +require "application_system_test_case" + +class FixthemapTest < ApplicationSystemTestCase + test "should have 'create a note' link with correct map hash" do +visit fixthemap_path(:lat => 60, :lon => 30, :zoom => 10) + +within_co

Re: [openstreetmap/openstreetmap-website] Fix fixthemap note link (PR #5869)

2025-04-01 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 995422129edf0e953fc5c8d716424ffd9da9b6b2 Convert zoom to number in OSM.formatHash -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5869/files/12e5841304693ff23b3beb1d8b05d68048758969..995422129edf0e953fc5c8d716424ffd9da9b6b2 You ar

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. abdb44aeb29ca3c54ad284a54b3a0edfb16d013c Remove controls sprite -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5752/files/2aeb66e3dece95a6d6049435aba8eb6daaa2b13b..abdb44aeb29ca3c54ad284a54b3a0edfb16d013c You are receiving this because

Re: [openstreetmap/openstreetmap-website] Fix fixthemap note link (PR #5869)

2025-04-01 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 28a1360ff1a91abb9f945ce06dd90c44e3704282 Convert zoom to number in OSM.formatHash -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5869/files/995422129edf0e953fc5c8d716424ffd9da9b6b2..28a1360ff1a91abb9f945ce06dd90c44e3704282 You ar

[openstreetmap/openstreetmap-website] Shorten options of map controls (PR #5873)

2025-04-01 Thread Anton Khorev via rails-dev
This is in addition to #5872 where I wrote `{ position }` instead of a longer `{ position: position }`. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5873 -- Commit Summary -- * Shorten options of map controls --

Re: [openstreetmap/openstreetmap-website] Use L.OSM.locate control in user.js (PR #5872)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5872#pullrequestreview-2733297862 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-01 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5752) You don't need css for any icons here. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5752#issuecomment-2769908510 You are receiving this because you are subsc

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 2 commits. daf4005a2a9ac28c399f6962afb431c95035f597 Update and inline markers efa51b2d8cbdeb180fd658fcf57fc7d44d18c603 Clean up old markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/20e655b294bd428ea814ebb63b7f35d4d8da2f61..efa51

[openstreetmap/openstreetmap-website] Use L.OSM.locate control in user.js (PR #5872)

2025-04-01 Thread Anton Khorev via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5872 -- Commit Summary -- * Use L.OSM.locate control in user.js -- File Changes -- M app/assets/javascripts/user.js (23) -- Patch Links -- https://github.com/o

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5752) Speaking just of clip paths: Without a _``_ `url()`/`src()` or `shape()`, and `path()` being [barely](https://caniuse.com/mdn-css_properties_clip-path_path) out of the 2021 compatibility threshold, only `polygon()` is left of the op

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-01 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5752) > it makes icons with holes in it impossible Are you sure about this? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5752#issuecomment-2769643915 You are rece

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 2aeb66e3dece95a6d6049435aba8eb6daaa2b13b Remove controls sprite -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5752/files/88d59de7a36b668c6f0ace10800bf4a398e3b1bc..2aeb66e3dece95a6d6049435aba8eb6daaa2b13b You are receiving this because

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-01 Thread Nenad Vujicic via rails-dev
@nenad-vujicic requested changes on this pull request. Here is what I see on my side: ![image](https://github.com/user-attachments/assets/4b4610aa-1f31-4524-abdf-4cb80591b581) instead of ![image](https://github.com/user-attachments/assets/4b34e896-cd88-4aee-9229-ee87c341ddee) It seems somethin

[openstreetmap/openstreetmap-website] Reply to an OSM PM in an external email client results in "Mail delivery failed:" (Issue #5871)

2025-04-01 Thread SomeoneElseOSM via rails-dev
SomeoneElseOSM created an issue (openstreetmap/openstreetmap-website#5871) ### URL n/a ### How to reproduce the issue? As https://www.openstreetmap.org/user/SomeoneElse I sent an OSM PM to https://www.openstreetmap.org/user/SomeoneElse2 . That appeared at the email address of SomeoneElse2 .

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-01 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 4 commits. 440e9d679fc16533aa86fb45a7ab034bc5cfaf73 Unify active control button behaviour 23bfa0eb0f1dc0409c3fd2090a58f6b46af82b4c Write fixthemap note link without JS 933b70f46f502930c2b170b18a24bdc8ebb5ca47 Click links instead of icons in tests ede43d4041cb9fdf7d20975b8623c7e52d