Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)

2025-03-10 Thread Emin Kocan via rails-dev
@kcne commented on this pull request. > @@ -0,0 +1,102 @@ +//= link cal-heatmap/dist/cal-heatmap.css Thanks for the feedback, Tom. Since the code inside `common.scss` was unnecessary, I removed it completely, linked the `.css` file to `manifest.js`, and included it in the view directly. Let m

[openstreetmap/openstreetmap-website] Bump rack from 2.2.12 to 2.2.13 (PR #5788)

2025-03-10 Thread dependabot[bot] via rails-dev
Bumps [rack](https://github.com/rack/rack) from 2.2.12 to 2.2.13.
Changelog

Sourced from rack's changelog.

[2.2.13] - 2025-03-11

Security


Re: [openstreetmap/openstreetmap-website] Show new/modified/deleted count in place of " 🖊" in changeset card (Issue #5758)

andrewharvey left a comment (openstreetmap/openstreetmap-website#5758) > If OSMCha has it, why copy the same thing to osm.org? If someone needs > accurate data, that's what OSMCha is for. Better to have this by default on OSM.org in my opinion. Fragmenting into many different tools makes the le

Re: [openstreetmap/openstreetmap-website] Show new/modified/deleted count in place of " 🖊" in changeset card (Issue #5758)

maro-21 left a comment (openstreetmap/openstreetmap-website#5758) > In OSMCha it shows added/modified/deleted feature counts as > ![Image](https://github.com/user-attachments/assets/53b9caaf-3a0e-4db0-9012-9b0791304042) If OSMCha has it, why copy the same thing to osm.org? If someone needs accur

Re: [openstreetmap/openstreetmap-website] My user experience with number of changes on a changeset list (Issue #5770)

maro-21 left a comment (openstreetmap/openstreetmap-website#5770) > Opposite of "let's have more numbers" Then, since there are both supporters and opponents of this solution, I suggest giving the option to set this in the preferences. For me, the numbers that tell how many objects someone has

Re: [openstreetmap/openstreetmap-website] Source of translations of future dates (Issue #5769)

tomhughes left a comment (openstreetmap/openstreetmap-website#5769) That's certainly the ideal yes, but sometimes practicality gets in the way - we're not going to have full date customisation for every translation that includes a date because that would be impractical so the dates are translate

Re: [openstreetmap/openstreetmap-website] Show dates of reported items on issue pages (PR #5787)

Merged #5787 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5787#event-16658802688 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Source of translations of future dates (Issue #5769)

aceman444 left a comment (openstreetmap/openstreetmap-website#5769) Hi, you cannot take a string produced by Rails (or anything) and then just prepend or append any random words to it in OSM strings. That is just invalid Internationalization (i18n) of the program. You must allow for translation

Re: [openstreetmap/openstreetmap-website] Implement Balanced Full-Text Search for Diary Entries (PR #5156)

Closed #5156. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5156#event-16663113113 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Implement Balanced Full-Text Search for Diary Entries (PR #5156)

kcne left a comment (openstreetmap/openstreetmap-website#5156) Closing as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5156#issuecomment-2712115948 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)

nertc left a comment (openstreetmap/openstreetmap-website#5009) This PR is linked to the https://github.com/openstreetmap/leaflet-osm/pull/47. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5009#issuecomment-2711715222 You are re

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (Issue #4931)

Reopened #4931. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4931#event-16661065637 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mail

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

@tomhughes requested changes on this pull request. Please rebase this to get rid of the merge commit and squash the fixups into the original commit. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5784#pullrequestreview-2672309

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

@Jimmykhangnguyen pushed 2 commits. 9b44996c365f4d489b50a0d44a397f5f82ecb52a Fixed the grammatical mistake regarding the hyphen in "sign-up" and "log-in" mentioned in Issue #5772 cefda7e5db50dd9084703c37c9712c9f0b52aa83 Merge branch 'typoFixIssue#5772' of https://github.com/Jimmykhangnguyen/op

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (Issue #4931)

nertc left a comment (openstreetmap/openstreetmap-website#4931) This issue is not closed and needs to be reopened. Sorry, it seems I wrongly used `Fixes` keyword. I meant that https://github.com/openstreetmap/leaflet-osm/pull/38 was part of the fix, not the whole fix. -- Reply to this email d

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@nertc pushed 1 commit. daee2fd4adb7813f8b7168ad2b6d1ee6e936f34c Add social profile links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/418929188fbc31a640defff703b102ddbf354afe..daee2fd4adb7813f8b7168ad2b6d1ee6e936f34c You are receiving this becaus

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

nertc left a comment (openstreetmap/openstreetmap-website#5439) > That seems to have been some glitch with the tests. I forced a rerun and they > passed fine. I rebased `master` to https://github.com/openstreetmap/openstreetmap-website/pull/5009 and it has the same exact errors. -- Reply to

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

Jimmykhangnguyen left a comment (openstreetmap/openstreetmap-website#5784) I assume "log-in" in the `setup_user_auth` section of both `config\locales\en.yml` and `config\locales\en-GB.yml` will have to be tackled. This, however, touches on the "log-in" found in `config\locales` files of other l

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)

nertc left a comment (openstreetmap/openstreetmap-website#5009) PR was updated. `master` was rebased. Conflicts were resolved. Failed tests were not impacted by this PR (for more information see https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2711306484). -- Reply

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

hlfan left a comment (openstreetmap/openstreetmap-website#5784) There are still two texts containing "log-in" left in `setup_user_auth` that should be dehyphenated as well. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5784#iss

[openstreetmap/openstreetmap-website] Set dir="auto" on changeset comment bodies (Issue #5785)

NeatNit created an issue (openstreetmap/openstreetmap-website#5785) ### URL https://www.openstreetmap.org/changeset/163401189 ### How to reproduce the issue? This is a sub-issue of #3428. Some keywords for search: RTL bidi bidirectional LTR Comments inherit the directionality of the entire we