Re: [openstreetmap/openstreetmap-website] Replace var in javascript with let/const (PR #5558)
@hlfan commented on this pull request. > - url: content_path, + url: path, Or maybe not given #5663 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5558#discussion_r1953873847 You are receiving this because you are su
Re: [openstreetmap/openstreetmap-website] Split engine translations into providers and modes (PR #5652)
The issues laid out in #5629 aren't page-breaking, but IMO changing to a system that removes the possibility of inconsistencies entirely is worth the lego. Usually, only 3 translations for the modes are needed, only the non-Latin scripts need the graceful fallback. And it's a step in the directio
Re: [openstreetmap/openstreetmap-website] After restoring a closed tab, the page's CSS styles are not loaded (Issue #5663)
It could be that we need to reintroduce the xhr query parameter and undo https://github.com/openstreetmap/openstreetmap-website/commit/8130b38368baec913df53a63f14a9e4af1a31a75 if that response is used for tab restoration. -- Reply to this email directly or view it on GitHub: https://github.com/
[openstreetmap/openstreetmap-website] Comment changesets scope (PR #5666)
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5666 -- Commit Summary -- * Rename api changeset comment tests * Split api changeset comment create fail tests * Split api changeset comment create scope and terms
Re: [openstreetmap/openstreetmap-website] After restoring a closed tab, the page's CSS styles are not loaded (Issue #5663)
Ah yes I can reproduce that. Unfortunately absolutely nobody understands that code... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5663#issuecomment-2655128262 You are receiving this because you are subscribed to this thread.
Re: [openstreetmap/openstreetmap-website] Navbar going small unneccesarily (Issue #5664)
Just English. This only started happening a few days ago. I've since cleared all types of cookies and cache of the site multiple times. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5664#issuecomment-2655129659 You are receivi
Re: [openstreetmap/openstreetmap-website] Navbar going small unneccesarily (Issue #5664)
I just tried it in responsive mode on a 4K screen with device size set to 2560x1440 and `$(window).width()` was 2560 while `compactWidth` was only coming out at about 500 so clearly there's something different in your environment. What language are you using? Is it something with very long strin
Re: [openstreetmap/openstreetmap-website] After restoring a closed tab, the page's CSS styles are not loaded (Issue #5663)
Added the URL. But I think I missed an important step in the text (there is one in the video). 1. Open https://openstreetmap.org/history 2. Select any changeset and then also close the tab, wait and restore the tab. If you open the changeset by URL, the tab is restored correctly. Probably the p
Re: [openstreetmap/openstreetmap-website] Navbar going small unneccesarily (Issue #5664)
I regularly use firefox on hidpi screens and don't see this so there must be something unusual about your environment I think. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5664#issuecomment-2655113228 You are receiving this b
[openstreetmap/openstreetmap-website] Bump rack from 2.2.10 to 2.2.11 (PR #5665)
Bumps [rack](https://github.com/rack/rack) from 2.2.10 to 2.2.11.
Re: [openstreetmap/openstreetmap-website] Split engine translations into providers and modes (PR #5652)
If you want this to be considered for merging then you should remove the draft flag. That said I'm not sure I really see the point of it - is this really just to reduce the number of translations from 9 to 6 so saving a total of 3 translations? All while introducing new "lego" to the translatio
[openstreetmap/openstreetmap-website] Navbar going small unneccesarily (Issue #5664)
### URL https://www.openstreetmap.org ### How to reproduce the issue? 1. Use monitor with 2560x1440 resolution (also tested on 1920x1080) 2. Use Firefox (version 135.0, Windows 11) 3. Open OSM homepage in full screen browser window 4. Body gets 'small-nav' class (as per [applications.js lines 9
Re: [openstreetmap/openstreetmap-website] Use fetch to make overpass requests for the query tool (PR #5662)
@tomhughes pushed 1 commit. caa31388a39697a16e637965c20c156e39ab349e Use fetch to make overpass requests for the query tool -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5662/files/4439bcf660e8812e0596d11db23b72a8abb0acfe..caa31388a39697a16e637965c20c156e39a
Re: [openstreetmap/openstreetmap-website] Use fetch to make overpass requests for the query tool (PR #5662)
@tomhughes commented on this pull request. >.appendTo($ul); - } -})); + }); Added, though I don't believe it really matters much - it just means on the next query we'll send an abort on a controller that has nothing listening to it's signal. -- Reply to this email
Re: [openstreetmap/openstreetmap-website] After restoring a closed tab, the page's CSS styles are not loaded (Issue #5663)
https://www.openstreetmap.org/changeset/162437268 looks like it was he changeset you used, and restoring the tab works fine for me in firefox. It's hard so to see how what you describe can be anything other than a browser bug to be honest - if the browser can load it right the first time then it
Re: [openstreetmap/openstreetmap-website] Use fetch to make overpass requests for the query tool (PR #5662)
@HolgerJeromin commented on this pull request. >.appendTo($ul); - } -})); + }); Missing controller cleanup? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5662#pullrequestreview-2613338410 You are rec
Re: [openstreetmap/openstreetmap-website] After restoring a closed tab, the page's CSS styles are not loaded (Issue #5663)
It would help if you provided a working URL instead of leaving us to guess a valid changeset... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5663#issuecomment-2654958611 You are receiving this because you are subscribed to th
[openstreetmap/openstreetmap-website] After restoring a closed tab, the page's CSS styles are not loaded (Issue #5663)
### URL _No response_ ### How to reproduce the issue? https://github.com/user-attachments/assets/64f5513a-64e2-4658-aba0-0683c924a091"; /> 1. Open the changeset page for the view openstreetmap.org/changeset/X 2. Close the tab 3. Wait a few seconds 4. Restore the tab 5. Styles are not loade
Re: [openstreetmap/openstreetmap-website] Allow users to delete their own diary entries (PR #4540)
@tomhughes commented on this pull request. > @@ -43,7 +43,7 @@ def initialize(user) can [:new, :show, :create, :destroy], :oauth2_authorization can [:edit, :update, :destroy], :account can [:show], :dashboard -can [:new, :create, :edit, :update, :comment, :subs
Re: [openstreetmap/openstreetmap-website] Allow users to delete their own diary entries (PR #4540)
@tomhughes pushed 1 commit. 579c99fd1e90cdc361afae1627c442c037f704aa Allow users to delete their own diary entries -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4540/files/1fbf075e44d01827cdd5b79f0902912fdfe0cd6d..579c99fd1e90cdc361afae1627c442c037f704aa You
Re: [openstreetmap/openstreetmap-website] Use turbo for the settings page to stop the URL changing (PR #5453)
@tomhughes pushed 3 commits. 72d0196402edfdde4d3b86273c808b4f71f9c8d9 Use turbo for the settings page to stop the URL changing 4685912b06fa0323e6ee1d8965539e389b822474 Replace count.zero? with empty? fb0907b0bb335f646321d32893b142cbc4b181c9 Move errors from email to new_email properly -- Vi
Re: [openstreetmap/openstreetmap-website] Update to rails 8 (PR #5430)
@tomhughes pushed 5 commits. b3e28072217c99161a2ebbc9636678fc84909dba Drop support for ruby 3.1 d0e25a3a5d54e76e9fa538b266625fc4959c3406 Update to rails 8.0.1 36dcc034a062b95d954a38ff9e218248b04d5c99 Avoid parsing of XML requests with ; in the body a0abc6b20ff46e0cdb278cd19ed55bda10881e1c Use
Re: [openstreetmap/openstreetmap-website] Replace var in javascript with let/const (PR #5558)
@tomhughes pushed 2 commits. b5f68d9661d738e6eecf7b4248bf7bb9faa666b7 Update eslint to prefer let/const over var 32c1df3808cc00556b8931c3c8ee079291790e83 Replace uses of var with let or const as appropriate -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/555
Re: [openstreetmap/openstreetmap-website] Label administrative boundaries by real-world designation (PR #5493)
Are you able to address the review comments so we can think about getting this merged? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5493#issuecomment-2654748273 You are receiving this because you are subscribed to this thread.
Re: [openstreetmap/openstreetmap-website] Use fetch to make overpass requests for the query tool (PR #5662)
@tomhughes pushed 1 commit. 4439bcf660e8812e0596d11db23b72a8abb0acfe Use fetch to make overpass requests for the query tool -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5662/files/1527b18a9e76b7790260bfd18be9e2fdddf02d82..4439bcf660e8812e0596d11db23b72a8abb
[openstreetmap/openstreetmap-website] Use fetch to make overpass requests for the query tool (PR #5662)
Switches query tool to use `fetch` for it's overpass requests. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5662 -- Commit Summary -- * Use fetch to make overpass requests for the query tool -- File Changes --
Re: [openstreetmap/openstreetmap-website] Set iD map param with array (PR #5632)
[MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment) says: > The parentheses around the assignment statement are required when using > object literal destructuring assignment without a declaration. As for why it works in the console? ¯\\\_(ツ
Re: [openstreetmap/openstreetmap-website] Set iD map param with array (PR #5632)
Merged #5632 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5632#event-16285360814 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
Merged #5661 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5661#event-16285360832 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Set iD map param with array (PR #5632)
@tomhughes approved this pull request. Thanks for addressing all the review comment - this looks good to me now. The only thing that slightly confuses me is the need for parentheses around the destructuring on lines 20 and 22 as it seems to work without that when I try it in the node console bu
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5661#issuecomment-2654496198 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] API active blocks list (PR #5452)
@tomhughes approved this pull request. Thanks - this looks good to me now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5452#pullrequestreview-2612814262 You are receiving this because you are subscribed to this thread. Mess
Re: [openstreetmap/openstreetmap-website] Get directions using fetch (PR #5642)
@tomhughes approved this pull request. Thanks - this looks good now I think. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5642#pullrequestreview-2612785675 You are receiving this because you are subscribed to this thread. Me
Re: [openstreetmap/openstreetmap-website] Adds storing note's properties to notes (PR #5650)
Merged #5650 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5650#event-16285117208 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Get directions using fetch (PR #5642)
Merged #5642 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5642#event-16285117211 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Updates notes filtering to search description too (PR #5622)
Merged #5622 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5622#event-16285117198 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Updates notes filtering to search description too (PR #5622)
@tomhughes approved this pull request. Thanks - this looks good now I think. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5622#pullrequestreview-2612792794 You are receiving this because you are subscribed to this thread. Me
Re: [openstreetmap/openstreetmap-website] Adds storing note's properties to notes (PR #5650)
@tomhughes approved this pull request. Thanks - this looks good to me now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5650#pullrequestreview-2612779407 You are receiving this because you are subscribed to this thread. Mess
Re: [openstreetmap/openstreetmap-website] Updates notes filtering to search description too (PR #5622)
@nenad-vujicic pushed 2 commits. 663459d1c1e5e097c9b6d3f6742682eaff3f86e7 Adds index to notes on description column 4133936c6304b7d1a57c85d53fb7c3a906190164 Updates notes filtering to search description too -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/562
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5661#pullrequestreview-2612497351 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
> Also, wouldn't it be better to create an iD 2.31.2 patch for this It would be possible to create a patch release for this but I would prefer to only include this change in the next minor release version, as strictly speaking this does change the [API](https://github.com/openstreetmap/iD/blob/
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
@tyrasd commented on this pull request. > @@ -33,5 +33,5 @@ $(document).ready(function () { if (id.data("gpx")) params.set("gpx", id.data("gpx")); - id.attr("src", id.data("url") + "#" + params); + id.attr("src", id.data("url") + "#" + params.toString().replace("+", "%20")); I've fixed
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
@tyrasd pushed 1 commit. c025613ff6038439d3b5591aebee915f75999575 replace all occurrences of `+` -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5661/files/0b5fa06a39e1cd793e2c77116201c521aa02ec38..c025613ff6038439d3b5591aebee915f75999575 You are receiving this
Re: [openstreetmap/openstreetmap-website] Add changeset comment search api with filtering by author and time (PR #4359)
@AntonKhorev pushed 6 commits. 0ab0b601baa272b17577ec0967d6207ea65f8680 Move common query limit method of changesets and notes to mixin 9865debcc9a5d34ce37b4af51b897f033c3d9657 Add changeset comment query limit settings; use common query limit in changeset comment feeds 0d368fb2afdda121d7aa22f
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
@nertc commented on this pull request. > +:substack => %r{substack\.com/@([a-zA-Z0-9_-]+)}, +:telegram => %r{t\.me/([a-zA-Z0-9_]+)}, +:threads => %r{threads\.net/@([a-zA-Z0-9_]+)}, +:tiktok => %r{tiktok\.com/@([a-zA-Z0-9_]+)}, +:twitch => %r{twitch\.tv/([a-zA-Z0-9_]+)}, +
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
Thanks for the review -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2653844962 You are receiving this because you are subscribed to this thread. Message ID: ___ rail
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
@nertc commented on this pull request. > @@ -40,6 +40,21 @@ + +<%= t ".social_links.legend" %> + + <%= f.fields_for :social_links do |social_link_form| %> + + <%= social_link_form.text_field :url, :hide_label => true, :wrapper_class => "col-sm-8" %> +
Re: [openstreetmap/openstreetmap-website] Refactor diaries index with guard clauses (PR #4191)
@AntonKhorev pushed 1 commit. 337c8c8dc1b0890e0a4647a7c1e420d84f04854c Refactor diaries index with guard clauses -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4191/files/7d9f02f00a11f7ff6f4b93dec286ab33086de96f..337c8c8dc1b0890e0a4647a7c1e420d84f04854c You a
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
@nertc commented on this pull request. > +# created_at :datetime not null +# updated_at :datetime not null +# +# Indexes +# +# index_social_links_on_user_id (user_id) +# +# Foreign Keys +# +# fk_rails_... (user_id => users.id) +# + +class SocialLink < ApplicationRecord + b
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
@nertc commented on this pull request. > @@ -40,6 +40,21 @@ + Editor of the social links was moved below the description, as, I think, description has higher priority and should be displayed higher in the editor, and also social links are positioned next to the description and,
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
@nertc commented on this pull request. > + +<%= image_tag "/assets/social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' : social_link.parsed[:platform]}.svg", + :alt => social_link.parsed[:platform].nil? ? "other" : social_link.parsed[:platform], +
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
@nertc commented on this pull request. > +:mastodon => %r{mastodon\.social/@([a-zA-Z0-9_]+)}, +:medium => %r{medium\.com/@([a-zA-Z0-9_]+)}, +:quora => %r{quora\.com/profile/([a-zA-Z0-9_-]+)}, +:reddit => %r{reddit\.com/user/([a-zA-Z0-9_-]+)}, +:skype => %r{join\.skype\.com/in
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
@hlfan requested changes on this pull request. > @@ -33,5 +33,5 @@ $(document).ready(function () { if (id.data("gpx")) params.set("gpx", id.data("gpx")); - id.attr("src", id.data("url") + "#" + params); + id.attr("src", id.data("url") + "#" + params.toString().replace("+", "%20")); Thi
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
@nertc commented on this pull request. > +:substack => %r{substack\.com/@([a-zA-Z0-9_-]+)}, +:telegram => %r{t\.me/([a-zA-Z0-9_]+)}, +:threads => %r{threads\.net/@([a-zA-Z0-9_]+)}, +:tiktok => %r{tiktok\.com/@([a-zA-Z0-9_]+)}, +:twitch => %r{twitch\.tv/([a-zA-Z0-9_]+)}, +
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
PR was updated according to the comments. Also, master was rebased as a base for this branch. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2653813177 You are receiving this because you are subscribed to this t
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
@hlfan commented on this pull request. > @@ -33,5 +33,5 @@ $(document).ready(function () { if (id.data("gpx")) params.set("gpx", id.data("gpx")); - id.attr("src", id.data("url") + "#" + params); + id.attr("src", id.data("url") + "#" + params.toString().replace("+", "%20")); This will o
Re: [openstreetmap/openstreetmap-website] API active blocks list (PR #5452)
@AntonKhorev pushed 3 commits. 565d41f94d1f5537f956abe690252cc8829b8aa6 Add active blocks list api endpoint with empty response d92e470a70f25bd7e4cc3743f01d44fde2b9de78 Skip blocks check when getting active blocks list bb7d95c18cfd13721927af4e69cc157bce5ea24b Output active blocks list -- Vi
Re: [openstreetmap/openstreetmap-website] API active blocks list (PR #5452)
@AntonKhorev commented on this pull request. > @@ -0,0 +1,23 @@ +module Api + module UserBlocks +class ActiveListsController < ApiController + before_action :disable_blocks_check Updated to match #5658 -- Reply to this email directly or view it on GitHub: https://github.com/openstre
Re: [openstreetmap/openstreetmap-website] API element resources - index paths (PR #5591)
That's right, they should be but they aren't. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5591#issuecomment-2653719053 You are receiving this because you are subscribed to this thread. Message ID:
Re: [openstreetmap/openstreetmap-website] Show edit history of deleted users (PR #4224)
@AntonKhorev pushed 3 commits. e5e946059492a74a610958bc78dcbd53d82dc78e Add links to previous/next changesets of deleted user fcc21c32193299a904abaf1b36a26f0c53bb3902 Show edit history of deleted users 00ad7bd665c867e02011e98dd8ccb27f7c9cc4bc Remove deleted authors from history feed -- View
[openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
The current version of iD (v2.31, before the fix for https://github.com/openstreetmap/iD/issue/10761 : https://github.com/openstreetmap/iD/pull/10766), does not fully support `x-www-form-urlencoded` "query-style" strings in the hash: Specifically, spaces encoded as `+` will not be decoded back
Re: [openstreetmap/openstreetmap-website] Add user id redirect paths (PR #4215)
@AntonKhorev pushed 2 commits. 08fa5981df42aeaf95eca0a705b6e26098261d32 Add user id redirect paths 01ddd31b3304925333befaaae0fc16710d15ff0a Add error page for incorrect user ids -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4215/files/3c44a3eda04d0f65fc7
Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)
@tyrasd pushed 1 commit. 0b5fa06a39e1cd793e2c77116201c521aa02ec38 lint -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5661/files/051ae5953f18e2bcc4a4612e9851c95c0f86842e..0b5fa06a39e1cd793e2c77116201c521aa02ec38 You are receiving this because you are subscribe
Re: [openstreetmap/openstreetmap-website] Add user block api call (PR #4301)
@AntonKhorev pushed 3 commits. ef6724f77e65639c04d0f5082a934ef1f63b8012 Move write_api scope check to decrease number of ifs e4cca84d61c75672102c8f3c6ac70f205c9c1462 Test more block attributes in show call fef78b57db11f9bcb2434d48f34d8b0e6d65e5e6 Add user block api call -- View it on GitHub
Re: [openstreetmap/openstreetmap-website] API element resources - index paths (PR #5591)
What? But they aren't. (??) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5591#issuecomment-2653638970 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
@nertc pushed 1 commit. 411888ca16b5ae3877497dc607b73bffe3fafaed Add social profile links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/8263827fa86f1b6a3b21919ee8e016ac5d64b6f2..411888ca16b5ae3877497dc607b73bffe3fafaed You are receiving this becaus
Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)
@AntonKhorev pushed 5 commits. e434aab9ee8b8b559cd67b34ec1d0cea412b884a Test required parameter message in element multi fetch 34b3ef786b3858181ee543e3fda35774b3fecf99 Add generic api elements controller for multi fetches a8d8df26289cf16770ed9274f25cd70c099508e7 Add basic version support to e
Re: [openstreetmap/openstreetmap-website] Dynamic "more" dropdown (PR #5363)
@AntonKhorev pushed 5 commits. 424316b41c155af251597ce4993accd819fe797a Switch to/from compact nav by moving nav items c8757cf1d00836a34e8aa3e1244b3a0694914dc2 Use fixed small/compact nav breakpoint width cdd156137b746491b1b529300c9e76f7882057f3 Move secondary menu items to "more" dropdown d
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@jachym commented on this pull request. > @@ -9,6 +14,43 @@ L.extend(L.LatLngBounds.prototype, { } }); +if (OSM.MAPTILER_KEY) { + maplibregl.setRTLTextPlugin( + "https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";, @1ec5 and @HolgerJeromin an
[openstreetmap/openstreetmap-website] Add a Reset button to the map layers panel (Issue #5660)
### Problem Add a Reset button to the map layers panel, where I placed the "R",  That way, when the user sees the weird colors at "W", they won't panic. The Reset button would also choose the standard mapni
Re: [openstreetmap/openstreetmap-website] Adds storing note's properties to notes (PR #5650)
@nenad-vujicic commented on this pull request. > @@ -379,17 +382,30 @@ def bbox_condition(notes) end end +## +# Get author's information (for logged in users - user_id, for logged out users - IP address) +def author_info + author = current_user if scope_enabled?(:
Re: [openstreetmap/openstreetmap-website] Updates notes filtering to search description too (PR #5622)
@nenad-vujicic pushed 2 commits. 3666de16f28742601a549176a2cf72ab1fade3f0 Adds index to notes on description column 4ddb7cb6b10c8ece316b806f284c25a9645272f4 Updates notes filtering to search description too -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/562
Re: [openstreetmap/openstreetmap-website] Adds storing note's properties to notes (PR #5650)
@nenad-vujicic pushed 1 commit. fadbee0af0fe633d3ebd7e338cc180d73b93c832 Adds storing note's properties to notes -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5650/files/9c14e5d2f6ebf56b26097e4303d50dc1fdc2e8b5..fadbee0af0fe633d3ebd7e338cc180d73b93c832 You a
Re: [openstreetmap/openstreetmap-website] Updates notes filtering to search description too (PR #5622)
@nenad-vujicic commented on this pull request. > @@ -0,0 +1,11 @@ +class AddTextIndexToNotes < ActiveRecord::Migration[7.2] + disable_ddl_transaction! + + def up +add_index :notes, "to_tsvector('english', description)", :using => "GIN", :name => "index_notes_on_description", :algorithm =>
Re: [openstreetmap/openstreetmap-website] Stop using session flash to communicate with callbacks (PR #5658)
Merged, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5658#issuecomment-2653142136 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev
Re: [openstreetmap/openstreetmap-website] Stop using session flash to communicate with callbacks (PR #5658)
Merged #5658 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5658#event-16277832219 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Fix spelling of the word available in DOCKER md (PR #5659)
Merged #5659 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5659#event-16277746909 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Fix spelling of the word available in DOCKER md (PR #5659)
Merged, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5659#issuecomment-2653128415 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev
