@hlfan requested changes on this pull request.


> @@ -33,5 +33,5 @@ $(document).ready(function () {
 
   if (id.data("gpx")) params.set("gpx", id.data("gpx"));
 
-  id.attr("src", id.data("url") + "#" + params);
+  id.attr("src", id.data("url") + "#" + params.toString().replace("+", "%20"));

This will only replace the first encoded space, not multiple.

Also, wouldn't it be better to create an iD 2.31.2 patch for this, as was done 
with #5623?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5661#pullrequestreview-2612043610
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5661/review/2612043...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to