> This needs rebasing and some adjustment after merge of my #5613
It's not much, though. I already applied the IIFE before your PR got merged.
However, I took the opportunity to separate the
`javascripts.directions.instructions.` prefixes.
--
Reply to this email directly or view it on GitHub:
@hlfan pushed 1 commit.
957ae192b61efa1d8de354f45f28429b3df75cf4 Refactor direction engines and unify
structure
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5621/files/a824e6a8abb480f42b8f15ad309cf83ffd6bfee6..957ae192b61efa1d8de354f45f28429b3df75cf4
You ar
@hlfan pushed 1 commit.
a824e6a8abb480f42b8f15ad309cf83ffd6bfee6 Refactor direction engines and unify
structure
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5621/files/3528239e2c938965303ab75262f9e45d0de5236c..a824e6a8abb480f42b8f15ad309cf83ffd6bfee6
You ar
@AntonKhorev commented on this pull request.
> +one_contribution: "1 contribution on %{date}"
+contributions: "%{count} contributions on %{date}"
```suggestion
contributions:
one: "%{count} contribution on %{date}"
other: "%{count} contributio
@AntonKhorev commented on this pull request.
> +return value === 1 ?
+ I18n.t("javascripts.heatmap.tooltip.one_contribution", { date:
localizedDate }) :
+ I18n.t("javascripts.heatmap.tooltip.contributions", { count: value,
date: localizedDate });
```suggestion
return I18n.t(
@AntonKhorev pushed 1 commit.
9ce80389f377a16374fb14f4fd042293f40e9f26 Add josm scheme link to edit menu
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5351/files/438c8a18fc6c4c49480ed7ace2ac8cbae977c11e..9ce80389f377a16374fb14f4fd042293f40e9f26
You are receiv
@AntonKhorev pushed 5 commits.
f5dbcc580283056bdf3b6abd34e0adf89138e84b Switch to/from compact nav by moving
nav items
935ff09668078449bc8bc85895e843ad2f3e1f90 Use fixed small/compact nav
breakpoint width
5bb8fc3cd02320ff4824f33378e50722168f3781 Move secondary menu items to "more"
dropdown d
@AntonKhorev pushed 3 commits.
03491bb78c3055a913f3be2af47986cab6cab233 Add active blocks list api endpoint
with empty response
5730474a5e33f64eec4e5933028ccff830739a15 Skip blocks check when getting active
blocks list
c0c17b01691cfa64ce99c9171ff9fd28618c6193 Output active blocks list
--
Vi
@tomhughes pushed 2 commits.
d657e1c0d9a3aba84411b97fb6a089387b8cd5da Update eslint to prefer let/const
over var
99fb2a9ee6872d01f4301b7e7b8e97d0d9ee328f Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
Merged #5628 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5628#event-16215617674
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5598 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5598#event-16215705551
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I think this looks good now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5598#issuecomment-2640925012
You are receiving this because you are subscribed to this thread.
Message ID:
_
If we want to be exact about suspended users, should we treat them always like
deleted? There were explicit checks for deleted in helper that let suspended
through.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5627#issuecommen
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5628#issuecomment-2640912669
You are receiving this because you are subscribed to this thread.
Message ID:
___
Closed in favor of #5568, #5579 and #5609.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5511#issuecomment-2640909060
You are receiving this because you are subscribed to this thread.
Message ID:
___
Closed #5511.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5511#event-16215594698
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Test for
https://github.com/openstreetmap/openstreetmap-website/pull/5627/commits/cb51f46a4ff913985d535afed0fd8d7d1d955126.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5628
-- Commit Summary --
* Test showing no
Merged #5627 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5627#event-16215486044
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
This needs rebasing and some adjustment after merge of my #5613
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5621#issuecomment-2640783441
You are receiving this because you are subscribed to this thread.
Message ID:
__
> but we did have a plan to do that by refactoring notes
Which part of that plan included reproducing buggy behavior throughout
migrations?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5609#issuecomment-2640728261
You are rece
Merged #5613 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5613#event-16213806709
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5613#pullrequestreview-2599446873
You are receiving this because you are subscribed to this thread.
Message ID
Merged #5614 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5614#event-16213578366
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5625 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5625#event-16213578358
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5623 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5623#event-16213578433
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5614#pullrequestreview-2599398787
You are receiving this because you are subscribed to this thread.
Message ID
@tomhughes requested changes on this pull request.
We'll need to add a text index on `notes.description` like the one we have on
`note_comments.body` or this will have to read every note.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-webs
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5625#issuecomment-2640511959
You are receiving this because you are subscribed to this thread.
Message ID:
___
This is a follow on to #5609 that does a couple of things.
Firstly it adds a test for a note whose original author has been deleted.
Secondly it corrects the test for whether to drop the first comment to align
with what the note model does in the `comments` association so that the first
comment
I understand the desire to fix this but we did have a plan to do that by
refactoring notes, which is now well under way, so I'm not quite sure why we
had to jump in with this interim solution which has no tests and which I'm not
sure is even correct.
--
Reply to this email directly or view it
@zdila commented on this pull request.
> @@ -11,6 +15,40 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ L.OpenMapTiles = L.MaplibreGL.extend({
Implemented. Thanks for noticing.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreet
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5609#issuecomment-2640179815
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Closed #3450 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3450#event-16212508302
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
Fixed in #5609
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3450#issuecomment-2640281600
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Fixed in #5609
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3396#issuecomment-2640273657
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Closed #3396 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3396#event-16212459985
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@zdila pushed 1 commit.
4931b9c4ea1c5a11a4ac58c11d69ecf7efdc3d1c add support for RTL
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/da7489a136e29a65dc7f47af143da8ee961116e5..4931b9c4ea1c5a11a4ac58c11d69ecf7efdc3d1c
You are receiving this because you
Fixed in #5609
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2146#issuecomment-2640261225
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Closed #2146 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2146#event-16212400959
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
Closed #2176.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2176#event-16212291025
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
No longer necessary after
https://github.com/openstreetmap/openstreetmap-website/pull/5609 and preceding
PRs.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2176#issuecomment-2640232407
You are receiving this because you are sub
Closed #3607.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3607#event-16212100549
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed #3608.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3608#event-16212204087
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
No longer necessary after
https://github.com/openstreetmap/openstreetmap-website/pull/5609 and preceding
PRs.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3608#issuecomment-2640217168
You are receiving this because you are sub
No longer necessary after #5609 and preceding PRs.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3607#issuecomment-2640198487
You are receiving this because you are subscribed to this thread.
Message ID:
___
@AntonKhorev commented on this pull request.
> @@ -52,10 +52,10 @@
<% end %>
- <% if @note_comments.length > 1 %>
+ <% if @note_comments.length > (!@note.author.nil? && @note.author.status ==
"deleted" ? 0 : 1) %>
Maybe but nobody is complaining about this message. It mostly means
Merged #5609 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5609#event-16211918012
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
If it's put in `OSM` scope, maybe put the factories in the neighborhood of
`OSM.Directions.engines` where the engines end up.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5613#issuecomment-2640135367
You are receiving this beca
@zdila pushed 1 commit.
da7489a136e29a65dc7f47af143da8ee961116e5 add support for RTL
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/c9241ff862ca2dcf15bd185dd8886d611a44576d..da7489a136e29a65dc7f47af143da8ee961116e5
You are receiving this because you
@AntonKhorev pushed 7 commits.
889cb64e1a330d1bf8c9cfdc0c35b350d015438d Declare api node ways as nested
resources
d7602ccd6e1ed6621c6a03ff60a7838f37ce5cd7 Declare api node relations as nested
resources
56a0543a68849949e8250fb00e8ac168e88a65e3 Declare api way relations as nested
resources
cef
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
Creates nested resources instead of the following actions: `ways_for_node`,
`relations_for_node`, `relations_for_way`, `relations_for_relation`. After that
there's no nonstandard actions in api element controllers for current
versions of elements.
You can view, comment on, or merge this pull req
Otherwise it's getting fixed in some unrelated commit, like #4042.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5625
-- Commit Summary --
* Remove spaces before colons in en.yml
-- File Changes --
M config/l
> For example, in leaflet.share.js there is a substantial amount of html
> construction: ...
Was done in
https://github.com/openstreetmap/openstreetmap-website/pull/4335/files#diff-2b34a8a6e260ed3c05d38b8250e07e05617d32985d2250826373e7c2bce40d8f.
Was ignored by everyone.
--
Reply to this emai
Sorry I did try to search for prior tickets.
I'm running Google Chrome, latest version, on Debian but from Google's
repository, with no extensions enabled for openstreetmap.org, and yes it
doesn't seem to restore by itself. GitHub does, OSM doesn't.
--
Reply to this email directly or view it o
> > You don't need to touch every single line via indenting if you write the
> > globals as
> > `const DemoEngine = function (...) { ... };`
>
> Then we would have `DemoEngine` poluting the global scope...
You can put it in `OSM` scope. `OSM.RoutingEngines.DemoEngine = ...`
--
Reply to this
This is basically another version of #4898 I think - are you using
"better-osm-org" by any chance?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5624#issuecomment-2639763556
You are receiving this because you are subscribed to
If a user is writing a changeset comment on a changeset page
`https://www.openstreetmap.org/changeset/:id:` and they accidentally close the
browser tab, the in-progress comment is lost upon restoring the tab.
It would be preferable for the in-progress comment to be restored in the input
text ar
What browser are you using that doesn't restore forms on page restore these
days?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5624#issuecomment-2639760852
You are receiving this because you are subscribed to this thread.
Me
Small bugfix release, fixing flickering when switching background layers or
zooming (https://github.com/openstreetmap/iD/issues/10738).
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5623
-- Commit Summary --
* Upd
### Description
PR updates notes filtering (querying) to search for query text in both note
comments and note's description.
### How has this been tested?
Using automated tests before and after migration plus manual tests before and
after migration.
You can view, comment on, or merge this pul
i want to solve this issue
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5540#issuecomment-2639547003
You are receiving this because you are subscribed to this thread.
Message ID:
_
@nenad-vujicic commented on this pull request.
> @@ -52,10 +52,10 @@
<% end %>
- <% if @note_comments.length > 1 %>
+ <% if @note_comments.length > (!@note.author.nil? && @note.author.status ==
"deleted" ? 0 : 1) %>
Fixed in the last push. Thanks!
Q: Do we need to replace current
@nenad-vujicic pushed 2 commits.
85bc737dee2523d0c880fc14280d2e1955cc447c Switches from comments to all_comments
592b28fd23534946b92ace7858287727e4afc169 Removes dropping note's first comment
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5609/files/0c08a73ec
@zdila pushed 9 commits.
cd4923cd656c3457da10c445e5e8139387ae53fa Add OpenMapTiles OSM vector map
295f0ab88763e0651c80382008a1352a6acf52e1 remove 3D map link from OMT
attribution
9ef470aa32efd83d6937b35eb26e27ae894ae19e add MAPTILER_KEY configuration
21dc45827f2228bf4a7b4fd89bfae306086ec244 O
@zdila pushed 1 commit.
b46499626f268319b942e282aae59d16b42b848a add support for RTL
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/fd2e5620f7fa151baa72d8364ad2df294bdc12e3..b46499626f268319b942e282aae59d16b42b848a
You are receiving this because you
@nertc commented on this pull request.
> @@ -40,6 +40,21 @@
+
What do you think is a good place for it? Should it be between the description
and avatar, before the description or the last one?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetma
@Satya900 We do [not work with
assigns](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#assigning-issues).
Just go ahead! :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5616#issuecomment-
@HolgerJeromin pushed 2 commits.
a4e6934d599e92d755ab1ff949ed468eea1a9bf0 Fix all no-implicit-globals eslint
errors
49b65a09dd83764ee7c0bb2ab5661775cceeefab Change eslint no-implicit-globals
rule to error
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5613/
69 matches
Mail list logo
