This is a follow on to #5609 that does a couple of things. Firstly it adds a test for a note whose original author has been deleted.
Secondly it corrects the test for whether to drop the first comment to align with what the note model does in the `comments` association so that the first comment is only dropped if the author was active because in other cases the model will already have excluded it. This primarily affects users in state `suspended` I think. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5627 -- Commit Summary -- * Add a test for viewing a note opened by a deleted user * Correct test for notes opened by inactive users -- File Changes -- M app/controllers/notes_controller.rb (2) M test/controllers/notes_controller_test.rb (9) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5627.patch https://github.com/openstreetmap/openstreetmap-website/pull/5627.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5627 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
