Re: [openstreetmap/openstreetmap-website] The map doesn't load (Issue #5555)

2025-01-25 Thread Holger Jeromin via rails-dev
Can you show us the js code with the syntax error? Should be reachable via click on the syntaxError in the console -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/#issuecomment-2614232212 You are receiving this because you ar

Re: [openstreetmap/openstreetmap-website] The map doesn't load (Issue #5555)

2025-01-25 Thread Tom Hughes via rails-dev
There haven't been any deployments for days so this is not related to #1155 at all - that was an operational issue relating to the production deployment and was something triggered by doing new deployments I believe. Nobody else has reported any problems so it seems this must be something speci

[openstreetmap/openstreetmap-website] The map doesn't load (Issue #5555)

2025-01-25 Thread maro-21 via rails-dev
Thanks for quickly repairing https://github.com/openstreetmap/operations/issues/1115. Now the error occurs again. The website works, but there is no map, no left menu, History doesn't work. I can't click on my nickname and see the user menu. But Diaries and GPS traces work. Errors: ``` SyntaxEr

Re: [openstreetmap/openstreetmap-website] Modernize eslint config (Issue #5554)

2025-01-25 Thread Tom Hughes via rails-dev
Can you explain what this has to do with keeping the current config? Are you saying that the current config is invoking some style rules that are no longer having any effect? We'd still want to keep the other rules though? We wouldn't want to just dump the whole thing... -- Reply to this email

[openstreetmap/openstreetmap-website] Modernize eslint config (Issue #5554)

2025-01-25 Thread Holger Jeromin via rails-dev
We could discuss if we want to keep the current [eslint config](https://github.com/openstreetmap/openstreetmap-website/blob/master/config/eslint.js). Most stylistic rules are now removed from eslint because most use a formatter like prettier.io But the style rules are moved to [another repo](htt

Re: [openstreetmap/openstreetmap-website] Add linting for .js.erb files (Issue #5523)

2025-01-25 Thread Holger Jeromin via rails-dev
> Maybe create a new issue for this topic. > https://github.com/prettier/plugin-ruby could be starting point. I am not sure if this only formats ruby code. I am an JS/TS expert so I focus on (native and embedded) js code. -- Reply to this email directly or view it on GitHub: https://github.com

Re: [openstreetmap/openstreetmap-website] Add linting for .js.erb files (Issue #5523)

2025-01-25 Thread Splines via rails-dev
> Most stylistic rules are now removed from eslint because most use a formatter > like prettier.io @HolgerJeromin Formatting rules have indeed been [deprecated](https://github.com/eslint/eslint/issues/17522) in the _core_ of ESLint. But mainly because of ongoing maintenance cost. Luckily, antfu

Re: [openstreetmap/openstreetmap-website] Add linting for .js.erb files (Issue #5523)

2025-01-25 Thread mmd via rails-dev
Maybe create a new issue for this topic. https://github.com/prettier/plugin-ruby could be starting point. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-2614086393 You are receiving this because you are subscr

Re: [openstreetmap/openstreetmap-website] Add linting for .js.erb files (Issue #5523)

2025-01-25 Thread Marwin Hochfelsner via rails-dev
That would indeed be an interesting issue to be discussed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-2614081848 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2025-01-25 Thread SomeoneElseOSM via rails-dev
> https://en.wiktionary.org/wiki/following#Noun, 4 (pedant alert) Someone on social media will have "a following", which is a group of people that follow them. The plural of that is ("followings") would apply to "more than one person who has more than one group following them", and wouldn't r

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2025-01-25 Thread Boris Verkhovskiy via rails-dev
The first quote for that definition comes from [this paper](https://link.springer.com/chapter/10.1007/978-3-642-54212-1_1), and this is the first paragraph of its abstract > Online social network is becoming more and more prevalent currently. [...] > Weibo increases rapidly and draws 100 millio

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2025-01-25 Thread Anton Khorev via rails-dev
https://en.wiktionary.org/wiki/following#Noun, 4 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5261#issuecomment-2613951363 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Add linting for .js.erb files (Issue #5523)

2025-01-25 Thread Holger Jeromin via rails-dev
We should discuss if we want to keep the current eslint config. Most stylistic rules are now removed from eslint because most use a formatter like prettier.io -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-261

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2025-01-25 Thread Boris Verkhovskiy via rails-dev
But it's not. Following that comment thread, the only one who said they think that it's correct is @nertc, the original suggestion was "Following". As soon as I saw "Followings" on the website I thought "this was contributed by someone whose native language is not English" and came searching for

Re: [openstreetmap/openstreetmap-website] Refactor embed.js.erb (PR #5550)

2025-01-25 Thread Holger Jeromin via rails-dev
@HolgerJeromin approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5550#pullrequestreview-2573998167 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Embedded map - missing cs-CZ translation (Issue #5526)

2025-01-25 Thread Vladan Kudláč via rails-dev
Hi, is there any ETA when will be the fix deployed on openstreetmap.org? Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5526#issuecomment-2613859629 You are receiving this because you are subscribed to this thread. Mess