Re: [openstreetmap/openstreetmap-website] Tile edges more noticeable recently (Issue #5546)
Yes, white lines on light theme, dark on dark theme. OK, hope it gets fixed soon. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5546#issuecomment-2613807399 You are receiving this because you are subscribed to this thread. Me
Re: [openstreetmap/openstreetmap-website] Tile edges more noticeable recently (Issue #5546)
Closed #5546 as duplicate. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5546#event-16066645703 You are receiving this because you are subscribed to this thread. Message ID: ___ rai
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
> "Followings" for "list of people you're following" here See https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1910425185, apparently some people think it's correct. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap
[openstreetmap/openstreetmap-website] Bump coverallsapp/github-action from 2.3.4 to 2.3.5 (PR #5553)
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.4 to 2.3.5.Release notes
Sourced from coverallsapp/github-action's releases.
[openstreetmap/openstreetmap-website] Bump eslint from 9.18.0 to 9.19.0 (PR #5552)
Bumps [eslint](https://github.com/eslint/eslint) from 9.18.0 to 9.19.0.As discussed in https://github.com/openstreetmap/openstreetmap-website/pull/5474#issuecomment-2585349128, this PR adds an error handling in case the API request fails.  You can view, comment on, or merge th
Re: [openstreetmap/openstreetmap-website] Use dark map tiles in embed (PR #5519)
Reopened #5519. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5519#event-16063124204 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailin
[openstreetmap/openstreetmap-website] Refactor embed.js.erb (PR #5550)
Refactors from #5519 and #5523 without adding dark mode (yet). You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5550 -- Commit Summary -- * Refactor embed.js.erb -- File Changes -- M app/assets/javascripts/embed
Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of our .js.erb files (PR #5549)
`64:5` `error` `Assignment to function parameter 'search'` `no-param-reassign` is really unnecessary, the entire function should be refactored to use the URLSearchParams Web API. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/55
Re: [openstreetmap/openstreetmap-website] Use dark map tiles in embed (PR #5519)
1 Warning :warning: Merge commits are found in PR. Please rebase to get rid of the merge commits in this PR, see CONTRIBUTING.md. Generated by :no_entry_sign: https://danger.systems/";>Danger -- Reply to this em
Re: [openstreetmap/openstreetmap-website] Use dark map tiles in embed (PR #5519)
@hlfan pushed 1 commit. 9ab853e67b7c33e0dd7f434b391b79b6e604ed1b Merge branch 'master' into embed-dark-mode -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5519/files/037279aa9340d3db97fd890df11de38b9056724b..9ab853e67b7c33e0dd7f434b391b79b6e604ed1b You are re
Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of our .js.erb files (PR #5549)
According to https://github.com/openstreetmap/openstreetmap-website/blob/master/lib/tasks/eslint.rake#L23 we would need to use `bundle exec rails eslint:fix` instead. This seems to work for me at least. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/ope
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
"Followings" for "list of people you're following" sounds grammatically incorrect to me. In my experience websites use just "Following" for this as in "[people you are] following". -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
If I had to guess, my guess would be that your locale on the website is "en-GB". This would allow for the email in the screenshot, because: * In en.yml the `friendship_notification.subject` text was changed, but the i18n key remained the same * In en.yml the email content was changed, and the i1
Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)
Updated the code again, resolved some issues raised here. Few remarks: > CSP violations, days of week won't be visible if not resolved: > > > Content-Security-Policy: (Report-Only policy) The page’s settings would > > block an inline style (style-src-attr) from being applied > > 
@kcne commented on this pull request. > +//= require popper +//= require tooltip + + +/* global CalHeatmap, CalendarLabel, Tooltip */ +document.addEventListener("DOMContentLoaded", () => { + const heatmapElement = document.querySelector("#cal-heatmap"); + + if (!heatmapElement) { +console.
Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)
@kcne pushed 2 commits. e1f5c0efa7265ab8280fa4c5931b32402555b9fd Add heatmap javascript logic, styles and localization 3e5bbc764f0f66cc557ade29d56ecc5e896aea93 Add tests for heatmap data in UsersController -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5402
Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of our .js.erb files (PR #5549)
> Is `--fix` of any help here, have you tried this out already? We run eslint via `bundle exec rails eslint`, and that doesn't support the `--fix` option. Our configuration doesn't support running eslint directly, since we [use ruby code in the configuration](https://github.com/openstreetmap/op
Re: [openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of our .js.erb files (PR #5549)
_✖ 40 problems (31 errors, 9 warnings) 26 errors and 0 warnings potentially fixable with the `--fix` option._ Is `--fix` of any help here, have you tried this out already? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5549#iss
Re: [openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)
@nenad-vujicic pushed 9 commits. 354ff7345d672b582ad4ab4a500cb6c5ec99d9b3 Adds optional using of notes records 0fd95b34d2e62ce5cc5cef7c375408561a9138eb Added helper routine note_description 5989ea88418f6e087fcf3591e48470cca45a4295 Replaced using description with note_description 230998c0575174
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@tomhughes After this PR was merged, on 21 Jan there was a case when there was an old version of the subject and a new version of the body in the mail. After I saw this screenshot, I tried to find out the reason, but mail subject and body were changed in the same PR, I couldn't reproduce it neit
Re: [openstreetmap/openstreetmap-website] Create api map resource (PR #5545)
Merged #5545 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5545#event-16060343355 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Simplify write_notes scope check in api notes controller (PR #5544)
Merged #5544 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5544#event-16060343366 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Create api map resource (PR #5545)
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5545#issuecomment-2612760562 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] Simplify write_notes scope check in api notes controller (PR #5544)
Yes it's probably a hangover from when we had other ways to authenticate to the API that would set `current_user` but it's redundant now as you say. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5544#issuecomment-2612754242 You
Re: [openstreetmap/openstreetmap-website] Move scope_enabled? to ApiController (PR #5543)
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5543#issuecomment-2612738797 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] Remove doorkeeper_token branch from web deny_access (PR #5542)
Merged #5542 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5542#event-16059949993 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Remove doorkeeper_token branch from web deny_access (PR #5542)
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5542#issuecomment-2612737801 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] Move scope_enabled? to ApiController (PR #5543)
Merged #5543 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5543#event-16059950010 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Fix some eslint errors (quotes spacing and parseInt radix) on .js.erb files (PR #5548)
Merged #5548 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5548#event-16059932268 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Fix some eslint errors (quotes spacing and parseInt radix) on .js.erb files (PR #5548)
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5548#issuecomment-2612735489 You are receiving this because you are subscribed to this thread. Message ID: ___
[openstreetmap/openstreetmap-website] Add eslint-plugin-erb to provide linting of our .js.erb files (PR #5549)
Fixes #5523 This is a draft, since our .js.erb files don't currently pass the linting. I've fixed the straightforward ones in #5548 but there are a few more to complete before this can be merged. I've opened this pull request to make it easier for other developers (who have more JS skills) to
Re: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)
@nertc commented on this pull request. > @@ -44,6 +44,11 @@ def index end @issues, @newer_issues_id, @older_issues_id = get_page_items(@issues, :limit => @params[:limit]) + +@unique_reporters = @issues.each_with_object({}) do |issue, reporters| + reporters[issue.id] = issue
[openstreetmap/openstreetmap-website] Fix some eslint errors (quotes spacing and parseInt radix) on .js.erb files (PR #5548)
These have been flagged by the eslint-erb-plugin, and need to be fixed before that can be added. Refs #5523 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5548 -- Commit Summary -- * Fix some eslint errors (quo
Re: [openstreetmap/openstreetmap-website] Add linting for .js.erb files (Issue #5523)
> Is this the shortest time the _awaiting upstream_ tag was necessary? I think so! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-2612667455 You are receiving this because you are subscribed to this thread. M
Re: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)
@nertc pushed 1 commit. f223d673ae1fe831f6615bdb6ac5bbf7a6c81f14 Show reporting user on issues screen -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4990/files/eb7309ccc79dd1da457c70e69d182d7d75fad70d..f223d673ae1fe831f6615bdb6ac5bbf7a6c81f14 You are receiving
Re: [openstreetmap/openstreetmap-website] Tile edges more noticeable recently (Issue #5546)
Duplicate of #5109 and your #3383 Do you have dark mode active? If yes, this is more visible because the dark background has a bigger contrast than the light background. The linked issues are still open: https://github.com/Leaflet/Leaflet/issues/3575 https://github.com/Leaflet/Leaflet/issues/93
Re: [openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)
@nenad-vujicic commented on this pull request. >def description -comments.first.body +if !author.nil? && author.status == "deleted" + RichText.new("text", I18n.t("notes.show.description_when_author_is_deleted")) +elsif user_ip.nil? && user_id.nil? + comments.first.body
[openstreetmap/openstreetmap-website] "Search" -> "Search OpenStreetMap" to save space (Issue #5547)
Here we see Google Maps has saved plenty of space by putting their name in the searchbar:   Indeed "Search OpenStreet
Re: [openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)
@nenad-vujicic pushed 8 commits. dd7351f38fe3011592da001e5d21bce6f7f79ed9 Added helper routine note_description f654d29d8d73591cbd4255cd12145f0e9019a4d9 Replaced using description with note_description 5ccab1b63361a68025c953f9a3e2f3acff5477ea Removed unnecessary methods from Note 742597d3b9900
[openstreetmap/openstreetmap-website] Tile edges more noticeable recently (Issue #5546)
 Seen in Chrome browser. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5546 You are receiving this because you are subscribed to this thre
Re: [openstreetmap/openstreetmap-website] Moves the note's description, author ID, and author IP from the first comment to the note itself (PR #5485)
> Hi @nenad-vujicic thanks for putting in the effort to address #3831 > > You might have noticed that I've started some time ago working on #4481 to > address the same issue. Since your first PR in this direction (#5494) has > been merged I noticed the merge conflicts when I tried to merge the l
Re: [openstreetmap/openstreetmap-website] Add linting for .js.erb files (Issue #5523)
If you introduce linting here you might also be interested in: - How we use ESLint on GitHub Actions via [this file](https://github.com/MaMpf-HD/mampf/blob/23aae01471c4361b85e86df06e349cd8acfb735c/.github/workflows/linter.yml#L39-L75) to lint only the changes inside changed `.js` and `.js.erb` f
