> > * Sending the user to /login?referer=%2Fuser%2Fusername%2Fblocks is a
> > workaround that somewhat works for non-needs_view blocks too and is not
> > affected by GDPR. (*)
>
> > * Don't care about non-needs_view blocks and want a simpler workaround?
> > Send users to /login. (**)
>
> Hmmm,
This PR adds `/account/blocks` page that does the following:
- if there are needs_view blocks, redirects to the earliest one of them
- if there are any active blocks, redirects to the earliest one of them
- if there are no active blocks, displays a message that there aren't any
blocks, possibly wi
> All it really does is "bookmark" somebody so that they are included in a list
> of people that you can narrow down the trace and changeset views to just
> those people.
Following up on this ...
I am now a member of the DWG.
During this last week, I got a message that has added me as a friend
The issue here is in osm.js.erb: if mlon and mlat are set, we're not
initializing "loc" from the _osm_location cookie. Later on we cannot set
mapParams.layers, since "loc" should be nil at this time. This impacts both the
notes layer, as well as the map layer.
```javascript
} else if (param
### Problem
The JS with embedded Ruby isn't held to the same standards as all the other JS
code.
### Description
Please look into enabling linting files with embedded Ruby in ESLint.
The [eslint-plugin-erb](//github.com/Splines/eslint-plugin-erb) could help here.
### Screenshots
![osm.js.erb]
Improved unlinted version of #5519
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5522
-- Commit Summary --
*
Since #5261 is merged, this issue should be marked as resolved.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3310#issuecomment-2600962204
You are receiving this because you are subscribed to this thread.
Message ID:
So, when I tested the changes locally, I edited the evaluated JS to make
iteration faster for me. Then the linter got mad. But eslint alone doesn't
check files that have embedded ruby, which I'll criticise in an issue later on.
As I don't like touching and "un-touching" code, I guess I'll keep ma
Closed #5519.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5519#event-15989301711
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@tomhughes pushed 3 commits.
bf3983562b0c6ca265882005eb62492a0e62ae5a Use turbo for the settings page to
stop the URL changing
d223270779fc28a84d2227fbf63aab0f92d012c2 Replace count.zero? with empty?
368ea6589769e8eb9ccfb1a50f9fa611039c17fb Move errors from email to new_email
properly
--
Vi
Firstly I didn't say it wasn't wanted, I said it is better to keep it in a
separate commit to make reviewing easier.
Secondly what "same linting as usual" is this? As far as I know it was already
passing our eslint rules so is this some additional linting of your own?
--
Reply to this email di
@tomhughes commented on this pull request.
>def description
-comments.first.body
+if user_ip.nil? && user_id.nil?
+ comments.first.body
+else
+ RichText.new("text", self[:description])
+end
end
I don't think I've said that as such.
What I have said is that we n
@AntonKhorev commented on this pull request.
>def description
-comments.first.body
+if user_ip.nil? && user_id.nil?
+ comments.first.body
+else
+ RichText.new("text", self[:description])
+end
end
Weren't you insisting on not showing the true description until LW
Just doing the same linting as usual, why is this not wanted now @tomhughes?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5519#issuecomment-2600902355
You are receiving this because you are subscribed to this thread.
Message I
Merged #5515 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5515#event-15989108358
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5516 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5516#event-15989108341
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5517 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5517#event-15989108343
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5489 as completed via #5520.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5489#event-15989108397
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5520 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5520#event-15989108339
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
Please try to avoid including stylistic changes like replacing single quotes
with double quotes in the same commit as functional changes as it makes it very
hard to tell what the actual functional changes are when reviewing...
--
Reply to this email
@tomhughes commented on this pull request.
>def description
-comments.first.body
+if user_ip.nil? && user_id.nil?
+ comments.first.body
+else
+ RichText.new("text", self[:description])
+end
end
We could make it consistent by using `all_comments` instead but that
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5520#issuecomment-2600896747
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5517#issuecomment-2600896430
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5516#issuecomment-2600895236
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5515#issuecomment-2600894905
You are receiving this because you are subscribed to this thread.
Message ID:
___
> Why does this need to use `[:user_id]` etc rather than the more typical
> `.user_id` form?
I replaced using `[:user_id]` with `user_id` (same with user_ip), but had to
leave self[:description] because of possible recursion. I couldn't use
self.{user_id, user_ip, description} because of Ruboco
@AntonKhorev commented on this pull request.
>def author_id
-comments.first.author_id
+if user_ip.nil? && user_id.nil?
+ comments.first.author_id
+else
+ user_id
+end
end
If user_id is a true id of the user who created the note, it won't necessarily
match `auth
@AntonKhorev commented on this pull request.
>def description
-comments.first.body
+if user_ip.nil? && user_id.nil?
+ comments.first.body
+else
+ RichText.new("text", self[:description])
+end
end
I assume that `self[:description]` is going to be the true note de
@nenad-vujicic pushed 2 commits.
bb9d30fef5a295b42bffaf0cfe49329e9fb9989b Adds optional use of notes records
57b066df587a29ffe6f79db8da9061be839dc7f6 small fix
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5511/files/31dbd76c9cf4ec2e7d11673f0a272bab8d615807.
I didn't take into account that sometimes centering is useful and necessary:
https://github.com/user-attachments/assets/2c222546-6754-4605-9591-d42df41e9ffb
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521#issuecomment-26008
@deevroman pushed 1 commit.
6e64adb8c0d02008abcb8351169ed043464cc864 Fix left/right sidebar resizing on
mobile devices
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521/files/a0d853d418e424481a9b6120ad86b1f650ece769..6e64adb8c0d02008abcb8351169ed043464cc864
@deevroman pushed 1 commit.
898ea3d1bc17468e3cfef0e36b6127e9208e70c0 Fix left/right sidebar resizing on
mobile devices
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521/files/6e64adb8c0d02008abcb8351169ed043464cc864..898ea3d1bc17468e3cfef0e36b6127e9208e70c0
@deevroman pushed 1 commit.
a0d853d418e424481a9b6120ad86b1f650ece769 Fix left/right sidebar resizing on
mobile devices
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521/files/e75db2ceae901b24385a676054b8510280200e2a..a0d853d418e424481a9b6120ad86b1f650ece769
This PR fixes multiple issues about the map resetting its position when opening
various menus on mobile devices.
https://github.com/openstreetmap/openstreetmap-website/issues/4755
https://github.com/openstreetmap/openstreetmap-website/issues/991
...
1. Get rid of the hardcoded left sidebar width
34 matches
Mail list logo
