@AntonKhorev commented on this pull request.
> def author_id
- comments.first.author_id
+ if user_ip.nil? && user_id.nil?
+ comments.first.author_id
+ else
+ user_id
+ end
end
If user_id is a true id of the user who created the note, it won't necessarily
match `author.id`, see my comment for `description`. Attempts to fix that for
`author` were made in the past but were rejected by the maintainers, see for
example #3607.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5511#pullrequestreview-2561026988
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5511/review/2561026...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
