Re: [openstreetmap/openstreetmap-website] blocks with needs_view flag not shown when user does oauth authorisation (for example login into an OSM editor) (Issue #5490)
> that may not be popular with clients that have invested a lot here in > optimising the flow Looking at JOSM, I seem to remember that they *used to* have some "fully automatic" authorization where you'd input the username and password into JOSM itself and JOSM would then fake towards the OSM w
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)
@deevroman pushed 1 commit. 5b37b549391bc12ca25019960c726aa306417ec3 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/a32249ec8ba1ebf437028bf15
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)
@deevroman commented on this pull request. > @@ -124,7 +124,7 @@ L.OSM.layers = function (options) { map.fire("overlaylayerchange", { layer: layer }); }); -map.on("layeradd layerremove", function () { +map.on("baselayerchange overlaylayerchange", function ()
Re: [openstreetmap/openstreetmap-website] Use baselayerchange/overlaylayerchange instead of layeradd/layerremove (PR #5474)
Okay, firing events from `addObject` / `removeObject` turned out to be the best idea. And I changed this PR to use `baselayerchange`/`overlaylayerchange` I also replaced layeradd for `map.on("layeradd",...)`, which tracks the layer's on/off state with `dataLayer.on("add", ...)`. Using `overlayla
[openstreetmap/openstreetmap-website] Bump eslint from 9.17.0 to 9.18.0 (PR #5491)
Bumps [eslint](https://github.com/eslint/eslint) from 9.17.0 to 9.18.0.@deevroman pushed 1 commit. a359de90c209df00b40ba5520291b7e295b0b2c8 Use baselayerchange/overlaylayerchange instead of layeradd/layerremove for speed up Map Data layer render -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5474/files/a9579cec394e621082e2a813f
Re: [openstreetmap/openstreetmap-website] display an encouragement to contribute after many anonymous notes (PR #5468)
Hi, Thanks again for the positive and pertinent comments, I pushed a new version with: - only 1 squashed commit - updated threshold - modified warning with a gap - deletion of the cookie after successful login -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap
Re: [openstreetmap/openstreetmap-website] display an encouragement to contribute after many anonymous notes (PR #5468)
@etiennejourdier commented on this pull request. > @@ -39,6 +39,8 @@ def successful_login(user, referer = nil) session[:fingerprint] = user.fingerprint session_expires_after 28.days if session[:remember_me] +cookies.delete :_osm_anonymous_notes_count > The point could be that if
Re: [openstreetmap/openstreetmap-website] display an encouragement to contribute after many anonymous notes (PR #5468)
@etiennejourdier commented on this pull request. > + + <%= t ".anonymous_warning_html", +:log_in => link_to(t(".anonymous_warning_log_in"), login_path(:referer => new_note_path)), +:sign_up => link_to(t(".anonymous_warning_sign_up"), new_user_path) %> +<% i
Re: [openstreetmap/openstreetmap-website] display an encouragement to contribute after many anonymous notes (PR #5468)
@etiennejourdier commented on this pull request. > @@ -5,9 +5,17 @@ <%= t(".intro") %> <% if !current_user %> -<%= t ".anonymous_warning_html", - :log_in => link_to(t(".anonymous_warning_log_in"), login_path(:referer => new_note_path)), -
Re: [openstreetmap/openstreetmap-website] display an encouragement to contribute after many anonymous notes (PR #5468)
@etiennejourdier pushed 1 commit. 13d1113e2f94e1a40268a8677bb443d2728b3307 display an encouragment to contribute after to many anonymous notes -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5468/files/6e6000c099cdac32f75a03290242ed718b980c3a..13d1113e2f94e1a4
Re: [openstreetmap/openstreetmap-website] blocks with needs_view flag not shown when user does oauth authorisation (for example login into an OSM editor) (Issue #5490)
> but for clients that already have a token and are just hitting the API > there's no way we can magically display a message. I meant case when user tries to get a new token -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5490#
Re: [openstreetmap/openstreetmap-website] blocks with needs_view flag not shown when user does oauth authorisation (for example login into an OSM editor) (Issue #5490)
> but for clients that already have a token and are just hitting the API > there's no way we can magically display a message. Wouldn't be possible that when a user is blocked, their tokens are invalidated, so they are forced to re-login? -- Reply to this email directly or view it on GitHub: h
Re: [openstreetmap/openstreetmap-website] blocks with needs_view flag not shown when user does oauth authorisation (for example login into an OSM editor) (Issue #5490)
I thought there were already issues for this? In general there isn't really a solution is there, outside of making the message available to clients for them to display? We can obviously display it during the login when authorising a new application, though that may not be popular with clients t
[openstreetmap/openstreetmap-website] blocks with needs_view flag not shown when user does oauth authorisation (for example login into an OSM editor) (Issue #5490)
### Problem user doing oauth authorisation (for example login into an OSM editor) which is blocked will not be notified by osm.org about a block ### Description This was tested on Android, as part of https://github.com/streetcomplete/StreetComplete/issues/6062 resulting from https://community
Re: [openstreetmap/openstreetmap-website] Proposal for Messages API (Issue #4509)
At least the list of recent API changes on that page has this entry: _In July 2024, the [Messaging API](https://wiki.openstreetmap.org/wiki/Messaging_API_proposal) was added._ -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4
Re: [openstreetmap/openstreetmap-website] Messages API `message_read` field is missing (Issue #5489)
Well, it looks like you found the bug? If you send yourself a message, it is unread in the inbox until you mark it as read.  -- Reply to this email directly or view it on GitHub: https://github.com/opens
Re: [openstreetmap/openstreetmap-website] Messages API `message_read` field is missing (Issue #5489)
You won't see it on a message to yourself but you would on a message from somebody else. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5489#issuecomment-2582885084 You are receiving this because you are subscribed to this thre
Re: [openstreetmap/openstreetmap-website] Messages API `message_read` field is missing (Issue #5489)
> 2\. To confirm that it is a bug and not just not included because of weird > API design (missing == false??): How does it confirm that? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5489#issuecomment-2582881814 You are rece
Re: [openstreetmap/openstreetmap-website] Proposal for Messages API (Issue #4509)
But not documented in https://wiki.openstreetmap.org/wiki/API_v0.6 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4509#issuecomment-2582868756 You are receiving this because you are subscribed to this thread. Message ID: _
[openstreetmap/openstreetmap-website] Messages API `message_read` field is missing (Issue #5489)
### URL https://master.apis.dev.openstreetmap.org/api/0.6/user/messages ### How to reproduce the issue? 1. **Send yourself a message** `POST https://master.apis.dev.openstreetmap.org/api/0.6/user/messages` Body: `recipient_id=, title=Test123, body=Test123` Headers: `Authorization=Beare
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@AntonKhorev commented on this pull request. > - <%= link_to t(".remove as friend"), > remove_friend_path(:display_name => @user.display_name), :method => :post %> + <%= link_to t(".unfollow"), follow_path(:display_name => @user.display_name), :method => :dele
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@nertc commented on this pull request. > + has_many :follows, -> { joins(:following).where(:users => { :status => > %w[active confirmed] }) } + has_many :followings, :through => :follows, :source => :following > Maybe use "Following" instead of "Followed users" for better clarity. It > alig
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@AntonKhorev commented on this pull request. > + has_many :follows, -> { joins(:following).where(:users => { :status => > %w[active confirmed] }) } + has_many :followings, :through => :follows, :source => :following Why `:following` and not `:followee`? Currently `:follows` are right next t
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@nertc commented on this pull request. > + follow: +heading: "Do you want to follow %{user}?" +button: "Follow User" + unfollow: +heading: "Do you want to unfollow %{user}?" +button: "Unfollow" I tried to stick to the formulations from the `friendship`
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@nertc commented on this pull request. > - <%= link_to t(".remove as friend"), > remove_friend_path(:display_name => @user.display_name), :method => :post %> + <%= link_to t(".unfollow"), follow_path(:display_name => @user.display_name), :method => :delete %>
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@AntonKhorev commented on this pull request. > + follow: +heading: "Do you want to follow %{user}?" +button: "Follow User" + unfollow: +heading: "Do you want to unfollow %{user}?" +button: "Unfollow" Why one of the buttons is "Follow User" but another o
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@AntonKhorev commented on this pull request. > - <%= link_to t(".remove as friend"), > remove_friend_path(:display_name => @user.display_name), :method => :post %> + <%= link_to t(".unfollow"), follow_path(:display_name => @user.display_name), :method => :dele
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@nertc commented on this pull request. > + before_action :check_database_writable, :only => [:create, :destroy, :edit] + before_action :lookup_friend, :only => [:create, :destroy, :edit] `:only` was removed -- Reply to this email directly or view it on GitHub: https://github.com/openstreetm
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@nertc commented on this pull request. > + scope "/user/:display_name" do +resource :follow, :only => [:create, :destroy, :edit], :path => "follow" + end Redirections were added from `/make_friend` and `/remove_friend` to `/follow/edit` -- Reply to this email directly or view it on Git
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@nertc commented on this pull request. > + belongs_to :befriender, :class_name => "User", :foreign_key => :user_id, > :inverse_of => :follows + belongs_to :befriendee, :class_name => "User", :foreign_key => :friend_user_id, :inverse_of => :follows `:befriender` was changed to `:follower` an
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@nertc pushed 2 commits. 9f615bd98e9aba76eb0c712fce430109d8212575 Modify the way Friends are added a153faf0010fdf2b977a4f35f49bdaf3814c6fbc Refactor friendships controller and model -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5261/files/5c9c7b818519080ba9
Re: [openstreetmap/openstreetmap-website] Delete changeset tags (PR #5309)
If you delete a tag and comment the changeset, that replicates the changeset and the deleted tag is not included. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5309#issuecomment-2582620866 You are receiving this because you are
Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)
@nertc pushed 1 commit. 5c9c7b818519080ba96106e5cf8c0b92abba2874 Refactor friendships controller and model -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5261/files/36fba94eaa196762872d337975836625a65c107e..5c9c7b818519080ba96106e5cf8c0b92abba2874 You are rec
Re: [openstreetmap/openstreetmap-website] display an encouragement to contribute after many anonymous notes (PR #5468)
> but it seemed pointless as the cookie will expire 30 days after the last > anonymous note anyway The point could be that if I log in my session may expire faster than that and I'll se the message again. But maybe it's not worth doing anything about it. -- Reply to this email directly or view
