Re: [openstreetmap/openstreetmap-website] Resourceful routes for users api (PR #5433)

2024-12-26 Thread Anton Khorev via rails-dev
Let's keep `user/details` non-resourceful for now, I'll try something else later. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5433#issuecomment-2563259454 You are receiving this because you are subscribed to this thread. Mess

Re: [openstreetmap/openstreetmap-website] Resourceful routes for users api (PR #5433)

2024-12-26 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 5 commits. 91de69bc17cfd5958cdb6c6ccad1ab98c0b828ae Move users index route to api namespace b31ac7430e86b9661b836269162d4c57d3c2d1fb Move user show route to api namespace e6b23c133ee69d937cc44ec48cd2947b985b4ad1 Move user details route to api namespace 880032ed853727c8e861

Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-12-26 Thread Anton Khorev via rails-dev
> Sure, but I think appearance and language are important enough to be quickly > accessible at all times, like on Wikipedia. UI language is not quickly accessible on Wikipedia: ![image](https://github.com/user-attachments/assets/a82c5df4-7d7a-4e44-a115-34f198424cb1) -- Reply to this email dir

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2024-12-26 Thread Anton Khorev via rails-dev
When I'm making a site for myself and there's this kind of UI with *Add* buttons adding an input and *Remove* buttons next to added inputs, I don't bother doing it. I just put a ``, it's easier to edit. In this case I'd have a textarea with each nonempty line corresponding to a link. Why don't

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2024-12-26 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > +# created_at :datetime not null +# updated_at :datetime not null +# +# Indexes +# +# index_social_links_on_user_id (user_id) +# +# Foreign Keys +# +# fk_rails_... (user_id => users.id) +# + +class SocialLink < ApplicationRecor

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2024-12-26 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > @@ -225,4 +225,27 @@ $(document).ready(function () { $("#read_tou").on("click", function () { $("#continue").prop("disabled", !($(this).prop("checked") && $("#read_ct").prop("checked"))); }); + + $("#add-social-link").click(function (ev

Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-12-26 Thread Nekzuris via rails-dev
> you can't have a button in the header for every possible setting Sure, but I think appearance and language are important enough to be quickly accessible at all times, like on Wikipedia. Another option to consider would be placing them directly in the drop-down menu, like on YouTube or Reddit:

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2024-12-26 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > @@ -40,6 +40,21 @@ + +<%= t ".social_links.legend" %> + + <%= f.fields_for :social_links do |social_link_form| %> + + <%= social_link_form.text_field :url, :hide_label => true, :wrapper_class => "col-sm-8

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2024-12-26 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > +:substack => %r{substack\.com/@([a-zA-Z0-9_-]+)}, +:telegram => %r{t\.me/([a-zA-Z0-9_]+)}, +:threads => %r{threads\.net/@([a-zA-Z0-9_]+)}, +:tiktok => %r{tiktok\.com/@([a-zA-Z0-9_]+)}, +:twitch => %r{twitch\.tv/([a-zA-Z0-9_]+)},

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2024-12-26 Thread Anton Khorev via rails-dev
Do we need another set of icons in addition to `app/assets/images/social_icons`? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2563191266 You are receiving this because you are subscribed to this thread. Messag

Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-12-26 Thread Anton Khorev via rails-dev
> It also requires at least 6 clicks to change one value from the home page, 8 > for both, +1 to go back to the home page. 3 clicks on Wikipedia in a similar scenario, without the *Appearance* sidebar visible. You can propose: - one always visible preferences button (takes space of one button,

Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

2024-12-26 Thread Anton Khorev via rails-dev
> [This > proposal](https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2480755496) > is much better Only if you look at it in isolation, because there's also #5201 and you can't have a button in the header for every possible setting. -- Reply to this email directl

Re: [openstreetmap/openstreetmap-website] Enable commenting when reactivating note? (Issue #5444)

2024-12-26 Thread Anton Khorev via rails-dev
I thought about this when #5359 was discovered. Always having a textarea would have fixed that bug. I don't know why there's no comment input for closed noted, but it looks like a deliberate choice. When commenting was first added to the web ui there was no reopen action available https://gith

Re: [openstreetmap/openstreetmap-website] Login page does not check if a user is logged in (Issue #5441)

2024-12-26 Thread Anton Khorev via rails-dev
We can add a message to the login page that you're already logged in. And if there's a referrer, we can add a link to that page. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5441#issuecomment-2563121432 You are receiving this

Re: [openstreetmap/openstreetmap-website] Login page does not check if a user is logged in (Issue #5441)

2024-12-26 Thread Tom Hughes via rails-dev
Quite this is behaving as intended but the user has changed context behind the site's back - the page was rendered in one context with a set of cookies that indicated the user is logged in and the user then switched to a different context with different cookies which is not really a supported th

[openstreetmap/openstreetmap-website] Enable commenting when reactivating note? (Issue #5444)

2024-12-26 Thread Nenad Vujicic via rails-dev
### Problem Not sure if this is a feature or a bug, but when note is closed, logged-in users are unable to add a comment when reactivating note. It looks like backend already supports adding comment when reactivating (processing of `text` API::NotesController#reopen). Perhaps it could be usable

Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)

2024-12-26 Thread Emin Kocan via rails-dev
I've updated the code to account for the "Preferred Website Color Scheme." Theme settings should now be working correctly. **UX Thoughts:** - **Disabling Feature in Profile:** Data is already public and open, so I believe all mappers should have a contribution graph. This feature provides val