I've updated the code to account for the "Preferred Website Color Scheme."
Theme settings should now be working correctly.
**UX Thoughts:**
- **Disabling Feature in Profile:** Data is already public and open, so I
believe all mappers should have a contribution graph. This feature provides
valuable insights for more experienced mappers as a reference point to
understand others' activity.
- **"Never Contributed" Case:** Showing an empty heatmap with a fallback
message seems like a good approach. From a UX perspective, maintaining a
consistent layout across profiles would be more intuitive and visually cohesive.
**Code Comments:**
- **Localizing Starting Week:** I attempted to localize the starting week as
suggested but couldn't find a clean solution due to limitations with the
`ghDays` subdomain. If anyone has suggestions, I'm open to exploring further.
- **Separate JS Files:** There's already a `heatmap.js` file containing
heatmap-related functionality, included in `application.js` for precompilation.
I'm hesitant to introduce additional files unless there's a clear benefit.
Consolidating heatmap logic here seems to make sense for now.
- **Updating `package.json`:** I’ll update the `package.json` as part of the
changes, but I’m unsure if additional configuration is needed. Please let me
know if there are any dependencies or settings to consider. @gravitystorm
Let me know if further adjustments or discussions are needed!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2562356509
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5402/c2562356...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
