> Maybe for discussion in #5328 to conclude? Reacting to comments there or
> posting new, if you have something new to say, may be a good idea.
@matkoniecz Whatever the outcome of #5328 comes to it seems very unlikely the
consensus will be to keep the current dimming filter as is. This dimming f
@AntonKhorev pushed 3 commits.
9cd4bcba679ad1c1352485c7a69649816643d91b Group tagless way nodes with same
related ways
5ad3bad2158dc7783015ae3e7127ed1f6a03de51 Show only one icon for way node group
f794d36c03122e2c00fc7e057913bc2d4dbe835c Write browse element icons as
--
View it on GitHub:
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
#5317 + some other changes
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5355
-- Commit Summary --
* Show "node also part of ways" as nested lists on way pages
* Put nested "also..." lists into collapsible detail
>Something to remember if SVG filters will be used: Firefox ignores filter
>definitions if they are behind a display: none.
@hlfan Looks like it's fixed now.
>Do you mean layering filters or changing the Map Tile URL under the heading
>Map Tile URL?
I wanted to test different layers like Cycle
I think i need to clarify something regarding:
> For example, the maintainers of the current default map layer
> (openstreetmap-carto) have stated that they aren't planning on creating a
> dark version of their style
While this is true there are a number of additional points that are important
> One thing was wrong, the filter was applied twice. Yes, no one noticed it in
> 6 months.
That’s funny because hundreds of people complained about it within the first
hour it was live.
It doesn’t matter that it was applied twice, you and every other dev saw it
like that thought it was fine. Y
> I use OSM almost daily, from time to time on Discord and forums, I even
> contribute to iD occasionally, but I never saw any indication that a dark
> mode was in active development and about to be released.
It was in active development, six months ago. It would have been difficult to
miss it
> Unfortunately it doesn't work for me in Firefox
Something to remember if SVG filters will be used: Firefox ignores filter
definitions if they are behind a `display: none`.
> Is there a way to test different layers?
Do you mean layering filters or changing the Map Tile URL under the heading Ma
> I made a little utility to try out filter combinations more easily:
> https://codepen.io/hlfan/full/GRVVGog For convenient editing in the dev
> tools, the outputted filter is stored in a custom property and the filter is
> also applied to the SVG that holds the filters.
@hlfan This is really
In 6 months no one has noticed anything wrong with it or realized that a better
proposal already exists? Crazy.
At this rate it will probably take us 6 more months to get that filter removed
and 6 years to discuss the 2 filters we're proposing.
--
Reply to this email directly or view it on Git
> Everyone had ~6 months to test the dark mode before it was launched
I use OSM almost daily, from time to time on Discord and forums, I even
contribute to iD occasionally, but I never saw any indication that a dark mode
was in active development and about to be released.
--
Reply to this ema
> Everyone had ~6 months to test the dark mode before it was launched into
> production
Is this an "everyone who watched every single commit in this repo" everyone
(which likely isn’t many), or was this communicated anywhere else?
--
Reply to this email directly or view it on GitHub:
https://g
Well it mostly started out as me trying to fix the alignment and the scaling
became a kind of side effect as I realised that thing weren't very consistently
sized. Possibly now that I know about the background image hack that might not
be strictly necessary...
--
Reply to this email directly o
> vertical size to scale
Why do you need to scale the icons?
> they are being added using pseudo elements
That's what I was going to stop doing after #5317. I was going to write the
icons as `` or ``, set their size to 20x20 px, center them inside
that size using `object-fit: none` (this lets
@AntonKhorev commented on this pull request.
> @@ -83,12 +85,30 @@ def create
lat = OSM.parse_float(params[:lat], OSM::APIBadUserInput, "lat was not a
number")
comment = params[:text]
+ # Extract the tags parameter (if it exists)
+ tags = []
+ if params[:tags].pre
> Is there any possibile conflict in giving users both a Dark UI toggle and a
> Dark Map choice?
I don't think there's a conflict, but it's another choice that's going to
affect the implementation. We'll have to store the dark map setting for each UI
color mode in this case.
--
Reply to this
>> And by "develop" I mean also trialling them with a large number of users,
>> not just launching into production a result satisfying you, me and four
>> people in here.
> You mean we shouldn't repeat what was done in
> https://github.com/openstreetmap/openstreetmap-website/pull/4712? /s
And
@tomhughes requested changes on this pull request.
> @@ -9,6 +9,13 @@ SET xmloption = content;
SET client_min_messages = warning;
SET row_security = off;
+--
+-- Name: public; Type: SCHEMA; Schema: -; Owner: -
+--
+
+-- *not* creating schema, since initdb creates it
+
+
This block is noise
I moved that ruby code to a module, but now there's no dependency on it. If
it's changed, `osm.js` won't be recompiled.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5352#issuecomment-2496084066
You are receiving this because yo
@AntonKhorev pushed 1 commit.
37ce56f225262db0017b44aed56e10c88925dc55 Put api keys directly in js layer
definitions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5352/files/25279c4697a5805c6e0c3325ed8963bbca9d0d8b..37ce56f225262db0017b44aed56e10c88925dc55
Y
@Wilhem275
>It's not a fear, it's an absolute certainty that the output will be a mess 😄
Exactly what's happening here:
I messed something up back then and couldn't be bothered to edit the screenshot
afterwards, since it was just about showing the new options. Here is what the
preview actually l
> One size can't fit all.
> And by "develop" I mean also trialling them with a large number of users, not
> just launching into production a result satisfying you, me and four people in
> here.
You mean we shouldn't repeat what was done in #4712? /s
> the output will be a mess 😄
Exactly what's
> and if we implement some straightforward preferences (e.g. auto/light/dark
> prefs for UI and/or maps) then I think most people will be reasonably happy
> with the outcome
> That's what you'll get if there's an option for the map mode independent of
> the ui mode.
@gravitystorm @AntonKhorev
Although we're using SVG icons because they are being added using pseudo
elements it's currently impossible to directly set a size for them to scale
to as https://stackoverflow.com/a/8993934 explains.
So instead we use a solution based on the alternate approach there of setting
the image as a b
Merged #5353 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5353#event-15410468431
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5353#issuecomment-2495970881
You are receiving this because you are subscribed to this thread.
Message ID:
___
I'm sure this could be improved, but a massive multi line block of ruby
embedded is a js file is definitely not the answer to my mind at least.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5352#issuecomment-2495930790
You are r
28 matches
Mail list logo
