Re: [openstreetmap/openstreetmap-website] How to configure rapid editor in a local deployment environment? (Issue #5285)

2024-10-24 Thread Tom Hughes via rails-dev
We don't write rapid or know anything about it so we are unable to help - you should address your questions to the rapid developers. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5285#issuecomment-2435788665 You are receiving

Re: [openstreetmap/openstreetmap-website] How to configure rapid editor in a local deployment environment? (Issue #5285)

2024-10-24 Thread Tom Hughes via rails-dev
The only thing I would say (and it won't be the cause of the problem) is that you don't need to put the rapid id or keys in `settings.local.yml` as the rails code doesn't need them and by doing so you're duplicating those settings and overwriting the id and key the web site uses for itself. --

Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)

2024-10-24 Thread Tom Hughes via rails-dev
I've opened https://github.com/danger/danger/pull/1501 for upstream that I believe should fix things... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2436035422 You are receiving this because you are subscrib

[openstreetmap/openstreetmap-website] Bump coverallsapp/github-action from 2.3.3 to 2.3.4 (PR #5286)

2024-10-24 Thread dependabot[bot] via rails-dev
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.3 to 2.3.4.
Release notes

Sourced from coverallsapp/github-action's releases.


Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)

> 3. When you mentioned "blue on blue" colors I'm not sure if this is something > I've introduced in this PR Obviously you didn't introduce it. That comment was made in July. > since when I toggle dark mode on my end everything is looking fine. Check it when the note is colored as "submitted".

Re: [openstreetmap/openstreetmap-website] How to configure rapid editor in a local deployment environment? (Issue #5285)

Closed #5285 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5285#event-14855363967 You are receiving this because you are subscribed to this thread. Message ID: ___ r

[openstreetmap/openstreetmap-website] How to configure rapid editor in a local deployment environment? (Issue #5285)

### Problem When I tried to use rapid, I encountered an authorization failure issue. ### Description `oauth2/authorize` success but `token` call failed with 401 and { "error": "invalid_client", "error_description": "Client authentication failed due to unknown client, no client authent

[openstreetmap/openstreetmap-website] Note subscriptions db table (PR #5284)

Part one of #5283. Creates the note subscription table and starts adding subscriptions for anyone who comments a note. These subscriptions are not yet used for anything, email notifications still go to all note commenters. You can view, comment on, or merge this pull request online at: https:/

Re: [openstreetmap/openstreetmap-website] Note subscriptions (PR #5283)

@AntonKhorev pushed 6 commits. 51187ec2e0bdbe0ae728f4eb37250c4394e376f4 Subscribe users when they interact with notes d67bca8a39a12876c2ab265b0dfdcbf61394c652 Backfill note subscriptions f91f74db2e7fc206ff8a7f349e33f34a1f0871a4 Send notifications to note subscribers instead of commenters fc9e

Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)

> Yes, the goal was to implement the filters that were most commonly requested > and improve the feature based on that feedback. Where are these requests? For example #832 wants status filter but doesn't say anything about date ranges. Why would a status filter be incomplete without a date rang

Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)

> Time for what? For PR review? Exactly, since each PR would need to be reviewed sequentially, it would prolong the overall process. > Are you sure? Is it complete with exactly the filters you added and not some > other filters? Yes, the goal was to implement the filters that were most commonl

Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)

> Adding filters one by one would significantly increase the time required Time for what? For PR review? > and might leave the feature feeling incomplete. Are you sure? Is it complete with exactly the filters you added and not some other filters? -- Reply to this email directly or view it on

Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)

@kcne pushed 1 commit. 900b9153f3daecf2bc8bcf3e10ac6a5cfc380a8d Remove filtering by interaction. Group status by open, closed and commented -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/cc6c281028aef5983500b62091321f4b215bba3c..900b9153f3daecf2bc8

Re: [openstreetmap/openstreetmap-website] Add filtering functionality to user notes page (PR #5255)

@kcne pushed 1 commit. cc6c281028aef5983500b62091321f4b215bba3c Remove filtering by interaction. Group status by open, closed and commented -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/8725d95265e95b1b16610bbc6d483a0afffe9d9e..cc6c281028aef598350

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

@nertc commented on this pull request. > @@ -280,8 +280,8 @@ resource :profile, :only => [:edit, :update] # friendships - match "/user/:display_name/make_friend" => "friendships#make_friend", :via => [:get, :post], :as => "make_friend" - match "/user/:display_name/remove_friend" => "f