@nertc commented on this pull request.
> @@ -280,8 +280,8 @@
resource :profile, :only => [:edit, :update]
# friendships
- match "/user/:display_name/make_friend" => "friendships#make_friend", :via
=> [:get, :post], :as => "make_friend"
- match "/user/:display_name/remove_friend" => "friendships#remove_friend",
:via => [:get, :post], :as => "remove_friend"
+ match "/user/:display_name/follow_user" => "friendships#follow_user", :via
=> [:get, :post], :as => "follow_user"
+ match "/user/:display_name/unfollow_user" => "friendships#unfollow_user",
:via => [:get, :post], :as => "unfollow_user"
@AntonKhorev `app/views/user_mailer/friendship_notification.html.erb` and
`app/views/user_mailer/friendship_notification.text.erb` changes are about
redirections from mail notifications. For the consistent visual output this PR
is focused on changing every occurrence of "friend" on user side and changing
them to "following". Main focus is what will users see (including both texts
and URLs). I agree that it will be great if friendship functionality is
refactored (currently it is just renamed), but those changes are out of scope
of this PR and will be done as a separate PR as soon as this PR will be merged
(adding them to this PR will complicate things as there will be not only user
side changes, but logical changes in `routes.rb`, `ability.rb` and etc. which
will need much deeper testing than just text and URL comparisons).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1814440209
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5261/review/2391585...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
