Re: [openstreetmap/openstreetmap-website] Note subscriptions (PR #5283)

2024-10-23 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 3b1657c342809c4395ac5c92699962fd8a5ba715 Add subscribe/unsubscribe buttons to note pages -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5283/files/433ae3df1656bbcb97f380dd7420111a15e85af1..3b1657c342809c4395ac5c92699962fd8a5ba715

[openstreetmap/openstreetmap-website] Note subscriptions (PR #5283)

2024-10-23 Thread Anton Khorev via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5283 -- Commit Summary -- * Create note subscription table and model * Subscribe users when they interact with notes * Backfill note subscriptions * Send notific

Re: [openstreetmap/openstreetmap-website] Directions need to say "go straight onto road B" (Issue #5280)

2024-10-23 Thread 積丹尼 Dan Jacobson via rails-dev
Bing Maps also has all the >Road name changes to 信義路四段99巷 And even adds > The last intersection before your destination is 四维路66巷 >If you reach 四維路76巷, you've gone too far And it even tells you how to say the words. -- Reply to this email directly or view it on GitHub: https://github.com/opens

Re: [openstreetmap/openstreetmap-website] Directions need to say "go straight onto road B" (Issue #5280)

2024-10-23 Thread 積丹尼 Dan Jacobson via rails-dev
And the winner is... https://www.google.com/maps/dir/?api=1&origin=25.036723%2C121.547048&destination=25.034351%2C121.547037 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5280#issuecomment-2433979183 You are receiving this be

Re: [openstreetmap/openstreetmap-website] Directions need to say "go straight onto road B" (Issue #5280)

2024-10-23 Thread mmd via rails-dev
https://discuss.graphhopper.com/t/how-to-handle-when-street-name-changes-on-a-route/5528 mentions some url parameter to get all street names. I haven’t checked what options other routing engines are offering. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap

[openstreetmap/openstreetmap-website] Gateway time-out when opening a long relation history (Issue #5282)

2024-10-23 Thread Máté Gyöngyösi via rails-dev
### URL https://www.openstreetmap.org/relation/7795942/history ### How to reproduce the issue? 1. Open the URL 2. See the following error: https://github.com/user-attachments/assets/2f5c66a8-8966-4b5c-b214-37daa0a2ccc1";> ### Screenshot(s) or anything else? This relation is enormous: it ha

Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)

2024-10-23 Thread mmd via rails-dev
Fails :no_entry_sign: Gem/Bundle changes were not documented in the Description. If this is a major update, add #gemlock_major_upgrade to the PR Description. Generated by :no_entry_sign: https://danger.systems/js";>dangerJS ag

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2024-10-23 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > @@ -280,8 +280,8 @@ resource :profile, :only => [:edit, :update] # friendships - match "/user/:display_name/make_friend" => "friendships#make_friend", :via => [:get, :post], :as => "make_friend" - match "/user/:display_name/remove_friend"

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

2024-10-23 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > + <% Locale.available + .map { |locale| Language.find_by(:code => locale.to_s) } + .select { |locale| locale } + .sort_by { |locale| locale[:english_name] } + .each do |language| %> +

Re: [openstreetmap/openstreetmap-website] Directions need to say "go straight onto road B" (Issue #5280)

2024-10-23 Thread Anton Khorev via rails-dev
This is the Graphhopper instructions for the query: ![image](https://github.com/user-attachments/assets/8b9875cb-379e-4a6c-a51f-5f02c9097540) None of the engines mentions "19" in their instructions. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstree

Re: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -60,6 +61,13 @@ <%= link_to t(".reports_count", :count => issue.reports_count), issue %> <%= link_to reportable_title(issue.reportable), reportable_url(issue.reportable) %> <%= link_to issue.reported_user.display_name

Re: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -60,6 +61,13 @@ <%= link_to t(".reports_count", :count => issue.reports_count), issue %> <%= link_to reportable_title(issue.reportable), reportable_url(issue.reportable) %> <%= link_to issue.reported_user.display_name

Re: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -60,6 +61,13 @@ <%= link_to t(".reports_count", :count => issue.reports_count), issue %> <%= link_to reportable_title(issue.reportable), reportable_url(issue.reportable) %> <%= link_to issue.reported_user.display_name

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)

2024-10-23 Thread David Tsiklauri via rails-dev
If there are no other change requests for this PR, I'll create a new PR for the [leaflet-osm](https://github.com/openstreetmap/leaflet-osm) to merge changes done in the `vendor/assets/leaflet/leaflet.osm.js`. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -86,6 +86,16 @@ OSM.initializeDataLayer = function (map) { if (dataLoader) dataLoader.abort(); +let spanLoading = $("#layers-data-loading"); + +if (!spanLoading.length) { + spanLoading = $("") +.attr("id", "layers-data-loa

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > -remove_friend: - heading: "Unfriend %{user}?" - button: "Unfriend" - success: "%{name} was removed from your friends." - not_a_friend: "%{name} is not one of your friends." +follow_user: + heading: "Do you want to follow

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -27,19 +27,19 @@ - <%= t ".my friends" %> + <%= t ".followed users" %> I agree with you. Wording was changed from `followed users` to `followings`. I was also thinking about it. `followed users` is more understandable, but `f

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > - heading: "Add %{user} as a friend?" - button: "Add as friend" - success: "%{name} is now your friend!" - failed: "Sorry, failed to add %{name} as a friend." - already_a_friend: "You are already friends with %{name}." - limi

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -1603,12 +1603,12 @@ en: footer_html: "You can also read the message at %{readurl} and you can send a message to the author at %{replyurl}" friendship_notification: hi: "Hi %{to_user}," - subject: "[OpenStreetMap] %{user} added

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > - heading: "Unfriend %{user}?" - button: "Unfriend" - success: "%{name} was removed from your friends." - not_a_friend: "%{name} is not one of your friends." +follow_user: + heading: "Do you want to follow %{user}?" + but

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > - <%= render :partial => "contact", :collection => friends, :locals => { :type => "friend" } %> + <%= render :partial => "contact", :collection => friends, :locals => { :type => "followed user" } %> `fo

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -91,7 +91,7 @@ en: support_url: Support URL allow_read_prefs: read their user preferences allow_write_prefs: modify their user preferences -allow_write_diary: create diary entries, comments and make friends +

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

2024-10-23 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > + <% Locale.available + .map { |locale| Language.find_by(:code => locale.to_s) } + .select { |locale| locale } + .sort_by { |locale| locale[:english_name] } + .each do |language| %> +><%

Re: [openstreetmap/openstreetmap-website] Error in bundle exec db:create (Issue #5281)

2024-10-23 Thread Tom Hughes via rails-dev
Apparently you don't have the gd2 library installed so you will need to fix that. I have no idea about Mac's but I believe the `brew install gd` from https://github.com/openstreetmap/openstreetmap-website/blob/master/INSTALL.md#macosx is supposed to take take of that. -- Reply to this email di

Re: [openstreetmap/openstreetmap-website] Error in bundle exec db:create (Issue #5281)

2024-10-23 Thread Tom Hughes via rails-dev
Closed #5281 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5281#event-14803320283 You are receiving this because you are subscribed to this thread. Message ID: ___ rai