Re: [racket] Beginners request for code review.

2013-02-01 Thread Piotr Klibert
I'm sorry for not responding until now - I read all the posts and am very, very grateful for all the great comments and advice I got. I had no time to do anything other than to read them though, I plan to take my time tomorrow to implement most of them and to answer to all the posts. For now I'd l

Re: [racket] Beginners request for code review.

2013-02-01 Thread Marijn
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Poitr, On 31-01-13 02:20, Piotr Klibert wrote: > Hello all. > > TL;DR: I "want" a code review. Link to the repository at the end. [snip] > The code lives here: > http://bazaar.launchpad.net/~klibertp/+junk/bezier/files > > I will really apprec

Re: [racket] Beginners request for code review.

2013-01-31 Thread Matthias Felleisen
A couple of detailed, somewhat random thoughts: -- preliminary style guide: http://www.ccs.neu.edu/home/matthias/Style/style/ -- equip modules and functions with purpose statements -- consider using (module+ test ...) -- use define-inline, try the optimization coach -- you might wis

Re: [racket] Beginners request for code review.

2013-01-31 Thread Piotr Klibert
I tried this a bit (this is why all the constants in bezier-math are floats) but I didn't notice any improvement. May be that I was using flonums inconsistently, I'll try once again. Best regards, Piotr Klibert 2013/1/31 Jens Axel Søgaard : > 2013/1/31 Carl Eastlund : >> Piotr, >> >> This isn't g

Re: [racket] Beginners request for code review.

2013-01-31 Thread David Van Horn
On 1/31/13 5:40 AM, Piotr Klibert wrote: I have a problem with your suggestion, namely: 2) If you make this a github repository, then you could publish it as a 'raco pkg' package and everyone could try it out. Looks like fun! I use bzr and launchpad for personal things and github for work rel

Re: [racket] Beginners request for code review.

2013-01-31 Thread Jens Axel Søgaard
2013/1/31 Carl Eastlund : > Piotr, > > This isn't good Racket code, it's *gorgeous*. That was my impression at > first glance, and the more I look, the more I like it. Your Bezier library > absolutely does not read like the code of a novice Racketeer. Few enough > people regularly use a combinat

Re: [racket] Beginners request for code review.

2013-01-31 Thread Piotr Klibert
I have a problem with your suggestion, namely: > 2) If you make this a github repository, then you could publish > it as a 'raco pkg' package and everyone could try it out. > Looks like fun! I use bzr and launchpad for personal things and github for work related stuff, so that's why it was on lau

Re: [racket] Beginners request for code review.

2013-01-30 Thread Carl Eastlund
Piotr, This isn't good Racket code, it's *gorgeous*. That was my impression at first glance, and the more I look, the more I like it. Your Bezier library absolutely does not read like the code of a novice Racketeer. Few enough people regularly use a combination of objects, pattern matching, map

[racket] Beginners request for code review.

2013-01-30 Thread Piotr Klibert
Hello all. TL;DR: I "want" a code review. Link to the repository at the end. This is my first post here so I think it's appropriate to introduce myself. I'm a professional programmer and I have been programming for nearly twenty years now. At work I use Python and CoffeeScript; before that I used