Re: [R-pkg-devel] use of assert in C++

2024-12-18 Thread Dirk Eddelbuettel
On 18 December 2024 at 19:46, Bielow, Chris wrote: | hoping this is the right place for this: | I stumbled upon documentation regarding the use of `assert` in C++ code, in | particular, https://cran.r-project.org/web/packages/policies.html states | that | | ``` | Thus C/C++ calls to assert/abort

[R-pkg-devel] use of assert in C++

2024-12-18 Thread Bielow, Chris
Dear all, hoping this is the right place for this: I stumbled upon documentation regarding the use of `assert` in C++ code, in particular, https://cran.r-project.org/web/packages/policies.html states that ``` Thus C/C++ calls to assert/abort/exit/std::terminate, Fortran calls to STOP and so on mu

[R-pkg-devel] r-hub question

2024-12-18 Thread Roy Mendelssohn - NOAA Federal via R-package-devel
Hi All: r-hub has changed the way that it works. Now you need Github, plus it writes things to your Github repo. I do not understand what it writes, I am always loath to add anything to a repo I don't understand, and I wonder if it conflicts in any way with existing Github actions. Or alt

Re: [R-pkg-devel] Changes in function call with respect to the current published version

2024-12-18 Thread John Fox
Dear Jose, On 2024-12-18 10:26 a.m., John Fox wrote: Caution: External email. Dear Jose, Assuming that you can fix the bugs in the original function, one approach would be to make myfun() generic, say myfun <- function(y, ...) UseMethod("myfun"), with the (fixed) original myfun() as the defau

Re: [R-pkg-devel] Non-reproducible ASAN flagged issue

2024-12-18 Thread David Cortes
Thank you, that was very helpful indeed! I've filed a bug report with GCC just in case: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118113 Best regads, David Cortes On Wed, 2024-12-18 at 17:34 +0300, Ivan Krylov wrote: > В Tue, 17 Dec 2024 20:26:01 +0100 > David Cortes пишет: > > > I am seeing

Re: [R-pkg-devel] Changes in function call with respect to the current published version

2024-12-18 Thread John Fox
Dear Jose, Assuming that you can fix the bugs in the original function, one approach would be to make myfun() generic, say myfun <- function(y, ...) UseMethod("myfun"), with the (fixed) original myfun() as the default method and a new function method, which would probably set up a call to the

Re: [R-pkg-devel] Non-reproducible ASAN flagged issue

2024-12-18 Thread Ivan Krylov via R-package-devel
В Tue, 17 Dec 2024 20:26:01 +0100 David Cortes пишет: > I am seeing a curious error in an ASAN package check which is not > reproducible in the r-debug containers > (https://github.com/wch/r-debug), and which I'm suspecting might be a > compiler bug. r-debug differs from the gcc-ASAN special che

Re: [R-pkg-devel] Changes in function call with respect to the current published version

2024-12-18 Thread Georgi Boshnakov
> myfun(formula, data = mydata, ..., y, x, z) Of course, it should be > myfun(formula, data, ..., y, x, z) With no default for 'data'. Georgi Boshnakov -Original Message- From: R-package-devel On Behalf Of Georgi Boshnakov Sent: 17 December 2024 22:34 To: Jose Barrera-Gómez ; R Pack

Re: [R-pkg-devel] Non-reproducible ASAN flagged issue

2024-12-18 Thread Tomas Kalibera
On 12/17/24 20:26, David Cortes wrote: I am seeing a curious error in an ASAN package check which is not reproducible in the r-debug containers (https://github.com/wch/r-debug), and which I'm suspecting might be a compiler bug. Wanted to ask for a second opinion on whether this could actually be