Re: config wierdness

2008-02-19 Thread Matt Sergeant
On Sat, 16 Feb 2008, Matt Sergeant wrote: Isn't this fixed by r845? Answer from Chris here at MAAWG: Yes it does :-) Matt.

Re: config wierdness

2008-02-16 Thread Matt Sergeant
On Thu, 14 Feb 2008, Chris Lewis wrote: Like Solaris usually does (grr), "hostname" returns the host node name (no dots), not the FQDN. config/me contains the FQDN, but $self->qp->config("me") _still_ returns the node name. I see the "sub config" code uses `hostname` as the default, but shou

Re: config wierdness

2008-02-14 Thread Ask Bjørn Hansen
On Feb 14, 2008, at 8:56, Peter J. Holzer wrote: I've fixed one or two subtle bugs there in the past. The code is a bit convoluted and I wouldn't be surprised if some non-obvious bug had crept in there again. Yeah ... I glanced over it and didn't see anything obvious. I added a very si

Re: config wierdness

2008-02-14 Thread Chris Lewis
Chris Lewis wrote: Guy Hulbert wrote: On Thu, 2008-02-14 at 12:05 -0500, Chris Lewis wrote: That last change would break it -- the config_dir_memo thing is returned above. that would break _all_ config(), wouldn't it? config()'s on other than "me" work fine. I was wrong anyway. I thought

Re: config wierdness

2008-02-14 Thread Chris Lewis
Guy Hulbert wrote: On Thu, 2008-02-14 at 12:05 -0500, Chris Lewis wrote: That last change would break it -- the config_dir_memo thing is returned above. that would break _all_ config(), wouldn't it? config()'s on other than "me" work fine. I was wrong anyway. I thought that it was possib

Re: config wierdness

2008-02-14 Thread Guy Hulbert
On Thu, 2008-02-14 at 12:05 -0500, Chris Lewis wrote: > > That last change would break it -- the config_dir_memo thing is > returned > > above. > > that would break _all_ config(), wouldn't it? config()'s on other > than > "me" work fine. I was wrong anyway. I thought that it was possible for

Re: config wierdness

2008-02-14 Thread Chris Lewis
Guy Hulbert wrote: On Thu, 2008-02-14 at 11:45 -0500, Chris Lewis wrote: unnoticed because the definition of 'me' is redundant. It's beginning to look like someone broke config() between the version you're running and mine - I think mine is SVN head. I'm on r733 ... I've updated my copy of

Re: config wierdness

2008-02-14 Thread Guy Hulbert
On Thu, 2008-02-14 at 12:00 -0500, Guy Hulbert wrote: > - return $configdir; > + return $config_dir_memo{$config} = $configdir; > } > > That last change would break it -- the config_dir_memo thing is > returned > above. Oops ... missed the assignment ... never mind. -- --gh

Re: config wierdness

2008-02-14 Thread Guy Hulbert
On Thu, 2008-02-14 at 11:45 -0500, Chris Lewis wrote: > > unnoticed because the definition of 'me' is redundant. > > It's beginning to look like someone broke config() between the version > you're running and mine - I think mine is SVN head. I'm on r733 ... I've updated my copy of the trunk an

Re: config wierdness

2008-02-14 Thread Chris Lewis
Chris Lewis wrote: Steve has walked tested the code in 0.40, and it works right there. 0.42rc1 (SVN head) doesn't. Hrm. SVN head returns qpsmtpd self-identifying as 0.42rc1, and it has the buggy caching code. SVN 0.43rc1 has the buggy caching code. SVN 0.42rc1 does _not_ have the cache.

Re: config wierdness

2008-02-14 Thread Peter J. Holzer
On 2008-02-14 11:34:32 -0500, Guy Hulbert wrote: > On Thu, 2008-02-14 at 17:23 +0100, Peter J. Holzer wrote: > > is needed). The problem is that the current version of qpsmtpd > > *ignores* > > The one I'm running does not. > > > the config file. No configuration tool will solve this problem. Fix

Re: config wierdness

2008-02-14 Thread Chris Lewis
Guy Hulbert wrote: On Thu, 2008-02-14 at 10:43 -0500, Chris Lewis wrote: BUT, here's the rub: even if you try to work around that by setting config/me to the FQDN, config(me) still returns `hostname`. This implies to me a bug in qpsmtpd's config handling. I think 'bug' is a bit strong. No,

Re: config wierdness

2008-02-14 Thread Guy Hulbert
On Thu, 2008-02-14 at 17:23 +0100, Peter J. Holzer wrote: > is needed). The problem is that the current version of qpsmtpd > *ignores* The one I'm running does not. > the config file. No configuration tool will solve this problem. Fixing > the routine which reads the config file will. Are you su

Re: config wierdness

2008-02-14 Thread Steve Kemp
On Thu Feb 14, 2008 at 17:14:48 +0100, Peter J. Holzer wrote: > > I'm not asking how to fudge Solaris config to return the FQDN, or how to > > write a function that can return a FQDN (I can figure that out from > > /etc/hosts), but how to get qpsmtpd to return the value I'd expect from > > conf

Re: config wierdness

2008-02-14 Thread Peter J. Holzer
On 2008-02-14 10:52:07 -0500, Guy Hulbert wrote: > On Thu, 2008-02-14 at 10:43 -0500, Chris Lewis wrote: > > BUT, here's the rub: even if you try to work around that by setting > > config/me to the FQDN, config(me) still returns `hostname`. This > > implies to me a bug in qpsmtpd's config handli

Re: config wierdness

2008-02-14 Thread Peter J. Holzer
On 2008-02-14 10:22:32 -0500, Chris Lewis wrote: > Using FQDN in, say, "helo" isn't an unfortunate linux novelty, it's a > requirement by RFC821/2821. > > The point here really is that I'm trying to build code that is portable, > and possibly quite widely deployed. Futzing around with what host

Re: config wierdness

2008-02-14 Thread Guy Hulbert
On Thu, 2008-02-14 at 10:43 -0500, Chris Lewis wrote: > BUT, here's the rub: even if you try to work around that by setting > config/me to the FQDN, config(me) still returns `hostname`. This > implies to me a bug in qpsmtpd's config handling. I think 'bug' is a bit strong. There is a project (

Re: config wierdness

2008-02-14 Thread Guy Hulbert
On Thu, 2008-02-14 at 10:36 -0500, Guy Hulbert wrote: > Looks as if changing `hostname` to `hostname -f` in the code would be > the correct fix. Apparently I am incorrect here. Sorry about that. IIRC, there is not a universal way on solaris to get the FQDN. The 'domainname' command is to get th

Re: config wierdness

2008-02-14 Thread Chris Lewis
Guy Hulbert wrote: On Thu, 2008-02-14 at 10:22 -0500, Chris Lewis wrote: Using FQDN in, say, "helo" isn't an unfortunate linux novelty, it's a requirement by RFC821/2821. RFC821/2821 do not say anything about the hostname command, afiak. That's a bit of a non-sequitor. Of course it doesn't.

Re: config wierdness

2008-02-14 Thread Guy Hulbert
On Thu, 2008-02-14 at 10:22 -0500, Chris Lewis wrote: > The point here really is that I'm trying to build code that is portable, > and possibly quite widely deployed. Futzing around with what hostname > returns on a given OS instance simply isn't an option. The real issue I was guessing that

Re: config wierdness

2008-02-14 Thread Guy Hulbert
On Thu, 2008-02-14 at 10:18 -0500, Charlie Brady wrote: > On Thu, 14 Feb 2008, Guy Hulbert wrote: > > > On Thu, 2008-02-14 at 09:41 -0500, Chris Lewis wrote: > >> Like Solaris usually does (grr), "hostname" returns the host node > >> name > >> (no dots), not the FQDN. > > > > This is correct behav

Re: config wierdness

2008-02-14 Thread Guy Hulbert
On Thu, 2008-02-14 at 10:22 -0500, Chris Lewis wrote: > Using FQDN in, say, "helo" isn't an unfortunate linux novelty, it's a > requirement by RFC821/2821. RFC821/2821 do not say anything about the hostname command, afiak. -- --gh

Re: config wierdness

2008-02-14 Thread Chris Lewis
Guy Hulbert wrote: On Thu, 2008-02-14 at 09:41 -0500, Chris Lewis wrote: Like Solaris usually does (grr), "hostname" returns the host node name (no dots), not the FQDN. This is correct behaviour. IYO, NMO ;-) Sun's hostname command, iirc, uses the hosts table and is well-documented[*]. Y

Re: config wierdness

2008-02-14 Thread Charlie Brady
On Thu, 14 Feb 2008, Guy Hulbert wrote: On Thu, 2008-02-14 at 09:41 -0500, Chris Lewis wrote: Like Solaris usually does (grr), "hostname" returns the host node name (no dots), not the FQDN. This is correct behaviour. Maybe *that* is, but is *this*? config/me contains the FQDN, but $self->

Re: config wierdness

2008-02-14 Thread Guy Hulbert
On Thu, 2008-02-14 at 09:41 -0500, Chris Lewis wrote: > Like Solaris usually does (grr), "hostname" returns the host node > name > (no dots), not the FQDN. This is correct behaviour. Sun's hostname command, iirc, uses the hosts table and is well-documented[*]. You can have it return long names

config wierdness

2008-02-14 Thread Chris Lewis
Running qpsmtpd-async 0.42rc1 on Solaris 2.9 (Yes, qpsmtpd runs rather well on that). Queueing (if any) is done by a homebrew Net::SMTP plugin. No qmail. Like Solaris usually does (grr), "hostname" returns the host node name (no dots), not the FQDN. config/me contains the FQDN, but $self->q