Re: ident/p0f plugin

2009-04-01 Thread Robert Spier
Thanks, I've reformatted it a little bit and comitted it as 2491f63f069aaf708d5f1980a08a10a7f43d6f70, and have asked Ask to pull it into the main repository. -R Tom Callahan wrote: > > Oops, disregard that, I was silly. Too much copy paste with not > enough attention paid to what I was doing

Re: ident/p0f plugin

2009-04-01 Thread Tom Callahan
Oops, disregard that, I was silly. Too much copy paste with not enough attention paid to what I was doing ;) Please let me know if this one looks better (I tested it, it too works and should fail more gracefully). Thanks, Tom Tom Callahan wrote: I just did the minimal modification to get i

Re: ident/p0f plugin

2009-04-01 Thread Tom Callahan
I just did the minimal modification to get it working with the new p0f API (it does indeed work for me); theoretically it should be roughly as complete as the old p0f plugin. In the interests of completeness I'll fix it up and send in a better version though. Thanks, Tom Robert Spier wrote:

Re: ident/p0f plugin

2009-03-31 Thread Robert Spier
Thanks Tom, but did you test this? It might work, but failure cases aren't going to. It references log_err and cleanup:, neither of which exist. (Turns out the whole plugin needs some rewriting to fail better, it has some dies that need removing.) Tom Callahan wrote: > > I think it was discus