Re: Source cleanup, was Re: async and tls take two

2008-05-05 Thread Ask Bjørn Hansen
On May 5, 2008, at 8:31 AM, Steve Kemp wrote: I'll have to beat myself later, in the meantime here's a patch against SVN trunk: http://www.steve.org.uk/Software/tmp/qpsmtpd/qpsmtpd-txn-transaction.diff Committed, thanks! (r885) Might be worth removing the file "log/.cvsignore" from th

Re: Source cleanup, was Re: async and tls take two

2008-05-05 Thread Ask Bjørn Hansen
On May 5, 2008, at 8:22 AM, Steve Kemp wrote: I'm not 100% familiar with the Makefile.PL in the source directory, but I see that there is already a "perltidyrc" file, so it shouldn't be a huge job to automate the invocation of perltidy. For now if we just made a habit of running perltidy on

Re: Source cleanup, was Re: async and tls take two

2008-05-05 Thread Steve Kemp
On Mon May 05, 2008 at 16:22:34 +0100, Steve Kemp wrote: > I will submit a patch against the trunk hopefully tomorrow. Hmm, that was actually a small job. It seems that I was being inconsistent much more in my *own* plugins than the core is. Ahem. I'll have to beat myself later, in the

Source cleanup, was Re: async and tls take two

2008-05-05 Thread Steve Kemp
On Mon May 05, 2008 at 11:06:18 -0400, Matt Sergeant wrote: > Yes, it has been discussed before. We just need the tuits to make it so. I'm not 100% familiar with the Makefile.PL in the source directory, but I see that there is already a "perltidyrc" file, so it shouldn't be a huge job to auto

Re: async and tls take two

2008-05-05 Thread Matt Sergeant
On 5-May-08, at 10:45 AM, Steve Kemp wrote: Seeing changes like this makes me wonder if we should consider running all source through perltidy at some point. Perhaps as part of a "make update", or "make commit" target. Yes, it has been discussed before. We just need the tuits to make it

Re: async and tls take two

2008-05-05 Thread Steve Kemp
On Sun May 04, 2008 at 21:21:03 -0400, Matt Sergeant wrote: > --- plugins/tls (revision 876) > +++ plugins/tls (working copy) > @@ -150,7 +150,7 @@ > return DECLINED unless $local_port == 465; # SMTPS > > unless ( _convert_to_ssl($self) ) { > - return (DENY_DISCONNECT, "Cannot esta

Re: async and tls take two

2008-05-04 Thread Douglas Hunter
Matt Sergeant wrote: On 4-May-08, at 7:28 PM, Matt Sergeant wrote: Yeah this makes a lot more sense... Though I wonder if we shouldn't modify Danga::Client to just have some sort of "reader" entry, so that anything else (not just TLS) can hook into the event_read stream. I'll have a poke. C

Re: async and tls take two

2008-05-04 Thread Matt Sergeant
On 4-May-08, at 7:28 PM, Matt Sergeant wrote: Yeah this makes a lot more sense... Though I wonder if we shouldn't modify Danga::Client to just have some sort of "reader" entry, so that anything else (not just TLS) can hook into the event_read stream. I'll have a poke. Can you check if thi

Re: async and tls take two

2008-05-04 Thread Matt Sergeant
Yeah this makes a lot more sense... Though I wonder if we shouldn't modify Danga::Client to just have some sort of "reader" entry, so that anything else (not just TLS) can hook into the event_read stream. I'll have a poke. On 4-May-08, at 12:59 PM, Douglas Hunter wrote: Howdy all, In the