On 5-May-08, at 10:45 AM, Steve Kemp wrote:
Seeing changes like this makes me wonder if we should consider
running
all source through perltidy at some point. Perhaps as part of a
"make update", or "make commit" target.
Yes, it has been discussed before. We just need the tuits to make it so.
ObRelated: I would be happy to submit a patch to unify plugin
argument names. I see big differences between:
./queue/exim-bsmtp: my ( $self, $txn ) = @_;
./logging/file: my ( $self, $txn ) = @_;
And:
./virus/clamav: my ( $self, $transaction ) = @_;
./valid_users: my ( $self, $transaction, $sender, %param ) = @_;
For example. I'd suggest s/txn/transaction/g on all plugins
shipped with the core distribution, because I think the verbosity
and consistency wouldn't be a bad thing.
That would be a nice easy project for someone with a bit of time on
their hands... (hint hint)
Matt.
