In the short term, I've reverted your change in my branch, and will
send that upstream to ask.
-R
Jared Johnson wrote:
>
> - my $self = shift;
> - my $key = shift;
> - @_ and $self->{_notes}->{$key} = shift;
> - #warn Data::Dumper->Dump([\$self->{_notes}], [qw(notes)]);
> - $self->{_notes
- my $self = shift;
- my $key = shift;
- @_ and $self->{_notes}->{$key} = shift;
- #warn Data::Dumper->Dump([\$self->{_notes}], [qw(notes)]);
- $self->{_notes}->{$key};
+ my ($self,$key,$value) = @_;
+ $self->{_notes}->{$key} = $value if defined $value;
+ return $self->{_notes}->{$key};
Applied to my tree as commit ea86b9fdb242be7b4aca8a5acfec6ad30360fc9f
Will get into the main tree eventually.
Jared Johnson wrote:
>
> > Jared, if you still want Address notes, please submit a patch with
> > just that functionality.
>
> See address_notes_minor.diff and address_notes_sans_retur
Jared, if you still want Address notes, please submit a patch with
just that functionality.
See address_notes_minor.diff and address_notes_sans_return_self.diff in
this thread :)
-Jared
Matt Sergeant wrote:
>
> On Fri, 09 Jan 2009 22:00:36 -0600, Jared Johnson wrote:
> > Most notably for Address:host(), user(),
> > notes() and Connection::notes(), Transaction::notes(): it changes the
> > 'set' version of these get/set methods to return $self. This makes it
> > possible to do t
I can't say I don't hope you're overruled, as I personally enjoy using
that syntax all over the place and would be happy to submit patches to
have the rest of QP act that way :) Nevertheless, here's another
variant that retains the previous behavior, but with the more
standard/one-line-shorter
On Fri, 09 Jan 2009 22:00:36 -0600, Jared Johnson wrote:
> Most notably for Address:host(), user(),
> notes() and Connection::notes(), Transaction::notes(): it changes the
> 'set' version of these get/set methods to return $self. This makes it
> possible to do things like:
>
> $rcpt->user('jaredj
