Matt Sergeant wrote:
>
> On Fri, 09 Jan 2009 22:00:36 -0600, Jared Johnson wrote:
> > Most notably for Address:host(), user(),
> > notes() and Connection::notes(), Transaction::notes(): it changes the
> > 'set' version of these get/set methods to return $self. This makes it
> > possible to do things like:
> >
> > $rcpt->user('jaredj')->host('nmgi.com')->notes(score => 5.0);
> >
> > where one was previously forced to do:
> >
> > $rcpt->user('jaredj');
> > $rcpt->host('nmgi.com');
> > $rcpt->notes(score => 5.0);
>
> Honestly I'd reject this part of the patch. It's contrary to what every
> other setter in qpsmtpd does, and makes for unintuitive code anyway.
I'd reject it too. It goes against our historical style, and I agree
it makes it more confusing to read.
Jared, if you still want Address notes, please submit a patch with
just that functionality.
-R
