On Wed, Aug 29, 2012 at 1:38 PM, Peter Maydell wrote:
> On 22 August 2012 19:03, Max Filippov wrote:
>> --- a/target-xtensa/xtensa-semi.c
>> +++ b/target-xtensa/xtensa-semi.c
>> @@ -218,6 +218,8 @@ void HELPER(simcall)(CPUXtensaState *env)
>>
>> default:
On Wed, Aug 29, 2012 at 2:34 PM, Peter Maydell wrote:
> On 29 August 2012 11:13, Max Filippov wrote:
>> On Wed, Aug 29, 2012 at 1:38 PM, Peter Maydell
>> wrote:
>>> On 22 August 2012 19:03, Max Filippov wrote:
>>>> --- a/target-xtensa/xtensa-semi.c
&g
Guest errno values are taken from the newlib. Convert only those errno
values that can be returned from used system calls.
Signed-off-by: Max Filippov
---
target-xtensa/xtensa-semi.c | 106 +++---
1 files changed, 98 insertions(+), 8 deletions(-)
diff --git
dex in initializer not of integer type
/home/buildbot/slave-public/default_mingw32/build/target-xtensa/xtensa-semi.c:134:
error: (near initialization for 'guest_errno')
Will put those under #ifdefs...
--
Thanks.
-- Max
index in initializer not of integer type
xtensa-semi.c:124: error: (near initialization for 'guest_errno')
xtensa-semi.c:134: error: 'ELOOP' undeclared (first use in this function)
xtensa-semi.c:134: error: array index in initializer not of integer type
xtensa-semi.c:134: error:
On Thu, Sep 6, 2012 at 8:45 AM, Stefan Weil wrote:
> Am 06.09.2012 02:36, schrieb Max Filippov:
>
>> Put the following errno value mappings under #ifdef:
>>
>> xtensa-semi.c: In function 'errno_h2g':
>> xtensa-semi.c:113: error: 'ENOTBLK' un
On Sat, Sep 8, 2012 at 12:22 AM, Stefan Weil wrote:
> Am 06.09.2012 14:48, schrieb Max Filippov:
>
>> On Thu, Sep 6, 2012 at 8:45 AM, Stefan Weil wrote:
>>>
>>> Am 06.09.2012 02:36, schrieb Max Filippov:
>>>
>>>> Put the following errno value
fpu/softfloat.h
@@ -219,7 +219,7 @@ void float_raise( int8 flags STATUS_PARAM);
enum {
float_muladd_negate_c = 1,
float_muladd_negate_product = 2,
-float_muladd_negate_result = 3,
+float_muladd_negate_result = 4,
};
/*----
--
Thanks.
-- Max
This series implements floating point coprocessor and coprocessor context
options for xtensa and fixes a couple of bugs to make it work.
Max Filippov (9):
softfloat: make float_muladd_negate_* flags independent
target-xtensa: handle boolean option in overlays
target-xtensa: specialize
Flags passed into float{32,64}_muladd are treated as bits; assign
independent bits to float_muladd_negate_* to allow precise control over
what gets negated in float{32,64}_muladd.
Signed-off-by: Max Filippov
---
fpu/softfloat.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
Signed-off-by: Max Filippov
---
target-xtensa/overlay_tool.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-xtensa/overlay_tool.h b/target-xtensa/overlay_tool.h
index a3a5650..e395053 100644
--- a/target-xtensa/overlay_tool.h
+++ b/target-xtensa/overlay_tool.h
NaN propagation rule: leftmost NaN in the expression gets propagated to
the result.
Signed-off-by: Max Filippov
---
fpu/softfloat-specialize.h |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h
index 4902450
There are 16 32-bit FP registers (f0 - f15), control and status user
registers (fcr, fsr).
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
gdbstub.c |8 +++
target-xtensa/cpu.h |3 ++
target-xtensa/helper.h|2 +
target-xtensa
These are load/store instructions for FP registers with immediate or
register index and optional base post-update.
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
target-xtensa/translate.c | 58 +---
1 files changed, 54 insertions
These are FP arithmetic opcodes.
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
target-xtensa/helper.h|7 +
target-xtensa/op_helper.c | 37 +++
target-xtensa/translate.c | 61 -
3 files
These are FP to integer and integer to FP conversion opcodes.
See ISA, 4.3.10 for more details.
Note that utrunc.s implementation follows ISS behaviour, not ISA.
Signed-off-by: Max Filippov
---
target-xtensa/helper.h|4 +++
target-xtensa/op_helper.c | 43
In case Coprocessor Context option is enabled CPENABLE SR bits control
whether access to coprocessors is allowed or would rise one of
CoprocessorXDisabled exceptions.
See ISA, 4.4.5 for more details.
FP is coprocessor 0.
Signed-off-by: Max Filippov
---
target-xtensa/cpu.h |5
These are comparison and conditional move opcodes.
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
target-xtensa/helper.h|8
target-xtensa/op_helper.c | 47 ++
target-xtensa/translate.c | 81
On Sun, Sep 9, 2012 at 1:31 PM, Peter Maydell wrote:
> On 9 September 2012 02:29, Max Filippov wrote:
>> @@ -262,9 +263,13 @@ float32 float32_maybe_silence_nan( float32 a_ )
>> #error Rules for silencing a signaling NaN are target-specific
>> # endif
>&g
On Sun, Sep 9, 2012 at 2:05 PM, Peter Maydell wrote:
> On 9 September 2012 02:29, Max Filippov wrote:
>> +float32 HELPER(abs_s)(float32 v)
>> +{
>> +return float32_abs(v);
>> +}
>> +
>> +float32 HELPER(neg_s)(float32 v)
>> +{
>> +return
On Sun, Sep 9, 2012 at 3:06 PM, Peter Maydell wrote:
> On 9 September 2012 02:29, Max Filippov wrote:
>> +uint32_t HELPER(ftoui)(float32 v, uint32_t rounding_mode, uint32_t scale)
>> +{
>> +float_status fp_status = {0};
>> +float32 zero = {0};
>
> This p
On Sun, Sep 9, 2012 at 4:13 PM, Max Filippov wrote:
> On Sun, Sep 9, 2012 at 1:31 PM, Peter Maydell
> wrote:
>> the Xtensa ISA it says it doesn't have signaling NaNs. Maybe
>> it would be better to have a define for NO_SIGNALING_NANS
>> which made float*_is_signal
FP-to-integer convertors with float32_scalbn
- reimplement comparison with zero in FP-to-integer convertors
Max Filippov (10):
softfloat: make float_muladd_negate_* flags independent
softfloat: add NO_SIGNALING_NANS
target-xtensa: handle boolean option in overlays
target-xtensa: special
In case Coprocessor Context option is enabled CPENABLE SR bits control
whether access to coprocessors is allowed or would rise one of
CoprocessorXDisabled exceptions.
See ISA, 4.4.5 for more details.
FP is coprocessor 0.
Signed-off-by: Max Filippov
---
target-xtensa/cpu.h |5
There are 16 32-bit FP registers (f0 - f15), control and status user
registers (fcr, fsr).
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
Changes v1->v2:
- add float32_val/make_float32 to fp registers accessors
gdbstub.c |8 +++
target-xtensa/cp
These are load/store instructions for FP registers with immediate or
register index and optional base post-update.
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
target-xtensa/translate.c | 58 +---
1 files changed, 54 insertions
These are FP to integer and integer to FP conversion opcodes.
See ISA, 4.3.10 for more details.
Note that utrunc.s implementation follows ISS behaviour, not ISA.
Signed-off-by: Max Filippov
---
Changes v1->v2:
- replace float32_mul/div in FP-to-integer convertors with float32_sca
On Sun, Sep 9, 2012 at 8:16 PM, Peter Maydell wrote:
> On 9 September 2012 17:04, Max Filippov wrote:
>> These are FP to integer and integer to FP conversion opcodes.
>> See ISA, 4.3.10 for more details.
>>
>> Note that utrunc.s implementation follows ISS behaviour,
Architectures that don't have signaling NaNs can define
NO_SIGNALING_NANS, it will make float*_is_quiet_nan return 1 for any NaN
and float*_is_signaling_nan always return 0.
Signed-off-by: Max Filippov
---
fpu/softfloat-specialize.h | 64
These are FP arithmetic opcodes.
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
target-xtensa/helper.h|7 +
target-xtensa/op_helper.c | 37 +++
target-xtensa/translate.c | 61 -
3 files
These are comparison and conditional move opcodes.
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
target-xtensa/helper.h|8
target-xtensa/op_helper.c | 47 ++
target-xtensa/translate.c | 81
Flags passed into float{32,64}_muladd are treated as bits; assign
independent bits to float_muladd_negate_* to allow precise control over
what gets negated in float{32,64}_muladd.
Signed-off-by: Max Filippov
Reviewed-by: Aurelien Jarno
---
fpu/softfloat.h |2 +-
1 files changed, 1
Signed-off-by: Max Filippov
---
target-xtensa/overlay_tool.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-xtensa/overlay_tool.h b/target-xtensa/overlay_tool.h
index a3a5650..e395053 100644
--- a/target-xtensa/overlay_tool.h
+++ b/target-xtensa/overlay_tool.h
NaN propagation rule: leftmost NaN in the expression gets propagated to
the result.
Signed-off-by: Max Filippov
---
Changes v1->v2:
- drop float32_maybe_silence_nan specialization
fpu/softfloat-specialize.h |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/
On Sun, Sep 9, 2012 at 9:24 PM, Marc Gauthier wrote:
> Hi Max,
>
> Max Filippov wrote:
>> On Sun, Sep 9, 2012 at 8:16 PM, Peter Maydell
>> wrote:
>> > On 9 September 2012 17:04, Max Filippov wrote:
>> >> These are FP to integer and integer to FP con
udio-card-list=pcspk
>
> It looks like this particular configuration never worked, since
> xtensa-softmmu was introduced (commit
> cfa550c6acc6718c3f932e858366e3e1e81266d6).
Other embedded platforms (I've tried cris-softmmu, lm32-softmmu, or32-softmmu,
sh4-softmmu) give the same result.
> Does it even make sense to have a PC-speaker on a Xtensa machine?
> Should the machine have a i8254 PIT?
I doubt that it's meaningful for any of the mentioned _architectures_,
definitely not for xtensa.
--
Thanks.
-- Max
wer's tcg - gototb's target was expected to be
> always filled via tb_set_jmp_target (even though it's clearly not what
> tcg/README prescribes, sorry about that).
--
Thanks.
-- Max
d drop float32_maybe_silence_nan specialization
- fix fp registers access in gdbstub
- replace float32_mul/div in FP-to-integer convertors with float32_scalbn
- reimplement comparison with zero in FP-to-integer convertors
Max Filippov (10):
softfloat: make float_muladd_negate_* flags independent
softfloa
NaN propagation rule: leftmost NaN in the expression gets propagated to
the result.
Signed-off-by: Max Filippov
---
fpu/softfloat-specialize.h |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h
index 50b54b8
There are 16 32-bit FP registers (f0 - f15), control and status user
registers (fcr, fsr).
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
gdbstub.c |8 +++
target-xtensa/cpu.h |3 ++
target-xtensa/helper.h|2 +
target-xtensa
These are FP to integer and integer to FP conversion opcodes.
See ISA, 4.3.10 for more details.
Note that ISA description for utrunc.s is currently incorrect and will
be fixed in future revisions.
Signed-off-by: Max Filippov
---
target-xtensa/helper.h|4 +++
target-xtensa/op_helper.c
On Sun, Sep 9, 2012 at 8:38 PM, Max Filippov wrote:
> On Sun, Sep 9, 2012 at 8:16 PM, Peter Maydell
> wrote:
>> On 9 September 2012 17:04, Max Filippov wrote:
>>> These are FP to integer and integer to FP conversion opcodes.
>>> See ISA, 4.3.10 for more detai
Signed-off-by: Max Filippov
---
target-xtensa/overlay_tool.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-xtensa/overlay_tool.h b/target-xtensa/overlay_tool.h
index a3a5650..e395053 100644
--- a/target-xtensa/overlay_tool.h
+++ b/target-xtensa/overlay_tool.h
These are FP arithmetic opcodes.
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
target-xtensa/helper.h|7 +
target-xtensa/op_helper.c | 37 +++
target-xtensa/translate.c | 61 -
3 files
These are load/store instructions for FP registers with immediate or
register index and optional base post-update.
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
target-xtensa/translate.c | 58 +---
1 files changed, 54 insertions
Flags passed into float{32,64}_muladd are treated as bits; assign
independent bits to float_muladd_negate_* to allow precise control over
what gets negated in float{32,64}_muladd.
Signed-off-by: Max Filippov
Reviewed-by: Aurelien Jarno
---
fpu/softfloat.h |2 +-
1 files changed, 1
In case Coprocessor Context option is enabled CPENABLE SR bits control
whether access to coprocessors is allowed or would rise one of
CoprocessorXDisabled exceptions.
See ISA, 4.4.5 for more details.
FP is coprocessor 0.
Signed-off-by: Max Filippov
---
target-xtensa/cpu.h |5
Architectures that don't have signaling NaNs can define
NO_SIGNALING_NANS, it will make float*_is_quiet_nan return 1 for any NaN
and float*_is_signaling_nan always return 0.
Signed-off-by: Max Filippov
---
fpu/softfloat-specialize.h | 67
These are comparison and conditional move opcodes.
See ISA, 4.3.10 for more details.
Signed-off-by: Max Filippov
---
target-xtensa/helper.h|8
target-xtensa/op_helper.c | 47 ++
target-xtensa/translate.c | 81
On Wed, Sep 19, 2012 at 4:49 PM, malc wrote:
> On Wed, 19 Sep 2012, Max Filippov wrote:
>
>> On Tue, Sep 18, 2012 at 11:52 PM, malc wrote:
>> >
>> > Looks like PPC/PPC64 is also hit by shift issues, on top of that xtensa
>>
>> malc, could you pleas
b_handle_packet().
>>
>> Reported-by: Aneesh Kumar K.V
>> Cc: qemu-sta...@nongnu.org (for 1.6)
>> Cc: Peter Maydell
>> Cc: Max Filippov
>> Signed-off-by: Andreas Färber
>> ---
>> gdbstub.c | 6 --
>> include/qom/cpu.h | 2 ++
>>
Signed-off-by: Max Filippov
---
target-xtensa/translate.c | 8
1 file changed, 8 insertions(+)
diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c
index 504cc53..c82d988 100644
--- a/target-xtensa/translate.c
+++ b/target-xtensa/translate.c
@@ -3018,6 +3018,14 @@ void
| 35 ---
> 2 files changed, 41 insertions(+), 7 deletions(-)
[...]
> +obj-$(CONFIG_STRONARM) += strongarm.o
Typo in config symbol name.
--
Thanks.
-- Max
336 100644
> --- a/default-configs/m68k-softmmu.mak
> +++ b/default-configs/m68k-softmmu.mak
> @@ -4,3 +4,6 @@ include pci.mak
> include usb.mak
> CONFIG_COLDFIRE=y
> CONFIG_PTIMER=y
> +CONFIG_AN5206=y
> +CONFIG_DUMMY_M68K=y
> +CONFIG_MCF5208=y
--
Thanks.
-- Max
A new test on corrupted images with overlapping cluster allocations.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/060 | 107 +
tests/qemu-iotests/060.out | 43 ++
tests/qemu-iotests/group | 1 +
3 files changed, 151
Adds a new function checking for overlapping cluster allocations.
Furthermore, qcow2_check now marks the image as consistent if no
corruptions have been found.
Signed-off-by: Max Reitz
---
block/qcow2-cluster.c | 414 ++
block/qcow2.c
-by: Max Reitz
---
block/qcow2-refcount.c | 142 +
block/qcow2.h | 28 ++
2 files changed, 170 insertions(+)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 1244693..c8141c8 100644
--- a/block/qcow2-refcount.c
This adds an incompatible bit indicating corruption to qcow2. Any image
with this bit set may not be written to unless for repairing (and
subsequently clearing the bit if the repair has been successful).
Signed-off-by: Max Reitz
---
block/qcow2.c | 44
The pre-write overlap check function is now called before most of the
qcow2 writes (aborting it on collision or other error).
Signed-off-by: Max Reitz
---
block/qcow2-cache.c| 17 +
block/qcow2-cluster.c | 23 +++
block/qcow2-snapshot.c | 24
If a qcow2 image file becomes corrupted, any write may inadvertently
overwrite important metadata structures such as the L1 table. This
series adds functionality for detecting, preventing and (to some
extent) repairing such collisions.
Max Reitz (5):
qcow2: Add corrupt bit
qcow2: Metadata
Hi,
On Mon, Aug 26, 2013 at 15:04 +0200, Max Reitz wrote:
Adds a new function checking for overlapping cluster allocations.
Furthermore, qcow2_check now marks the image as consistent if no
corruptions have been found.
Signed-off-by: Max Reitz
Such overlappings are often (if not always) found
This adds an incompatible bit indicating corruption to qcow2. Any image
with this bit set may not be written to unless for repairing (and
subsequently clearing the bit if the repair has been successful).
Signed-off-by: Max Reitz
---
block/qcow2.c | 44
If a qcow2 image file becomes corrupted, any write may inadvertently
overwrite important metadata structures such as the L1 table. This
series adds functionality for detecting, preventing and (to some
extent) repairing such collisions.
Max Reitz (5):
qcow2: Add corrupt bit
qcow2: Metadata
-by: Max Reitz
---
block/qcow2-refcount.c | 142 +
block/qcow2.h | 28 ++
2 files changed, 170 insertions(+)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 1244693..c8141c8 100644
--- a/block/qcow2-refcount.c
Adds a new function checking for overlapping cluster allocations.
Furthermore, qcow2_check now marks the image as consistent if no
corruptions have been found.
Signed-off-by: Max Reitz
---
block/qcow2-cluster.c | 414 ++
block/qcow2.c
The pre-write overlap check function is now called before most of the
qcow2 writes (aborting it on collision or other error).
Signed-off-by: Max Reitz
---
block/qcow2-cache.c| 17 +
block/qcow2-cluster.c | 23 +++
block/qcow2-snapshot.c | 24
A new test on corrupted images with overlapping cluster allocations.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/060 | 107 +
tests/qemu-iotests/060.out | 43 ++
tests/qemu-iotests/group | 1 +
3 files changed, 151
Hi,
Okay, so this did arrive after all (albeit 4 h late) – sorry for the
duplicate (see the series from 15:18).
Kind regards,
Max
Am 27.08.2013 11:54, schrieb Kevin Wolf:
Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
This adds an incompatible bit indicating corruption to qcow2. Any image
with this bit set may not be written to unless for repairing (and
subsequently clearing the bit if the repair has been successful
Am 27.08.2013 12:17, schrieb Kevin Wolf:
Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
Two new functions are added; the first one checks a given range in the
image file for overlaps with metadata (main header, L1 tables, L2
tables, refcount table and blocks).
The second one should be used
Am 27.08.2013 13:32, schrieb Kevin Wolf:
Am 26.08.2013 um 15:04 hat Max Reitz geschrieben:
The pre-write overlap check function is now called before most of the
qcow2 writes (aborting it on collision or other error).
Signed-off-by: Max Reitz
---
block/qcow2-cache.c| 17
ve the irq at -12002...
> irq:[927016]receive the irq at -12002...
> irq:[927017]receive the irq at -12002...
> irq:[927018]receive the irq at -12002...
> ...
> can somebody tell me what's wrong?
You have raised IRQ in your pl061_raise_irq(), but you haven't lowered it.
--
Thanks.
-- Max
-by: Max Reitz
---
block/qcow2-cluster.c | 66 ++
block/qcow2.c | 182 ++
block/qcow2.h | 2 +
3 files changed, 250 insertions(+)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index cca76d4..ac50db2
This series adds support to qemu-img, block and qcow2 for amending image
options on existing image files.
Max Reitz (3):
block: Image file option amendment
qcow2: Implement bdrv_amend_options
qemu-iotest: qcow2 image option amendment
block.c| 8 ++
block/qcow2
Add tests for qemu-img amend on qcow2 image files.
Signed-off-by: Max Reitz
---
This test is numbered 061 for not interfering with my "metadata overlap
checks" series (although I will have to adapt my code to those new checks
anyway when/if they are included in master).
---
tests/qe
This patch adds the "amend" option to qemu-img which allows changing
image options on existing image files. It also adds the generic bdrv
implementation which is basically just a wrapper for the image format
specific function.
Signed-off-by: Max Reitz
---
block.c
l
qemu_set_irq(gPl061->irq, 0)
and write to that register from your driver's ISR.
Or you can choose an edge-triggered IRQ to play with.
> 2013/8/27 Max Filippov
>>
>> On Tue, Aug 27, 2013 at 3:55 PM, she roy wrote:
>> > How to lower it? Thank you very much!
>&g
led by level.
You need to update GPIOIC register from your driver's ISR to clear it.
>
> 2013/8/28 Max Filippov
>>
>> On Wed, Aug 28, 2013 at 12:01 PM, she roy wrote:
>> > I tested qemu_irq_pulse(gPl061->irq); the guest did not generate an
>> > interr
On Wed, Aug 28, 2013 at 12:27 PM, Max Filippov wrote:
> On Wed, Aug 28, 2013 at 12:19 PM, she roy wrote:
>> PL061 has a register GPIOIS to control if the interrupt is lever-triggered
>> or edge-triggered, I will try this. Thanks.
>
> This register defines which event on
Hi,
Am 28.08.2013 13:06, schrieb Kevin Wolf:
Am 28.08.2013 um 10:08 hat Max Reitz geschrieben:
Implement bdrv_amend_options for compat, size, backing_file, backing_fmt
and lazy_refcounts.
Downgrading images from compat=1.1 to compat=0.10 is achieved through
handling all incompatible flags
Am 28.08.2013 13:40, schrieb Kevin Wolf:
Am 28.08.2013 um 10:08 hat Max Reitz geschrieben:
Add tests for qemu-img amend on qcow2 image files.
Signed-off-by: Max Reitz
---
This test is numbered 061 for not interfering with my "metadata overlap
checks" series (although I will have t
Hi,
Am 28.08.2013 13:48, schrieb Kevin Wolf:
Am 28.08.2013 um 13:39 hat Max Reitz geschrieben:
+/* clear incompatible features */
+if (s->incompatible_features & QCOW2_INCOMPAT_DIRTY) {
+BdrvCheckResult result;
+ret = qcow2_check(bs, &result, BDRV
Hi,
Am 28.08.2013 13:54, schrieb Kevin Wolf:
Am 28.08.2013 um 13:47 hat Max Reitz geschrieben:
Am 28.08.2013 13:40, schrieb Kevin Wolf:
Am 28.08.2013 um 10:08 hat Max Reitz geschrieben:
Add tests for qemu-img amend on qcow2 image files.
Signed-off-by: Max Reitz
---
This test is numbered
ality
Max Reitz (5):
qcow2: Add corrupt bit
qcow2: Metadata overlap checks
qcow2: Employ metadata overlap checks
qcow2: More complete consistency check
qemu-iotests: Overlapping cluster allocations
block/qcow2-cache.c| 17 ++
block/qcow2-cluster.c | 25 ++-
block/
This adds an incompatible bit indicating corruption to qcow2. Any image
with this bit set may not be written to unless for repairing (and
subsequently clearing the bit if the repair has been successful).
Signed-off-by: Max Reitz
---
block/qcow2.c | 45
A new test on corrupted images with overlapping cluster allocations.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/060 | 111 +
tests/qemu-iotests/060.out | 37 +++
tests/qemu-iotests/group | 1 +
3 files changed, 149 insertions
The qcow2_check_refcounts function has been extended to be able to fix
OFLAG_COPIED errors and multiple references on refcount blocks.
If no corruptions remain after an image repair (and no errors have been
encountered), clear the corrupt flag in qcow2_check.
Signed-off-by: Max Reitz
---
block
-by: Max Reitz
---
block/qcow2-refcount.c| 148 ++
block/qcow2.h | 28 +
include/monitor/monitor.h | 1 +
monitor.c | 1 +
4 files changed, 178 insertions(+)
diff --git a/block/qcow2-refcount.c b/block/qcow2
The pre-write overlap check function is now called before most of the
qcow2 writes (aborting it on collision or other error).
Signed-off-by: Max Reitz
---
block/qcow2-cache.c| 17 +
block/qcow2-cluster.c | 21 +
block/qcow2-snapshot.c | 22
Am 29.08.2013 10:23, schrieb Kevin Wolf:
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
This adds an incompatible bit indicating corruption to qcow2. Any image
with this bit set may not be written to unless for repairing (and
subsequently clearing the bit if the repair has been successful
Am 29.08.2013 10:51, schrieb Kevin Wolf:
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
Two new functions are added; the first one checks a given range in the
image file for overlaps with metadata (main header, L1 tables, L2
tables, refcount table and blocks).
The second one should be used
Adds an "assigned" flag to QEMUOptionParameter which is cleared at the
beginning of parse_option_parameters and set on (successful)
set_option_parameter and set_option_parameter_int.
Signed-off-by: Max Reitz
---
include/qemu/option.h | 1 +
util/qemu-option.c| 9 +
2 fil
Am 29.08.2013 11:18, schrieb Kevin Wolf:
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
The pre-write overlap check function is now called before most of the
qcow2 writes (aborting it on collision or other error).
Signed-off-by: Max Reitz
---
block/qcow2-cache.c| 17
Do not try to update the refcount for zero clusters in
qcow2_update_snapshot_refcount.
Signed-off-by: Max Reitz
---
block/qcow2-refcount.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 1244693..7555242
Zero cluster expansion for inactive L2 tables
- Correct handling of preallocated zero clusters
- More test cases
Max Reitz (3):
block: Image file option amendment
qcow2: Implement bdrv_amend_options
qemu-iotest: qcow2 image option amendment
block.c| 8 ++
block/
Add tests for qemu-img amend on qcow2 image files.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/061 | 152 ++
tests/qemu-iotests/061.out | 318 +
tests/qemu-iotests/group | 1 +
3 files changed, 471 insertions(+)
create
This patch adds the "amend" option to qemu-img which allows changing
image options on existing image files. It also adds the generic bdrv
implementation which is basically just a wrapper for the image format
specific function.
Signed-off-by: Max Reitz
---
block.c
-by: Max Reitz
---
block/qcow2-cluster.c | 154 ++
block/qcow2.c | 184 ++
block/qcow2.h | 2 +
3 files changed, 340 insertions(+)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
Am 29.08.2013 13:36, schrieb Kevin Wolf:
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
The qcow2_check_refcounts function has been extended to be able to fix
OFLAG_COPIED errors and multiple references on refcount blocks.
If no corruptions remain after an image repair (and no errors have
Am 29.08.2013 14:30, schrieb Eric Blake:
On 08/29/2013 04:16 AM, Max Reitz wrote:
Do not try to update the refcount for zero clusters in
qcow2_update_snapshot_refcount.
Why? What does this fix?
(Hint - your commit message could use more details, and you should add a
testsuite addition that
101 - 200 of 14987 matches
Mail list logo
