Re: [Qemu-devel] [RESEND][PATCH for 1.2] audio: Make pcspk card selectable again

2012-08-16 Thread malc
On Thu, 16 Aug 2012, Jan Kiszka wrote: > Since we moved pcspk into hwlib, CONFIG_PCSPK is no longer defined per > target. Therefore, statically built soundhw array in arch_init.c stopped > including this card. > > Work around this by re-adding this define to config-target.mak. > Long-term, a dyna

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-23 Thread malc
On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > After applying this version 2 of this patch series, I can > successfully run "Micoport UNIX System V/386, v 2.1" (ca 1987) > under qemu. (although not if I try to enable KVM) > > Version 1 of this series was posted about 4 weeks ago. See > http://pa

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Jan Kiszka wrote: > On 2012-08-24 05:58, malc wrote: > > On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > > > >> After applying this version 2 of this patch series, I can > >> successfully run "Micoport UNIX System V/386, v 2.1" (ca

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Jan Kiszka wrote: > On 2012-08-24 14:02, malc wrote: > > On Fri, 24 Aug 2012, Jan Kiszka wrote: > > > >> On 2012-08-24 05:58, malc wrote: > >>> On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > >>> > >>>

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Aurelien Jarno wrote: > On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: > > Optionally, make memory access helpers take a parameter for CPUState > > instead of relying on global env. > > > > On most targets, perform simple moves to reorder registers. On i386, > >

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread malc
On Fri, 24 Aug 2012, malc wrote: > On Fri, 24 Aug 2012, Aurelien Jarno wrote: > > > On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: [..snip..] > > - On 32 bit hosts, which usually need register alignments for 64-bit > > values (at least on arm and mips),

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Andreas F?rber wrote: > Am 24.08.2012 17:35, schrieb malc: > > On Fri, 24 Aug 2012, malc wrote: > > > >> On Fri, 24 Aug 2012, Aurelien Jarno wrote: > >> > >>> On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: > >

Re: [Qemu-devel] [PATCH] linux-user: If loading fails, print error as string, not number

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Peter Maydell wrote: > If the attempt to load the guest executable fails, print the > error message as a string, not a number. This requires us to > fix a couple of places in loader_exec() where we were returning > -1 instead of a valid negative errno. > > The change allows u

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-27 Thread malc
On Mon, 27 Aug 2012, Anthony Liguori wrote: > malc writes: > > > On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > > > >> After applying this version 2 of this patch series, I can > >> successfully run "Micoport UNIX System V/386, v 2.1" (ca 1987) >

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-27 Thread malc
On Mon, 27 Aug 2012, Anthony Liguori wrote: > malc writes: > [..snip..] > > > > Number 2 was, and should stay, as the emulation wasn't correct before it, > > don't really care about the rest. > > Okay, please revert the rest then. > Done. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH]] audio: previous audio buffer should be flushed

2012-08-28 Thread malc
On Tue, 28 Aug 2012, munkyu.im wrote: > Winwave audio backend has problem with pausing and restart audio out. > Unlike other backends, Winwave pausing API does not flush audio buffer. > As a result, the previous audio data are playedin front of > user expected sound when user restart audio. > So c

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 07:40:56PM +, Blue Swirl wrote: > > On Mon, Aug 27, 2012 at 7:24 PM, Michael S. Tsirkin wrote: > > > On Mon, Aug 27, 2012 at 07:12:27PM +, Blue Swirl wrote: > > >> On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:24:40PM +0100, Peter Maydell wrote: > > On 28 August 2012 17:01, Michael S. Tsirkin wrote: > > > We copied HACKING from libvirt but it has some bogus stuff: > > > neither underscore capital, double underscore, or undersco

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Peter Maydell wrote: > On 28 August 2012 18:21, Michael S. Tsirkin wrote: > > We are talking about stuff like __kvm_pv_eoi - so the chance is exactly 0. > > And if it does happen then you run a simple script and fix > > this one instance. > > Why not just use a name that doe

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Anthony Liguori wrote: > Blue Swirl writes: > > > On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: > >> On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: > >>> On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > >>> > On 27.08.2012 22:56, Blue Swi

[Qemu-devel] Sanity

2012-02-07 Thread malc
This is a 32bit machine, the target is i386-softmmu, yet, libhw32 is mostly empty and libhw64 is populated, furthermore[1]: $ rm libhw64/ac97.o $ make V=1 make BUILD_DIR=/home/malc/x/bld/qemu/master -C libhw64 V="1" TARGET_DIR="libhw64/" all make[1]: Entering directory `/

Re: [Qemu-devel] Help - `flush_icache_range' MacPPC

2012-02-07 Thread malc
On Tue, 7 Feb 2012, Alexander Graf wrote: > > On 07.02.2012, at 13:52, Maurizio Caloro wrote: > > > Hello Together > > Here i drive with me MiniMac G4 1.4Ghz and i try to run Qemu 1.0. i wan't > > run one Virt. MS Server2008 it's this realistic?. > > > > Unfortunitly from the first (other) Mai

Re: [Qemu-devel] Help - `flush_icache_range' MacPPC

2012-02-07 Thread malc
On Tue, 7 Feb 2012, Maurizio Caloro wrote: > Hello Together > Here i drive with me MiniMac G4 1.4Ghz and i try to run Qemu 1.0. i wan't run > one Virt. MS Server2008 it's this realistic?. > > Unfortunitly from the first (other) Mailinglist i don't become any Answer. > > on a possible error reco

Re: [Qemu-devel] Help - `flush_icache_range' MacPPC

2012-02-07 Thread malc
On Tue, 7 Feb 2012, Alexander Graf wrote: > > On 07.02.2012, at 22:12, malc wrote: > > > On Tue, 7 Feb 2012, Alexander Graf wrote: > > > >> > >> On 07.02.2012, at 13:52, Maurizio Caloro wrote: > >> > >>> Hello Together > >>

Re: [Qemu-devel] [PATCH] PPC64: Add support for ldbrx and stdbrx instructions

2012-02-07 Thread malc
On Wed, 8 Feb 2012, David Gibson wrote: > From: Thomas Huth > > These instructions for loading and storing byte-swapped 64-bit values have > been introduced in PowerISA 2.06. > > Signed-off-by: Thomas Huth > --- > target-ppc/translate.c | 30 ++ > 1 files changed

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread malc
On Wed, 8 Feb 2012, Andreas F?rber wrote: > malc, > > Arbitrarily reformatting your files is not okay. If you want a different > formatting, you need to fix checkpatch.pl first to not error on that > formatting in your files. It was always formatter like this (internally co

Re: [Qemu-devel] [PATCH] make: Remove duplicate use of GLIB_CFLAGS

2012-02-08 Thread malc
On Wed, 8 Feb 2012, Stefan Weil wrote: > Makefile, Makefile.hw, Makefile.target and libcacard/Makefile > added GLIB_CFLAGS to QEMU_CFLAGS. > > Makefile.objs does this, too, and is included by all other > Makefiles, so GLIB_CFLAGS were added twice (reported by malc). > Tha

Re: [Qemu-devel] [PATCH v2] qom: Unify type registration

2012-02-09 Thread malc
semicolon after the closing brace. > > Signed-off-by: Andreas F?rber > Cc: Anthony Liguori > Cc: malc No objectsions, thanks for the effort. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-09 Thread malc
On Thu, 9 Feb 2012, Andreas F?rber wrote: > Disable warnings for spaces before opening parenthesis in > hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. > > Signed-off-by: Andreas F?rber > Cc: Blue Swirl > Cc: malc Thanks. > --- > scripts/checkpatch.pl |5 +++

Re: [Qemu-devel] [PATCH] make: Remove duplicate use of GLIB_CFLAGS

2012-02-09 Thread malc
On Wed, 8 Feb 2012, Stefan Weil wrote: > Makefile, Makefile.hw, Makefile.target and libcacard/Makefile > added GLIB_CFLAGS to QEMU_CFLAGS. > > Makefile.objs does this, too, and is included by all other > Makefiles, so GLIB_CFLAGS were added twice (reported by malc). Applied, t

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-09 Thread malc
On Fri, 10 Feb 2012, Evgeny Voevodin wrote: > On 02/09/2012 06:59 PM, Andreas F?rber wrote: > > Disable warnings for spaces before opening parenthesis in > > hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. > > Why audio files are such a special thing? Because they are consistently formatted the way t

Re: [Qemu-devel] How to follow a child process created in the guest OS?

2012-02-10 Thread malc
On Sat, 11 Feb 2012, Andreas F?rber wrote: > Am 10.02.2012 11:26, schrieb ???: > > On Fri, Feb 10, 2012 at 08:14:41AM +, Stefan Hajnoczi wrote: > >> On Thu, Feb 09, 2012 at 06:33:16PM +0800, ??? wrote: > >>> I am running a tiny OS on QEMU and debugging it with gdbstub. The tiny OS > >>> will

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-16 Thread malc
On Thu, 16 Feb 2012, Michael S. Tsirkin wrote: > Use scanf instead of manual string scanning. > > Signed-off-by: Michael S. Tsirkin > --- > hw/pci.c | 81 > +- > 1 files changed, 38 insertions(+), 43 deletions(-) > > diff --git a/h

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-16 Thread malc
On Thu, 16 Feb 2012, Eric Blake wrote: > On 02/16/2012 12:23 PM, malc wrote: > > On Thu, 16 Feb 2012, Michael S. Tsirkin wrote: > > > >> Use scanf instead of manual string scanning. > >> > >> + > >> +/* Parse [[:]:] */ > &g

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-17 Thread malc
On Fri, 17 Feb 2012, Michael S. Tsirkin wrote: > On Thu, Feb 16, 2012 at 11:23:40PM +0400, malc wrote: > > > +{ > > > +unsigned dom, bus, slot, func; > > > +int n = -1; > > > + > > > +/* Parse [[:]:] */ > > > +sscanf(addr,

Re: [Qemu-devel] bug in popcnt emulation with some register operand(s)?

2012-10-10 Thread malc
On Thu, 11 Oct 2012, Andriy Gapon wrote: > on 08/10/2012 12:02 Andriy Gapon said the following: > > on 08/10/2012 10:52 malc said the following: > >> On Mon, 8 Oct 2012, Andriy Gapon wrote: > >> > >>> > >>> I am running Qemu (plain, no kvm, et

Re: [Qemu-devel] bug in popcnt emulation with some register operand(s)?

2012-10-14 Thread malc
On Sun, 14 Oct 2012, Andriy Gapon wrote: [..snip..] > > Hmm... Since you are the author of the patch, wouldn't be more > appropriate for you to submit it? Besides, I can only mostly repeat the > bug report as I do not quite understand the code and can not properly > describe what the patch do

Re: [Qemu-devel] [PATCH 00/11] static patches

2012-10-14 Thread malc
On Sun, 14 Oct 2012, Blue Swirl wrote: > On Sun, Oct 14, 2012 at 7:58 PM, Blue Swirl wrote: > > I made a small tool to detect unused functions and > > variables. Here's some fixes. > > Just run the attached tool in an object directory and after some time, > it will produce a list of suspect symb

Re: [Qemu-devel] [PATCH 2/2] target-arm: Implement abs_i32 inline rather than as a helper

2012-10-18 Thread malc
On Thu, 18 Oct 2012, Peter Maydell wrote: [..snip..] > > -/* FIXME: Implement this natively. */ > -#define tcg_gen_abs_i32(t0, t1) gen_helper_abs(t0, t1) > +static void tcg_gen_abs_i32(TCGv dest, TCGv src) > +{ > +TCGv c0 = tcg_const_i32(0); > +printf("tcg_gen_abs_i32\n"); ^^^

Re: [Qemu-devel] [PATCH 03/12] hw/pl080: Use LOG_GUEST_ERROR and LOG_UNIMP

2012-10-25 Thread malc
On Thu, 25 Oct 2012, Peter Maydell wrote: > Use LOG_GUEST_ERROR and LOG_UNIMP in preference to hw_error(). It's weird that printing something + abort is replaced by just printing a message and the commit message doesn't really reflect the fact. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH] HACKING: List areas where we may rely on impdef C behaviour

2012-10-30 Thread malc
On Tue, 30 Oct 2012, Peter Maydell wrote: > Add a section to HACKING describing the bits of implementation > defined C compiler behaviour which C code in QEMU is allowed > to rely on. People who will desperately do a text search for "behaviour" in relevant standards will soon learn that the briti

Re: [Qemu-devel] [PATCH] HACKING: List areas where we may rely on impdef C behaviour

2012-10-30 Thread malc
On Tue, 30 Oct 2012, Peter Maydell wrote: > On 30 October 2012 16:40, malc wrote: > > On Tue, 30 Oct 2012, Peter Maydell wrote: > > > >> Add a section to HACKING describing the bits of implementation > >> defined C compiler behaviour which C code i

Re: [Qemu-devel] [PATCH] TCG: Fix compile breakage in tcg_dump_ops

2012-06-23 Thread malc
On Sun, 24 Jun 2012, Alexander Graf wrote: > Commit eeacee4d865 changed the syntax of tcg_dump_ops, but didn't convert > all users (notably missing the ppc ones) to it. Fix them to the new syntax. Applied. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-25 Thread malc
On Mon, 25 Jun 2012, Peter Maydell wrote: > Add field32() and field64() functions which extract a particular > bit field from a word and return it. Based on an idea by Jia Liu. > > Suggested-by: Jia Liu > Signed-off-by: Peter Maydell > --- [..snip..] > +static inline uint64_t field64(uint64_t

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-20 Thread malc
On Thu, 20 Sep 2012, Max Filippov wrote: > On Wed, Sep 19, 2012 at 11:53 PM, Richard Henderson wrote: > > On 09/19/2012 11:30 AM, Peter Maydell wrote: > >> ...but on the other hand that ought to work for PPC too, so > >> presumably my analysis is wrong somewhere. > > > > It isn't. It's a target-

Re: [Qemu-devel] [PATCH 0/2] target-xtensa: fix extui and gen_check_loop_end

2012-09-20 Thread malc
On Fri, 21 Sep 2012, Max Filippov wrote: > Max Filippov (2): > target-xtensa: fix extui shift amount > target-xtensa: don't emit extra tcg_gen_goto_tb > > target-xtensa/translate.c | 28 > 1 files changed, 24 insertions(+), 4 deletions(-) > Applied, thanks.

Re: [Qemu-devel] [PATCH v2 0/7] tcg: movcond (ppc32 version)

2012-09-21 Thread malc
diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index 26c4b33..0fb6fc7 100644 --- a/tcg/ppc/tcg-target.c +++ b/tcg/ppc/tcg-target.c @@ -390,6 +390,7 @@ static int tcg_target_const_match(tcg_target_long val, #define ORCXO31(412) #define EQVXO31(284) #define NAND XO31(476) +#def

Re: [Qemu-devel] [PATCH v2 0/7] tcg: movcond (ppc32 version)

2012-09-21 Thread malc
On Fri, 21 Sep 2012, Richard Henderson wrote: > On 09/21/2012 01:10 PM, malc wrote: > > +if (dest == v2) { > > +label_ptr = s->code_ptr; > > +tcg_out32 (s, tcg_to_bc[tcg_invert_cond (cond)]); > > +tcg_out_

Re: [Qemu-devel] [PATCH 1/8] tcg: Adjust descriptions of *cond opcodes

2012-09-22 Thread malc
On Fri, 21 Sep 2012, Richard Henderson wrote: > The README file documented the operand ordering of the tcg_gen_* > functions. Since we're documenting opcodes here, use the true > operand ordering. Thanks, looks good. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH] audio: Fix warning from static code analysis

2012-09-22 Thread malc
On Sat, 22 Sep 2012, Stefan Weil wrote: > Am 03.09.2012 21:25, schrieb Stefan Weil: > > smatch report: > > audio/audio_template.h:416 AUD_open_out(18) warn: > > variable dereferenced before check 'as' (see line 414) > > > > Moving the ldebug statement after the statement which checks 'as' > > f

Re: [Qemu-devel] [PATCH 1/2] linux-user: ppc: mark as long long aligned

2012-10-01 Thread malc
On Sun, 30 Sep 2012, Alexander Graf wrote: > The PPC32 ABI dictates that long long (64bit) parameters are pass in odd/even > register pairs. Because unlike ARM and MIPS we start at an odd register > number, > we can reuse the same aligning code that ARM and MIPS use. > > Signed-off-by: Alexander

Re: [Qemu-devel] bug in popcnt emulation with some register operand(s)?

2012-10-08 Thread malc
On Mon, 8 Oct 2012, Andriy Gapon wrote: > > I am running Qemu (plain, no kvm, etc) on an AMD 10h machine that > provides popcnt instruction. Qemu advertises availability of pocnt > to a guest as well. What I see in the guest that popcnt > 0x20(%r12),%r8 instruction actually placed its result in

[Qemu-devel] Breakage

2012-09-17 Thread malc
Some(thing|one) broke compilation with pcspk enabled. Symptoms being: ../libhw32/hw/pcspk.o: In function `pcspk_io_write': /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to `pit_set_gate' ../libhw32/hw/pcspk.o: In function `pcspk_io_read': /home/malc/x/rcs/git/qemu

Re: [Qemu-devel] Breakage

2012-09-17 Thread malc
On Mon, 17 Sep 2012, Anthony Liguori wrote: > malc writes: > > > Some(thing|one) broke compilation with pcspk enabled. > > Symptoms being: > > > > ../libhw32/hw/pcspk.o: In function `pcspk_io_write': > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:145:

Re: [Qemu-devel] Breakage

2012-09-18 Thread malc
On Tue, 18 Sep 2012, Max Filippov wrote: > On Tue, Sep 18, 2012 at 12:15 AM, Eduardo Habkost wrote: > > On Mon, Sep 17, 2012 at 11:54:42PM +0400, malc wrote: > >> On Mon, 17 Sep 2012, Anthony Liguori wrote: > >> > >> > malc writes: > >> > &g

[Qemu-devel] Shifts, ppc[64], xtensa

2012-09-18 Thread malc
Looks like PPC/PPC64 is also hit by shift issues, on top of that xtensa exposed another bug in power's tcg - gototb's target was expected to be always filled via tb_set_jmp_target (even though it's clearly not what tcg/README prescribes, sorry about that). Thanks to Max Filippov for pointing to

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-19 Thread malc
On Tue, 18 Sep 2012, Richard Henderson wrote: > On 09/18/2012 12:52 PM, malc wrote: > > case INDEX_op_shl_i32: > > if (const_args[2]) { > > +if (args[2] > 31) { > > +tcg_out_movi (s, TCG_TYPE_I32, 0, args[2]); > > +

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-19 Thread malc
On Wed, 19 Sep 2012, Max Filippov wrote: > On Tue, Sep 18, 2012 at 11:52 PM, malc wrote: > > > > Looks like PPC/PPC64 is also hit by shift issues, on top of that xtensa > > malc, could you please expand a little bit what are these shift issues? > (sounds like a modern t

Re: [Qemu-devel] [PATCH 0/5] tcg: movcond

2012-09-19 Thread malc
deferring the issue to the register > allocator instead of trying to do that in the backend. > > >From my side, I am ok with it. That said I'd also like to have at least > the opinion of Malc and Blue (Cc:ed). Comments from others are also > welcome. I don't hav

Re: [Qemu-devel] [PATCH] arch_init.c: Improve '-soundhw help' for non-HAS_AUDIO_CHOICE archs

2012-09-19 Thread malc
On Wed, 19 Sep 2012, Peter Maydell wrote: > For architectures which don't set HAS_AUDIO_CHOICE, improve the > '-soundhw help' message so that it doesn't simply print an empty > list, implying no sound support at all. > [..snip..] Applied, thanks. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH 3/3] hw/: Introduce spec. ver. 2.00 compliant SD host controller

2011-12-26 Thread malc
On Mon, 26 Dec 2011, Mitsyanko Igor wrote: > This patch adds implementation of "SD specification version 2.00" compliant > SD host controller. Also it provides interface to implement SoC-specific > controllers on top of this specification-compliant one. > [..snip..] > + > +void sdhcv2_reset(SDHC

Re: [Qemu-devel] [PATCH 06/11] hw/ac97: add support for volume control

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > Combine output volume with Master and PCM registers values. > Use default values in mixer_reset (). > Set volume on post-load to update backend values. > --- > hw/ac97.c | 79 > + > 1 fi

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > Hello, > > This patch series implements client-side audio volume support. This > reduces confusion of guest users when volume control is not effective > (because mixemu is disabled or because client-side is muted and can't be > unmuted by the gue

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > It's more appropriate to set the maximum value into a fitting integer. > --- > audio/audio.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/audio/audio.c b/audio/audio.c > index bd9237e..06c2384 100644 > --- a/audi

Re: [Qemu-devel] [PATCH 08/11] Do not use pa_simple PulseAudio API

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > Unfortunately, pa_simple is a limited API which doesn't let us > retrieve the associated pa_stream. It is needed to control the volume > of the stream. > --- > audio/paaudio.c | 356 > +-- > 1 fi

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 9:03 PM, malc wrote: > > How's putting UINT_MAX into int64_t more appropriate? UINT_MAX is > > even one less than one in 32.32 fixpoint... I must be missing something > > here. > > Right, th

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > Hi Vassili > > Thanks for your review! > > On Mon, Mar 12, 2012 at 8:44 PM, malc wrote: > > a. Pulse/Spice have per connection volume > > Each playback/recorde stream has it's own volume, and that's what

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 9:29 PM, malc wrote: > >> So what I meant is rather G_MAXUINT32. > > > > Just leave it as is, it's perfectly fine. > > But it's not convenient to fit into a regular integer, as the

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 9:51 PM, malc wrote: > >> > >> > b. Other drivers are not affected > >> > >> I don't see yet how, but I will review other drivers ctl_{in,out} > >> implementations >

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Anthony Liguori wrote: > On 03/12/2012 03:43 PM, Peter Maydell wrote: > > On 12 March 2012 20:29, Anthony Liguori wrote: > > > On 03/12/2012 03:24 PM, Peter Maydell wrote: > > > > I agree that that's a specific area it would be nice to do > > > > better in. It seems to me tha

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 10:00 PM, malc wrote: > > I really do not understand your point at all, mixeng_volume fields > > are int64_t's it's irrelevant what you initialize them with, they > > are still 64bit integers,

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 10:11 PM, malc wrote: > >> AUD_set_volume_out (SWVoiceOut *sw, int mute, uint8_t lvol..) > >> > >> sw->vol.l = nominal_volume.l * lvol / 255; > >> > >> So the range was [0

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Anthony Liguori wrote: > On 03/12/2012 04:09 PM, malc wrote: > > On Mon, 12 Mar 2012, Anthony Liguori wrote: > > > > > On 03/12/2012 03:43 PM, Peter Maydell wrote: > > > > On 12 March 2012 20:29, Anthony Liguori wrote: > > > &g

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Anthony Liguori wrote: > On 03/12/2012 04:43 PM, malc wrote: > > On Mon, 12 Mar 2012, Anthony Liguori wrote: > > > Patch came on a Thursday and was applied on a Saturday. That's pretty > > > much > > > one business day. > > >

Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of UINT_MAX

2012-03-12 Thread malc
On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 10:42 PM, malc wrote: > > nominal_volume.[lr] is int64_t... i don't get where you take this ^32 > > from. > > from where it is defined, audio/audio.c: > > const struct mixeng_volume no

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)

2012-03-13 Thread malc
On Tue, 13 Mar 2012, Marc-Andr? Lureau wrote: > On Tue, Mar 13, 2012 at 11:19 AM, Gerd Hoffmann wrote: > > I think we should remove the mixemu configure option.  It makes code > > bitrot.  Patch #4 proves that.  If you want to keep it because of the > > overhead or other reasons I'd suggest to ma

Re: [Qemu-devel] [PATCH v4 05/11] hw/ac97: add support for volume control

2012-03-13 Thread malc
On Tue, 13 Mar 2012, Marc-Andr? Lureau wrote: > Combine output volume with Master and PCM registers values. > Use default values in mixer_reset (). > Set volume on post-load to update backend values. > > v4: > - fix some code style Don't think it fixes anything... > > Signed-off-by: Marc-Andr?

Re: [Qemu-devel] [PATCH v4 11/11] audio/rfc: remove PLIVE and PERIOD options

2012-03-13 Thread malc
On Tue, 13 Mar 2012, Marc-Andr? Lureau wrote: > - period seems to be unused now > - plive is very obscure and should either be documented or perhaps removed Plive is obscure because the use case was, in any case it's been years since i've used it so it can, probably, safely go away. Period on th

Re: [Qemu-devel] [PATCH v4 05/11] hw/ac97: add support for volume control

2012-03-13 Thread malc
On Tue, 13 Mar 2012, Marc-Andr? Lureau wrote: > On Tue, Mar 13, 2012 at 4:37 PM, malc wrote: > > On Tue, 13 Mar 2012, Marc-Andr? Lureau wrote: > > > >> Combine output volume with Master and PCM registers values. > >> Use default values in mixer_reset (). >

[Qemu-devel] Breakage

2012-03-18 Thread malc
97161e177b4ea2730dff13c4df01475762ab6048 broke booting of a DOS image i've been using for years, the VM stalls at "Booting from hard disk" BIOS message never making any progress. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] Breakage

2012-03-18 Thread malc
On Sun, 18 Mar 2012, Avi Kivity wrote: > On 03/18/2012 06:12 PM, malc wrote: > > 97161e177b4ea2730dff13c4df01475762ab6048 broke booting of a DOS image > > i've been using for years, the VM stalls at "Booting from hard disk" > > BIOS message never making any

Re: [Qemu-devel] [PATCH 2/2] ppc: Use uintptr_t for arguments of ppc_tb_set_jmp_target

2012-03-19 Thread malc
On Mon, 19 Mar 2012, Stefan Weil wrote: > The previous commit changed function tb_set_jmp_target1 and is needed > for w64 hosts. > > This patch is not needed for w64, but it synchronizes tb_set_jmp_target1 > and ppc_tb_set_jmp_target so that both functions have the same signature

Re: [Qemu-devel] [PATCH 2/2] ppc: Use uintptr_t for arguments of ppc_tb_set_jmp_target

2012-03-19 Thread malc
On Mon, 19 Mar 2012, Andreas F?rber wrote: > Am 19.03.2012 22:33, schrieb malc: > > On Mon, 19 Mar 2012, Stefan Weil wrote: > > > >> The previous commit changed function tb_set_jmp_target1 and is needed > >> for w64 hosts. > >> > >> Th

Re: [Qemu-devel] [PATCH] qemu tcg: Remove one entry of INDEX_op_ld_i64 from ppc_op_defs

2012-03-29 Thread malc
On Thu, 29 Mar 2012, David Gibson wrote: > From: Li Zhang > > There two entries of INDEX_op_ld_i64 in the ppc_op_defs. That causes an > assertion failure in tcg_add_target_add_op_defs() when --enable-debug is > used on a ppc64 backend (that's ppc64 host, not target). > Thanks, applied. [..sn

Re: [Qemu-devel] [PATCH 1/3] Add ppc_init_cacheline_sizes() function for OpenBSD.

2011-05-26 Thread malc
On Wed, 25 May 2011, Brad wrote: > Add ppc_init_cacheline_sizes() function for OpenBSD to fix compilation > of PowerPC host support for OpenBSD/powerpc based architectures. > > Signed-off-by: Brad Smith > > --- > cache-utils.c | 11 +-- > 1 files changed, 9 insertions(+), 2 deletions

Re: [Qemu-devel] [PATCH 1/3] Add ppc_init_cacheline_sizes() function for OpenBSD.

2011-05-26 Thread malc
On Thu, 26 May 2011, Brad wrote: > - Original message - > > On Wed, 25 May 2011, Brad wrote: > > > > > Add ppc_init_cacheline_sizes() function for OpenBSD to fix compilation > > > of PowerPC host support for OpenBSD/powerpc based architectures. > > > > > > Signed-off-by: Brad Smith > >

Re: [Qemu-devel] [PATCH] host-pcc: enable building with -m32 or -m64

2011-05-26 Thread malc
On Thu, 26 May 2011, Stefan Berger wrote: > With the below patch I can build either ppc (-m32) or ppc64 (-m64) versions of > Qemu (on a ppc64 host) when passing these compiler flags via 'configure ... > --extra-cflags="-m32"'. > > Signed-off-by: Stefan Berger > > --- > configure |9 +++

Re: [Qemu-devel] [PATCH] host-pcc: enable building with -m32 or -m64

2011-05-26 Thread malc
On Thu, 26 May 2011, Stefan Berger wrote: > On 05/26/2011 04:20 PM, Andreas F?rber wrote: > > Am 26.05.2011 um 21:00 schrieb Stefan Berger: > > > > > With the below patch I can build either ppc (-m32) or ppc64 (-m64) > > > versions of Qemu (on a ppc64 host) when passing these compiler flags via >

Re: [Qemu-devel] [PATCH 1/3] Add ppc_init_cacheline_sizes() function for OpenBSD.

2011-05-26 Thread malc
On Thu, 26 May 2011, Brad wrote: > On 26/05/11 9:15 AM, malc wrote: > > On Thu, 26 May 2011, Brad wrote: > > > > > - Original message - > > > > On Wed, 25 May 2011, Brad wrote: > > > > > > > > > Add ppc_init_cacheline_sizes

Re: [Qemu-devel] [PATCH] audio: fix integer overflow expression

2011-05-31 Thread malc
On Tue, 31 May 2011, Peter Maydell wrote: > From: Juha Riihim?ki > > Fix an integer overflow that can happen for signed 32 bit types > when using FLOAT_MIXENG. (Note that at the moment this is only true > when using the MacOSX coreaudio audio driver.) > > Signed-off-by: Juha Riihim?ki > Review

Re: [Qemu-devel] [PATCH v2] audio: fix integer overflow expression

2011-05-31 Thread malc
ff-by: Juha Riihim?ki > [Peter Maydell: Removed unnecessary casts] > Signed-off-by: Peter Maydell > --- > v1->v2 : as suggested by Malc, removed one unnecessary cast > from each change. Applied with minor stylistic change, thanks to all involved. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-03 Thread malc
On Fri, 3 Jun 2011, Aurelien Jarno wrote: > On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: > > pulse/simple.h does not include stdlib.h > > We cannot use NULL since it may not be defined > > Use 0 instead > > I am unable to reproduce this issue, even with gcc-4.6. Also ple

Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-06-03 Thread malc
On Sat, 4 Jun 2011, Aurelien Jarno wrote: > On Sat, Jun 04, 2011 at 01:57:23AM +0400, malc wrote: > > On Fri, 3 Jun 2011, Aurelien Jarno wrote: > > > > > On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote: > > > > pulse/simple.h does not in

Re: [Qemu-devel] [patch 2/7] Add blkmirror block driver

2011-06-06 Thread malc
On Mon, 6 Jun 2011, Marcelo Tosatti wrote: > Mirrored writes are used by live block copy. > > Signed-off-by: Marcelo Tosatti > > Index: qemu-block-copy/block/blkmirror.c > === > --- /dev/null > +++ qemu-block-copy/block/blkmirror.c

Re: [Qemu-devel] [PATCH v2 3/3] move unaligned memory access functions to bswap.h

2011-06-06 Thread malc
On Mon, 6 Jun 2011, Richard Henderson wrote: > Patches 1-3: > Reviewed-by: Richard Henderson > > That said, > > On 06/06/2011 09:25 AM, Paolo Bonzini wrote: > > +/* conservative code for little endian unaligned accesses */ > > +static inline int lduw_le_p(const void *ptr) > > +{ > > +#ifdef _AR

Re: [Qemu-devel] [PATCH v2 3/3] move unaligned memory access functions to bswap.h

2011-06-07 Thread malc
On Tue, 7 Jun 2011, Richard Henderson wrote: > On 06/06/2011 04:07 PM, malc wrote: > > Depends on how bswap_16 is defined. If it is __builtin_bswap16 > > then 4.5.0 and 4.6.0 generate byte reversed loads, and previous > > versions lack that builtin, so i don't think th

Re: [Qemu-devel] assigned EHCI USB headset not working

2011-06-09 Thread malc
e invoking qemu helps? It > >> depends on your host-side interface. Using ALSA here, it is generally > >> required. > >> > >> Note that this discussion rather belongs on qemu-devel. > > > > Thank you very much. Setting the variable did the trick. > > Could this perhaps be included in the man page? I am sure there will be > > others who will eventually run into the same problem as I did. > > It is a long-standing issue of QEMU that I always wanted to understand > but never found the time for. CC'ing malc, maybe he has a good idea how > to finally attack this. > Attack what exactly? -- mailto:av1...@comtv.ru

Re: [Qemu-devel] assigned EHCI USB headset not working

2011-06-09 Thread malc
On Thu, 9 Jun 2011, Jan Kiszka wrote: > On 2011-06-09 17:13, malc wrote: > > On Thu, 9 Jun 2011, Jan Kiszka wrote: > > [..snip..] > > Sound output over (at least) ALSA is not smoothly working in polled > mode. It's similar to [1], which is yet uns

Re: [Qemu-devel] [Bug 796480] [NEW] Addresses with 4GB differences are consider as one single address in QEMU

2011-06-13 Thread malc
On Mon, 13 Jun 2011, Khansa Butt wrote: > Public bug reported: > > THIS IS THE ISSUE OF USER MODE EMULATION > Information about guest and host > ** > guest: 64 bit x86 user mode binary > host: 32 bit Linux OS > uname -a :Linux KICS-HPCNL-32blue 2.6.33.3-85.fc13.i68

Re: [Qemu-devel] [PATCH] target-i386: fix cmpxchg

2011-06-17 Thread malc
On Fri, 17 Jun 2011, Christoph Egger wrote: > Correct emulation of i386 cmpxchg instruction in the case where the > comparison outcome is unequal and the memory write causes a page > fault. > > From: Andreas Gustafsson > Signed-off-by: Christoph Egger We've been through this a couple of times

Re: [Qemu-devel] [PATCH] Optimize screendump

2011-06-19 Thread malc
On Sun, 19 Jun 2011, Avi Kivity wrote: CONFORMING TO The four functionsgetc_unlocked(), getchar_unlocked(), putc_unlocked(), putchar_unlocked() are in POSIX.1-2001. The non-standard *_unlocked() variants occur on a few Unix systems, and are available in rece

Re: [Qemu-devel] [PATCH 14/18] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1

2011-06-19 Thread malc
On Mon, 20 Jun 2011, Blue Swirl wrote: > Use TCG_REG_CALL_STACK instead of TCG_REG_R1 etc. for consistency. You spell it TCG_REG_CALL_STACK in the subject/comment but REG_CALL_STACK in the patch, which suggest that it was never even compile tested. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Alexander Graf wrote: > > On 25.07.2011, at 12:09, Avi Kivity wrote: > > > On 07/25/2011 01:04 PM, Alexander Graf wrote: > >> On 25.07.2011, at 12:02, Avi Kivity wrote: > >> > >> > On 07/25/2011 12:56 PM, Alexander Graf wrote: > >> >> > > >> >> > That argument can be u

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Anthony Liguori wrote: > On 07/25/2011 09:30 AM, Max Filippov wrote: > > > > > > > > qemu_malloc() is type-unsafe as it returns a void pointer. > > > > > > > > Introduce > > > > > > > > QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. > > > > > > > > > > > > > > J

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Avi Kivity wrote: > On 07/25/2011 05:47 PM, malc wrote: > > Right right.. only g_new aborts on zero.. > > > > "If n_structs is 0 it returns NULL > <http://developer.gnome.org/glib/2.28/glib-Standard-Macros.html#NULL:CAPS>. " Right yo

  1   2   3   4   5   6   7   8   >