Re: [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'

2014-10-21 Thread Chen Gang
Good news for us! thank you for your work. :-) Thanks Send from Lenovo A788t. Peter Maydell wrote: >On 9 October 2014 15:00, Chen Gang wrote: >> The related variables are useless, need be removed, or can not pass >> microblaze building, after fix it, can build microblaz

Re: [Qemu-devel] [Consult] microblaze: About running upstream main branch qemu

2014-10-21 Thread Chen Gang
21, 2014 at 06:41:14PM +0800, Chen Gang wrote: >> On 10/21/14 12:37, Guenter Roeck wrote: >> > On 10/20/2014 08:23 AM, Chen Gang wrote: >> >> On 10/19/2014 10:58 PM, Guenter Roeck wrote: >> >>> >> >>> This doesn't use devicetree, but the

[Qemu-devel] [RESEND PATCH v4 03/10] acpi, mem-hotplug: Add acpi_memory_hotplug_sci() to rise sci for memory hotplug.

2014-10-22 Thread Tang Chen
Add a new API named acpi_memory_hotplug_sci() to send memory hotplug SCI. Doing this is because this procedure will be used by other functions in the next coming patches. Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 12 1 file changed, 8 insertions(+), 4 deletions

[Qemu-devel] [RESEND PATCH v4 05/10] acpi, piix4: Add memory hot unplug support for piix4.

2014-10-22 Thread Tang Chen
From: Hu Tao Implement acpi_memory_unplug_cb(), sending an sci to guest to trigger memory hot-remove, and call it in piix4_device_unplug_cb(). Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/acpi/piix4.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/acpi

[Qemu-devel] [RESEND PATCH v4 00/10] QEmu memory hot unplug support.

2014-10-22 Thread Tang Chen
k. Hu Tao (4): acpi, piix4: Add memory hot unplug support for piix4. pc: Add memory hot unplug support for pc machine. pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support. pc, acpi bios: Add memory hot unplug interface. Tang Chen (6): acpi, mem-hotplug: Use PC_DIMM

[Qemu-devel] [RESEND PATCH v4 01/10] acpi, mem-hotplug: Use PC_DIMM_SLOT_PROP in acpi_memory_plug_cb().

2014-10-22 Thread Tang Chen
Replace string "slot" in acpi_memory_plug_cb() with MACRO PC_DIMM_SLOT_PROP. Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c index ed39241..c6580da 10064

[Qemu-devel] [RESEND PATCH v4 04/10] acpi, mem-hotplug: Add acpi_memory_unplug_cb() to implement memory unplug.

2014-10-22 Thread Tang Chen
Add a new bool member named is_removing to MemStatus indicating that the memory solt is being removed. Set it to true in acpi_memory_unplug_cb(), and send SCI to guest. Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 15 +++ include/hw/acpi/memory_hotplug.h | 3

[Qemu-devel] [RESEND PATCH v4 10/10] pc, acpi bios: Add memory hot unplug interface.

2014-10-22 Thread Tang Chen
From: Hu Tao This patch implements MEMORY_SLOT_EJECT_METHOD according to ACPI spec. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/i386/ssdt-mem.dsl | 5 + hw/i386/ssdt-misc.dsl| 13 - include/hw/acpi/pc-hotplug.h | 2 ++ 3 files changed, 19

[Qemu-devel] [RESEND PATCH v4 02/10] acpi, mem-hotplug: Add acpi_memory_get_slot_status_descriptor() to get MemStatus.

2014-10-22 Thread Tang Chen
Add a new API named acpi_memory_get_slot_status_descriptor() to obtain a single memory slot status. Doing this is because this procedure will be used by other functions in the next coming patches. Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 27 +++ 1 file

[Qemu-devel] [RESEND PATCH v4 08/10] pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support.

2014-10-22 Thread Tang Chen
From: Hu Tao Implement unrealize function for pc-dimm device. It remove subregion from hotplug region, and delete ram address range from guest ram list. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/mem/pc-dimm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/mem

[Qemu-devel] [RESEND PATCH v4 06/10] acpi, ich9: Add memory hot unplug support for ich9.

2014-10-22 Thread Tang Chen
Implement ich9_pm_device_unplug_cb() to support memory hot-remove, calling acpi_memory_unplug_cb(). And itself will be called in ich9_device_unplug_cb(). Signed-off-by: Tang Chen --- hw/acpi/ich9.c | 12 hw/isa/lpc_ich9.c | 5 +++-- include/hw/acpi/ich9.h | 2 ++ 3

[Qemu-devel] [RESEND PATCH v4 09/10] acpi: Add hardware implementation for memory hot unplug.

2014-10-22 Thread Tang Chen
Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- docs/specs/acpi_mem_hotplug.txt | 8 ++-- hw/acpi/memory_hotplug.c| 14 +++--- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/docs/specs/acpi_mem_hotplug.txt b/docs/specs/acpi_mem_hotplug.txt index 1290994..5

[Qemu-devel] [RESEND PATCH v4 07/10] pc: Add memory hot unplug support for pc machine.

2014-10-22 Thread Tang Chen
From: Hu Tao Implement device unplug callback for PCMachine. And it now only support pc-dimm hot-remove. The callback will call piix4 or ich9 callbacks introduced in previous patches. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/i386/pc.c | 31 +++ 1 file

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-24 Thread Chen, Tiejun
On 2014/10/12 17:50, Michael S. Tsirkin wrote: On Thu, Oct 09, 2014 at 01:53:16PM +0800, Chen, Tiejun wrote: On 2014/10/7 15:26, Michael S. Tsirkin wrote: On Tue, Sep 30, 2014 at 10:43:09AM +0800, Chen, Tiejun wrote: On 2014/9/29 18:01, Michael S. Tsirkin wrote: On Sun, Sep 28, 2014 at 10

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-ppc: kvm: Fix memory overflow issue about strncat()

2014-10-24 Thread Chen Gang
On 10/24/14 15:49, Michael Tokarev wrote: > On 10/13/2014 06:47 PM, Alexander Graf wrote: >> On 13.10.14 16:36, Chen Gang wrote: >>> strncat() will append additional '\0' to destination buffer, so need >>> additional 1 byte for it, or may cause memory over

Re: [Qemu-devel] [Consult] microblaze: About running upstream main branch qemu

2014-10-26 Thread Chen Gang
And I still shall try qemu and kernel distribution for testing. But excuse me, maybe I can not finish within this month, I shall try to finish within next month. Thanks. 发自我的 iPad > 在 2014年10月22日,上午8:28,Chen Gang 写道: > > OK, thanks, there are multiple branches in upstream qemu. So

Re: [Qemu-devel] [Consult] microblaze: About running upstream main branch qemu

2014-10-26 Thread Chen Gang
Thank your information about qemu, again. Thanks. On 10/22/2014 08:28 AM, Chen Gang wrote: > OK, thanks, there are multiple branches in upstream qemu. Sorry > for my original said, and I can only say: for upstream develop > master branch, it does not support microblaze. > > Excuse me, I

Re: [Qemu-devel] [Consult] microblaze: About running upstream main branch qemu

2014-10-26 Thread Chen Gang
On 10/26/14 21:28, Chen Gang wrote: > Hello Guenter Roeck: > > I still shall try qemu and kernel distribution, next, since it can do > it successfully (whether 'sim' can be success or not). > I got confirmation from microblaze members, at present, microblaze sim can

Re: [Qemu-devel] [Consult] microblaze: About running upstream main branch qemu

2014-10-27 Thread Chen Gang
rsion 4.8.3 20140624 (Red Hat 4.8.3-1) (GCC)" for x86_64 qemu. Next I shall try to use virtio file to share the local data to virtual guest (I guess, it should be OK). Thanks again! On 10/27/2014 09:47 AM, Chen Gang wrote: > On 10/26/14 21:28, Chen Gang wrote: >> Hello Guenter

Re: [Qemu-devel] [RESEND PATCH v4 00/10] QEmu memory hot unplug support.

2014-10-29 Thread Tang Chen
On 10/29/2014 05:37 PM, Igor Mammedov wrote: On Wed, 22 Oct 2014 18:00:02 +0800 Tang Chen wrote: This patch-set implements memory hot-remove for QEmu. Rebased on Igor's asynchronize hotplug framework (qemu v2.1.2, the latest). Approach: QEmu sets GPE status bit, then triggers SCI to n

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-30 Thread Chen, Tiejun
Sorry some urgent things always procrastinate on my response. On 2014/10/24 21:47, Michael S. Tsirkin wrote: On Fri, Oct 24, 2014 at 03:36:20PM +0800, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent devices from using it. As we populate slots in order it doesn't

Re: [Qemu-devel] [Consult] microblaze: About running upstream main branch qemu

2014-10-31 Thread Chen Gang
On 10/27/14 22:47, Chen Gang wrote: > > After a little try, I succeed run microblaze under upstream qemu 2.1.2 > and upstream Linux kernel 3.17-rc7, with the xilinux own ramdisk: > "microblaze_complete.cpio.gz". :-) > > Compiler is "gcc version 4.9.1 20140717 (Re

Re: [Qemu-devel] [Consult] microblaze: About running upstream main branch qemu

2014-10-31 Thread Chen Gang
-ethernetlite-3.00.a", }, { /* end of list */ }, Next, I shall send related kernel patch for upstream kernel, and continue for microbaze DejaGNU with microbaze qemu, and sorry again, I did not finish it within this month. Thanks. On 10/30/14 22:20, Chen Gang wrote: > O

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-02 Thread Chen, Tiejun
On 2014/10/30 15:47, Chen, Tiejun wrote: Sorry some urgent things always procrastinate on my response. On 2014/10/24 21:47, Michael S. Tsirkin wrote: On Fri, Oct 24, 2014 at 03:36:20PM +0800, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent devices from using it. As

[Qemu-devel] [PATCH] pc-bios: petalogix-s3adsp1800.dtb: Use 'xlnx, xps-ethernetlite-2.00.a' instead of 'xlnx, xps-ethernetlite-2.00.b'

2014-11-03 Thread Chen Gang
; edit work.dts (replace 'xlnx,xps-ethernetlite-2.00.b') "./scripts/dtc/dtc -I dts -O dtb -o ..qemu/petalogix-s3adsp1800.dtb ../work.dts" (Since I am not quite sure whether can read this patch or not, I put the related dtb file in attachment, please check, thanks). Sign

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-03 Thread Chen, Tiejun
On 2014/11/3 19:35, Paolo Bonzini wrote: On 03/11/2014 08:48, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent devices from using it. As we populate slots in order it doesn't seem to important ... If we populate slot at !1f GFX driver can't find this

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-03 Thread Chen, Tiejun
On 2014/11/3 19:36, Chen, Tiejun wrote: On 2014/11/3 19:35, Paolo Bonzini wrote: On 03/11/2014 08:48, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent devices from using it. As we populate slots in order it doesn't seem to important ... If we populate slot at !1

Re: [Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-08-31 Thread Chen, Tiejun
On 2014/8/31 16:48, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:23:48AM +0800, Chen, Tiejun wrote: On 2014/8/28 9:44, Chen, Tiejun wrote: On 2014/8/27 21:03, Michael S. Tsirkin wrote: On Wed, Aug 27, 2014 at 05:13:07PM +0800, Tiejun Chen wrote: We will try to reuse

[Qemu-devel] [PATCH 0/1] qemu:pci-assign: try to pci-assign.c

2014-08-31 Thread Tiejun Chen
ios, dev); +if (!bios || !bios_size) { +XEN_PT_ERR(NULL, "VGA: getting VBIOS!\n"); +rc = -1; +goto out; +} ... ---- Tiejun Chen (1): hw/pci-assign: split

[Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-08-31 Thread Tiejun Chen
We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen --- hw/i386/kvm/pci-assign.c| 136 +--- include/hw/pci/pci

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-31 Thread Chen, Tiejun
On 2014/8/31 16:58, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:28:50AM +0800, Chen, Tiejun wrote: On 2014/8/28 8:56, Chen, Tiejun wrote: + */ +dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0), +"xen-igd-passthrough-isa-bridge"); +

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-01 Thread Chen, Tiejun
On 2014/9/1 14:05, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:50:37AM +0800, Chen, Tiejun wrote: On 2014/8/31 16:58, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:28:50AM +0800, Chen, Tiejun wrote: On 2014/8/28 8:56, Chen, Tiejun wrote: + */ +dev

Re: [Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Chen, Tiejun
On 2014/9/1 16:27, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:07:19AM +0800, Tiejun Chen wrote: We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen

Re: [Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Chen, Tiejun
On 2014/9/1 17:53, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 05:26:24PM +0800, Chen, Tiejun wrote: On 2014/9/1 16:27, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:07:19AM +0800, Tiejun Chen wrote: We will try to reuse assign_dev_load_option_rom in xen side, and especially its

[Qemu-devel] [v3][PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Tiejun Chen
We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen --- hw/i386/kvm/pci-assign.c| 46 + include/hw/pci/pci

[Qemu-devel] [v3][PATCH 0/1] qemu:pci-assign: try to pci-assign.c

2014-09-01 Thread Tiejun Chen
g VBIOS!\n"); +rc = -1; +goto out; +} ... ---- Tiejun Chen (1): hw/pci-assign: split pci-assign.c hw/i386/kvm/pci-assign.c| 46 ++ include/hw/pci/pci-assign.h | 16 2 fi

Re: [Qemu-devel] [v3][PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Chen, Tiejun
On 2014/9/1 18:46, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 06:36:47PM +0800, Tiejun Chen wrote: We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen

Re: [Qemu-devel] [v3][PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Chen, Tiejun
On 2014/9/1 19:08, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 06:56:55PM +0800, Chen, Tiejun wrote: On 2014/9/1 18:46, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 06:36:47PM +0800, Tiejun Chen wrote: We will try to reuse assign_dev_load_option_rom in xen side, and especially its

[Qemu-devel] [PATCH] gtk.c: Fix memory leak in gd_set_keycode_type()

2014-09-01 Thread Chen Fan
) ==14553==by 0x80DBFBC: XkbGetKeyboardByName (in /usr/lib64/libX11.so.6.3.0) ==14553==by 0x40C704: gtk_display_init (gtk.c:1798) ==14553==by 0x1AEDC1: main (vl.c:4480) Signed-off-by: Chen Fan --- ui/gtk.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c

[Qemu-devel] [PATCH] xen-hvm.c: Improve the return method for xen_hvm_init()

2014-09-02 Thread Chen Gang
xen && make -j4 && make check" execute result: "echo $? == 0". Signed-off-by: Chen Gang --- xen-hvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen-hvm.c b/xen-hvm.c index 0d09940..35efec0 100644 --- a/xen-hvm.c +++ b/xen-hvm.c @@ -9

Re: [Qemu-devel] [PATCH] xen-hvm.c: Improve the return method for xen_hvm_init()

2014-09-02 Thread Chen Gang
Oh, sorry, forgot Cc to qemu trivial. Thanks. On 9/3/14 0:22, Chen Gang wrote: > When failure occurs, it need use "return -1" instead of exit(1), so can > let upper caller has chance to print failure information, too, then user > can know the failure result more clearly. >

Re: [Qemu-devel] [PATCH] xen-hvm.c: Improve the return method for xen_hvm_init()

2014-09-03 Thread Chen Gang
On 9/4/14 7:32, Stefano Stabellini wrote: > On Wed, 3 Sep 2014, Chen Gang wrote: >> On 9/3/14 0:22, Chen Gang wrote: [...] >>> xen_hvm_init() may also return -errno, which may let upper caller think >>> more (e.g. free some other related resources and try again), a

[Qemu-devel] [PATCH v2] xen-hvm.c: Always return -1 when failure occurs in xen_hvm_init()

2014-09-04 Thread Chen Gang
r failure. It is not a normal function, it does not release related resources when return -1, so need give related comments for it. It passes common check: "./configure --enable-xen && make && make check" "echo $? == 0" Signed-off-by: Chen Gang --- xen

[Qemu-devel] Any Patches for NPT/EPT emulation in QEMU?

2014-09-05 Thread Chen Haibo
Hi There, I just checked QEMU and found that there is still no support for EPT/NPT. I saw there were discussions adding such support 2 years ago. Is there any progress towards this direction since then? Does anyone have patches available? Thanks - Haibo

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] xen-hvm.c: Always return -1 when failure occurs in xen_hvm_init()

2014-09-15 Thread Chen Gang
ope I can find additonal patches for it. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] xen-hvm.c: Always return -1 when failure occurs in xen_hvm_init()

2014-09-15 Thread Chen Gang
ope I can find additional patches for it. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed

Re: [Qemu-devel] [RESEND PATCH v3 1/8] acpi, piix4: Add memory hot unplug support for piix4.

2014-09-15 Thread Tang Chen
Hi Igor, On 09/04/2014 08:15 PM, Igor Mammedov wrote: On Wed, 27 Aug 2014 16:08:32 +0800 Tang Chen wrote: From: Hu Tao Implement acpi_memory_unplug_cb(), sending an sci to guest to trigger memory hot-remove, and call it in piix4_device_unplug_cb(). Signed-off-by: Hu Tao Signed-off-by

Re: [Qemu-devel] [RESEND PATCH v3 2/8] acpi, ich9: Add memory hot unplug support for ich9.

2014-09-15 Thread Tang Chen
Hi Igor, On 09/04/2014 08:25 PM, Igor Mammedov wrote: On Wed, 27 Aug 2014 16:08:33 +0800 Tang Chen wrote: Implement ich9_pm_device_unplug_cb() to support memory hot-remove, calling acpi_memory_unplug_cb(). And itself will be called in ich9_device_unplug_cb(). Signed-off-by: Tang Chen

Re: [Qemu-devel] [RESEND PATCH v3 4/8] qdev: Add memory hot unplug support for bus-less devices.

2014-09-16 Thread Tang Chen
Hi Igor, On 09/04/2014 09:22 PM, Igor Mammedov wrote: On Wed, 27 Aug 2014 16:08:35 +0800 Tang Chen wrote: From: Hu Tao Implement bus-less device hot-remove in qdev_unplug(). It will call PCMachine callback introduced in previous patch. subject/commit message doesn't need to me

Re: [Qemu-devel] [RESEND PATCH v3 6/8] acpi: Add hardware implementation for memory hot unplug.

2014-09-16 Thread Tang Chen
Hi Igor, On 09/04/2014 10:20 PM, Igor Mammedov wrote: .. + +acpi_handle_ost_event(mdev); _OST is optional and OSPM doesn't have to call it at all, it was already discussed on list and using _OST for device removal was evaluated as not usable. We use _OST here as supplementary status

Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-17 Thread Chen, Tiejun
On 2014/7/16 22:20, Konrad Rzeszutek Wilk wrote: On Thu, Jul 03, 2014 at 11:27:40PM +0300, Michael S. Tsirkin wrote: On Thu, Jul 03, 2014 at 12:09:28PM -0700, Jesse Barnes wrote: On Thu, 3 Jul 2014 14:26:12 -0400 Konrad Rzeszutek Wilk wrote: On Thu, Jul 03, 2014 at 10:32:12AM +0300, Michae

[Qemu-devel] [PATCH] kvm-all: Use 'tmpcpu' instead of 'cpu' in sub-looping to avoid 'cpu' be NULL

2014-07-18 Thread Chen Gang
ULL, so need define additional temporary variable for 'cpu' to avoid the case. Signed-off-by: Chen Gang --- kvm-all.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 3ae30ee..1402f4f 100644 --- a/kvm-all.c +++

Re: [Qemu-devel] [PATCH] kvm-all: Use 'tmpcpu' instead of 'cpu' in sub-looping to avoid 'cpu' be NULL

2014-07-20 Thread Chen Gang
On 07/20/2014 03:29 PM, Jan Kiszka wrote: > On 2014-07-19 03:21, Chen Gang wrote: >> If kvm_arch_remove_sw_breakpoint() in CPU_FOREACH() always be fail, it >> will let 'cpu' NULL. And the next kvm_arch_remove_sw_breakpoint() in >> QTAILQ_FOREACH_SAFE() will get NULL

[Qemu-devel] [PATCH] i386/helper: add cpu dump APIC information

2014-07-21 Thread Chen Fan
When KVM exit reason is KVM_EXIT_SHUTDOWN, there will cause guest to reset, but we can't get any information to fix. we knew KVM handle triple fault will set exit_reason to KVM_EXIT_SHUTDOWN, so we also should dump the APIC information to help to fix. Signed-off-by: Chen Fan --- includ

Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-23 Thread Chen, Tiejun
anth...@codemonkey.ws; Paolo Bonzini; Zhang, Yang Z; Chen, Tiejun Subject: Re: [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support On Thu, Jul 17, 2014 at 05:37:12PM +, Kay, Allen M wrote: That sounds great. Tiejun could you confirm that with windows driver g

[Qemu-devel] [PATCH 0/4] xen:passthrough: introduce a separate machine to igd passthrough

2014-07-24 Thread Tiejun Chen
As we discussed currently we have to introduce a separate machine to work out igd passthrough. Tiejun Chen (4): hw:i386:pc_piix: split pc_init1() xen:hw:pci-host:piix: create host bridge to passthrough xen:hw:pci

[Qemu-devel] [PATCH 3/4] xen:hw:pci-host:piix: introduce xen_igd_i440fx_init

2014-07-24 Thread Tiejun Chen
This is almost same as an original i440fx_init but just work with that xen igd host bridge to passthrough. Signed-off-by: Tiejun Chen --- hw/pci-host/piix.c | 79 include/hw/i386/pc.h | 10 +++ 2 files changed, 89 insertions(+) diff

[Qemu-devel] [PATCH 1/4] hw:i386:pc_piix: split pc_init1()

2014-07-24 Thread Tiejun Chen
We'd like to split pc_init1 and then we can share something with other stuff. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 93 +-- 1 file changed, 70 insertions(+), 23 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_p

[Qemu-devel] [PATCH 4/4] xen:hw:i386:pc_piix: introduce new machine for IGD passthrough

2014-07-24 Thread Tiejun Chen
Now we can introduce a new machine, xenigd, specific to IGD passthrough. This can avoid involving other common codes. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 87 +++ 1 file changed, 87 insertions(+) diff --git a/hw/i386/pc_piix.c b

[Qemu-devel] [PATCH 2/4] xen:hw:pci-host:piix: create host bridge to passthrough

2014-07-24 Thread Tiejun Chen
Implement that pci host bridge to specific to passthrough. Actually this just inherit the standard one. This is based on http://patchwork.ozlabs.org/patch/363810/. Signed-off-by: Tiejun Chen --- hw/pci-host/piix.c | 43 +++ 1 file changed, 43 insertions

[Qemu-devel] [PATCH] target-i386/cpu.c: Fix two error output indentation

2014-07-28 Thread Chen Fan
Signed-off-by: Chen Fan --- target-i386/cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 6d008ab..217500c 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1716,9 +1716,9 @@ static void x86_set_hv_spinlocks

Re: [Qemu-devel] [PATCH 0/4] xen:passthrough: introduce a separate machine to igd passthrough

2014-07-28 Thread Chen, Tiejun
Michael, Paolo and Stefano, Any comments? Thanks Tiejun On 2014/7/24 19:30, Tiejun Chen wrote: As we discussed currently we have to introduce a separate machine to work out igd passthrough. Tiejun Chen (4): hw:i386

Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-29 Thread Chen, Tiejun
On 2014/7/26 1:01, Konrad Rzeszutek Wilk wrote: On Thu, Jul 24, 2014 at 09:44:41AM +0800, Chen, Tiejun wrote: On 2014/7/24 4:54, Konrad Rzeszutek Wilk wrote: On Sat, Jul 19, 2014 at 12:27:21AM +, Kay, Allen M wrote: For the MCH PCI registers that do need to be read - can you tell us which

Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-29 Thread Chen, Tiejun
On 2014/7/29 16:32, Paolo Bonzini wrote: Il 29/07/2014 08:59, Chen, Tiejun ha scritto: (see https://lkml.org/lkml/2014/6/19/121) "gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type". Because Windows always use this way, so I think this point should be sa

Re: [Qemu-devel] [PATCH 1/4] hw:i386:pc_piix: split pc_init1()

2014-07-30 Thread Chen, Tiejun
On 2014/7/29 19:26, Michael S. Tsirkin wrote: On Thu, Jul 24, 2014 at 07:30:26PM +0800, Tiejun Chen wrote: We'd like to split pc_init1 and then we can share something with other stuff. Signed-off-by: Tiejun Chen Did you test this patch? It does not look like it can work. Just compil

Re: [Qemu-devel] [PATCH 2/4] xen:hw:pci-host:piix: create host bridge to passthrough

2014-07-30 Thread Chen, Tiejun
On 2014/7/29 19:17, Michael S. Tsirkin wrote: On Thu, Jul 24, 2014 at 07:30:27PM +0800, Tiejun Chen wrote: Implement that pci s/that/a/ Fixed. host bridge to specific s/to specific/specific/ Fixed. to passthrough. Actually this just inherit s/inherit/inherits/ Fixed. the

Re: [Qemu-devel] [PATCH 3/4] xen:hw:pci-host:piix: introduce xen_igd_i440fx_init

2014-07-30 Thread Chen, Tiejun
On 2014/7/29 19:19, Michael S. Tsirkin wrote: On Thu, Jul 24, 2014 at 07:30:28PM +0800, Tiejun Chen wrote: This is almost same as an original i440fx_init but just work with that xen igd host bridge to passthrough. Signed-off-by: Tiejun Chen --- hw/pci-host/piix.c | 79

Re: [Qemu-devel] [PATCH 4/4] xen:hw:i386:pc_piix: introduce new machine for IGD passthrough

2014-07-30 Thread Chen, Tiejun
On 2014/7/29 19:29, Michael S. Tsirkin wrote: On Thu, Jul 24, 2014 at 07:30:29PM +0800, Tiejun Chen wrote: Now we can introduce a new machine, xenigd, specific to IGD passthrough. This can avoid involving other common codes. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 87

[Qemu-devel] [v2][PATCH 0/5] xen: introduce new machine for IGD passthrough

2014-07-30 Thread Tiejun Chen
/qemu-system-i386 -hda test.img -m 2560 -boot c -machine pc As we discussed we need to create a separate machine to support current IGD passthrough. Tiejun Chen (5): hw:i386:pc_piix: split pc_init1() hw:pci-host:piix

[Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-30 Thread Tiejun Chen
We'd like to split i440fx_init and then we can share something with other stuff. Signed-off-by: Tiejun Chen --- hw/pci-host/piix.c | 91 -- 1 file changed, 75 insertions(+), 16 deletions(-) v2: * New patch to separate i440fx_init diff

[Qemu-devel] [v2][PATCH 1/5] hw:i386:pc_piix: split pc_init1()

2014-07-30 Thread Tiejun Chen
We'd like to split pc_init1 and then we can share something with other stuff. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 117 +++--- 1 file changed, 93 insertions(+), 24 deletions(-) v2: * Fix some coding style diff --git a/hw

[Qemu-devel] [v2][PATCH 3/5] xen:hw:pci-host:piix: create host bridge to passthrough

2014-07-30 Thread Tiejun Chen
Implement a pci host bridge specific to passthrough. Actually this just inherits the standard one. This is based on http://patchwork.ozlabs.org/patch/363810/. Signed-off-by: Tiejun Chen --- hw/pci-host/piix.c | 42 ++ 1 file changed, 42 insertions(+) v2

[Qemu-devel] [v2][PATCH 5/5] xen:hw:i386:pc_piix: introduce new machine for IGD passthrough

2014-07-30 Thread Tiejun Chen
Now we can introduce a new machine, xenigd, specific to IGD passthrough. This can avoid involving other common codes. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 105 ++ 1 file changed, 105 insertions(+) v2: * Unify prefix with

[Qemu-devel] [v2][PATCH 4/5] xen:hw:pci-host:piix: introduce xen_igd_passthrough_i440fx_init

2014-07-30 Thread Tiejun Chen
This is almost same as an original i440fx_init but just work with that xen igd host bridge to passthrough. Signed-off-by: Tiejun Chen --- hw/pci-host/piix.c | 32 include/hw/i386/pc.h | 11 +++ 2 files changed, 43 insertions(+) v2: * Based on patch

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 17:10, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote: We'd like to split i440fx_init and then we can share something with other stuff. Signed-off-by: Tiejun Chen I think this is too much work for very little benefit. Just pass const

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote: We'd like to split i440fx_init and then we can share something with

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 18:12, Chen, Tiejun wrote: On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote: We'd like to split i440fx_ini

[Qemu-devel] [v3][PATCH 3/4] xen:hw:pci-host:piix: create host bridge to passthrough

2014-07-31 Thread Tiejun Chen
Implement a pci host bridge specific to passthrough. Actually this just inherits the standard one. This is based on http://patchwork.ozlabs.org/patch/363810/. Signed-off-by: Tiejun Chen --- hw/pci-host/piix.c | 41 + include/hw/i386/pc.h | 2 ++ 2

[Qemu-devel] [v3][PATCH 1/4] i440fx: make types configurable at run-time

2014-07-31 Thread Tiejun Chen
Xen wants to supply a different pci and host devices, inheriting i440fx devices. Make types configurable. Signed-off-by: Michael S. Tsirkin Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c| 4 +++- hw/pci-host/piix.c | 9 - include/hw/i386/pc.h | 6 +- 3 files changed, 12

[Qemu-devel] [v3][PATCH 0/5] xen: introduce new machine for IGD passthrough

2014-07-31 Thread Tiejun Chen
* Test: boot with a preinstalled ubuntu 14.04 ./i386-softmmu/qemu-system-i386 -hda test.img -m 2560 -boot c -machine pc As we discussed we need to create a separate machine to support current IGD passthrough. Tiejun Chen (4

[Qemu-devel] [v3][PATCH 2/4] hw:i386:pc_piix: split pc_init1()

2014-07-31 Thread Tiejun Chen
We'd like to split pc_init1 and then we can share something with other stuff. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 117 +++--- 1 file changed, 93 insertions(+), 24 deletions(-) v3: * Rebase v2: * Fix some coding style diff

[Qemu-devel] [v3][PATCH 4/4] xen:hw:i386:pc_piix: introduce new machine for IGD passthrough

2014-07-31 Thread Tiejun Chen
Now we can introduce a new machine, xenigd, specific to IGD passthrough. This can avoid involving other common codes. Signed-off-by: Tiejun Chen --- hw/i386/pc_piix.c | 106 ++ 1 file changed, 106 insertions(+) v3: * Rebase v2: * Unify

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 23:44, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 06:12:32PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 02:31

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-07-31 Thread Chen, Tiejun
On 2014/7/31 23:47, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 08:10:53PM +0800, Chen, Tiejun wrote: On 2014/7/31 18:12, Chen, Tiejun wrote: On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S

[Qemu-devel] [PATCH 1/3] query-memdev: fix potential memory leaks

2014-08-01 Thread Chen Fan
Signed-off-by: Chen Fan --- numa.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/numa.c b/numa.c index 7bf7834..a2b4bca 100644 --- a/numa.c +++ b/numa.c @@ -318,10 +318,11 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner, static int

[Qemu-devel] [PATCH 0/3] Fix some memory leaks about query memdev

2014-08-01 Thread Chen Fan
9) ==15046==by 0x2BCDEF: fd_chr_read (qemu-char.c:213) Chen Fan (3): query-memdev: fix potential memory leaks qom/object.c: fix string_output_get_string() memory leak hmp: fix MemdevList memory leak hmp.c| 15 ++- numa.c | 6 +- qom/object.c | 11 --

[Qemu-devel] [PATCH 2/3] qom/object.c: fix string_output_get_string() memory leak

2014-08-01 Thread Chen Fan
string_output_get_string() always return the data the sov->string point. and never free. Signed-off-by: Chen Fan --- hmp.c| 6 -- qom/object.c | 11 --- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/hmp.c b/hmp.c index 4d1838e..2414cc7 100644 --- a/hm

[Qemu-devel] [PATCH 3/3] hmp: fix MemdevList memory leak

2014-08-01 Thread Chen Fan
Signed-off-by: Chen Fan --- hmp.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hmp.c b/hmp.c index 2414cc7..0b1c830 100644 --- a/hmp.c +++ b/hmp.c @@ -1685,13 +1685,14 @@ void hmp_info_memdev(Monitor *mon, const QDict *qdict) { Error *err = NULL

Re: [Qemu-devel] [Qemu-trivial] [PATCH-trivial] qemu-img: Check getchar() return value in read_password() for WIN32

2014-08-02 Thread Chen Gang
On 08/02/2014 09:35 PM, Michael Tokarev wrote: > 06.07.2014 12:43, Chen Gang wrote: >> getchar() is a standard c library function which may return with failure >> (e.g. -1), so like another platforms, also need check it under WIN32. > > Applied to -trivial queue, with

[Qemu-devel] [PATCH] dump.c: Fix memory leak issue in cleanup processing for dump_init()

2014-08-03 Thread Chen Gang
In dump_init(), when failure occurs, need notice about 'fd' and memory mapping. So call dump_cleanup() for it (need let all initializations at front). Also simplify dump_cleanup(): remove redundant 'ret' and redundant 'fd' checking. Signed-off-b

[Qemu-devel] [v2 1/3] query-memdev: fix potential memory leaks

2014-08-03 Thread Chen Fan
Signed-off-by: Chen Fan Reviewed-by: Peter Crosthwaite --- numa.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/numa.c b/numa.c index 7bf7834..a2b4bca 100644 --- a/numa.c +++ b/numa.c @@ -318,10 +318,11 @@ void memory_region_allocate_system_memory(MemoryRegion *mr

[Qemu-devel] [v2 2/3] qom/object.c: fix string_output_get_string() memory leak

2014-08-03 Thread Chen Fan
string_output_get_string() uses g_string_free(str, false) to transfer the 'str' pointer to callers and never free it. Signed-off-by: Chen Fan --- hmp.c| 6 -- qom/object.c | 12 ++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/hmp.c b/hmp.c ind

[Qemu-devel] [v2 0/3] Fix some memory leaks about query memdev

2014-08-03 Thread Chen Fan
9) ==15046==by 0x2BCDEF: fd_chr_read (qemu-char.c:213) Chen Fan (3): query-memdev: fix potential memory leaks qom/object.c: fix string_output_get_string() memory leak hmp: fix MemdevList memory leak hmp.c| 15 ++- numa.c | 6 +- qom/object.c | 11 --

[Qemu-devel] [v2 3/3] hmp: fix MemdevList memory leak

2014-08-03 Thread Chen Fan
the memdev_list in hmp_info_memdev() is never freed. so we use existent method qapi_free_MemdevList() to free it. and also we can use qapi_free_MemdevList() to replace list loops to clean up the memdev list in error path. Signed-off-by: Chen Fan --- hmp.c | 2 ++ numa.c | 9 ++--- 2 files

Re: [Qemu-devel] [Xen-devel] [v3][PATCH 0/5] xen: introduce new machine for IGD passthrough

2014-08-03 Thread Chen, Tiejun
On 2014/7/31 20:09, Tiejun Chen wrote: v3: * Drop patch #4 * Add one patch #1 from Michael * Rebase v2: * Fix some coding style * New patch to separate i440fx_init * Just add prefix with XEN_IGD_PASSTHROUGH/xen_igd_passthrough * Based on patch #2 to regenerate * Unify prefix with

Re: [Qemu-devel] [v2][PATCH 2/5] hw:pci-host:piix: split i440fx_init

2014-08-04 Thread Chen, Tiejun
On 2014/7/31 17:53, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 05:26:41PM +0800, Chen, Tiejun wrote: On 2014/7/31 17:10, Michael S. Tsirkin wrote: On Thu, Jul 31, 2014 at 02:31:36PM +0800, Tiejun Chen wrote: We'd like to split i440fx_init and then we can share something with

Re: [Qemu-devel] [PATCH] dump.c: Fix memory leak issue in cleanup processing for dump_init()

2014-08-04 Thread Chen Gang
On 08/03/2014 11:56 PM, Laszlo Ersek wrote: > comments below > Excuse me for replying late, firstly. > On 08/03/14 17:28, Chen Gang wrote: >> In dump_init(), when failure occurs, need notice about 'fd' and memory >> mapping. So call dump_cleanup() for it (

Re: [Qemu-devel] Cc'ing emails [was: [PATCH] dump.c: Fix memory leak issue in cleanup processing for dump_init()]

2014-08-04 Thread Chen Gang
tice about soon. By the way, in honest, as a gmail member, I almost do not check my email in open mailing list, but always check personal mail which for sending patches. Thanks. -- Chen Gang Open share and attitude like air water and life which God blessed

Re: [Qemu-devel] Cc'ing emails [

2014-08-04 Thread Chen Gang
t; Ccing you for the patches with which you have absolutely nothing >> to do, and if a discussion emerges, you can't opt out of it >> anymore (especially for patches which raise hot discussions). >> So I'd rather think twice before contributing anything... > > That's sad. > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed

Re: [Qemu-devel] Cc'ing emails [

2014-08-05 Thread Chen Gang
On 08/05/2014 04:07 PM, Peter Maydell wrote: > n 5 August 2014 08:08, Michael Tokarev wrote: >> 05.08.2014 08:41, Chen Gang wrote: >>> >>> Every members have their own tastes, and one working flow may be not >>> suitable for all members. I can understand, a

<    1   2   3   4   5   6   7   8   9   10   >