[PATCH 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-03-09 Thread Zhang Chen
"RESET", "data": {"guest": true, "reason": "guest-reset"}} qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch' Long-term testing says that it's pretty safe. Signed-off-by: Like Xu Signed-off-by: Zhang Che

[PATCH 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-09 Thread Zhang Chen
ly later, and it's buggy when other agents try to call connection_get() with the same connection_track_table. Signed-off-by: Like Xu Signed-off-by: Zhang Chen --- net/colo-compare.c| 2 +- net/filter-rewriter.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/co

RE: [PATCH] docs/devel/migration.rst: Updates content from code and fixes minor issues

2022-03-09 Thread Zhang, Chen
Ping Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Thursday, January 27, 2022 6:33 PM > To: Dr. David Alan Gilbert ; Juan Quintela > ; qemu-dev ; qemu- > triv...@nongnu.org > Cc: Zhang, Chen > Subject: [PATCH] docs/devel/migration.rst: Updat

RE: [PATCH] ebpf: replace deprecated bpf_program__set_socket_filter

2022-05-30 Thread Zhang, Chen
f: replace deprecated bpf_program__set_socket_filter > > bpf_program__set_ functions have been deprecated since libbpf 0.8. > Replace with the equivalent bpf_program__set_type call to avoid a > deprecation warning. > > Signed-off-by: Haochen Tong It looks good to me. By the way, add eBPF maintainers

RE: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-28 Thread Zhang, Chen
> -Original Message- > From: lizhij...@fujitsu.com > Sent: Monday, March 21, 2022 11:06 AM > To: Zhang, Chen ; Jason Wang > ; lizhij...@fujitsu.com > Cc: qemu-dev ; Like Xu > Subject: Re: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the >

[PATCH] docs/block-replication.txt: Fix replication top-id command demo

2021-10-18 Thread Zhang Chen
This demo not correct, the original childs1 can't pass the the bdrv_is_root_node check in replcation_start(). Keep consistent with docs/COLO-FT.txt Signed-off-by: Zhang Chen --- docs/block-replication.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/

RE: [PATCH V3] net/colo: check vnet_hdr_support flag when using virtio-net

2021-10-18 Thread Zhang, Chen
Hi Jason~ Have any comments or updates for this patch? Thanks Chen > -Original Message- > From: Markus Armbruster > Sent: Tuesday, October 12, 2021 5:31 PM > To: Zhang, Chen > Cc: Jason Wang ; Eric Blake ; > qemu-dev ; Li Zhijian ; > Lukas Straub ; Tao Xu >

RE: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-30 Thread Zhang, Chen
> -Original Message- > From: lizhij...@fujitsu.com > Sent: Thursday, March 31, 2022 9:15 AM > To: Zhang, Chen ; Jason Wang > > Cc: qemu-dev ; Like Xu > Subject: Re: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the > conn_l

RE: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-31 Thread Zhang, Chen
> -Original Message- > From: lizhij...@fujitsu.com > Sent: Friday, April 1, 2022 9:47 AM > To: Zhang, Chen ; Jason Wang > > Cc: qemu-dev ; Like Xu > Subject: Re: [PATCH 2/4] net/colo: Fix a "double free" crash to clear the > conn_list > > >

[PATCH V2 2/4] net/colo: Fix a "double free" crash to clear the conn_list

2022-03-31 Thread Zhang Chen
the same conn instance. It will trigger double free in conn_list clear. So this patch remove free action on hash table side to avoid double free the conn. Signed-off-by: Like Xu Signed-off-by: Zhang Chen --- net/colo-compare.c| 2 +- net/filter-rewriter.c | 2 +- 2 files changed, 2 insertions(+)

[PATCH V2 0/4] COLO net and runstate bugfix/optimization

2022-03-31 Thread Zhang Chen
This series fix some COLO related issues in internal stress testing. - V2: - Add more comments in patch 2/4 commit log. Zhang Chen (4): softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH net/colo: Fix a "double free" crash to clear the conn_list

[PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-03-31 Thread Zhang Chen
"RESET", "data": {"guest": true, "reason": "guest-reset"}} qemu-system-x86_64: invalid runstate transition: 'colo' -> 'prelaunch' Long-term testing says that it's pretty safe. Signed-off-by: Like Xu Signed-off-by: Zhang Che

[PATCH V2 3/4] net/colo.c: No need to track conn_list for filter-rewriter

2022-03-31 Thread Zhang Chen
Filter-rewriter no need to track connection in conn_list. This patch fix the glib g_queue_is_empty assertion when COLO guest keep a lot of network connection. Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian --- net/colo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH V2 4/4] net/colo.c: fix segmentation fault when packet is not parsed correctly

2022-03-31 Thread Zhang Chen
u Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian --- net/colo.c | 9 - net/trace-events | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/net/colo.c b/net/colo.c index 694f3c93ef..6b0ff562ad 100644 --- a/net/colo.c +++ b/net/colo.c @@ -46,7 +46,14 @@ int parse_pac

RE: [PATCH V2 0/4] COLO net and runstate bugfix/optimization

2022-04-13 Thread Zhang, Chen
No update for a while. Ping... Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Friday, April 1, 2022 11:47 AM > To: Jason Wang ; Li Zhijian > Cc: Zhang, Chen ; qemu-dev de...@nongnu.org> > Subject: [PATCH V2 0/4] COLO net and runstate bugfix/optimiza

RE: [PATCH V2 0/4] COLO net and runstate bugfix/optimization

2022-04-13 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Thursday, April 14, 2022 11:12 AM > To: Zhang, Chen > Cc: Li Zhijian ; qemu-dev de...@nongnu.org> > Subject: Re: [PATCH V2 0/4] COLO net and runstate bugfix/optimization > > On Thu, Apr 14, 2022 at 9

RE: [PATCH] tests/qtest/cxl-test: Remove temporary directories after testing

2022-10-17 Thread Zhang, Chen
porary directories after > testing > > The cxl-test leaves some temporary directories behind. Let's clean them up > now! > > Signed-off-by: Thomas Huth LGTM. Reviewed-by: Zhang Chen Thanks Chen > --- > tests/qtest/cxl-test.c | 3 +++ > 1 file changed, 3 insertions(+

RE: [PATCH v2] migration/channel-block: fix return value for qio_channel_block_{readv, writev}

2022-10-17 Thread Zhang, Chen
he call sides. Non-blocking mode is not implemented currently, so -1 it is. > > Signed-off-by: Fiona Ebner LGTM. Reviewed-by: Zhang Chen But I found the same problem elsewhere, for example: "qio_channel_rdma_writev/readv", "qio_channel_buffer_writev/readv"...etc... Ca

RE: [PATCH] vfio/migration: Fix wrong enum usage

2022-10-17 Thread Zhang, Chen
VFIOMigration") > Signed-off-by: Avihai Horon Looks good to me. Reviewed-by: Zhang Chen But I found nowhere using the enum of VFIO migration protocol v2 (vfio_device_mig_state). I don't know more about the background, should we remove the redundancy definition or add full support f

RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-04-27 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Wednesday, April 27, 2022 4:57 PM > To: Zhang, Chen > Cc: Li Zhijian ; qemu-dev de...@nongnu.org>; Like Xu > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition > support form COLO to PREL

RE: [PATCH 1/8] colo: Only support the same qemu version on source and destination

2023-06-27 Thread Zhang, Chen
> -Original Message- > From: Dong, Eddie > Sent: Friday, June 23, 2023 1:17 AM > To: Lukas Straub ; qemu-devel de...@nongnu.org> > Cc: Zhang, Hailiang ; Juan Quintela > ; Peter Xu ; Leonardo Bras > ; Zhang, Chen > Subject: RE: [PATCH 1/8] colo: Only suppo

RE: [PATCH 2/8] colo: Setup ram cache in normal migration path

2023-06-28 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Thursday, June 22, 2023 8:15 PM > To: qemu-devel > Cc: Zhang, Hailiang ; Juan Quintela > ; Peter Xu ; Leonardo Bras > ; Zhang, Chen > Subject: [PATCH 2/8] colo: Setup ram cache in normal migration path > &

RE: [PATCH] tests/qtest: check the return value

2023-11-20 Thread Zhang, Chen
> -Original Message- > From: zhujun2 > Sent: Tuesday, November 21, 2023 2:17 PM > To: Zhang, Chen > Cc: lviv...@redhat.com; pbonz...@redhat.com; qemu-devel@nongnu.org; > th...@redhat.com; zhuj...@cmss.chinamobile.com > Subject: [PATCH] tests/qtest: check the re

RE: [PATCH trivial] colo: examples: remove mentions of script= and (wrong) downscript=

2024-01-08 Thread Zhang, Chen
> -Original Message- > From: Michael Tokarev > Sent: Sunday, January 7, 2024 7:25 PM > To: qemu-devel@nongnu.org > Cc: Michael Tokarev ; qemu-triv...@nongnu.org; Zhang, > Chen ; Li Zhijian > Subject: [PATCH trivial] colo: examples: remove mentions of script= and

RE: [PATCH trivial] colo: examples: remove mentions of script= and (wrong) downscript=

2024-01-09 Thread Zhang, Chen
> -Original Message- > From: Michael Tokarev > Sent: Tuesday, January 9, 2024 1:44 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org; Li Zhijian > Subject: Re: [PATCH trivial] colo: examples: remove mentions of script= and > (wrong) downsc

RE: [PATCH] tests/qtest: remove unused variables

2023-11-15 Thread Zhang, Chen
> -Original Message- > From: qemu-devel-bounces+chen.zhang=intel@nongnu.org devel-bounces+chen.zhang=intel@nongnu.org> On Behalf Of zhujun2 > Sent: Wednesday, November 15, 2023 4:00 PM > To: th...@redhat.com > Cc: lviv...@redhat.com; pbonz...@redhat.com; qemu-devel@nongnu.org; >

RE: [PATCH v6 05/21] tap: Remove tap_receive()

2023-10-30 Thread Zhang, Chen
> -Original Message- > From: qemu-devel-bounces+chen.zhang=intel@nongnu.org devel-bounces+chen.zhang=intel@nongnu.org> On Behalf Of Akihiko > Odaki > Sent: Monday, October 30, 2023 1:12 PM > Cc: qemu-devel@nongnu.org; Yuri Benditovich > ; Andrew Melnychenko > ; Michael S . Tsirk

RE: [PATCH v6 13/21] virtio-net: Always set populate_hash

2023-10-30 Thread Zhang, Chen
> -Original Message- > From: qemu-devel-bounces+chen.zhang=intel@nongnu.org devel-bounces+chen.zhang=intel@nongnu.org> On Behalf Of Akihiko > Odaki > Sent: Monday, October 30, 2023 1:13 PM > Cc: qemu-devel@nongnu.org; Yuri Benditovich > ; Andrew Melnychenko > ; Michael S . Tsirk

RE: [PATCH v2] MAINTAINERS: Change my email address

2021-12-15 Thread Zhang, Chen
oves company and wants to carry on in their existing role > > as maintainer that is fine and doesn't need approva from their old > > company IMHO. > > I agree, this is why it is better to send that kind of change from the to-be- > stopped email address while it is still valid. Synced with Hailiang Zhang offline, verified. Acked-by: Zhang Chen Thanks Chen > > Thanks, > > Phil. >

[PATCH 1/2] net/colo-compare.c: Optimize compare order for performance

2021-12-19 Thread Zhang Chen
eues for performance. Signed-off-by: Zhang Chen Reported-by: leirao --- net/colo-compare.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index b966e7e514..216de5a12b 100644 --- a/net/colo-compare.c +++ b/net/colo-c

[PATCH 2/2] net/colo-compare.c: Update the default value comments

2021-12-19 Thread Zhang Chen
Make the comments consistent with the REGULAR_PACKET_CHECK_MS. Signed-off-by: Zhang Chen --- net/colo-compare.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 216de5a12b..62554b5b3c 100644 --- a/net/colo-compare.c +++ b/net/colo

RE: [PATCH] tests/qtest: Make the filter tests independent from a specific NIC

2021-12-20 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Thomas Huth > Sent: Monday, December 20, 2021 6:30 PM > To: qemu-devel@nongnu.org; Laurent Vivier > Cc: Paolo Bonzini ; Yang Hongyang > ; Zhang Chen > Subject: [PATC

[PATCH] MAINTAINERS: Update COLO Proxy section

2021-12-21 Thread Zhang Chen
Signed-off-by: Zhang Chen --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1de6ce6e44..5479b9376e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2983,6 +2983,7 @@ F: docs/colo-proxy.txt F: net/colo* F: net/filter-rewriter.c F: net/filter

RE: [PATCH] tests/qtest: Make the filter tests independent from a specific NIC

2021-12-21 Thread Zhang, Chen
> -Original Message- > From: Thomas Huth > Sent: Tuesday, December 21, 2021 3:35 PM > To: Zhang, Chen ; qemu-devel@nongnu.org; > Laurent Vivier > Cc: Paolo Bonzini > Subject: Re: [PATCH] tests/qtest: Make the filter tests independent from a > specific NIC

RE: [PATCH v2] net/filter: Optimize filter_send to coroutine

2021-12-26 Thread Zhang, Chen
> -Original Message- > From: Rao, Lei > Sent: Monday, December 27, 2021 9:20 AM > To: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com > Cc: qemu-devel@nongnu.org; Rao, Lei ; Li Zhijian > > Subject: [PATCH v2] net/filter: Optimize filter_send to c

RE: [PATCH] migration/colo.c: Add missed return in error handling

2021-12-28 Thread Zhang, Chen
> -Original Message- > From: Rao, Lei > Sent: Tuesday, December 28, 2021 3:35 PM > To: Zhang, Chen ; zhanghaili...@xfusion.com; > quint...@redhat.com; dgilb...@redhat.com > Cc: qemu-devel@nongnu.org; Rao, Lei > Subject: [PATCH] migration/colo.c: Add missed ret

[PATCH 0/3] Some minor fixes for migration states

2021-12-30 Thread Zhang Chen
This series solved some fixme and comments in code. Please see the details in each patch commit message. Zhang Chen (3): migration/migration.c: Add missed default error handler for migration state migration/migration.c: Avoid COLO boot in postcopy migration migration/migration.c: Remove

[PATCH 1/3] migration/migration.c: Add missed default error handler for migration state

2021-12-30 Thread Zhang Chen
In the migration_completion() no other status is expected, for example MIGRATION_STATUS_CANCELLING, MIGRATION_STATUS_CANCELLED, etc. Signed-off-by: Zhang Chen --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration

RE: [PATCH] MAINTAINERS: email address change

2021-12-30 Thread Zhang, Chen
> -Original Message- > From: Li Zhijian > Sent: Friday, December 31, 2021 1:09 PM > To: th...@redhat.com; peter.mayd...@linaro.org; f4...@amsat.org > Cc: qemu-devel@nongnu.org; Zhang, Chen ; Li > Zhijian > Subject: [PATCH] MAINTAINERS: email address change >

[PATCH 3/3] migration/migration.c: Remove the MIGRATION_STATUS_ACTIVE when migration finished

2021-12-30 Thread Zhang Chen
The MIGRATION_STATUS_ACTIVE indicates that migration is running. Remove it to be handled by the default operation, It should be part of the unknown ending states. Signed-off-by: Zhang Chen --- migration/migration.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/migration/migration.c b

[PATCH 2/3] migration/migration.c: Avoid COLO boot in postcopy migration

2021-12-30 Thread Zhang Chen
COLO dose not support postcopy migration and remove the Fixme. Signed-off-by: Zhang Chen --- migration/migration.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 2afa77da03..3fac9c67ca 100644 --- a/migration

RE: [PATCH V6 0/6] Passthrough specific network traffic in COLO

2021-05-12 Thread Zhang, Chen
Hi Markus, Jason and Dave. This series has been modified according to previous suggestions. Please review it again to make sure I fully understand comments. Thanks Chen > -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Zhang, Ch

[RFC PATCH] block/io.c: Flush parent for quorum in generic code

2021-05-12 Thread Zhang Chen
is shutdown. Signed-off-by: Zhang Chen Reported-by: Minghao Yuan --- block/io.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/block/io.c b/block/io.c index 35b6c56efc..4dc1873cb9 100644 --- a/block/io.c +++ b/block/io.c @@ -2849,6 +2849,13 @@

Re: [Qemu-devel] [PULL 9/9] colo-proxy: fix memory leak

2016-10-30 Thread Zhang Chen
On 10/30/2016 08:13 PM, Greg Kurz wrote: On Wed, 26 Oct 2016 10:24:11 +0800 Jason Wang wrote: From: Zhang Chen Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity and add some comments. Signed-off-by: Zhang Chen Reviewed-by: zhanghailiang Signed-off-by: Jason

Re: [Qemu-devel] [PULL 9/9] colo-proxy: fix memory leak

2016-10-31 Thread Zhang Chen
On 10/31/2016 03:40 PM, Jason Wang wrote: On 2016年10月31日 14:37, Zhang Chen wrote: On 10/30/2016 08:13 PM, Greg Kurz wrote: On Wed, 26 Oct 2016 10:24:11 +0800 Jason Wang wrote: From: Zhang Chen Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity and add some

Re: [Qemu-devel] [PATCH] net: split colo_compare_pkt_info into two trace events

2016-10-31 Thread Zhang Chen
, but it not the root cause of this bug. We better fix this in UST trace event codes But qemu 2.8 will be released, we need fix this quickly. So... Reviewed-by: Zhang Chen --- net/colo-compare.c | 21 +++-- net/trace-events | 3 ++- 2 files changed, 13 insertions(+), 11

[Qemu-devel] [PATCH] docs: fix COLO architecture diagram

2016-10-31 Thread Zhang Chen
Fix COLO-Proxy part of COLO architecture diagram Signed-off-by: Zhang Chen --- docs/COLO-FT.txt | 72 +--- 1 file changed, 37 insertions(+), 35 deletions(-) diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index 6282938..e289be2 100644 --- a

Re: [Qemu-devel] [PATCH] docs: fix COLO architecture diagram

2016-11-01 Thread Zhang Chen
that only touch colo related files ... Or uses still can't test COLO feature in qemu 2.8. Any ideas ? Thanks. I will send some patch about COLO-Proxy combine with COLO-frame in the future. On 2016/11/1 11:38, Zhang Chen wrote: Fix COLO-Proxy part of COLO architecture diagram

Re: [Qemu-devel] [PATCH] docs: Fix typos found by codespell

2016-11-01 Thread Zhang Chen
understand. Reviewed-by: Zhang Chen -- Thanks zhangchen

Re: [Qemu-devel] [PATCH] docs: Fix typos found by codespell

2016-11-02 Thread Zhang Chen
On 11/02/2016 09:29 PM, Eric Blake wrote: On 11/01/2016 08:32 PM, Zhang Chen wrote: I still don't understand the comment in docs/colo-proxy.txt. Me neither. Which part of the docs/colo-proxy.txt? The one quoted below. Perhaps I can explain it more clearly and make the doc b

Re: [Qemu-devel] [PATCH V12 02/10] colo-compare: introduce colo compare initialization

2016-08-31 Thread Zhang Chen
On 08/31/2016 03:53 PM, Jason Wang wrote: On 2016年08月17日 16:10, Zhang Chen wrote: This a COLO net ascii figure: Primary qemu Secondary qemu

Re: [Qemu-devel] [PATCH V12 03/10] net/colo.c: add colo.c to define and handle packet

2016-08-31 Thread Zhang Chen
On 08/31/2016 04:04 PM, Jason Wang wrote: On 2016年08月17日 16:10, Zhang Chen wrote: The net/colo.c is used by colo-compare and filter-rewriter. this can share common data structure like net packet, and other functions. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen

Re: [Qemu-devel] [PATCH V12 04/10] Jhash: add linux kernel jhashtable in qemu

2016-08-31 Thread Zhang Chen
On 08/31/2016 04:05 PM, Jason Wang wrote: On 2016年08月17日 16:10, Zhang Chen wrote: Jhash used by colo-compare and filter-rewriter s/used/will be used/ OK~~ Thanks Zhang Chen to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by

Re: [Qemu-devel] [PATCH V12 02/10] colo-compare: introduce colo compare initialization

2016-08-31 Thread Zhang Chen
On 08/31/2016 05:20 PM, Jason Wang wrote: On 2016年08月31日 17:03, Zhang Chen wrote: On 08/31/2016 03:53 PM, Jason Wang wrote: On 2016年08月17日 16:10, Zhang Chen wrote: This a COLO net ascii figure: Primary qemu Secondary qemu

Re: [Qemu-devel] [PATCH V12 05/10] colo-compare: track connection and enqueue packet

2016-08-31 Thread Zhang Chen
On 08/31/2016 04:52 PM, Jason Wang wrote: On 2016年08月17日 16:10, Zhang Chen wrote: In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn

Re: [Qemu-devel] [PATCH V12 06/10] colo-compare: introduce packet comparison thread

2016-08-31 Thread Zhang Chen
On 08/31/2016 05:13 PM, Jason Wang wrote: On 2016年08月17日 16:10, Zhang Chen wrote: If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes but secondary packet does not

Re: [Qemu-devel] [PATCH V12 07/10] colo-compare: add TCP, UDP, ICMP packet comparison

2016-08-31 Thread Zhang Chen
On 08/31/2016 05:33 PM, Jason Wang wrote: On 2016年08月17日 16:10, Zhang Chen wrote: We add TCP,UDP,ICMP packet comparison to replace IP packet comparison. This can increase the accuracy of the package comparison. Less checkpoint more efficiency. Signed-off-by: Zhang Chen Signed-off-by: Li

Re: [Qemu-devel] [PATCH V12 02/10] colo-compare: introduce colo compare initialization

2016-08-31 Thread Zhang Chen
On 08/31/2016 05:39 PM, Zhang Chen wrote: On 08/31/2016 05:20 PM, Jason Wang wrote: On 2016年08月31日 17:03, Zhang Chen wrote: On 08/31/2016 03:53 PM, Jason Wang wrote: On 2016年08月17日 16:10, Zhang Chen wrote: This a COLO net ascii figure: Primary qemu Secondary qemu

[Qemu-devel] [PATCH V13 04/12] net/colo.c: add colo.c to define and handle packet

2016-09-05 Thread Zhang Chen
The net/colo.c is used by colo-compare and filter-rewriter. this can share common data structure like net packet, and other functions. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/Makefile.objs | 1 + net/colo-compare.c | 113

[Qemu-devel] [PATCH V13 00/12] Introduce COLO-Proxy

2016-09-05 Thread Zhang Chen
- other bug fix - add RFC index - add usage in patch 1/4 v2: - add jhash.h v1: - initial patch Zhang Chen (12): docs: Add documentation for COLO-proxy qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext colo-compare: introduce colo compare initialization net/colo.

[Qemu-devel] [PATCH V13 09/12] filter-rewriter: introduce filter-rewriter initialization

2016-09-05 Thread Zhang Chen
condary. usage: colo secondary: -object filter-redirector,id=f1,netdev=hn0,queue=tx,indev=red0 -object filter-redirector,id=f2,netdev=hn0,queue=rx,outdev=red1 -object filter-rewriter,id=rew0,netdev=hn0,queue=all Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Con

[Qemu-devel] [PATCH V13 08/12] colo-compare: add TCP, UDP, ICMP packet comparison

2016-09-05 Thread Zhang Chen
We add TCP,UDP,ICMP packet comparison to replace IP packet comparison. This can increase the accuracy of the package comparison. Less checkpoint more efficiency. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 145

[Qemu-devel] [PATCH V13 01/12] docs: Add documentation for COLO-proxy

2016-09-05 Thread Zhang Chen
Introduce the design of COLO-proxy, and how to use it. Signed-off-by: Zhang Chen --- docs/colo-proxy.txt | 188 1 file changed, 188 insertions(+) create mode 100644 docs/colo-proxy.txt diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt

[Qemu-devel] [PATCH V13 11/12] filter-rewriter: rewrite tcp packet to keep secondary connection

2016-09-05 Thread Zhang Chen
ction kept good. In code We use offset( = secondary_seq - primary_seq ) to rewrite seq or ack. handle_primary_tcp_pkt: tcp_pkt->th_ack += offset; handle_secondary_tcp_pkt: tcp_pkt->th_seq -= offset; Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang

[Qemu-devel] [PATCH V13 05/12] Jhash: add linux kernel jhashtable in qemu

2016-09-05 Thread Zhang Chen
Jhash will be used by colo-compare and filter-rewriter to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/qemu/jhash.h | 59 net/colo.h | 1 + 2

[Qemu-devel] [PATCH V13 03/12] colo-compare: introduce colo compare initialization

2016-09-05 Thread Zhang Chen
,id=red0,host=3.3.3.3,port=9003 -chardev socket,id=red1,host=3.3.3.3,port=9004 -object filter-redirector,id=f1,netdev=hn0,queue=tx,indev=red0 -object filter-redirector,id=f2,netdev=hn0,queue=rx,outdev=red1 Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net

[Qemu-devel] [PATCH V13 07/12] colo-compare: introduce packet comparison thread

2016-09-05 Thread Zhang Chen
checkpoint. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 231 + net/colo.c | 1 + net/colo.h | 3 + trace-events | 2 + 4 files changed, 237 insertions

[Qemu-devel] [PATCH V13 10/12] filter-rewriter: track connection and parse packet

2016-09-05 Thread Zhang Chen
We use net/colo.h to track connection and parse packet Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo.c| 14 ++ net/colo.h| 1 + net/filter-rewriter.c | 50 ++ 3

[Qemu-devel] [PATCH V13 02/12] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-09-05 Thread Zhang Chen
Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang Reviewed-by: Daniel P. Berrange

[Qemu-devel] [PATCH V13 12/12] MAINTAINERS: add maintainer for COLO-proxy

2016-09-05 Thread Zhang Chen
add Zhang Chen and Li zhijian as co-maintainers of COLO-proxy. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b6fb84e..4781f9f 100644 --- a/MAINTAINERS

[Qemu-devel] [PATCH V13 06/12] colo-compare: track connection and enqueue packet

2016-09-05 Thread Zhang Chen
;s own conn. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 51 - net/colo.c | 108 + net/colo.h | 27 ++ 3 files changed, 176 insert

Re: [Qemu-devel] [PATCH V13 06/12] colo-compare: track connection and enqueue packet

2016-09-06 Thread Zhang Chen
On 09/06/2016 03:51 PM, Jason Wang wrote: On 2016年09月05日 17:37, Zhang Chen wrote: In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn

Re: [Qemu-devel] [PATCH V13 00/12] Introduce COLO-Proxy

2016-09-06 Thread Zhang Chen
On 09/06/2016 04:02 PM, Jason Wang wrote: On 2016年09月05日 17:37, Zhang Chen wrote: COLO-proxy is a part of COLO project. COLO project is composed of COLO-frame, COLO-proxy and block-replication. It is used to compare the network package to help COLO decide whether to do checkpoint. With COLO

[Qemu-devel] [PATCH V14 04/12] Jhash: add linux kernel jhashtable in qemu

2016-09-08 Thread Zhang Chen
Jhash will be used by colo-compare and filter-rewriter to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/qemu/jhash.h | 59 net/colo.h | 1 + 2

[Qemu-devel] [PATCH V14 00/12] Introduce COLO-Proxy

2016-09-08 Thread Zhang Chen
ame v2.7 - fix most of Dave's comments (except RCU) - add TCP,UDP,ICMP and other packet comparison - add trace-event - add some comments - other bug fix - add RFC index - add usage in patch 1/4 v2: - add jhash.h v1: - initial patch Zhang Chen (12): qemu-char: Add qemu_c

[Qemu-devel] [PATCH V14 10/12] filter-rewriter: rewrite tcp packet to keep secondary connection

2016-09-08 Thread Zhang Chen
ction kept good. In code We use offset( = secondary_seq - primary_seq ) to rewrite seq or ack. handle_primary_tcp_pkt: tcp_pkt->th_ack += offset; handle_secondary_tcp_pkt: tcp_pkt->th_seq -= offset; Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang

[Qemu-devel] [PATCH V14 06/12] colo-compare: introduce packet comparison thread

2016-09-08 Thread Zhang Chen
checkpoint. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 233 + net/colo.c | 1 + net/colo.h | 3 + trace-events | 2 + 4 files changed, 239 insertions

[Qemu-devel] [PATCH V14 07/12] colo-compare: add TCP, UDP, ICMP packet comparison

2016-09-08 Thread Zhang Chen
We add TCP,UDP,ICMP packet comparison to replace IP packet comparison. This can increase the accuracy of the package comparison. Less checkpoint more efficiency. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 147

[Qemu-devel] [PATCH V14 11/12] MAINTAINERS: add maintainer for COLO-proxy

2016-09-08 Thread Zhang Chen
add Zhang Chen and Li zhijian as co-maintainers of COLO-proxy. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b6fb84e..4781f9f 100644 --- a/MAINTAINERS

[Qemu-devel] [PATCH V14 05/12] colo-compare: track connection and enqueue packet

2016-09-08 Thread Zhang Chen
;s own conn. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 53 +- net/colo.c | 109 + net/colo.h | 39 +++ 3 files changed, 191

[Qemu-devel] [PATCH V14 12/12] docs: Add documentation for COLO-proxy

2016-09-08 Thread Zhang Chen
Introduce the design of COLO-proxy, and how to use it. Signed-off-by: Zhang Chen --- docs/colo-proxy.txt | 188 1 file changed, 188 insertions(+) create mode 100644 docs/colo-proxy.txt diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt

[Qemu-devel] [PATCH V14 02/12] colo-compare: introduce colo compare initialization

2016-09-08 Thread Zhang Chen
,id=red0,host=3.3.3.3,port=9003 -chardev socket,id=red1,host=3.3.3.3,port=9004 -object filter-redirector,id=f1,netdev=hn0,queue=tx,indev=red0 -object filter-redirector,id=f2,netdev=hn0,queue=rx,outdev=red1 Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net

[Qemu-devel] [PATCH V14 01/12] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-09-08 Thread Zhang Chen
Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang Reviewed-by: Daniel P. Berrange

[Qemu-devel] [PATCH V14 08/12] filter-rewriter: introduce filter-rewriter initialization

2016-09-08 Thread Zhang Chen
condary. usage: colo secondary: -object filter-redirector,id=f1,netdev=hn0,queue=tx,indev=red0 -object filter-redirector,id=f2,netdev=hn0,queue=rx,outdev=red1 -object filter-rewriter,id=rew0,netdev=hn0,queue=all Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Con

[Qemu-devel] [PATCH V14 03/12] net/colo.c: add colo.c to define and handle packet

2016-09-08 Thread Zhang Chen
The net/colo.c is used by colo-compare and filter-rewriter. this can share common data structure like net packet, and other functions. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/Makefile.objs | 1 + net/colo-compare.c | 114

[Qemu-devel] [PATCH V14 09/12] filter-rewriter: track connection and parse packet

2016-09-08 Thread Zhang Chen
We use net/colo.h to track connection and parse packet Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo.c| 14 ++ net/colo.h| 1 + net/filter-rewriter.c | 50 ++ 3

[Qemu-devel] [PATCH 0/3] Add new qmp commands to suppurt Xen COLO

2016-11-30 Thread Zhang Chen
Xen COLO depend on qemu COLO replication function. So, We need new qmp commands for Xen to use qemu replication. Zhang Chen (3): Migration: Don't load vmdesc when xen is enabled Add a new qmp command to start/stop replication Add a new qmp command to do checkpoint, get replication

[Qemu-devel] [PATCH 1/3] Migration: Don't load vmdesc when xen is enabled

2016-11-30 Thread Zhang Chen
Xen need't this. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- migration/savevm.c | 4 1 file changed, 4 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index 0363372..bec6c7e 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1973,6 +19

[Qemu-devel] [PATCH 3/3] Add a new qmp command to do checkpoint, get replication error

2016-11-30 Thread Zhang Chen
We can call this qmp command to do checkpoint outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- docs/qmp-commands.txt | 24 migration/colo.c | 10 ++ qapi-schema.json | 22

[Qemu-devel] [PATCH 2/3] Add a new qmp command to start/stop replication

2016-11-30 Thread Zhang Chen
We can call this qmp command to start/stop replication outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- docs/qmp-commands.txt | 17 + migration/colo.c | 22 ++ qapi-schema.json | 18

[Qemu-devel] [PATCH] docs: Fix description of the sentence

2016-11-30 Thread Zhang Chen
Say it in another way to make it easier to understand. Signed-off-by: Zhang Chen Signed-off-by: Eric Blake Signed-off-by: Stefan Weil --- docs/colo-proxy.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt index 76767cb..c4941de

Re: [Qemu-devel] [PATCH 1/3] Migration: Don't load vmdesc when xen is enabled

2016-12-01 Thread Zhang Chen
On 12/01/2016 10:54 PM, Eric Blake wrote: On 12/01/2016 12:06 AM, Zhang Chen wrote: Xen need't this. Huh? Did you mean: Xen doesn't need this. Yes, you get the point. I will fix this comments in next version. Thanks Zhang Chen Signed-off-by: Zhang Chen Signed-off-by: We

Re: [Qemu-devel] [PATCH for-2.8] docs: Fix description of the sentence

2016-12-01 Thread Zhang Chen
On 12/01/2016 10:57 PM, Eric Blake wrote: On 12/01/2016 12:55 AM, Zhang Chen wrote: Say it in another way to make it easier to understand. Signed-off-by: Zhang Chen Signed-off-by: Eric Blake I guess that's because I suggested the replacement text to use, even though I didn't

Re: [Qemu-devel] [PATCH 2/3] Add a new qmp command to start/stop replication

2016-12-01 Thread Zhang Chen
On 12/01/2016 10:55 PM, Eric Blake wrote: On 12/01/2016 12:06 AM, Zhang Chen wrote: We can call this qmp command to start/stop replication outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- +++ b/qapi-schema.json @@ -4676,6 +4676,24

Re: [Qemu-devel] [PATCH 3/3] Add a new qmp command to do checkpoint, get replication error

2016-12-01 Thread Zhang Chen
On 12/01/2016 10:55 PM, Eric Blake wrote: On 12/01/2016 12:06 AM, Zhang Chen wrote: We can call this qmp command to do checkpoint outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- docs/qmp-commands.txt | 24

Re: [Qemu-devel] [PATCH 0/3] Add new qmp commands to suppurt Xen COLO

2016-12-06 Thread Zhang Chen
ID: ed37ef1f91c20f0ab162ce60f8c38400b917fa64 COLO: introduce new API to prepare/start/do/get_error/stop replication a0ddc0b359375b2418213966dfbdbfab593ecc6f tools/libxl: introduction of libxl__qmp_restore to load qemu state Thanks Zhang Chen Thanks! - Stefano On Thu, 1 Dec 2016, Zhang Chen

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.8] docs: Fix description of the sentence

2016-12-07 Thread Zhang Chen
On 12/02/2016 03:57 PM, Laurent Vivier wrote: On 02/12/2016 03:59, Zhang Chen wrote: On 12/01/2016 10:57 PM, Eric Blake wrote: On 12/01/2016 12:55 AM, Zhang Chen wrote: Say it in another way to make it easier to understand. Signed-off-by: Zhang Chen Signed-off-by: Eric Blake I guess

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.9] docs: Fix description of the sentence

2016-12-07 Thread Zhang Chen
On 12/07/2016 09:30 PM, Stefan Hajnoczi wrote: On Wed, Dec 07, 2016 at 10:01:49AM +0100, Laurent Vivier wrote: Le 07/12/2016 à 09:58, Zhang Chen a écrit : On 12/02/2016 03:57 PM, Laurent Vivier wrote: On 02/12/2016 03:59, Zhang Chen wrote: On 12/01/2016 10:57 PM, Eric Blake wrote: On 12

[Qemu-devel] [PATCH for-2.9 V2 0/3] Add new qmp commands to suppurt Xen COLO

2016-12-08 Thread Zhang Chen
a0ddc0b359375b2418213966dfbdbfab593ecc6f tools/libxl: introduction of libxl__qmp_restore to load qemu state Zhang Chen (3): Migration: Don't load vmdesc when xen is enabled Add a new qmp command to start/stop replication Add a new qmp command to do checkpoint, get replication error doc

[Qemu-devel] [PATCH for-2.9 V2 2/3] Add a new qmp command to start/stop replication

2016-12-08 Thread Zhang Chen
We can call this qmp command to start/stop replication outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen --- docs/qmp-commands.txt | 17 + migration/colo.c | 22 ++ qapi-schema.json | 19 +++ 3 files

<    1   2   3   4   5   6   7   8   9   10   >