On 11/02/2016 09:29 PM, Eric Blake wrote:
On 11/01/2016 08:32 PM, Zhang Chen wrote:
I still don't understand the comment in docs/colo-proxy.txt.
Me neither.
Which part of the docs/colo-proxy.txt?
The one quoted below.
Perhaps I can explain it more clearly and make the doc better.
+++ b/docs/colo-proxy.txt
@@ -158,7 +158,7 @@ secondary.
== Usage ==
-Here, we use demo ip and port discribe more clearly.
+Here, we use demo ip and port describe more clearly.
Primary(ip:3.3.3.3):
-netdev
tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown
-device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66
Maybe:
Here is an example using demonstration IP and port addresses to more
clearly describe the usage.
The remaining hunks are clear improvements, so:
Reviewed-by: Eric Blake <ebl...@redhat.com>
It's easier to understand.
Okay, so you like my proposal for a potential reword. Now, who should
submit it as a patch? Stefan (since he found the confusing sentence in
the first place), you (since you wrote most of the document to begin
with), or me (since I proposed wording that you like)?
I will submit the patch later, if you think that's OK.
--
Thanks
zhangchen
