Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

2016-05-12 Thread Zhang Chen
On 05/12/2016 04:01 PM, Jason Wang wrote: On 2016年05月12日 14:49, Zhang Chen wrote: On 05/09/2016 06:49 PM, Zhang Chen wrote: + +s->chr_sec_in = qemu_chr_find(s->sec_indev); +if (s->chr_sec_in == NULL) { +error_setg(errp, "Secondary IN Device

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-12 Thread Zhang Chen
On 05/12/2016 04:07 PM, Jason Wang wrote: On 2016年05月12日 14:33, Zhang Chen wrote: +ret = net_fill_rstate(&s->rs, buf, size); + +if (ret == -1) { +goto eoc; +} else if (ret == 1) { +if (qemu_send_packet_async(&s->

Re: [Qemu-devel] [PATCH V2] net/net: Add SocketReadState for reuse codes

2016-05-13 Thread Zhang Chen
On 05/13/2016 12:02 PM, Jason Wang wrote: On 2016年05月12日 17:19, Zhang Chen wrote: This function is from net/socket.c, move it to net.c and net.h. Add SocketReadState to make others reuse net_fill_rstate(). suggestion from jason. v2: - rename ReadState to SocketReadState - add

RE: [PULL V2 25/25] net/colo.c: fix segmentation fault when packet is not parsed correctly

2022-07-31 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Monday, August 1, 2022 12:18 PM > To: Zhang, Chen ; Xu, Tao3 > Cc: qemu-devel@nongnu.org; Li Zhijian ; Peter > Maydell > Subject: Re: [PULL V2 25/25] net/colo.c: fix segmentation fault when packet > is not parsed

[PATCH] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-02 Thread Zhang Chen
e any misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/net/colo.c b/net/colo.c index 6b0ff562ad..dfb15b4c14 1

RE: [PATCH 0/1] Update vfio-user module to the latest

2022-08-02 Thread Zhang, Chen
> -Original Message- > From: Qemu-devel bounces+chen.zhang=intel@nongnu.org> On Behalf Of Jagannathan > Raman > Sent: Tuesday, August 2, 2022 9:24 AM > To: qemu-devel@nongnu.org > Cc: stefa...@gmail.com; berra...@redhat.com > Subject: [PATCH 0/1] Update vfio-user module to the lates

RE: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-04 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, August 5, 2022 11:46 AM > To: Zhang, Chen > Cc: Peter Maydell ; Li Zhijian > ; qemu-dev > Subject: Re: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity. > > On Tue, Aug 2, 2022 a

RE: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-05 Thread Zhang, Chen
> -Original Message- > From: Peter Maydell > Sent: Friday, August 5, 2022 4:53 PM > To: Zhang, Chen > Cc: Jason Wang ; Li Zhijian ; > qemu-dev > Subject: Re: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity. > > On Fri, 5 Aug 2022 a

[PATCH V2] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-05 Thread Zhang Chen
e any misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/net/colo.c b/net/colo.c index 6b0ff562ad..524afa3d9b 1

RE: [PATCH V2] net/colo.c: Fix the pointer issuse reported by Coverity.

2022-08-08 Thread Zhang, Chen
> -Original Message- > From: Peter Maydell > Sent: Friday, August 5, 2022 5:57 PM > To: Zhang, Chen > Cc: Jason Wang ; Li Zhijian ; > qemu-dev > Subject: Re: [PATCH V2] net/colo.c: Fix the pointer issuse reported by > Coverity. > > On Fri, 5 Aug 20

[PATCH V3] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-08 Thread Zhang Chen
e any misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 18 ++ net/colo.h | 1 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/net/colo.c b/net/colo.c

RE: [PATCH V3] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-09 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Tuesday, August 9, 2022 4:12 PM > To: Zhang, Chen > Cc: Peter Maydell ; Li Zhijian > ; qemu-dev > Subject: Re: [PATCH V3] net/colo.c: Fix the pointer issue reported by > Coverity. > > On Tue, Aug 9, 2022

RE: [PATCH V3] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-09 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Tuesday, August 9, 2022 4:43 PM > To: Zhang, Chen > Cc: Peter Maydell ; Li Zhijian > ; qemu-dev > Subject: Re: [PATCH V3] net/colo.c: Fix the pointer issue reported by > Coverity. > > On Tue, Aug 9, 2022

[PATCH V4] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-09 Thread Zhang Chen
e any misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 18 ++ net/colo.h | 1 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/net/colo.c b/net/colo.c

[PATCH V4 RESEND] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-09 Thread Zhang Chen
e any misconfiguration here, the vnet_hdr_len is wrong for parse the packet, the data+offset will point to wrong place. Signed-off-by: Zhang Chen --- net/colo.c | 18 ++ net/colo.h | 1 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/net/colo.c b/net/colo.c

RE: [PATCH V4] net/colo.c: Fix the pointer issue reported by Coverity.

2022-08-09 Thread Zhang, Chen
Please review the V4 RESEND version. Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Tuesday, August 9, 2022 4:45 PM > To: Jason Wang ; Peter Maydell > ; Li Zhijian ; qemu-dev > > Cc: Zhang, Chen > Subject: [PATCH V4] net/colo.c: Fix the pointer is

RE: [PATCH V2 09/11] migration: privatize colo interfaces

2024-03-11 Thread Zhang, Chen
> -Original Message- > From: Steve Sistare > Sent: Tuesday, March 12, 2024 1:49 AM > To: qemu-devel@nongnu.org > Cc: Alex Williamson ; Cedric Le Goater > ; Michael S. Tsirkin ; David Hildenbrand > ; Peter Xu ; Fabiano Rosas > ; Zhang, Hailiang ; Zhang, > Che

RE: COLO state?

2024-04-14 Thread Zhang, Chen
> -Original Message- > From: Fabiano Rosas > Sent: Thursday, April 11, 2024 10:40 PM > To: Zhang, Hailiang ; Zhang, Chen > ; Li Zhijian > Cc: qemu-devel@nongnu.org; Peter Xu > Subject: COLO state? > > Hi COLO maintainers, > > Would you please take

RE: [PATCH v2] migration/colo: Fix bdrv_graph_rdlock_main_loop: Assertion `!qemu_in_coroutine()' failed.

2024-04-16 Thread Zhang, Chen
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Wednesday, April 17, 2024 2:14 PM > To: Li Zhijian ; Zhang, Hailiang > ; pet...@redhat.com; faro...@suse.de > Cc: qemu-devel@nongnu.org; Zhang, Chen ; Wen > Congyang ; Xie Changlong > > Subject: Re

RE: [PATCH 2/3] migration/colo: make colo_incoming_co() return void

2024-05-10 Thread Zhang, Chen
> -Original Message- > From: Li Zhijian > Sent: Thursday, May 9, 2024 11:31 AM > To: Peter Xu ; Fabiano Rosas > Cc: Zhang, Hailiang ; qemu- > de...@nongnu.org; Zhang, Chen ; Li Zhijian > > Subject: [PATCH 2/3] migration/colo: make colo_incoming_co() return

RE: [PATCH 3/3] migration/colo: Tidy up bql_unlock() around bdrv_activate_all()

2024-05-10 Thread Zhang, Chen
> -Original Message- > From: Li Zhijian > Sent: Thursday, May 9, 2024 11:31 AM > To: Peter Xu ; Fabiano Rosas > Cc: Zhang, Hailiang ; qemu- > de...@nongnu.org; Zhang, Chen ; Li Zhijian > ; Michael Tokarev > Subject: [PATCH 3/3] migration/colo: Tid

RE: [PATCH 1/3] migration/colo: Minor fix for colo error message

2024-05-10 Thread Zhang, Chen
> -Original Message- > From: Li Zhijian > Sent: Thursday, May 9, 2024 11:31 AM > To: Peter Xu ; Fabiano Rosas > Cc: Zhang, Hailiang ; qemu- > de...@nongnu.org; Zhang, Chen ; Li Zhijian > > Subject: [PATCH 1/3] migration/colo: Minor fix for colo error messag

Re: [Qemu-devel] [PATCH 0/3] Optimize COLO related codes and description

2019-05-09 Thread Zhang, Chen
Hi Dave, I noticed that you have reviewed all the patches in this series, can you queue it? Thanks Zhang Chen > -Original Message- > From: Zhang, Chen > Sent: Friday, April 26, 2019 5:07 PM > To: Laurent Vivier ; Dr. David Alan Gilbert > ; Juan Quintela ; zhanghail

[Qemu-devel] [PATCH V2 1/5] COLO-compare: Add new parameter to communicate with remote colo-frame

2019-06-09 Thread Zhang Chen
From: Zhang Chen We add the "notify_dev=chardevID" parameter. After that colo-compare can connect with remote(currently just for Xen, KVM-COLO didn't need it.) colo-frame through chardev socket, it can notify remote(Xen) colo-frame to handle checkpoint event. Signed-off

[Qemu-devel] [PATCH V2 3/5] COLO-compare: Make the compare_chr_send() can send notification message.

2019-06-09 Thread Zhang Chen
From: Zhang Chen We need use this function to send notification message for remote colo-frame(Xen). So we add new parameter for this job. Signed-off-by: Zhang Chen --- net/colo-compare.c | 41 + 1 file changed, 33 insertions(+), 8 deletions(-) diff

[Qemu-devel] [PATCH V2 0/5] Add Xen COLO support

2019-06-09 Thread Zhang Chen
From: Zhang Chen Xen COLO based on KVM COLO architecture, it shared COLO proxy and block replication with KVM COLO. The only differece is Xen COLO have own COLO-frame to handle live migration related function, so we need this series make Xen COLO frame can communicate with other COLO modules in

[Qemu-devel] [PATCH V2 2/5] COLO-compare: Add remote notification chardev handler frame

2019-06-09 Thread Zhang Chen
From: Zhang Chen Add chardev handler to send notification to remote(current from Xen) colo-frame. Signed-off-by: Zhang Chen --- net/colo-compare.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index

[Qemu-devel] [PATCH V2 4/5] COLO-compare: Add colo-compare remote notify support

2019-06-09 Thread Zhang Chen
From: Zhang Chen This patch make colo-compare can send message to remote COLO frame(Xen) when occur checkpoint. Signed-off-by: Zhang Chen --- net/colo-compare.c | 54 +- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/net/colo

[Qemu-devel] [PATCH V2 5/5] migration/colo.c: Add missed filter notify for Xen COLO.

2019-06-09 Thread Zhang Chen
From: Zhang Chen We need to notify net filter to do checkpoint for Xen COLO, like KVM side. Signed-off-by: Zhang Chen --- migration/colo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/colo.c b/migration/colo.c index 8c1644091f..9f84b1fa3c 100644 --- a/migration/colo.c +++ b

Re: [Qemu-devel] [PATCH V2 0/5] Add Xen COLO support

2019-06-09 Thread Zhang, Chen
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Monday, June 10, 2019 12:09 PM > To: Zhang, Chen ; Li Zhijian ; > Dr. David Alan Gilbert ; Juan Quintela > ; zhanghailiang ; > qemu-dev ; Stefano Stabellini > ; Paul Durrant > Cc

[Qemu-devel] [PATCH] block/replication.c: Fix crash issue after failover

2019-06-14 Thread Zhang Chen
From: Zhang Chen No block job on active disk after failover. In the replication_stop() function have canceled the block job, we check it again here. Signed-off-by: Zhang Chen --- block/replication.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/replication.c b

Re: [Qemu-devel] [PATCH] block/replication.c: Fix crash issue after failover

2019-06-15 Thread Zhang, Chen
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: Friday, June 14, 2019 6:18 PM > To: Zhang, Chen > Cc: Xie Changlong ; Max Reitz > ; qemu-block ; qemu-dev > ; Zhang Chen ; > vsement...@virtuozzo.com > Subject: Re: [PATCH] block/rep

Re: [Qemu-devel] [PATCH V3 6/7] Migration/colo.c: Add the necessary checks for colo_do_failover

2019-03-08 Thread Zhang, Chen
-Original Message- From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] Sent: Saturday, March 9, 2019 1:41 AM To: Zhang, Chen Cc: Li Zhijian ; Zhang Chen ; Juan Quintela ; zhanghailiang ; Markus Armbruster ; Eric Blake ; qemu-dev Subject: Re: [PATCH V3 6/7] Migration/colo.c

Re: [Qemu-devel] [PATCH V3 7/7] Migration/colo.c: Make user obtain the COLO mode info after failover

2019-03-08 Thread Zhang, Chen
-Original Message- From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] Sent: Saturday, March 9, 2019 1:46 AM To: Zhang, Chen Cc: Li Zhijian ; Zhang Chen ; Juan Quintela ; zhanghailiang ; Markus Armbruster ; Eric Blake ; qemu-dev Subject: Re: [PATCH V3 7/7] Migration/colo.c

Re: [Qemu-devel] [PATCH V3 4/7] Migration/colo.c: Add new COLOExitReason to handle all failover state

2019-03-11 Thread Zhang, Chen
-Original Message- From: Markus Armbruster [mailto:arm...@redhat.com] Sent: Sunday, March 10, 2019 1:06 AM To: Zhang, Chen Cc: Li Zhijian ; Zhang Chen ; Dr. David Alan Gilbert ; Juan Quintela ; zhanghailiang ; Eric Blake ; qemu-dev ; Zhang, Chen Subject: Re: [Qemu-devel] [PATCH V3

[Qemu-devel] [PATCH] MAINTAINERS: Update the latest email address

2019-03-14 Thread Zhang Chen
From: Zhang Chen Signed-off-by: Zhang Chen --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0e7baa9aa2..f127b1356c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2167,7 +2167,7 @@ F: include/migration/failover.h F: docs/COLO

[Qemu-devel] [PATCH V4 2/4] Migration/colo.c: Add new COLOExitReason to handle all failover state

2019-03-14 Thread Zhang Chen
From: Zhang Chen In this patch we add the processing state for COLOExitReason, because we have to identify COLO in the failover processing state or failover error state. In the way, we can handle all the failover state. We have improved the description of the COLOExitReason by the way. Signed

[Qemu-devel] [PATCH V4 1/4] Migration/colo.c: Fix COLO failover status error

2019-03-14 Thread Zhang Chen
From: Zhang Chen When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED. The origin codes misunderstand the FAILOVER_STATUS_REQUIRE. Signed-off-by: Zhang Chen Reviewed-by: Dr. David Alan Gilbert --- migration/colo.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions

[Qemu-devel] [PATCH V4 4/4] Migration/colo.c: Make user obtain the COLO mode info after failover

2019-03-14 Thread Zhang Chen
From: Zhang Chen Add the last_colo_mode to save the status after failover. This patch can solve the issue that user got nothing to call query_colo_status after failover. Signed-off-by: Zhang Chen --- migration/colo.c | 28 +++- 1 file changed, 23 insertions(+), 5

[Qemu-devel] [PATCH V4 3/4] Migration/colo.c: Add the necessary checks for colo_do_failover

2019-03-14 Thread Zhang Chen
From: Zhang Chen Signed-off-by: Zhang Chen Reviewed-by: Dr. David Alan Gilbert --- migration/colo.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/migration/colo.c b/migration/colo.c index dbe2b88807..d1ae2e6d11 100644 --- a/migration/colo.c +++ b/migration

[Qemu-devel] [PATCH V4 0/4] Migration/colo: Fix upstream bugs when occur failover

2019-03-14 Thread Zhang Chen
From: Zhang Chen This series focus on COLO failover bug fix and optimization. V4: - Remove merged patch. - Fix grammer issues in patch 2/4 to address markus's comments. - Rebased on upstream code. V3: - Fix grammer issues in patch 4/7. - Add more information in commit log of patc

[RFC PATCH 4/4] vl.c: Make Advanced Watch Dog delayed initialization

2019-10-16 Thread Zhang Chen
From: Zhang Chen Because Advanced Watch Dog module needs chardev socket to initialize properly before. Signed-off-by: Zhang Chen --- vl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/vl.c b/vl.c index 4489cfb2bb..4094f61d28 100644 --- a/vl.c +++ b/vl.c @@ -2683,6 +2683,13

[RFC PATCH 0/4] Introduce Advanced Watch Dog module

2019-10-16 Thread Zhang Chen
From: Zhang Chen Advanced Watch Dog is an universal monitoring module on VMM side, it can be used to detect network down(VMM to guest, VMM to VMM, VMM to another remote server) and do previously set operation. for example: send message to admin, notify another VMM, send qmp command to qemu do

[RFC PATCH 3/4] net/awd.c: Load advanced watch dog worker thread job

2019-10-16 Thread Zhang Chen
From: Zhang Chen This patch load pulse_timer and timeout_timer in the new iothread. The pulse timer will send pulse info to awd_node, and the timeout timer will check the reply pulse from awd_node. If timeout occur, it will send opt_script's data to the notification_node. Signed-off-by:

[RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog module framework

2019-10-16 Thread Zhang Chen
From: Zhang Chen This patch introduce a new module named Advanced Watch Dog, and defined the input and output parameter. AWD use standard chardev as the way of communicationg with the outside world. Demo command: -object advanced-watchdog,id=heart1,server=on,awd_node=h1,notification_node

[RFC PATCH 2/4] net/awd.c: Initailize input/output chardev

2019-10-16 Thread Zhang Chen
From: Zhang Chen Find and check the chardev awd_node and notification_node, The awd_node used for keep connect with outside(like VM client/other host/Remote server), and the notification_node used for do some operation when disconnect event occur. Signed-off-by: Zhang Chen --- net/awd.c | 37

Re: [RFC PATCH 0/4] Introduce Advanced Watch Dog module

2019-10-16 Thread Zhang Chen
rc.2019-10-16-11.34.59.10123] > Error 1 > make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-2eq69u33/src' > make: *** [docker-run-test-quick@centos7] Error 2 > > It looks this problem dose not caused by my patch series? Thanks Zhang Chen > real0m3.762s > user

Re: [RFC PATCH 0/4] Introduce Advanced Watch Dog module

2019-10-16 Thread Zhang Chen
019-10-16-11.34.59.10123] > Error 1 > make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-2eq69u33/src' > make: *** [docker-run-test-quick@centos7] Error 2 > It looks this problem dose not caused by my patch series? Thanks Zhang Chen > real0m3.762s > user0m2

RE: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog module framework

2019-10-22 Thread Zhang, Chen
> -Original Message- > From: Paolo Bonzini > Sent: Tuesday, October 22, 2019 1:24 AM > To: Zhang, Chen ; Jason Wang > ; qemu-dev > Cc: Zhang Chen > Subject: Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog > module framework > > On 16/10/19 13:

RE: [PATCH v6 1/4] block/replication.c: Ignore requests after failover

2019-10-23 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Saturday, October 19, 2019 2:46 AM > To: qemu-devel > Cc: Zhang, Chen ; Jason Wang > ; Wen Congyang ; > Xie Changlong ; Kevin Wolf > ; Max Reitz ; qemu-block > > Subject: Re: [PATCH v6 1/4] block/replic

RE: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog module framework

2019-10-23 Thread Zhang, Chen
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Wednesday, October 23, 2019 7:01 PM > To: Zhang, Chen ; Jason Wang > ; Paolo Bonzini ; qemu- > dev > Cc: Zhang Chen > Subject: Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog > mo

RE: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog module framework

2019-10-23 Thread Zhang, Chen
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Wednesday, October 23, 2019 7:39 PM > To: Zhang, Chen ; Jason Wang > ; Paolo Bonzini ; qemu- > dev > Cc: Zhang Chen > Subject: Re: [RFC PATCH 1/4] net/awd.c: Introduce Advanced Watch Dog > module f

RE: The issues about architecture of the COLO checkpoint

2020-02-12 Thread Zhang, Chen
For the issue 2: COLO need use the network packets to confirm PVM and SVM in the same state, Generally speaking, we can’t send PVM packets without compared with SVM packets. But to prevent jamming, I think COLO can do force checkpoint and send the PVM packets in this case. Thanks Zhang Chen

RE: The issues about architecture of the COLO checkpoint

2020-02-12 Thread Zhang, Chen
Add cc Jason Wang, he is a network expert. In case some network things goes wrong. Thanks Zhang Chen From: Zhang, Chen Sent: Thursday, February 13, 2020 10:10 AM To: 'Zhanghailiang' ; Daniel Cho Cc: Dr. David Alan Gilbert ; qemu-devel@nongnu.org Subject: RE: The issues about archi

Re: The issues about architecture of the COLO checkpoint

2020-02-16 Thread Zhang, Chen
time. If colo-compare got a primary packet without related secondary packet in a certain time , it will automatic trigger checkpoint. https://github.com/qemu/qemu/blob/master/net/colo-compare.c#L847 Thanks Zhang Chen Hi Hailiang, We base on qemu-4.1.0 for using COLO feature, in your

Re: [PATCH v7 0/4] colo: Add support for continuous replication

2020-02-19 Thread Zhang, Chen
Hi Jason, I noticed this series can't be merged or queued, do you met some problem about it? Thanks Zhang Chen Max Reitz ; qemu-block Subject: Re: [PATCH v7 0/4] colo: Add support for continuous replication On Fri, 25 Oct 2019 19:06:31 +0200 Lukas Straub wrote: Hello Everyone,

Re: The issues about architecture of the COLO checkpoint

2020-02-19 Thread Zhang, Chen
by QMP and qemu monitor commands. Thanks Zhang Chen Best regards, Daniel Cho Zhang, Chen mailto:chen.zh...@intel.com>> 於 2020年2月17日 週一 下午1:36寫道: On 2/15/2020 11:35 AM, Daniel Cho wrote: Hi Dave, Yes, I agree with you, it does need a timeout. Hi Daniel and Dave,

Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module

2020-02-19 Thread Zhang, Chen
On 2/12/2020 10:56 AM, Jason Wang wrote: On 2020/2/11 下午4:58, Zhang, Chen wrote: -Original Message- From: Jason Wang Sent: Monday, January 20, 2020 10:57 AM To: Zhang, Chen; Paolo Bonzini ; Philippe Mathieu-Daudé; qemu-dev Cc: Zhang Chen Subject: Re: [PATCH V4 0/5] Introduce Advanced

Re: [PATCH V3 0/4] Introduce Advanced Watch Dog module

2019-12-08 Thread Zhang, Chen
Hi All~ No news for a long time. Please give me more comments about this series. Thanks Zhang Chen On 11/19/2019 8:30 PM, Zhang, Chen wrote: From: Zhang Chen Advanced Watch Dog is an universal monitoring module on VMM side, it can be used to detect network down(VMM to guest, VMM to VMM

Re: [PATCH V3 0/4] Introduce Advanced Watch Dog module

2019-12-09 Thread Zhang, Chen
On 12/9/2019 5:08 PM, Paolo Bonzini wrote: On 08/12/19 18:52, Zhang, Chen wrote: Hi All~ No news for a long time. Please give me more comments about this series. Sorry, people were probably busy with the QEMU release candidates. Even before looking at the code, the series is completely

Re: [PATCH] colo: fix return without releasing RCU

2019-12-14 Thread Zhang, Chen
Reviewed-by: Zhang Chen --- migration/ram.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 7dd7f81..8d7c015 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -3891,26 +3891,27 @@ int

[PATCH V4 2/5] net/awd.c: Initailize input/output chardev

2019-12-17 Thread Zhang Chen
From: Zhang Chen Find and check the chardev awd_node and notification_node, The awd_node used for keep connect with outside(like VM client/other host/Remote server), and the notification_node used for do some operation when disconnect event occur. Signed-off-by: Zhang Chen --- net/awd.c | 37

[PATCH V4 4/5] vl.c: Make Advanced Watch Dog delayed initialization

2019-12-17 Thread Zhang Chen
From: Zhang Chen Advanced Watch Dog module needs chardev socket to initialize properly before running. Signed-off-by: Zhang Chen --- vl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/vl.c b/vl.c index 6a65a64bfd..048fe458b9 100644 --- a/vl.c +++ b/vl.c @@ -2689,6 +2689,13

[PATCH V4 3/5] net/awd.c: Load advanced watch dog worker thread job

2019-12-17 Thread Zhang Chen
From: Zhang Chen This patch load pulse_timer and timeout_timer in the new iothread. The pulse timer will send pulse info to awd_node, and the timeout timer will check the reply pulse from awd_node. If timeout occur, it will send opt_script's data to the notification_node. Signed-off-by:

[PATCH V4 0/5] Introduce Advanced Watch Dog module

2019-12-17 Thread Zhang Chen
From: Zhang Chen Advanced Watch Dog is an universal monitoring module on VMM side, it can be used to detect network down(VMM to guest, VMM to VMM, VMM to another remote server) and do previously set operation. Current AWD patch just accept any input as the signal to refresh the watchdog timer

[PATCH V4 5/5] docs/awd.txt: Add doc to introduce Advanced WatchDog(AWD) module

2019-12-17 Thread Zhang Chen
From: Zhang Chen Add docs to introduce Advanced WatchDog detail and usage. Signed-off-by: Zhang Chen --- docs/awd.txt | 88 1 file changed, 88 insertions(+) create mode 100644 docs/awd.txt diff --git a/docs/awd.txt b/docs/awd.txt new file

[PATCH V4 1/5] net/awd.c: Introduce Advanced Watch Dog module framework

2019-12-17 Thread Zhang Chen
From: Zhang Chen This patch introduce a new module named Advanced Watch Dog, and defined the input and output parameter. AWD use standard chardev as the way of communicationg with the outside world. If you want to use it, please add "--enable-awd" when configure qemu. Demo comman

Re: [Bug 1754542] Re: colo: vm crash with segmentation fault

2019-11-26 Thread Zhang Chen
Hi Lee, Can you introduce to me the detail test step about disk performance? I want to look into it when I have time. Thanks Zhang Chen On Wed, Nov 27, 2019 at 10:50 AM lee <1754...@bugs.launchpad.net> wrote: > > Hi Zhang Chen , > > I try colo follow https://wiki.qemu.org/F

RE: Network connection with COLO VM

2019-11-27 Thread Zhang, Chen
> -Original Message- > From: Dr. David Alan Gilbert > Sent: Wednesday, November 27, 2019 6:51 PM > To: Daniel Cho ; Zhang, Chen > ; lukasstra...@web.de > Cc: qemu-devel@nongnu.org > Subject: Re: Network connection with COLO VM > > * Daniel Cho (daniel...

RE: [PATCH V2 0/4] Introduce Advanced Watch Dog module

2019-11-27 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Wednesday, November 27, 2019 11:49 PM > To: Zhang, Chen > Cc: Jason Wang ; Paolo Bonzini > ; Philippe Mathieu-Daudé ; > qemu-dev ; Zhang Chen > Subject: Re: [PATCH V2 0/4] Introduce Advanced Watch Dog

RE: Network connection with COLO VM

2019-11-29 Thread Zhang, Chen
From: Daniel Cho Sent: Friday, November 29, 2019 10:43 AM To: Zhang, Chen Cc: Dr. David Alan Gilbert ; lukasstra...@web.de; qemu-devel@nongnu.org Subject: Re: Network connection with COLO VM Hi David, Zhang, Thanks for replying my question. We know why will occur this issue. As you said

Re: Network connection with COLO VM

2019-12-04 Thread Zhang, Chen
. Dave Yes, In previous COLO use cases, we need make primary node and secondary node boot in the same time. I did't expect such a big difference on netfilter/chardev. I think you can try without netfilter/chardev, after VM boot, re-build the netfilter/chardev related work with chardev serve

Re: [Qemu-devel] [PATCH 0/3] colo: Add support for continious replication

2019-08-14 Thread Zhang, Chen
Hi Lukas, Please fix this issue and add more comments in the commit log. Thanks Zhang Chen > -Original Message- > From: no-re...@patchew.org [mailto:no-re...@patchew.org] > Sent: Thursday, August 15, 2019 11:20 AM > To: lukasstra...@web.de > Cc: Zhang, Chen ; qemu-d

Re: [Qemu-devel] [PATCH v2 0/3] colo: Add support for continious replication

2019-08-15 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub [mailto:lukasstra...@web.de] > Sent: Friday, August 16, 2019 3:48 AM > To: Dr. David Alan Gilbert > Cc: qemu-devel ; Zhang, Chen > ; Jason Wang ; Xie > Changlong ; Wen Congyang > > Subject: Re: [Qemu-devel] [PATCH v2

RE: [PATCH V4 0/5] Introduce Advanced Watch Dog module

2020-02-11 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Monday, January 20, 2020 10:57 AM > To: Zhang, Chen ; Paolo Bonzini > ; Philippe Mathieu-Daudé ; > qemu-dev > Cc: Zhang Chen > Subject: Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module > > > On 20

RE: The issues about architecture of the COLO checkpoint

2020-02-11 Thread Zhang, Chen
> -Original Message- > From: Zhanghailiang > Sent: Wednesday, February 12, 2020 11:18 AM > To: Dr. David Alan Gilbert ; Daniel Cho > ; Zhang, Chen > Cc: qemu-devel@nongnu.org > Subject: RE: The issues about architecture of the COLO checkpoint > > Hi, >

RE: [PATCH 00/14] migration/ram.c: Refactor compress code

2023-04-02 Thread Zhang, Chen
> -Original Message- > From: qemu-devel-bounces+chen.zhang=intel@nongnu.org devel-bounces+chen.zhang=intel@nongnu.org> On Behalf Of Lukas > Straub > Sent: Monday, April 3, 2023 1:56 AM > To: qemu-devel > Cc: Dr. David Alan Gilbert ; Juan Quintela > ; Peter Xu > Subject: [PATCH

RE: [PATCH] MAINTAINERS: Remove and change David Gilbert maintainer entries

2023-04-03 Thread Zhang, Chen
he maintainer entries. > > 'virtiofs' is just the device code now, so is pretty small, and Stefan is > still a > maintainer there. > > 'migration' still has Juan. Reviewed-by: Zhang Chen Thanks for the guidance and help with the migration/HMP/QM

RE: [PATCH 2/2] migration/ram.c: Remove the qemu_mutex_lock in colo_flush_ram_cache.

2021-11-10 Thread Zhang, Chen
> -Original Message- > From: Rao, Lei > Sent: Wednesday, November 10, 2021 4:38 PM > To: Zhang, Chen ; > zhang.zhanghaili...@huawei.com; quint...@redhat.com; > dgilb...@redhat.com > Cc: qemu-devel@nongnu.org; Rao, Lei > Subject: [PATCH 2/2] migration/ram.c: Re

RE: [PATCH v2] Fixed a QEMU hang when guest poweroff in COLO mode

2021-11-10 Thread Zhang, Chen
> -Original Message- > From: Rao, Lei > Sent: Thursday, November 11, 2021 10:12 AM > To: Zhang, Chen ; > zhang.zhanghaili...@huawei.com; quint...@redhat.com; > dgilb...@redhat.com > Cc: qemu-devel@nongnu.org; Rao, Lei > Subject: [PATCH v2] Fixed a QEMU hang whe

RE: [PATCH] net/filter: Enable the vnet_hdr_support by default

2021-11-10 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Thursday, November 11, 2021 10:50 AM > To: Markus Armbruster > Cc: Zhang, Chen ; qemu-dev de...@nongnu.org>; Li Zhijian > Subject: Re: [PATCH] net/filter: Enable the vnet_hdr_support by default > > On W

[PATCH V2] net/filter: Enable the vnet_hdr_support by default

2021-11-10 Thread Zhang Chen
guarantees the compatibility for management layer like libvirt. But it still can't avoid user manual configuration error between different filters connected when enable/disable vnet_hdr_support. Signed-off-by: Zhang Chen --- net/colo-compare.c| 2 +- net/filter-mirror.c | 4 ++-- net/f

[PATCH for 7.0 V10 3/6] hmp-commands: Add new HMP command for filter passthrough

2021-11-11 Thread Zhang Chen
Add hmp_passthrough_filter_add and hmp_passthrough_filter_del make user can maintain object network passthrough list in human monitor Signed-off-by: Zhang Chen --- hmp-commands.hx | 26 ++ include/monitor/hmp.h | 2 ++ monitor/hmp-cmds.c| 63

[PATCH for 7.0 V10 0/6] Add passthrough support to object with network processing function

2021-11-11 Thread Zhang Chen
- Squash original 1-3 QAPI patches together. This series add passthrough support frame to object with network processing function. The first object is colo-compare. V3: Fix memory leak issue. V2: Optimize HMP code from Dave's

[PATCH for 7.0 V10 1/6] qapi/net: Add IPFlowSpec and QMP command for filter passthrough

2021-11-11 Thread Zhang Chen
,except object-name. Signed-off-by: Zhang Chen --- net/net.c | 10 +++ qapi/net.json | 73 +++ 2 files changed, 83 insertions(+) diff --git a/net/net.c b/net/net.c index f0d14dbfc1..5d0d5914fb 100644 --- a/net/net.c +++ b/net/net.c

[PATCH for 7.0 V10 6/6] net/net.c: Add handler for passthrough filter command

2021-11-11 Thread Zhang Chen
Use the connection protocol,src port,dst port,src ip,dst ip as the key to passthrough certain network traffic in object with network packet processing function. Signed-off-by: Zhang Chen --- net/net.c | 199 +- 1 file changed, 197 insertions

[PATCH for 7.0 V10 2/6] util/qemu-sockets.c: Add inet_parse_base to handle InetSocketAddressBase

2021-11-11 Thread Zhang Chen
No need to carry the flag all the time in many scenarios. Signed-off-by: Zhang Chen --- include/qemu/sockets.h | 1 + util/qemu-sockets.c| 14 ++ 2 files changed, 15 insertions(+) diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h index 0c34bf2398..3a0f8fa8f2 100644

[PATCH for 7.0 V10 4/6] net/colo-compare: Move data structure and define to .h file.

2021-11-11 Thread Zhang Chen
Rename structure with COLO index and move it to .h file, It make other modules can reuse COLO code. Signed-off-by: Zhang Chen --- net/colo-compare.c | 132 - net/colo-compare.h | 86 + 2 files changed, 109 insertions

[PATCH for 7.0 V10 5/6] net/colo-compare: Add passthrough list to CompareState

2021-11-11 Thread Zhang Chen
Add passthrough list for each CompareState. Signed-off-by: Zhang Chen --- net/colo-compare.c | 28 net/colo-compare.h | 12 2 files changed, 40 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index 9114b687de..df8bc5acce 100644 --- a

RE: [PATCH] net/filter: Enable the vnet_hdr_support by default

2021-11-11 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Wednesday, November 10, 2021 4:36 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Li Zhijian > Subject: Re: [PATCH] net/filter: Enable the vnet_hdr_support by default >

RE: [PATCH 1/2] migration/colo: Optimize COLO start code path

2021-11-16 Thread Zhang, Chen
> -Original Message- > From: Juan Quintela > Sent: Wednesday, November 17, 2021 12:28 AM > To: Zhang, Chen > Cc: Hailiang Zhang ; Dr . David Alan > Gilbert ; qemu-dev > Subject: Re: [PATCH 1/2] migration/colo: Optimize COLO start code path > > Zhang Chen

[PATCH V2] migration/colo: Optimize COLO primary node start code path

2021-11-17 Thread Zhang Chen
RATION_STATUS_ACTIVE". Signed-off-by: Zhang Chen --- migration/colo.c | 2 -- migration/migration.c | 13 +++-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/migration/colo.c b/migration/colo.c index 2415325262..ad1a4426b3 100644 --- a/migration/colo.c +++ b/migratio

[PATCH 1/2] net/colo-compare.c: Fix ACK track reverse issue

2021-11-17 Thread Zhang Chen
The TCP protocol ACK maybe bigger than uint32_t MAX. At this time, the ACK will reverse to 0. This patch fix the max_ack and min_ack track issue. Signed-off-by: Zhang Chen --- net/colo-compare.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/colo-compare.c b/net

[PATCH 2/2] net/colo-compare.c: Fix incorrect return when input wrong size

2021-11-17 Thread Zhang Chen
Signed-off-by: Zhang Chen --- net/colo-compare.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 1225f40e41..b966e7e514 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -807,7 +807,7 @@ static int compare_chr_send

RE: [PATCH] docs/COLO-FT.txt: Drop deprecated 'props' from object-add in COLO docs

2021-11-17 Thread Zhang, Chen
> -Original Message- > From: Rao, Lei > Sent: Thursday, November 18, 2021 12:17 PM > To: Zhang, Chen ; > zhang.zhanghaili...@huawei.com; quint...@redhat.com; > dgilb...@redhat.com > Cc: qemu-triv...@nongnu.org; qemu-devel@nongnu.org; Rao, Lei > > Subjec

RE: [PATCH] docs/block-replication.txt: Fix replication top-id command demo

2021-11-17 Thread Zhang, Chen
Ping... and add more people. The original demo can't boot block-replication with COLO. Thanks Chen > -Original Message- > From: Zhang, Chen > Sent: Monday, October 18, 2021 4:51 PM > To: Xie Changlong ; Wen Congyang > ; qemu-triv...@nongnu.org > Cc: Zha

RE: [PATCH] net/filter: Enable the vnet_hdr_support by default

2021-11-18 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, November 19, 2021 11:37 AM > To: Zhang, Chen > Cc: qemu-dev ; Markus Armbruster > ; Li Zhijian > Subject: Re: [PATCH] net/filter: Enable the vnet_hdr_support by default > > On Fri, Nov 19, 2021 at 1

[PATCH V3 1/2] net/filter: Enable the vnet_hdr_support by default

2021-11-18 Thread Zhang Chen
guarantees the compatibility for management layer like libvirt. But it still can't avoid user manual configuration error between different filters connected when enable/disable vnet_hdr_support. Signed-off-by: Zhang Chen --- net/colo-compare.c| 2 +- net/filter-mirror.c | 4 ++-- net/f

[PATCH V3 2/2] test/qtest/test-filter-mirror.c: Change the default vnet_hdr_support

2021-11-18 Thread Zhang Chen
As net filters changed default vnet_hdr_support=on. For this e1000 test case need to add vnet_hdr_support=off. Signed-off-by: Zhang Chen --- tests/qtest/test-filter-mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/test-filter-mirror.c b/tests/qtest/test

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-22 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Monday, June 20, 2022 6:37 PM > To: Zhang, Chen > Cc: Thomas Huth ; Jason Wang > ; qemu-dev ; Paolo > Bonzini ; Eduardo Habkost ; > Eric Blake ; Markus Armbruster > ; Peter Maydell ; Laurent > Vivier

<    1   2   3   4   5   6   7   8   9   10   >