Re: [Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries

2016-02-22 Thread Yi Min Zhao
于 Mon, 22 Feb 2016 14:15:07 +0100 Christian Borntraeger 写道: > On 02/19/2016 04:18 PM, Wei Yang wrote: > > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > > the more proper on retrieving MSIX entries. > > > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries.

[Qemu-devel] [PATCH v5 1/1] s390x: pci infrastructure modeling

2015-08-20 Thread Yi Min Zhao
From: Yi Min Zhao This patch introduce a new facility(and bus) to hold devices representing information actually provided by s390 firmware and I/O configuration. usage example: -device s390-pcihost,index=1 -device zpci,fid=2,uid=5,pci_id=vpci1,id=zpci1 -device vfio-pci,host=:00:00.0,id=vpci1

[Qemu-devel] [PATCH v5 0/1] s390 pci infrastructure modeling

2015-08-20 Thread Yi Min Zhao
From: Yi Min Zhao This patch extends the current s390 pci implementation to provide more flexibility in configuration of s390 specific device handling. For each vfio pci device, I create a zpci device to store s390 specific informations. And attach all of these special zpci devices to the s390

[Qemu-devel] [PATCH v4 0/1] s390 pci infrastruture modelling

2015-07-08 Thread Yi Min Zhao
From: Yi Min Zhao This patch extends the current s390 pci implementation to provide more flexibility in configuration of s390 specific device handling. For each vfio pci device, I create a zpci device to store s390 specific informations. And attach all of these special zpci devices to the s390

[Qemu-devel] [PATCH v4 1/1] s390 pci infrastructure modelling

2015-07-08 Thread Yi Min Zhao
From: Yi Min Zhao This patch introduce a new facility(and bus) to hold devices representing information actually provided by s390 firmware and I/O configuration. usage example: -device s390-pcihost -device zpci,fid=2,uid=5,pci_id=vpci1,id=zpci1 -device vfio-pci,host=:00:00.0,id=vpci1 The

Re: [Qemu-devel] [PATCH 0/4] four zpci patches

2017-08-23 Thread Yi Min Zhao
Why can't I receive [Qemu-devel] prefixed patches? 在 2017/8/23 下午3:26, Yi Min Zhao 写道: This patch set contains four small zpci patches to fixup different issues. 1) fixup calculation of msix boundary 2) remove zpci idx from msix message, instead we could use PCIDevice's id to

Re: [Qemu-devel] [PATCH 0/4] four zpci patches

2017-08-24 Thread Yi Min Zhao
在 2017/8/24 下午3:13, Cornelia Huck 写道: On Thu, 24 Aug 2017 13:20:12 +0800 Yi Min Zhao wrote: Why can't I receive [Qemu-devel] prefixed patches? 在 2017/8/23 下午3:26, Yi Min Zhao 写道: This patch set contains four small zpci patches to fixup different issues. 1) fixup calculation of

Re: [Qemu-devel] [PATCH 0/4] four zpci patches

2017-08-27 Thread Yi Min Zhao
在 2017/8/25 上午12:27, Eric Blake 写道: On 08/24/2017 03:48 AM, Yi Min Zhao wrote: 在 2017/8/24 下午3:13, Cornelia Huck 写道: On Thu, 24 Aug 2017 13:20:12 +0800 Yi Min Zhao wrote: Why can't I receive [Qemu-devel] prefixed patches? I sent patches to qemu-devel@nongnu.org and cc you also m

[Qemu-devel] [PATCH 2/4] s390x/pci: remove idx from msix msg data

2017-08-28 Thread Yi Min Zhao
PCIDevcie pointer has been a parameter of kvm_arch_fixup_msi_route(). So we don't need to store zpci idx in msix message data to find out the specific zpci device. Instead, we could use pci device id to find its corresponding zpci device. Signed-off-by: Yi Min Zhao --- hw/s390x/s390-pci-

[Qemu-devel] [PATCH 0/4] four zpci patches

2017-08-28 Thread Yi Min Zhao
rrupt routing entry 4) introduce our own iommu_replay callback Yi Min Zhao (4): s390x/pci: fixup trap_msix() s390x/pci: remove idx from msix msg data s390x/pci: fixup ind_offset of msix routing entry s390x/pci: add iommu replay callback hw/s390x/s390-pci-bus.c | 24 +--

[Qemu-devel] [PATCH 3/4] s390x/pci: fixup ind_offset of msix routing entry

2017-08-28 Thread Yi Min Zhao
ff-by: Yi Min Zhao --- target/s390x/kvm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index e348bfb7cc..c08b7757e7 100644 --- a/target/s390x/kvm.c +++ b/target/s390x/kvm.c @@ -2515,14 +2515,12 @@ int kvm_arch_fixup_msi_route(s

[Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-28 Thread Yi Min Zhao
ed-by: Pierre Morel Signed-off-by: Yi Min Zhao --- hw/s390x/s390-pci-inst.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c index b7beb8c36a..eba9ffb5f2 100644 --- a/hw/s390x/s390-pci-inst.c +++ b/hw/s390x/s390-pci-i

[Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-28 Thread Yi Min Zhao
off-by: Yi Min Zhao --- hw/s390x/s390-pci-bus.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 9e1f7ff5c5..359509ccea 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -407,6 +407,13 @@ static IOM

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-28 Thread Yi Min Zhao
在 2017/8/28 下午10:51, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote: The function trap_msix() is to check if pcistg instruction would access msix table entries. The correct boundary condition should be [table_offset, table_offset+entries*entry_size). But the current

Re: [Qemu-devel] [PATCH 2/4] s390x/pci: remove idx from msix msg data

2017-08-28 Thread Yi Min Zhao
在 2017/8/28 下午11:04, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:45 +0200 Yi Min Zhao wrote: PCIDevcie pointer has been a parameter of kvm_arch_fixup_msi_route(). s/PCIDevcie/PCIDevice Thanks! So we don't need to store zpci idx in msix message data to find out the specific zpci d

Re: [Qemu-devel] [PATCH 3/4] s390x/pci: fixup ind_offset of msix routing entry

2017-08-28 Thread Yi Min Zhao
在 2017/8/28 下午11:33, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:46 +0200 Yi Min Zhao wrote: The aibvo of zpci device should be constant after issued mpcifc registering irqs instruction. Each msix vector should offset from the aibvo. But for flic adapter interrupt, we should use the

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-28 Thread Yi Min Zhao
在 2017/8/28 下午11:57, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:47 +0200 Yi Min Zhao wrote: Let's introduce iommu replay callback for s390 pci iommu memory region. Currently we don't need any dma mapping replay. So let it return directly. This implementation will avoid meaning

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午4:00, Cornelia Huck 写道: On Tue, 29 Aug 2017 12:32:17 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午10:51, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote: The function trap_msix() is to check if pcistg instruction would access msix table entries. The

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午4:00, Cornelia Huck 写道: On Tue, 29 Aug 2017 12:32:17 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午10:51, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote: The function trap_msix() is to check if pcistg instruction would access msix table entries. The

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午4:07, Cornelia Huck 写道: [Restored cc:s. Please remember to do reply-all.] On Tue, 29 Aug 2017 12:46:51 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午11:57, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:47 +0200 Yi Min Zhao wrote: Let's introduce iommu replay callback for s39

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午4:22, Cornelia Huck 写道: On Tue, 29 Aug 2017 16:12:26 +0800 Yi Min Zhao wrote: 在 2017/8/29 下午4:00, Cornelia Huck 写道: On Tue, 29 Aug 2017 12:32:17 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午10:51, Cornelia Huck 写道: On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午5:33, Cornelia Huck 写道: On Tue, 29 Aug 2017 16:26:10 +0800 Yi Min Zhao wrote: 在 2017/8/29 下午4:07, Cornelia Huck 写道: [Restored cc:s. Please remember to do reply-all.] On Tue, 29 Aug 2017 12:46:51 +0800 Yi Min Zhao wrote: 在 2017/8/28 下午11:57, Cornelia Huck 写道: On Mon, 28

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午5:49, Cornelia Huck 写道: On Tue, 29 Aug 2017 11:33:53 +0200 Cornelia Huck wrote: My question was whether virtio-pci works with your patches on top at all - last time I checked on master, virtio-pci devices failed to realize with a "msi-x is mandatory" message. Just checked agai

Re: [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-29 Thread Yi Min Zhao
在 2017/8/29 下午5:57, Cornelia Huck 写道: On Tue, 29 Aug 2017 17:51:43 +0800 Yi Min Zhao wrote: 在 2017/8/29 下午5:33, Cornelia Huck 写道: My question was whether virtio-pci works with your patches on top at all - last time I checked on master, virtio-pci devices failed to realize with a "msi

Re: [Qemu-devel] [PATCH RFC v2 8/9] s390x/kvm: msi route fixup for non-pci

2017-07-18 Thread Yi Min Zhao
I think moving the new code on the top of this function would make it more readable. 在 2017/7/18 下午10:24, Cornelia Huck 写道: +} else { +DPRINTF("fixup_msi_route on non-pci machine?!\n"); +return -ENODEV; +}

Re: [Qemu-devel] [PATCH RFC v2 8/9] s390x/kvm: msi route fixup for non-pci

2017-07-18 Thread Yi Min Zhao
在 2017/7/18 下午11:22, Cornelia Huck 写道: On Tue, 18 Jul 2017 11:58:08 -0300 Philippe Mathieu-Daudé wrote: Hi Cornelia, On Tue, Jul 18, 2017 at 11:24 AM, Cornelia Huck wrote: If we don't provide pci, we cannot have a pci device for which we have to translate to adapter routes: just return -E

Re: [Qemu-devel] [PATCH RFC v2 7/9] s390x/pci: fence off instructions for non-pci

2017-07-18 Thread Yi Min Zhao
在 2017/7/18 下午10:24, Cornelia Huck 写道: If a guest running on a machine without zpci issues a pci instruction, throw them an exception. Signed-off-by: Cornelia Huck --- target/s390x/kvm.c | 54 +- 1 file changed, 41 insertions(+), 13 delet

Re: [Qemu-devel] [PATCH RFC v2 4/9] s390x/pci: do not advertise pci on non-pci builds

2017-07-19 Thread Yi Min Zhao
在 2017/7/19 下午4:00, Cornelia Huck 写道: On Tue, 18 Jul 2017 21:56:26 +0200 Christian Borntraeger wrote: On 07/18/2017 04:24 PM, Cornelia Huck wrote: Only set the zpci and aen feature bits on builds that actually support pci. Signed-off-by: Cornelia Huck --- target/s390x/kvm.c | 2 ++ 1 f

Re: [Qemu-devel] [PATCH RFC v2 4/9] s390x/pci: do not advertise pci on non-pci builds

2017-07-19 Thread Yi Min Zhao
在 2017/7/19 下午5:24, Cornelia Huck 写道: On Wed, 19 Jul 2017 16:56:18 +0800 Yi Min Zhao wrote: 在 2017/7/19 下午4:00, Cornelia Huck 写道: On Tue, 18 Jul 2017 21:56:26 +0200 Christian Borntraeger wrote: On 07/18/2017 04:24 PM, Cornelia Huck wrote: Only set the zpci and aen feature bits on

Re: [Qemu-devel] [PATCH RFC v2 4/9] s390x/pci: do not advertise pci on non-pci builds

2017-07-19 Thread Yi Min Zhao
在 2017/7/19 下午5:27, Yi Min Zhao 写道: 在 2017/7/19 下午5:24, Cornelia Huck 写道: On Wed, 19 Jul 2017 16:56:18 +0800 Yi Min Zhao wrote: 在 2017/7/19 下午4:00, Cornelia Huck 写道: On Tue, 18 Jul 2017 21:56:26 +0200 Christian Borntraeger wrote: On 07/18/2017 04:24 PM, Cornelia Huck wrote: Only set

Re: [Qemu-devel] [PATCH v3 4/9] s390x/pci: do not advertise pci on non-pci builds

2017-07-26 Thread Yi Min Zhao
Good. This patch resolves the problem I mentioned in previous verion. Thanks for your work. 在 2017/7/25 下午11:33, Cornelia Huck 写道: Only set the zpci feature bit on builds that actually support pci. Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.c | 5 + hw/s390x/s390-pci-bus.

[Qemu-devel] [PATCH 2/3] s390x/pci: fixup global refresh

2018-01-30 Thread Yi Min Zhao
rs in rpcit handler. Acked-by: Pierre Morel Signed-off-by: Yi Min Zhao --- hw/s390x/s390-pci-bus.c | 28 +- hw/s390x/s390-pci-bus.h | 3 ++ hw/s390x/s390-pci-inst.c | 95 ++-- 3 files changed, 90 insertions(+), 36 deletions(-) diff --git

[Qemu-devel] [PATCH 3/3] s390x/pci: use the right pal and pba in reg_ioat()

2018-01-30 Thread Yi Min Zhao
When registering ioat, pba should be comprised of leftmost 52 bits and rightmost 12 binary zeros, and pal should be comprised of leftmost 52 bits and right most 12 binary ones. Let's fixup this. Reviewed-by: Pierre Morel Signed-off-by: Yi Min Zhao --- hw/s390x/s390-pci-inst.c | 2 ++ 1

[Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

2018-01-30 Thread Yi Min Zhao
me, inform the guest with the corresponding error number when the check fails. Reviewed-by: Pierre Morel Signed-off-by: Yi Min Zhao --- hw/s390x/s390-pci-bus.c | 223 ++- hw/s390x/s390-pci-bus.h | 10 +++ hw/s390x/s390-pci-inst.c | 10 --- 3 files ch

[Qemu-devel] [PATCH 0/3] s390x/pci: fixup and optimize IOTLB code

2018-01-30 Thread Yi Min Zhao
are indexed by IOVA. Each PCI device has its own IOMMU. Therefore each IOMMU also has its own hashtable caching corresponding PCI device's DMA entries. Finally, we split 1M contiguous DMA range into 4K pages to do DMA map, and the code about error notification is also optimized. Yi Min Zhao (3

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

2018-01-31 Thread Yi Min Zhao
在 2018/1/31 下午3:42, Thomas Huth 写道: On 30.01.2018 10:47, Yi Min Zhao wrote: Current s390x PCI IOMMU code is lack of flags' checking, including: 1) protection bit 2) table length 3) table offset 4) intermediate tables' invalid bit 5) format control bit This patch introduces a new st

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

2018-02-01 Thread Yi Min Zhao
在 2018/1/31 下午6:58, Cornelia Huck 写道: On Tue, 30 Jan 2018 10:47:13 +0100 Yi Min Zhao wrote: Current s390x PCI IOMMU code is lack of flags' checking, including: 1) protection bit 2) table length 3) table offset 4) intermediate tables' invalid bit 5) format control bit This patch

Re: [Qemu-devel] [PATCH 3/3] s390x/pci: use the right pal and pba in reg_ioat()

2018-02-01 Thread Yi Min Zhao
在 2018/2/1 下午8:02, Cornelia Huck 写道: On Thu, 1 Feb 2018 12:33:01 +0100 Pierre Morel wrote: On 31/01/2018 12:44, Cornelia Huck wrote: On Tue, 30 Jan 2018 10:47:15 +0100 Yi Min Zhao wrote: When registering ioat, pba should be comprised of leftmost 52 bits and rightmost 12 binary zeros

Re: [Qemu-devel] [PATCH v1] pci: Set PCI-bus device entry before initializing bus master

2017-10-09 Thread Yi Min Zhao
I strongly agree. This will make IOMMU assignment easier. 在 2017/10/5 下午8:36, Pierre Morel 写道: When initializing the PCI-bus master pci_init_bus_master(PCIDevice *) calls pci_device_iommu_address_space(PCIDevice *) which in turn calls iommu_bus->iommu_fn(bus, opaque,devfn) If the device entry

Re: [Qemu-devel] [PATCH v2 4/7] s390x/pci: rework PCI STORE BLOCK

2017-11-21 Thread Yi Min Zhao
entry to both the Query PCI Function Group response and the PCIBusDevice structure. Initialize the maxstbl to 128 per default until we get the actual data from the hardware. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao ---   hw/s390x/s390-pci-bus.h  |  1 +   hw/s390x/s390-pci-inst.c | 62

Re: [Qemu-devel] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-23 Thread Yi Min Zhao
在 2017/11/23 下午6:33, Cornelia Huck 写道: On Thu, 23 Nov 2017 11:25:10 +0100 Thomas Huth wrote: On 23.11.2017 11:08, Cornelia Huck wrote: On Thu, 23 Nov 2017 11:01:23 +0100 Thomas Huth wrote: On 23.11.2017 10:49, Cornelia Huck wrote: On Thu, 23 Nov 2017 09:48:41 +0100 Thomas Huth wrote

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-23 Thread Yi Min Zhao
在 2017/11/23 下午8:18, Thomas Huth 写道: On 23.11.2017 13:07, Yi Min Zhao wrote: 在 2017/11/23 下午6:33, Cornelia Huck 写道: On Thu, 23 Nov 2017 11:25:10 +0100 Thomas Huth wrote: On 23.11.2017 11:08, Cornelia Huck wrote: On Thu, 23 Nov 2017 11:01:23 +0100 Thomas Huth wrote: On 23.11.2017

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-26 Thread Yi Min Zhao
在 2017/11/25 下午9:49, Pierre Morel 写道: On 24/11/2017 07:19, Yi Min Zhao wrote: 在 2017/11/23 下午8:18, Thomas Huth 写道: On 23.11.2017 13:07, Yi Min Zhao wrote: 在 2017/11/23 下午6:33, Cornelia Huck 写道: On Thu, 23 Nov 2017 11:25:10 +0100 Thomas Huth wrote: On 23.11.2017 11:08, Cornelia Huck

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Yi Min Zhao
在 2017/11/27 下午2:59, Thomas Huth 写道: On 25.11.2017 14:49, Pierre Morel wrote: On 24/11/2017 07:19, Yi Min Zhao wrote: 在 2017/11/23 下午8:18, Thomas Huth 写道: On 23.11.2017 13:07, Yi Min Zhao wrote: 在 2017/11/23 下午6:33, Cornelia Huck 写道: On Thu, 23 Nov 2017 11:25:10 +0100 Thomas Huth wrote

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Yi Min Zhao
在 2017/11/27 下午7:13, Thomas Huth 写道: On 27.11.2017 11:09, Yi Min Zhao wrote: 在 2017/11/27 下午2:59, Thomas Huth 写道: On 25.11.2017 14:49, Pierre Morel wrote: On 24/11/2017 07:19, Yi Min Zhao wrote: 在 2017/11/23 下午8:18, Thomas Huth 写道: On 23.11.2017 13:07, Yi Min Zhao wrote: 在 2017/11/23 下午

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-27 Thread Yi Min Zhao
wrote: On Mon, 27 Nov 2017 07:59:36 +0100 Thomas Huth wrote: On 25.11.2017 14:49, Pierre Morel wrote: On 24/11/2017 07:19, Yi Min Zhao wrote: 在 2017/11/23 下午8:18, Thomas Huth 写道: On 23.11.2017 13:07, Yi Min Zhao wrote: Another question, does 'cpu' in cpu_to_le

Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/pci: add common fmb

2018-10-16 Thread Yi Min Zhao
在 2018/10/1 下午5:22, Thomas Huth 写道: On 2018-09-29 07:48, Yi Min Zhao wrote: 在 2018/9/19 下午3:53, Thomas Huth 写道: On 2018-09-19 09:08, Yi Min Zhao wrote: [...] diff --git a/hw/s390x/s390-pci-bus.h b/hw/s390x/s390-pci-bus.h index 1f7f9b5814..fdf13a19c0 100644 --- a/hw/s390x/s390-pci-bus.h

[Qemu-devel] [PATCH v2] s390x/pci: add common fmb

2018-10-22 Thread Yi Min Zhao
update fmb failed, an event error would be generated. After pcilg/stg/stb and rpcit interception handlers issue successfully, increase the related counter. The guest could pass null address to switch off FMB and stop corresponding timer. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel

Re: [Qemu-devel] [PATCH v2] s390x/pci: add common fmb

2018-10-23 Thread Yi Min Zhao
在 2018/10/22 下午8:17, Thomas Huth 写道: On 2018-10-22 10:02, Yi Min Zhao wrote: Common function measurement block is used to report counters of successfully issued pcilg/stg/stb and rpcit instructions. This patch introduces a new struct ZpciFmb and schedules a timer callback to copy fmb to the

Re: [Qemu-devel] [PATCH v2] s390x/pci: add common fmb

2018-10-23 Thread Yi Min Zhao
在 2018/10/24 上午5:25, Cornelia Huck 写道: On Mon, 22 Oct 2018 13:17:34 +0100 Thomas Huth wrote: On 2018-10-22 10:02, Yi Min Zhao wrote: Common function measurement block is used to report counters of successfully issued pcilg/stg/stb and rpcit instructions. This patch introduces a new struct

Re: [Qemu-devel] [PATCH] s390x/pci: add common fmb

2018-09-19 Thread Yi Min Zhao
No comment? 在 2018/9/4 下午5:15, Yi Min Zhao 写道: Common function measurement block is used to report counters of successfully issued pcilg/stg/stb and rpcit instructions. This patch introduces a new struct ZpciFmb and schedules a timer callback to copy fmb to the guest memory at a interval time

Re: [Qemu-devel] [PATCH] s390x/pci: add common fmb

2018-09-25 Thread Yi Min Zhao
在 2018/9/20 下午6:06, Cornelia Huck 写道: On Tue, 4 Sep 2018 17:15:49 +0800 Yi Min Zhao wrote: Common function measurement block is used to report counters of successfully issued pcilg/stg/stb and rpcit instructions. This patch introduces a new struct ZpciFmb and schedules a timer callback to

Re: [Qemu-devel] [PATCH] s390x/pci: add common fmb

2018-09-28 Thread Yi Min Zhao
在 2018/9/19 下午3:53, Thomas Huth 写道: On 2018-09-19 09:08, Yi Min Zhao wrote: No comment? Since the zPCI spec is not available to the public, it's quite hard to give any valuable comments here... I'll try anyway... 在 2018/9/4 下午5:15, Yi Min Zhao 写道: Common function measuremen

[Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-15 Thread Yi Min Zhao
If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger the guest startup fails. So this patch excludes the code regarding seccomp staff if CONFIG_SECCOMP is undefined. Signed-off-by: Y

[Qemu-devel] [PATCH v2 0/1] Bug: Sandbox: libvirt breakdowns qemu guest

2018-05-15 Thread Yi Min Zhao
to sandbox only when CONFIG_SECCOMP is defined. Yi Min Zhao (1): sandbox: disable -sandbox if CONFIG_SECCOMP undefined vl.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) -- Yi Min

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-15 Thread Yi Min Zhao
在 2018/5/15 下午11:25, Eric Blake 写道: On 05/15/2018 06:33 AM, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger the guest startup fails. So this patch exclude

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-17 Thread Yi Min Zhao
Add Paolo to CC list. @Paolo, expect your comment. Thanks very much! 在 2018/5/15 下午11:25, Eric Blake 写道: On 05/15/2018 06:33 AM, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capa

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-17 Thread Yi Min Zhao
在 2018/5/17 下午8:41, Eduardo Otubo 写道: On 15/05/2018 - 19:33:48, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger the guest startup fails. So this patch ex

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-19 Thread Yi Min Zhao
在 2018/5/18 下午9:07, Ján Tomko 写道: On Fri, May 18, 2018 at 11:19:16AM +0200, Eduardo Otubo wrote: On 18/05/2018 - 09:52:12, Ján Tomko wrote: On Thu, May 17, 2018 at 02:41:09PM +0200, Eduardo Otubo wrote: > On 15/05/2018 - 19:33:48, Yi Min Zhao wrote: > > If CONFIG_SECCOMP is undef

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-23 Thread Yi Min Zhao
在 2018/5/23 下午3:47, Ján Tomko 写道: On Sat, May 19, 2018 at 04:20:37PM +0800, Yi Min Zhao wrote: 在 2018/5/18 下午9:07, Ján Tomko 写道: On Fri, May 18, 2018 at 11:19:16AM +0200, Eduardo Otubo wrote: On 18/05/2018 - 09:52:12, Ján Tomko wrote: But now libvirt requires QEMU >= 1.5.0 which alre

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-23 Thread Yi Min Zhao
在 2018/5/23 下午6:33, Eduardo Otubo 写道: On 05/23/2018 11:16 AM, Yi Min Zhao wrote: 在 2018/5/23 下午3:47, Ján Tomko 写道: On Sat, May 19, 2018 at 04:20:37PM +0800, Yi Min Zhao wrote: 在 2018/5/18 下午9:07, Ján Tomko 写道: On Fri, May 18, 2018 at 11:19:16AM +0200, Eduardo Otubo wrote: On 18/05

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-24 Thread Yi Min Zhao
在 2018/5/24 下午9:40, Paolo Bonzini 写道: On 24/05/2018 09:53, Eduardo Otubo wrote: Thanks! But I have not got response from Paolo.  I have added him to CC list.  I'll just wait one more ACK and will send a pull request on the seccomp queue. Thanks for the contribution. So... what I should d

[Qemu-devel] [PATCH] s390x/pci: add common fmb

2018-09-04 Thread Yi Min Zhao
update fmb failed, an event error would be generated. After pcilg/stg/stb and rpcit interception handlers issue successfully, increase the related counter. The guest could pass null address to switch off FMB and stop corresponding timer. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel --- hw

[Qemu-devel] [RFC PATCH 1/1] s390x/pci: add common fmb

2018-04-27 Thread Yi Min Zhao
to update fmb failed, an event error would be generated. After pcilg/stg/stb and rpcit interception handlers issue successfully, increase the related counter. Signed-off-by: Yi Min Zhao --- hw/s390x/s390-pci-bus.c | 3 ++- hw/s390x/s390-pci-bus.h | 16 + hw/s390x/s390-pci-inst.c

[Qemu-devel] [RFC PATCH 0/1] s390x/pci: add common fmb

2018-04-27 Thread Yi Min Zhao
Currently the code misses FMB functionality. This patch fixup this. Only common FMB is supported now. bb/zyimin/fmb Yi Min Zhao (1): s390x/pci: add common fmb hw/s390x/s390-pci-bus.c | 3 ++- hw/s390x/s390-pci-bus.h | 16 + hw/s390x/s390-pci-inst.c | 60

Re: [Qemu-devel] [RFC PATCH 0/1] s390x/pci: add common fmb

2018-04-27 Thread Yi Min Zhao
Wrong operation. Please ignore this series. 在 2018/4/27 下午6:02, Yi Min Zhao 写道: Currently the code misses FMB functionality. This patch fixup this. Only common FMB is supported now. bb/zyimin/fmb Yi Min Zhao (1): s390x/pci: add common fmb hw/s390x/s390-pci-bus.c | 3 ++- hw/s390x

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-28 Thread Yi Min Zhao
在 2018/5/25 下午5:36, Eduardo Otubo 写道: On 05/25/2018 06:23 AM, Yi Min Zhao wrote: 在 2018/5/24 下午9:40, Paolo Bonzini 写道: On 24/05/2018 09:53, Eduardo Otubo wrote: Thanks! But I have not got response from Paolo.  I have added him to CC list.   I'll just wait one more ACK and will s

[Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
and wraps qemu_opts_foreach finding sandbox option with CONFIG_SECCOMP. Because parse_sandbox() is moved into qemu-seccomp.c file, change seccomp_start() to static function. Signed-off-by: Yi Min Zhao --- 1. Problem Description == If QEMU is built without seccomp support, 'elevatepriv

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午4:40, Ján Tomko 写道: On Tue, May 29, 2018 at 03:31:40PM +0800, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup.

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午5:37, Paolo Bonzini 写道: On 29/05/2018 09:31, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch move

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午5:39, Eduardo Otubo 写道: On 29/05/2018 - 15:31:40, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午5:37, Paolo Bonzini 写道: On 29/05/2018 09:31, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch move

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-30 Thread Yi Min Zhao
在 2018/5/30 下午6:54, Eduardo Otubo 写道: On 29/05/2018 - 18:05:25, Yi Min Zhao wrote: 在 2018/5/29 下午5:37, Paolo Bonzini 写道: On 29/05/2018 09:31, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the cor

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-30 Thread Yi Min Zhao
在 2018/5/30 下午6:54, Eduardo Otubo 写道: Can you send a v4 with a cleaned up version? Also fixing a typo on the text (elevateDprivileges). Why elevateDprivileges? The option name in the code is 'elevateprivileges'.

[Qemu-devel] [PATCH v4] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-30 Thread Yi Min Zhao
and wraps qemu_opts_foreach finding sandbox option with CONFIG_SECCOMP. Because parse_sandbox() is moved into qemu-seccomp.c file, change seccomp_start() to static function. Signed-off-by: Yi Min Zhao Reviewed-by: Ján Tomko Tested-by: Ján Tomko Acked-by: Eduardo Otubo --- include/sysemu/seccomp.h |

Re: [Qemu-devel] block ais migration for machines <= 2.9

2017-09-20 Thread Yi Min Zhao
在 2017/9/21 上午12:04, Dr. David Alan Gilbert 写道: * Christian Borntraeger (borntrae...@de.ibm.com) wrote: Something like the following seems to do the tricks. Needs proper patch description, review, full test with different kernel versions. Without knowing anything about 'ais' - will this

Re: [Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-26 Thread Yi Min Zhao
在 2017/9/25 下午7:47, Christian Borntraeger 写道: On 09/25/2017 01:45 PM, Cornelia Huck wrote: On Mon, 25 Sep 2017 12:12:49 +0200 Christian Borntraeger wrote: On 09/25/2017 12:07 PM, Cornelia Huck wrote: On Fri, 22 Sep 2017 16:27:00 +0200 Halil Pasic wrote: One thing I would find very he

Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when migration is available

2017-09-26 Thread Yi Min Zhao
在 2017/9/26 下午10:06, Christian Borntraeger 写道: On 09/26/2017 03:43 PM, David Hildenbrand wrote: +/* try enable the AIS facility */ +test_attr.group = KVM_DEV_FLIC_AISM_ALL; +if (!ioctl(flic_state->fd, KVM_HAS_DEVICE_ATTR, test_attr)) { +kvm_vm_enable_cap(kvm_state, KVM

Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when migration is available

2017-09-26 Thread Yi Min Zhao
在 2017/9/26 下午9:36, Christian Borntraeger 写道: @@ -557,6 +557,12 @@ static void kvm_s390_flic_realize(DeviceState *dev, Error **errp) test_attr.group = KVM_DEV_FLIC_CLEAR_IO_IRQ; flic_state->clear_io_supported = !ioctl(flic_state->fd, KV

Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for <=2.10

2017-09-27 Thread Yi Min Zhao
在 2017/9/27 下午5:47, Cornelia Huck 写道: On Tue, 26 Sep 2017 20:40:25 +0200 David Hildenbrand wrote: On 26.09.2017 18:20, Cornelia Huck wrote: d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made creating the s390 phb dependant on the zpci facility. This broke migration from pre-cpu mo

[Qemu-devel] [PATCH v2 0/3] three zpci patches

2017-08-31 Thread Yi Min Zhao
r own iommu_replay callback Yi Min Zhao (3): s390x/pci: remove idx from msix msg data s390x/pci: fixup ind_offset of msix routing entry s390x/pci: add iommu replay callback hw/s390x/s390-pci-bus.c | 27 --- hw/s390x/s390-pci-bus.h | 2 ++ hw/s390x/s390-pci-inst.c

[Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-08-31 Thread Yi Min Zhao
PCIDevice pointer has been a parameter of kvm_arch_fixup_msi_route(). So we don't need to store zpci idx in msix message data to find out the specific zpci device. Instead, we could use pci device id to find its corresponding zpci device. Signed-off-by: Yi Min Zhao --- hw/s390x/s390-pci-

[Qemu-devel] [PATCH v2 2/3] s390x/pci: fixup ind_offset of msix routing entry

2017-08-31 Thread Yi Min Zhao
offset, but instead add the vector to the starting offset to get the absolute offset in the specific route. Signed-off-by: Yi Min Zhao --- target/s390x/kvm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index 3d490c5e4b..21ce06966c

[Qemu-devel] [PATCH v2 3/3] s390x/pci: add iommu replay callback

2017-08-31 Thread Yi Min Zhao
off-by: Yi Min Zhao --- hw/s390x/s390-pci-bus.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index bd8a3e1e1c..69f45e3715 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -397,6 +397,16 @@ static IOM

Re: [Qemu-devel] [PATCHv3 1/2] pci: move check for existing devfn into new pci_bus_devfn_available() helper

2017-09-04 Thread Yi Min Zhao
在 2017/7/17 上午4:27, Mark Cave-Ayland 写道: Also touch up the logic in do_pci_register_device() accordingly. Signed-off-by: Mark Cave-Ayland --- hw/pci/pci.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 0c6f74a..efc9c86 100

Re: [Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-09-05 Thread Yi Min Zhao
在 2017/9/5 下午4:29, Cornelia Huck 写道: On Fri, 1 Sep 2017 06:22:56 +0200 Yi Min Zhao wrote: PCIDevice pointer has been a parameter of kvm_arch_fixup_msi_route(). So we don't need to store zpci idx in msix message data to find out the specific zpci device. Instead, we could use pci devi

Re: [Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-09-05 Thread Yi Min Zhao
在 2017/9/5 下午4:50, Cornelia Huck 写道: On Tue, 5 Sep 2017 16:44:37 +0800 Yi Min Zhao wrote: 在 2017/9/5 下午4:29, Cornelia Huck 写道: On Fri, 1 Sep 2017 06:22:56 +0200 Yi Min Zhao wrote: PCIDevice pointer has been a parameter of kvm_arch_fixup_msi_route(). So we don't need to store zpc

Re: [Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-09-05 Thread Yi Min Zhao
在 2017/9/5 下午5:15, Cornelia Huck 写道: On Tue, 5 Sep 2017 17:08:14 +0800 Yi Min Zhao wrote: 在 2017/9/5 下午4:50, Cornelia Huck 写道: On Tue, 5 Sep 2017 16:44:37 +0800 Yi Min Zhao wrote: 在 2017/9/5 下午4:29, Cornelia Huck 写道: On Fri, 1 Sep 2017 06:22:56 +0200 Yi Min Zhao wrote

Re: [Qemu-devel] [PATCH v2 3/3] s390x/pci: add iommu replay callback

2017-09-05 Thread Yi Min Zhao
在 2017/9/5 下午5:28, Cornelia Huck 写道: On Fri, 1 Sep 2017 06:22:58 +0200 Yi Min Zhao wrote: Let's introduce iommu replay callback for s390 pci iommu memory region. Currently we don't need any dma mapping replay. So let it return directly. This implementation will avoid meaning

[Qemu-devel] [PATCH v3 0/3] three zpci patches

2017-09-05 Thread Yi Min Zhao
r own iommu_replay callback Yi Min Zhao (3): s390x/pci: remove idx from msix msg data s390x/pci: fixup ind_offset of msix routing entry s390x/pci: add iommu replay callback hw/s390x/s390-pci-bus.c | 28 +--- hw/s390x/s390-pci-bus.h | 2 ++ hw/s390x/s390-pci-inst.c

[Qemu-devel] [PATCH v3 3/3] s390x/pci: add iommu replay callback

2017-09-05 Thread Yi Min Zhao
off-by: Yi Min Zhao --- hw/s390x/s390-pci-bus.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index bd8a3e1e1c..3b9965fde0 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -397,6 +397,17 @@ static IOM

[Qemu-devel] [PATCH v3 1/3] s390x/pci: remove idx from msix msg data

2017-09-05 Thread Yi Min Zhao
PCIDevice pointer has been a parameter of kvm_arch_fixup_msi_route(). So we don't need to store zpci idx in msix message data to find out the specific zpci device. Instead, we could use pci device id to find its corresponding zpci device. Signed-off-by: Yi Min Zhao --- hw/s390x/s390-pci-

[Qemu-devel] [PATCH v3 2/3] s390x/pci: fixup ind_offset of msix routing entry

2017-09-05 Thread Yi Min Zhao
offset, but instead add the vector to the starting offset to get the absolute offset in the specific route. Signed-off-by: Yi Min Zhao --- target/s390x/kvm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index ebbeb4d6b3..931b85fe3d

Re: [Qemu-devel] [PATCH v3 0/3] three zpci patches

2017-09-05 Thread Yi Min Zhao
Thank you very much! 在 2017/9/5 下午7:58, Cornelia Huck 写道: On Tue, 5 Sep 2017 12:12:57 +0200 Yi Min Zhao wrote: This patch set contains three small zpci patches to fixup different issues. 1) remove zpci idx from msix message, instead we could use PCIDevice's id to find zpci devi

Re: [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by switching to ccw

2017-09-06 Thread Yi Min Zhao
在 2017/9/6 下午3:59, Cornelia Huck 写道: On Wed, 6 Sep 2017 14:57:48 +0800 QingFeng Hao wrote: 在 2017/9/5 23:16, Cornelia Huck 写道: Recent changes in s390x made pci support dependant on the zpci cpu feature, which is not provided on all models (and not on by default). This means we cannot instat

Re: [Qemu-devel] [PATCH 2/7] s390x/pci: rework PCI STORE

2017-11-10 Thread Yi Min Zhao
在 2017/11/10 上午12:50, Cornelia Huck 写道: On Tue, 7 Nov 2017 18:24:34 +0100 Pierre Morel wrote: Enhance the fault detection, correction of the fault reporting. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao --- hw/s390x/s390-pci-inst.c | 41

Re: [Qemu-devel] [PATCH 6/7] s390x/pci: move the memory region write from pcistg

2017-11-10 Thread Yi Min Zhao
s exactly fit to the byte ordering of pcilg instruction. For PCI config space, the data has been swapped according to the cpu byte ordering. So we use zpci_swap_endian() to swap the data back to the little-endian ordering. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao --- hw/s

[Qemu-devel] [PATCH] s390x/pci: forbid multifunction pci device

2018-03-13 Thread Yi Min Zhao
Currently we don't support pci multifunction. If a pci with multifucntion is plugged, the guest will spin forever. This patch fixes this. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel --- hw/s390x/s390-pci-bus.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/

Re: [Qemu-devel] [PATCH] s390x/pci: forbid multifunction pci device

2018-03-13 Thread Yi Min Zhao
在 2018/3/14 下午1:35, Thomas Huth 写道: On 14.03.2018 06:14, Yi Min Zhao wrote: Currently we don't support pci multifunction. If a pci with multifucntion is plugged, the guest will spin forever. This patch fixes this. Signed-off-by: Yi Min Zhao Reviewed-by: Pierre Morel --- hw/s390x/s39

[Qemu-devel] [PATCH 0/1] Bug: Sandbox: libvirt breakdowns qemu guest

2018-05-06 Thread Yi Min Zhao
x27;enable' for qemu_sandbox_opts by CONFIG_SECCOMP. Yi Min Zhao (1): sandbox: avoid to compile options if CONFIG_SECCOMP undefined vl.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.15.1 (Apple Git-101)

  1   2   >