Re: [PATCH V9 41/46] python/machine: QEMUMachine reopen_qmp_connection

On 7/26/2022 2:04 PM, John Snow wrote: > On Tue, Jul 26, 2022 at 12:12 PM Steve Sistare > wrote: >> >> Provide reopen_qmp_connection() to reopen a closed monitor connection. >> This is needed by cpr, because qemu exec closes the monitor socket. >> >> Signed-off-by: Steve Sistare >> --- >> python

Re: [PATCH V1] migration: export fewer options

On 2/25/2024 9:40 PM, Peter Xu wrote: > On Fri, Feb 23, 2024 at 09:13:24AM -0800, Steve Sistare wrote: >> A small number of migration options are accessed by migration clients, >> but to see them clients must include all of options.h, which is mostly >> for migration core code. migrate_mode() in p

Re: [PATCH V4 00/14] allow cpr-reboot for vfio

On 2/26/2024 4:01 AM, Peter Xu wrote: > On Mon, Feb 26, 2024 at 09:49:46AM +0100, Cédric Le Goater wrote: >> Go ahead. It will help me for the changes I am doing on error reporting >> for VFIO migration. I will rebase on top. > > Thanks for confirming. I queued the migration patches then, but lea

Re: [PATCH V4 00/14] allow cpr-reboot for vfio

On 2/26/2024 3:21 PM, Steven Sistare wrote: > On 2/26/2024 4:01 AM, Peter Xu wrote: >> On Mon, Feb 26, 2024 at 09:49:46AM +0100, Cédric Le Goater wrote: >>> Go ahead. It will help me for the changes I am doing on error reporting >>> for VFIO migration. I will reba

Re: [PATCH V1] migration: export fewer options

On 2/27/2024 3:08 AM, Peter Xu wrote: > On Mon, Feb 26, 2024 at 09:41:15AM -0500, Steven Sistare wrote: >> On 2/26/2024 2:40 AM, Markus Armbruster wrote: >>> Steve Sistare writes: >>> >>>> A small number of migration options are accessed by migration cli

Re: [PATCH v6 0/5] string list functions

On 2/27/2024 10:28 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Hi Markus, >> >> Here are the patches I queued until you told me you'd >> object to the CamelCase filename strList.[ch]. >> >> Steve, please take over ;) > > I'm going to post the part of the series I'm ready t

Re: [PATCH v7 0/3] string list functions

All the changes look good - steve On 2/27/2024 10:33 AM, Markus Armbruster wrote: > This is Steve's work (v1 to v5), tweaked by Philippe (v6), and now by > me. > > v7: > * Old PATCH 1 dropped > The proposed str_split() is a composition of g_strsplit() and a > conversion from char ** to strLis

Re: [PATCH V1 00/10] privatize migration.h

Please ignore this solo message, I accidentally sent it alone - steve On 2/27/2024 12:42 PM, Steve Sistare wrote: > migration/migration.h is the private interface for code in the migration > sub-directory, but many other clients include it because they need accessors > that are not exported by the

Re: [PATCH V4 14/14] migration: options incompatible with cpr

On 2/28/2024 2:21 AM, Markus Armbruster wrote: > Steve Sistare writes: > >> Fail the migration request if options are set that are incompatible >> with cpr. >> >> Signed-off-by: Steve Sistare >> --- >> migration/migration.c | 17 + >> qapi/migration.json | 2 ++ >> 2 files ch

Re: [PATCH V4 14/14] migration: options incompatible with cpr

On 2/28/2024 11:05 AM, Markus Armbruster wrote: > Steven Sistare writes: > >> On 2/28/2024 2:21 AM, Markus Armbruster wrote: >>> Steve Sistare writes: >>> >>>> Fail the migration request if options are set that are incompatible >>>

Re: [PATCH V2] migration: export fewer options

Just a reminder, after our further discussion in the V1 thread, this patch is still what I propose, no updates needed. Markus, I think Peter is looking for your blessing on the new file name: include/migration/client-options.h. - Steve On 2/26/2024 5:16 PM, Steve Sistare wrote: > A small number

Re: [PATCH V4 11/14] vfio: register container for cpr

On 2/29/2024 3:35 AM, Cédric Le Goater wrote: > Hello Steve, > > On 2/22/24 18:28, Steve Sistare wrote: >> Define entry points to perform per-container cpr-specific initialization >> and teardown. >> >> Signed-off-by: Steve Sistare >> --- >>   hw/vfio/container.c   | 11 ++- >>

Re: [PATCH] migration: re-format cpr-reboot documentation

Please ignore this, I will send a V2 that incorporates additional comments from Markus that I missed in my inbox. - Steve On 2/29/2024 9:15 AM, Steve Sistare wrote: > Re-wrap the cpr-reboot documentation to 70 columns, use '@' for > cpr-reboot references, and capitalize COLO. > > Suggested-by: M

Re: [PATCH V4 14/14] migration: options incompatible with cpr

On 2/29/2024 12:40 AM, Peter Xu wrote: > On Thu, Feb 29, 2024 at 06:31:26AM +0100, Markus Armbruster wrote: >> Hmm, perhaps Peter can still squash in the corrections before posting >> his PR. Peter? > > The PR was sent yesterday, it's already in PeterM's -staging. I worry it's > a bit late to ca

Re: [PATCH V4 10/14] migration: stop vm for cpr

On 2/25/2024 9:08 PM, Peter Xu wrote: > On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: >> When migration for cpr is initiated, stop the vm and set state >> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the >> possibility of ram and device state being out of sync, an

Re: [PATCH V3 09/13] migration: notifier error checking

On 2/20/2024 2:12 AM, Peter Xu wrote: > On Thu, Feb 08, 2024 at 10:54:02AM -0800, Steve Sistare wrote: >> Check the status returned by migration notifiers and report errors. >> If notifiers fail, call the notifiers again so they can clean up. >> None of the notifiers return an error status at this

Re: [PATCH V3 10/13] migration: stop vm for cpr

On 2/20/2024 2:33 AM, Peter Xu wrote: > On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote: >> When migration for cpr is initiated, stop the vm and set state >> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the >> possibility of ram and device state being out of sync, an

Re: [PATCH V3 00/13] allow cpr-reboot for vfio

On 2/20/2024 2:49 AM, Peter Xu wrote: > On Thu, Feb 08, 2024 at 10:53:53AM -0800, Steve Sistare wrote: >> Allow cpr-reboot for vfio if the guest is in the suspended runstate. The >> guest drivers' suspend methods flush outstanding requests and re-initialize >> the devices, and thus there is no dev

Re: [PATCH V4 5/5] migration: simplify exec migration functions

On 2/21/2024 10:54 AM, Fabiano Rosas wrote: > Fabiano Rosas writes: > >> Steve Sistare writes: >> >>> Simplify the exec migration code by using list utility functions. >>> >>> As a side effect, this also fixes a minor memory leak. On function return, >>> "g_auto(GStrv) argv" frees argv and each

Re: [PATCH V4 1/5] util: strList_from_string

On 2/21/2024 8:29 AM, Markus Armbruster wrote: > I apologize for the lateness of my review. No problem. Thanks for the review. > Steve Sistare writes: > >> Generalize hmp_split_at_comma() to take any delimiter string, rename >> as strList_from_string(), and move it to util/strList.c. >> >> No

Re: [PATCH V4 4/5] util: strList unit tests

On 2/21/2024 8:19 AM, Markus Armbruster wrote: > Steve Sistare writes: > >> Signed-off-by: Steve Sistare >> Reviewed-by: Marc-André Lureau >> --- >> tests/unit/meson.build| 1 + >> tests/unit/test-strList.c | 80 >> +++ >> 2 files changed, 81 i

Re: [PATCH V4 3/5] util: strv_from_strList

On 2/21/2024 8:14 AM, Markus Armbruster wrote: > Steve Sistare writes: > >> Signed-off-by: Steve Sistare >> Reviewed-by: Marc-André Lureau >> --- >> include/qemu/strList.h | 6 ++ >> util/strList.c | 14 ++ >> 2 files changed, 20 insertions(+) >> >> diff --git a/includ

Re: [PATCH V4 2/5] qapi: QAPI_LIST_LENGTH

On 2/21/2024 8:29 AM, Markus Armbruster wrote: > Steve Sistare writes: > >> Signed-off-by: Steve Sistare >> Reviewed-by: Marc-André Lureau >> --- >> include/qapi/util.h | 13 + >> 1 file changed, 13 insertions(+) >> >> diff --git a/include/qapi/util.h b/include/qapi/util.h >> index

Re: [PATCH V3 12/13] vfio: allow cpr-reboot migration if suspended

Hi Alex, any comments or RB on this or patch 11? The last few changes I am making for Peter will not change this patch. - Steve On 2/8/2024 1:54 PM, Steve Sistare wrote: > Allow cpr-reboot for vfio if the guest is in the suspended runstate. The > guest drivers' suspend methods flush outstandin

Re: [PATCH V3 10/13] migration: stop vm for cpr

On 2/20/2024 2:33 AM, Peter Xu wrote: > On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote: >> When migration for cpr is initiated, stop the vm and set state >> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the >> possibility of ram and device state being out of sync, an

Re: [PATCH V3 10/13] migration: stop vm for cpr

On 2/20/2024 2:33 AM, Peter Xu wrote: > On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote: >> When migration for cpr is initiated, stop the vm and set state >> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the >> possibility of ram and device state being out of sync, an

Re: [PATCH V3 10/13] migration: stop vm for cpr

On 2/22/2024 4:03 AM, Peter Xu wrote: > On Wed, Feb 21, 2024 at 04:23:07PM -0500, Steven Sistare wrote: >>> How about postcopy? I know it's nonsense to enable postcopy for cpr.. but >>> iiuc we don't yet forbid an user doing so. Maybe

Re: [PATCH V3 10/13] migration: stop vm for cpr

On 2/22/2024 4:30 AM, Peter Xu wrote: > On Thu, Feb 22, 2024 at 05:12:53PM +0800, Peter Xu wrote: >> On Wed, Feb 21, 2024 at 04:20:07PM -0500, Steven Sistare wrote: >>> On 2/20/2024 2:33 AM, Peter Xu wrote: >>>> On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sista

Re: [PATCH V4 00/14] allow cpr-reboot for vfio

Peter (and David if interested): these patches still need RB: migration: notifier error checking migration: stop vm for cpr migration: update cpr-reboot description migration: options incompatible with cpr Alex, these patches still need RB: vfio: register container for cpr vfio: allow

Re: [PATCH V4 1/5] util: strList_from_string

On 2/21/2024 12:01 PM, Steven Sistare wrote: > On 2/21/2024 8:29 AM, Markus Armbruster wrote: >> I apologize for the lateness of my review. > > No problem. Thanks for the review. > >> Steve Sistare writes: >> >>> Generalize hmp_split_at_comma() to t

Re: [PATCH V5 1/5] util: str_split

On 2/23/2024 1:01 AM, Philippe Mathieu-Daudé wrote: > On 22/2/24 22:47, Steve Sistare wrote: >> Generalize hmp_split_at_comma() to take any delimiter string, rename >> as str_split(), and move it to util/strList.c. >> >> No functional change. >> >> Signed-off-by: Steve Sistare >> --- >>   include/

Re: [PATCH V5 1/5] util: str_split

On 2/23/2024 12:41 PM, Philippe Mathieu-Daudé wrote: > On 23/2/24 15:01, Steven Sistare wrote: >> On 2/23/2024 1:01 AM, Philippe Mathieu-Daudé wrote: >>> On 22/2/24 22:47, Steve Sistare wrote: >>>> Generalize hmp_split_at_comma() to take any delimiter string, rename

Re: [PATCH V1] migration: export fewer options

On 2/26/2024 2:40 AM, Markus Armbruster wrote: > Steve Sistare writes: > >> A small number of migration options are accessed by migration clients, >> but to see them clients must include all of options.h, which is mostly >> for migration core code. migrate_mode() in particular will be needed by

Re: [PATCH v6 0/5] string list functions

Thanks for trying a V6 Philippe. I'll take it from here. It helps to know that someone besides me thinks these functions are worth having. - Steve On 2/26/2024 9:11 AM, Philippe Mathieu-Daudé wrote: > Hi Markus, > > Here are the patches I queued until you told me you'd > object to the CamelCas

Re: [PATCH V3 09/13] migration: notifier error checking

On 2/12/2024 4:24 AM, David Hildenbrand wrote: > On 08.02.24 19:54, Steve Sistare wrote: >> Check the status returned by migration notifiers and report errors. >> If notifiers fail, call the notifiers again so they can clean up. > > IIUC, if any of the notifiers will actually start to fail, say, d

Re: [PATCH V2] migration: export fewer options

On 3/1/2024 2:47 AM, Peter Xu wrote: On Thu, Feb 29, 2024 at 07:03:36AM +0100, Markus Armbruster wrote: Steven Sistare writes: Just a reminder, after our further discussion in the V1 thread, this patch is still what I propose, no updates needed. Markus, I think Peter is looking for your

Re: [PATCH V2 00/11] privatize migration.h

On 3/11/2024 3:30 PM, Peter Xu wrote: Steve, On Mon, Mar 11, 2024 at 10:48:47AM -0700, Steve Sistare wrote: Changes in V2: * rebase to migration-next, add RB Not apply even to master branch. Note that there're >=1 PULLs sent and merged since my last reply.. Perhaps you rebased to the "ol

Re: [PATCH V2 00/11] privatize migration.h

On 3/11/2024 3:45 PM, Steven Sistare wrote: On 3/11/2024 3:30 PM, Peter Xu wrote: Steve, On Mon, Mar 11, 2024 at 10:48:47AM -0700, Steve Sistare wrote: Changes in V2:    * rebase to migration-next, add RB Not apply even to master branch.  Note that there're >=1 PULLs sent and merg

Re: [PATCH V2 00/11] privatize migration.h

On 3/11/2024 4:28 PM, Peter Xu wrote: On Mon, Mar 11, 2024 at 04:24:14PM -0400, Steven Sistare wrote: On 3/11/2024 3:45 PM, Steven Sistare wrote: On 3/11/2024 3:30 PM, Peter Xu wrote: Steve, On Mon, Mar 11, 2024 at 10:48:47AM -0700, Steve Sistare wrote: Changes in V2:    * rebase to

Re: [PATCH V4 10/14] migration: stop vm for cpr

On 2/29/2024 8:28 PM, Peter Xu wrote: On Thu, Feb 29, 2024 at 10:21:14AM -0500, Steven Sistare wrote: On 2/25/2024 9:08 PM, Peter Xu wrote: On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: When migration for cpr is initiated, stop the vm and set state RUN_STATE_FINISH_MIGRATE

Re: [PATCH V1 18/26] migration: cpr-exec-args parameter

On 5/2/2024 8:23 AM, Markus Armbruster wrote: Steve Sistare writes: Create the cpr-exec-args migration parameter, defined as a list of strings. It will be used for cpr-exec migration mode in a subsequent patch. No functional change, except that cpr-exec-args is shown by the 'info migrate' co

Re: [PATCH V1 20/26] migration: cpr-exec mode

On 5/2/2024 8:23 AM, Markus Armbruster wrote: Steve Sistare writes: Add the cpr-exec migration mode. Usage: qemu-system-$arch -machine memfd-alloc=on ... migrate_set_parameter mode cpr-exec migrate_set_parameter cpr-exec-args \ ... -incoming migrate -d The migrate comman

cpr-exec doc (was Re: [PATCH V1 00/26] Live update: cpr-exec)

On 4/29/2024 11:55 AM, Steve Sistare wrote: This patch series adds the live migration cpr-exec mode. Here is the text I plan to add to docs/devel/migration/CPR.rst. It is premature for me to submit this as a patch, because it includes all the functionality I plan to add in this and future seri

Re: [PATCH] tap: fix net_init_tap() return code

On 4/4/2023 6:00 PM, Philippe Mathieu-Daudé wrote: > On 4/4/23 18:00, Steve Sistare wrote: >> When net_init_tap() succeeds for a multi-queue device, it returns a >> non-zero ret=1 code to its caller, because of this code where ret becomes > > Indeed g_unix_set_fd_nonblocking() returns TRUE on su

clean after distclean gobbles source files

Run 'make distclean', and GNUmakefile is removed. But, GNUmakefile is where we cd to build/. Run 'make distclean' or 'make clean' again, and Makefile applies the clean actions, such as this one, at the top level of the tree: find . \( -name '*.so' -o -name '*.dll' -o \ -name '*.[oda]

Re: [PATCH] tap: fix net_init_tap() return code

On 4/11/2023 2:32 AM, Jason Wang wrote: > 在 2023/4/5 23:38, Steven Sistare 写道: >> On 4/4/2023 6:00 PM, Philippe Mathieu-Daudé wrote: >>> On 4/4/23 18:00, Steve Sistare wrote: >>>> When net_init_tap() succeeds for a multi-queue device, it returns a >>>> non

Re: [PATCH] util/mmap: optimize qemu_ram_mmap() alignment

On 4/11/2023 3:57 AM, David Hildenbrand wrote: > On 10.04.23 17:46, Steve Sistare wrote: >> Guest RAM created with memory-backend-memfd is aligned to a >> QEMU_VMALLOC_ALIGN=2M boundary, and memory-backend-memfd does not support >> the "align" parameter to change the default.  This is sub-optimal o

Re: [PATCH] make: clean after distclean deletes source files

Any takers? I believe this patch is correct and clean. Examples, run in the top level of a git tree: $ configure ... $ make clean ... cleans ... $ make clean ... cleans ... $ make distclean ... cleans ... $ make distclean Makefile:180: *** Please call configure before running make. Stop. $ m

Re: [PATCH V8 02/39] migration: qemu file wrappers

On 6/15/2022 10:18 PM, Guoyi Tu wrote: > On 2022/6/15 22:51, Steve Sistare wrote: >> Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix >> files and file descriptors. >> > the function names should be updated. > > -- > Guoyi Yes indeed, thanks - Steve >> Signed-off-by: Stev

Re: [PATCH V8 05/39] vl: start on wakeup request

On 6/16/2022 11:55 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jun 15, 2022 at 7:27 PM Steve Sistare > wrote: > > If qemu starts and loads a VM in the suspended state, then a later wakeup > request will set the state to running, which is not sufficient

Re: [PATCH V8 04/39] memory: RAM_ANON flag

On 6/15/2022 4:25 PM, David Hildenbrand wrote: > On 15.06.22 16:51, Steve Sistare wrote: >> A memory-backend-ram or a memory-backend-memfd block with the RAM_SHARED >> flag set is not migrated when migrate_ignore_shared() is true, but this >> is wrong, because it has no named backing store, and its

Re: [PATCH V8 06/39] cpr: reboot mode

On 6/16/2022 7:10 AM, Daniel P. Berrangé wrote: > On Wed, Jun 15, 2022 at 07:51:53AM -0700, Steve Sistare wrote: >> Provide the cpr-save and cpr-load functions for live update. These save and >> restore VM state, with minimal guest pause time, so that qemu may be updated >> to a new version in bet

Re: [PATCH V8 02/39] migration: qemu file wrappers

On 6/16/2022 10:55 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jun 15, 2022 at 6:54 PM Steve Sistare > wrote: > > Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix > files and file descriptors. > > File descriptors are not really

Re: [PATCH V8 12/39] memory: flat section iterator

On 7/3/2022 3:52 AM, Peng Liang wrote: > On 6/15/2022 10:51 PM, Steve Sistare wrote: >> Add an iterator over the sections of a flattened address space. >> >> Signed-off-by: Steve Sistare >> Reviewed-by: Marc-André Lureau >> --- >> include/exec/memory.h | 31 +++ >> so

Re: [PATCH V8 13/39] oslib: qemu_clear_cloexec

On 6/16/2022 12:07 PM, Daniel P. Berrangé wrote: > On Wed, Jun 15, 2022 at 07:52:00AM -0700, Steve Sistare wrote: >> Define qemu_clear_cloexec, analogous to qemu_set_cloexec. >> >> Reviewed-by: Dr. David Alan Gilbert >> Signed-off-by: Steve Sistare >> --- >> include/qemu/osdep.h | 1 + >> util/o

Re: [PATCH V8 02/39] migration: qemu file wrappers

On 6/16/2022 11:29 AM, Daniel P. Berrangé wrote: > On Wed, Jun 15, 2022 at 07:51:49AM -0700, Steve Sistare wrote: >> Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix >> files and file descriptors. >> >> Signed-off-by: Steve Sistare >> --- >> migration/qemu-file-channel.c |

Re: [PATCH V8 24/39] pci: export export msix_is_pending

On 6/27/2022 6:44 PM, Michael S. Tsirkin wrote: > On Wed, Jun 15, 2022 at 07:52:11AM -0700, Steve Sistare wrote: >> Export msix_is_pending for use by cpr. No functional change. >> >> Signed-off-by: Steve Sistare > > the subject repeats export twice. > With that fixed: > > Acked-by: Michael S. T

Re: [PATCH V8 16/39] qapi: strv_from_strList

On 6/16/2022 12:08 PM, Marc-André Lureau wrote: > Hi > > On Wed, Jun 15, 2022 at 7:30 PM Steve Sistare > wrote: > > Signed-off-by: Steve Sistare > > --- >  include/qapi/util.h |  6 ++ >  qapi/qapi-util.c   

Re: [PATCH V8 14/39] qapi: strList_from_string

On 6/16/2022 12:04 PM, Marc-André Lureau wrote: > Hi > > On Wed, Jun 15, 2022 at 7:04 PM Steve Sistare > wrote: > > Generalize strList_from_comma_list() to take any delimiter character, > rename > as strList_from_string(), and move it to qapi/util.c. >

Re: [PATCH V8 27/39] vfio-pci: cpr part 1 (fd and dma)

On 7/3/2022 4:32 AM, Peng Liang wrote: > On 6/15/2022 10:52 PM, Steve Sistare wrote: [...] >> diff --git a/hw/vfio/cpr.c b/hw/vfio/cpr.c [...] >> +static int vfio_container_pre_save(void *opaque) >> +{ >> +VFIOContainer *container = (VFIOContainer *)opaque; >> +Error *err; > > According

Re: [PATCH V8 20/39] cpr: restart mode

On 7/3/2022 4:15 AM, Peng Liang wrote: > On 6/15/2022 10:52 PM, Steve Sistare wrote: >> Provide the cpr-save restart mode, which preserves the guest VM across a >> restart of the qemu process. After cpr-save, the caller passes qemu >> command-line arguments to cpr-exec, which directly exec's the n

Re: [PATCH V8 36/39] chardev: cpr for sockets

On 7/3/2022 4:19 AM, Peng Liang wrote: > On 6/15/2022 10:52 PM, Steve Sistare wrote: >> Save accepted socket fds before cpr-save, and look for them after cpr-load. >> Block cpr-exec if a socket enables the TLS or websocket option. Allow a >> monitor socket by closing it on exec. >> >> Signed-off-b

Re: [PATCH V8 38/39] python/machine: add QEMUMachine accessors

On 6/17/2022 10:16 AM, John Snow wrote: > On Wed, Jun 15, 2022, 11:27 AM Steve Sistare > wrote: > > Provide full_args() to return all command-line arguments used to start a > vm, some of which are not otherwise visible to QEMUMachine clients.  This >

Re: clean after distclean gobbles source files

On 4/13/2023 7:41 AM, Thomas Huth wrote: > On 07/04/2023 17.44, Steven Sistare wrote: >> Run 'make distclean', and GNUmakefile is removed. >> But, GNUmakefile is where we cd to build/. >> Run 'make distclean' or 'make clean' again, and Makefile

Re: clean after distclean gobbles source files

On 4/14/2023 11:41 AM, Thomas Huth wrote: > On 14/04/2023 17.30, Steven Sistare wrote: >> On 4/13/2023 7:41 AM, Thomas Huth wrote: >>> On 07/04/2023 17.44, Steven Sistare wrote: >>>> Run 'make distclean', and GNUmakefile is removed. >>>> But,

Re: [PATCH V7 01/29] memory: qemu_check_ram_volatile

On 2/24/2022 1:28 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Add a function that returns an error if any ram_list block represents >> volatile memory. >> >> Signed-off-by: Steve Sistare >> --- >> include/exec/memory.h | 8 >> softmmu/memory

Re: [PATCH V7 02/29] migration: fix populate_vfio_info

On 2/24/2022 1:42 PM, Peter Maydell wrote: > On Wed, 22 Dec 2021 at 19:45, Steve Sistare wrote: >> >> Include CONFIG_DEVICES so that populate_vfio_info is instantiated for >> CONFIG_VFIO. > > The commit message says "include CONFIG_DEVICES"... > >> Signed-off-by: Steve Sistare >> --- >> migrat

Re: [PATCH V7 03/29] migration: qemu file wrappers

On 2/24/2022 1:21 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Add qemu_file_open and qemu_fd_open to create QEMUFile objects for unix >> files and file descriptors. >> >> Signed-off-by: Steve Sistare >> --- >> migration/qemu-file-channel.c | 36 ++

Re: [PATCH V7 04/29] migration: simplify savevm

On 2/24/2022 1:25 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Use qemu_file_open to simplify a few functions in savevm.c. >> No functional change. >> >> Signed-off-by: Steve Sistare > > So I think this is mostly OK, but a couple of minor tidyups below

Re: [PATCH V7 10/29] machine: memfd-alloc option

On 2/18/2022 3:05 AM, Guoyi Tu wrote: > On Wed, 2021-12-22 at 11:05 -0800, Steve Sistare wrote: >> Allocate anonymous memory using memfd_create if the memfd-alloc >> machine >> option is set. >> >> Signed-off-by: Steve Sistare >> --- >> hw/core/machine.c | 19 +++ >> include/hw/

Re: [PATCH V7 28/29] chardev: cpr for sockets

On 2/18/2022 4:03 AM, Guoyi Tu wrote: > On Wed, 2021-12-22 at 11:05 -0800, Steve Sistare wrote: >> Save accepted socket fds before cpr-save, and look for them after >> cpr-load. >> in the environment after cpr-load. Reject cpr-exec if a socket >> enables >> the TLS or websocket option. Allow a mo

Re: [PATCH V7 29/29] cpr: only-cpr-capable option

On 2/18/2022 4:43 AM, Guoyi Tu wrote: > On Wed, 2021-12-22 at 11:05 -0800, Steve Sistare wrote: >> Add the only-cpr-capable option, which causes qemu to exit with an >> error >> if any devices that are not capable of cpr are added. This >> guarantees that >> a cpr-exec operation will not fail with

Re: [PATCH V7 05/29] vl: start on wakeup request

On 2/24/2022 1:51 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> If qemu starts and loads a VM in the suspended state, then a later wakeup >> request will set the state to running, which is not sufficient to initialize >> the vm, as vm_start was never call

Re: [PATCH V7 10/29] machine: memfd-alloc option

On 2/24/2022 12:56 PM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Allocate anonymous memory using memfd_create if the memfd-alloc machine >> option is set. >> >> Signed-off-by: Steve Sistare > > So other than the minor error nit that Guoyi spotted, I thi

Re: [PATCH V7 02/29] migration: fix populate_vfio_info

On 3/3/2022 11:21 AM, Peter Maydell wrote: > On Thu, 3 Mar 2022 at 15:55, Steven Sistare wrote: >> >> On 2/24/2022 1:42 PM, Peter Maydell wrote: >>> ...it also seems to be making a no-change-of-behaviour rewrite >>> of the rest of the file. Is there a reas

Re: [PATCH V6 00/27] Live Update

Soon. I'll aim for next week. Thanks for your continued interest! - Steve On 10/27/2021 2:16 AM, Zheng Chuan wrote: > Hi, Steve. > Any updates for this series?

Re: [PATCH V7 17/29] pci: export functions for cpr

On 12/22/2021 6:07 PM, Michael S. Tsirkin wrote: > On Wed, Dec 22, 2021 at 11:05:22AM -0800, Steve Sistare wrote: >> Export msix_is_pending, msix_init_vector_notifiers, and pci_update_mappings >> for use by cpr. No functional change. >> >> Signed-off-by: Steve Sistare > > With things like that,

Re: [PATCH V7 19/29] vfio-pci: cpr part 1 (fd and dma)

On 12/22/2021 6:15 PM, Michael S. Tsirkin wrote: > On Wed, Dec 22, 2021 at 11:05:24AM -0800, Steve Sistare wrote: >> Enable vfio-pci devices to be saved and restored across an exec restart >> of qemu. >> >> At vfio creation time, save the value of vfio container, group, and device >> descriptors in

Re: [PATCH V7 19/29] vfio-pci: cpr part 1 (fd and dma)

On 1/5/2022 4:14 PM, Michael S. Tsirkin wrote: > On Wed, Jan 05, 2022 at 12:24:21PM -0500, Steven Sistare wrote: >> On 12/22/2021 6:15 PM, Michael S. Tsirkin wrote: >>> On Wed, Dec 22, 2021 at 11:05:24AM -0800, Steve Sistare wrote: >>>> Enable vfio-pci devices to b

Re: [PATCH V7 19/29] vfio-pci: cpr part 1 (fd and dma)

On 1/5/2022 6:09 PM, Michael S. Tsirkin wrote: > On Wed, Jan 05, 2022 at 04:40:43PM -0500, Steven Sistare wrote: >> On 1/5/2022 4:14 PM, Michael S. Tsirkin wrote: >>> On Wed, Jan 05, 2022 at 12:24:21PM -0500, Steven Sistare wrote: >>>> On 12/22/2021 6:15 PM, Michael

Re: [PATCH V7 19/29] vfio-pci: cpr part 1 (fd and dma)

On 1/6/2022 4:12 AM, Michael S. Tsirkin wrote: > On Wed, Jan 05, 2022 at 06:24:25PM -0500, Steven Sistare wrote: >> On 1/5/2022 6:09 PM, Michael S. Tsirkin wrote: >>> On Wed, Jan 05, 2022 at 04:40:43PM -0500, Steven Sistare wrote: >>>> On 1/5/2022 4:14 PM, Michael

Re: [PATCH V7 17/29] pci: export functions for cpr

On 1/5/2022 3:16 PM, Michael S. Tsirkin wrote: > On Wed, Jan 05, 2022 at 12:22:25PM -0500, Steven Sistare wrote: >> On 12/22/2021 6:07 PM, Michael S. Tsirkin wrote: >>> On Wed, Dec 22, 2021 at 11:05:22AM -0800, Steve Sistare wrote: >>>> Export msix_is_pending, m

Re: [PATCH V7 00/29] Live Update

Hi Dave, It has been a long time since we chatted about this series. The vfio patches have been updated with feedback from Alex and are close to being final (I think). Could you take another look at the patches that you care about? To refresh your memory, you last reviewed V3 of the series,

Re: [PATCH V7 00/29] Live Update

Please? - Steve On 1/7/2022 1:45 PM, Steven Sistare wrote: > Hi Dave, > It has been a long time since we chatted about this series. The vfio > patches have been updated with feedback from Alex and are close to being > final (I think). Could you take another look at the patches t

Re: [PATCH V2] meson: fix dependency on qemu-keymap

On 2/20/2023 1:35 PM, Thomas Huth wrote: > On 06/02/2023 19.34, Steve Sistare wrote: >> When qemu-keymap is not available on the host, and enable-xkbcommon >> is specified, parallel make fails with: >> >>    % make clean >>    ... >>    % make -j 32 >>    ... >>    FAILED: pc-bios/keymaps/is >>   

Re: [PATCH V1] meson: fix dependency on qemu-keymap

On 2/6/2023 1:55 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jan 25, 2023 at 9:28 PM Steve Sistare > wrote: > > When qemu-keymap is not available on the host, and enable-xkbcommon > is specified, parallel make fails with: > >   % make clean >

Re: [PATCH V9 00/46] Live Update

: strv_from_strList qapi: strList unit tests - Steve On 12/7/2022 10:48 AM, Steven Sistare wrote: > This series desperately needs review in its intersection with live migration. > The code in other areas has been reviewed and revised multiple times -- thank > you! > > David, Juan, can you spa

Re: [PATCH V9 00/46] Live Update

and of course I immediately screwed up and forgot to delete series numbers from the email titles. I will resend. - Steve On 2/7/2023 1:44 PM, Steven Sistare wrote: > To make forward progress on this series and reduce its size, I will be posting > those of its patches that can be indepen

Re: [PATCH V2] python/machine: QEMUMachine reopen_qmp_connection

On 2/7/2023 3:28 PM, John Snow wrote: > On Tue, Feb 7, 2023 at 2:03 PM Steve Sistare > wrote: >> >> Provide reopen_qmp_connection() to reopen a closed monitor connection. >> This will be needed by cpr, because qemu exec closes the monitor socket. >> >> Signed-off-by: Steve Sistare >> Reviewed-by

Re: [PATCH V2] migration: simplify blockers

On 2/7/2023 3:05 PM, Peter Xu wrote: > On Tue, Feb 07, 2023 at 11:03:13AM -0800, Steve Sistare wrote: >> Modify migrate_add_blocker and migrate_del_blocker to take an Error ** >> reason. This allows migration to own the Error object, so that if >> an error occurs, migration code can free the Error

Re: [PATCH V2] memory: flat section iterator

On 2/7/2023 3:10 PM, Peter Xu wrote: > On Tue, Feb 07, 2023 at 11:03:29AM -0800, Steve Sistare wrote: >> Add an iterator over the sections of a flattened address space. >> This will be needed by cpr to issue vfio ioctl's on the same memory >> ranges that are already programmed. > > Should this bet

Re: [PATCH V2] python/machine: QEMUMachine reopen_qmp_connection

On 2/7/2023 4:23 PM, John Snow wrote: > On Tue, Feb 7, 2023 at 4:04 PM Steven Sistare > wrote: >> >> On 2/7/2023 3:28 PM, John Snow wrote: >>> On Tue, Feb 7, 2023 at 2:03 PM Steve Sistare >>> wrote: >>>> >>>> Provide reopen_qmp_connec

Re: [PATCH V2 1/4] qapi: strList_from_string

On 2/8/2023 1:43 AM, Marc-André Lureau wrote: > Hi > > On Tue, Feb 7, 2023 at 10:50 PM Steve Sistare > wrote: >> >> Generalize hmp_split_at_comma() to take any delimiter character, rename >> as strList_from_string(), and move it to qapi/util.c. >> >> No functional change. > > The g_strsplit() v

Re: [PATCH V2] memory: flat section iterator

On 2/7/2023 4:47 PM, Peter Xu wrote: > On Tue, Feb 07, 2023 at 04:28:49PM -0500, Steven Sistare wrote: >> On 2/7/2023 3:10 PM, Peter Xu wrote: >>> On Tue, Feb 07, 2023 at 11:03:29AM -0800, Steve Sistare wrote: >>>> Add an iterator over the sections of a flattened ad

Re: [PATCH V2] memory: RAM_NAMED_FILE flag

On 2/7/2023 3:23 PM, Peter Xu wrote: > On Tue, Feb 07, 2023 at 11:03:33AM -0800, Steve Sistare wrote: >> migrate_ignore_shared() is an optimization that avoids copying memory >> that is visible and can be mapped on the target. However, a >> memory-backend-ram or a memory-backend-memfd block with t

Re: [PATCH V2 1/4] qapi: strList_from_string

On 2/8/2023 9:17 AM, Alex Bennée wrote: > Steven Sistare writes: > >> On 2/8/2023 1:43 AM, Marc-André Lureau wrote: >>> Hi >>> >>> On Tue, Feb 7, 2023 at 10:50 PM Steve Sistare >>> wrote: >>>> >>>> General

Re: [PATCH V2 1/4] qapi: strList_from_string

On 2/9/2023 5:02 AM, Markus Armbruster wrote: > Alex Bennée writes: > >> Steven Sistare writes: >> >>> On 2/8/2023 1:43 AM, Marc-André Lureau wrote: >>>> Hi >>>> >>>> On Tue, Feb 7, 2023 at 10:50 PM Steve Sistare >>>&g

Re: [PATCH V2 0/4] string list functions

On 2/9/2023 5:05 AM, Markus Armbruster wrote: > Steve Sistare writes: > >> Add some handy string list functions, for general use now, and for >> eventual use in the cpr/live update patches. > > Submit them together with uses, please. Are you OK with me describing my intended uses in the commit

Re: [PATCH V2 0/4] string list functions

On 2/9/2023 5:48 AM, Daniel P. Berrangé wrote: > On Tue, Feb 07, 2023 at 10:48:43AM -0800, Steve Sistare wrote: >> Add some handy string list functions, for general use now, and for >> eventual use in the cpr/live update patches. >> >> Steve Sistare (4): >> qapi: strList_from_string >> qapi: QA

Re: [PATCH V2 1/4] qapi: strList_from_string

On 2/9/2023 11:46 AM, Markus Armbruster wrote: > Steven Sistare writes: > >> On 2/9/2023 5:02 AM, Markus Armbruster wrote: >>> Alex Bennée writes: >>> >>>> Steven Sistare writes: >>>> >>>>> On 2/8/2023 1:43 AM, Marc-André

  1   2   3   4   5   6   >