All the changes look good - steve
On 2/27/2024 10:33 AM, Markus Armbruster wrote:
> This is Steve's work (v1 to v5), tweaked by Philippe (v6), and now by
> me.
>
> v7:
> * Old PATCH 1 dropped
> The proposed str_split() is a composition of g_strsplit() and a
> conversion from char ** to strList *. I'm willing to accept a
> conversion function str_list_from_strv() next to
> strv_from_str_list(). I doubt having a function for the composition
> is worth the trouble.
> * Old PATCH 4 dropped
> The tests mostly test g_strsplit(). I'm willing to accept focused
> tests for strv_from_str_list() and str_list_from_strv().
> * PATCH 1-3: Commit messages tweaked
> * PATCH 2: strv_from_strList() renamed strv_from_str_list(), and moved
> to qapi/qapi-type-helpers.c. Function comment tweaked. Local
> variable @argv renamed to @strv.
> * PATCH 3: Adjust for the rename.
>
> Steve Sistare (3):
> qapi: New QAPI_LIST_LENGTH()
> qapi: New strv_from_str_list()
> migration: simplify exec migration functions
>
> include/qapi/type-helpers.h | 8 ++++++
> include/qapi/util.h | 13 +++++++++
> migration/exec.c | 57 ++++++-------------------------------
> qapi/qapi-type-helpers.c | 14 +++++++++
> 4 files changed, 43 insertions(+), 49 deletions(-)
>
