Trace 0x40e8a420 [7ffe5e98]
Trace 0x40e8b470 [7ffe627d]
My question is that are the numbers in the last column the guest
physical address of the executed instructions? If not, how can I
convert this virtual address to guest physical address?
Could anyone offer some help? Thanks.
- Steven
physical space to store these address for tb? Thanks.
Steven
On Fri, Aug 10, 2012 at 11:47 AM, Peter Maydell
wrote:
> On 10 August 2012 03:11, Steven wrote:
>> The function definition has a return address type tb_page_addr_t.
>> tb_page_addr_t get_page_addr_code(CPUArchState *env1, target_ulong addr)
>>
>> I am wondering is this
On Fri, Aug 10, 2012 at 11:47 AM, Peter Maydell
wrote:
> On 10 August 2012 03:11, Steven wrote:
>> The function definition has a return address type tb_page_addr_t.
>> tb_page_addr_t get_page_addr_code(CPUArchState *env1, target_ulong addr)
>>
>> I am wondering is this
On Fri, Aug 10, 2012 at 10:06 PM, Peter Maydell
wrote:
> On 10 August 2012 19:53, Steven wrote:
>> On Fri, Aug 10, 2012 at 11:47 AM, Peter Maydell
>> wrote:
>>> On 10 August 2012 03:11, Steven wrote:
>>>> The function definition has a return address type
instruction to be
translated
mov0x4(%esp),%edx
I tried to calculate the guest physical address of 0x4(%esp) in
the above in the function of disas_insns(...), is this possible? Or do
you have any other solutions?
Thanks.
Steven
On Sun, Aug 12, 2012 at 12:31 PM, Prathmesh Kallurka
> 2) - 1;
+qemu_log("cpu_A0: %llu\n", a0.i64);
switch(idx & 3) {
case 0:
tcg_gen_qemu_ld8u(t0, a0, mem_index);
}
I saw the value of cpu_A0 is always 23 (in decimal). Is there anything
about this? Or does cpu_A0 have a different meaning? Thanks.
steven
On Wed, Aug 15, 2012 at 4:57 AM, Prathmesh Kallurkar
wrote:
> 1. Did you get the guest physical address for the load/store instructions?
> No, I am getting the guest virtual address for the load and store
> instructions.
>
>
>>
>> 2. The code you pasted seems translated code. The number of input c
Hi,
I tried to trace the quest memory access for the load instructions.
However, it seems that the softmmu of qemu only works when qemu
fetches the guest code, like ldub_code?
Is there any place that will call the softmmu for quest memory access,
like ldub_data? Thanks.
Steven
Hi,
I would like to is there any function that could log the register
content of the guest machine, like "info registers" in the qemu
monitor mode.
Thanks.
steven
On Thu, Aug 16, 2012 at 4:02 AM, 陳韋任 (Wei-Ren Chen)
wrote:
>> I would like to is there any function that could log the register
>> content of the guest machine, like "info registers" in the qemu
>> monitor mode.
>
> Why not check how "info registes" be implemented in QEMU? ;)
> I guess you just
On Thu, Aug 16, 2012 at 12:54 PM, Peter Maydell
wrote:
> On 16 August 2012 17:36, Steven wrote:
>> I would like to get a trace of guest memory access. So I can not use
>> "info registers".
>> What I want to do is that when tcg fetches a load instruction at
>
On Thu, Aug 16, 2012 at 1:15 PM, Peter Maydell wrote:
> On 16 August 2012 18:13, Steven wrote:
>> So the run time function should be tcg_out_qemu_ld, right?
>
> No, tcg_out_qemu_ld is a translate time function, which emits
> the native (x86 in this case) instructions necess
On Thu, Aug 16, 2012 at 1:00 PM, Max Filippov wrote:
> On Thu, Aug 16, 2012 at 8:36 PM, Steven wrote:
>> On Thu, Aug 16, 2012 at 4:02 AM, 陳韋任 (Wei-Ren Chen)
>> wrote:
>>>> I would like to is there any function that could log the register
>>>> content of
On Thu, Aug 16, 2012 at 1:43 PM, Max Filippov wrote:
> On Thu, Aug 16, 2012 at 9:37 PM, Max Filippov wrote:
>> On Thu, Aug 16, 2012 at 9:29 PM, Steven wrote:
>>> On Thu, Aug 16, 2012 at 1:00 PM, Max Filippov wrote:
>>>> On Thu, Aug 16, 2012 at 8:36 PM, Steven wro
On Thu, Aug 16, 2012 at 12:54 PM, Peter Maydell
wrote:
> On 16 August 2012 17:36, Steven wrote:
>> I would like to get a trace of guest memory access. So I can not use
>> "info registers".
>> What I want to do is that when tcg fetches a load instruction at
>
On Thu, Aug 16, 2012 at 2:51 PM, Laurent Desnogues
wrote:
> On Thu, Aug 16, 2012 at 7:49 PM, Steven wrote:
> [...]
>> I want to get the guest memory address in the instruction mov
>> 0x4(%ebx) %eax, whic is 0x4(%ebx).
>> Since %ebx is not resolved until the exe
Hi, Max,
I appreciate your help and got some results using your patch. But I
still have two questions as blow.
>> I see that with the following patch
>>
>> diff --git a/softmmu_template.h b/softmmu_template.h
>> index b8bd700..2d02133 100644
>> --- a/softmmu_template.h
>> +++ b/softmmu_template.h
lts. Is there anything wrong? or could you explain this? Thanks.
steven
On Fri, Aug 17, 2012 at 7:57 AM, Max Filippov wrote:
> On Fri, Aug 17, 2012 at 3:14 PM, 陳韋任 (Wei-Ren Chen)
> wrote:
>>> > On Thu, Aug 16, 2012 at 7:49 PM, Steven wrote:
>>> > [...]
>
Hi, Xin,
Try Max's patch
http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03226.html
I used it to get all the guest virtual address because this patch
disable the fast mmu path.
Steven
On Thu, Aug 23, 2012 at 12:18 PM, Xin Tong wrote:
> On Thu, Aug 23, 2012 at 8:52 AM, Peter
On Sat, Aug 25, 2012 at 4:41 PM, Max Filippov wrote:
> On Sat, Aug 25, 2012 at 9:20 PM, Steven wrote:
>> On Tue, Aug 21, 2012 at 3:18 AM, Max Filippov wrote:
>>> On Tue, Aug 21, 2012 at 9:40 AM, Steven wrote:
>>>> Hi, Max,
>>>> I wrote a small progra
I added a special opcode, which is not used by existing x86. When the
process in the guest issues this opcode, the qemu starts to log its
mmu access.
On Mon, Aug 27, 2012 at 11:14 PM, 陳韋任 (Wei-Ren Chen)
wrote:
>> My final goal is to obtain the memory access trace for a particular
>> process in
Dear KVM developers:
I am trying use perf stat inside a VM to obtain some hardware cache
performance counter values.
The perf stat can report some numbers for L1 and TLB related counters. But
for the LLC-loads and LLC-load-misses, the numbers are always 0. It seems
that the these offcore events are
Hi, Kan,
Thanks for your reply.
1. If the guest is non-paravirt, can I get the LLC-loads number?
2. Do you know any method that can capture the LLC-loads for the guest?
Thanks.
- Hui
On Wed, Aug 27, 2014 at 9:05 AM, Liang, Kan wrote:
>
>
>>
>> Dear KVM developers:
>> I am trying use perf stat i
Hi, Kan,
Thanks for your reply.
1. If the guest is non-paravirt, can I get the LLC-loads number?
2. Do you know any method that can capture the LLC-loads for the guest? Thanks.
- Hui
On Wed, Aug 27, 2014 at 9:05 AM, Liang, Kan wrote:
>
>
>
> >
> > Dear KVM developers:
> > I am trying use perf
Hi, Kan,
The dTLB-load-misses is 0, but it shows 80.00%hit, does that mean the
TLB-load miss is 0.8 * (dTLB-loads). Thanks.
Performance counter stats for './parsecmgmt -a run -i native -c
gcc-hooks -n 1 -p freqmine':
0 dTLB-load-misses #0.00% of all dTLB
cache hit
Inside the guest, I am using "perf stat -e dTLB-load-misses -e
dTLB-loads -e L1-dcache-loads -e L1-dcache-load-misses -e
L1-dcache-prefetch-misses ", followed by the parsec command.
Thanks.
- Hui
On Wed, Aug 27, 2014 at 12:28 PM, Liang, Kan wrote:
>
>> > Hi, Kan,
>> >
>> > The dTLB-load-misses
ent on this? Thanks in advance.
- Steven
Signed-off-by: Steven Luo
---
This prevents a crash that would be exposed by a later patch in this
series. The removed check for non-null is clearly wrong, as it comes
after the pointer has already been dereferenced in this function.
slirp/tcp_subr.c | 7 +--
1 file changed, 5 insertions
with Linux and Windows 7 guests.
Edgar E. Iglesias (1):
slirp: Propagate host TCP RST to the guest.
Steven Luo (2):
slirp: don't crash when tcp_sockclosed() is called with a NULL tp
slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets
slirp/socket.c| 17 ++
this case.
Signed-off-by: Steven Luo
---
slirp/socket.c| 2 +-
slirp/tcp_input.c | 6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/slirp/socket.c b/slirp/socket.c
index 4372ec2..6d22127 100644
--- a/slirp/socket.c
+++ b/slirp/socket.c
@@ -188,7 +188,7 @@ soread(struct s
When the host aborts (RST) it's side of a TCP connection we need to
propagate that RST to the guest. The current code can leave such guest
connections dangling forever. Spotted by Jason Wessel.
[ste...@steven676.net: coding style adjustments]
Signed-off-by: Steven Luo
---
Edgar proposed
Hi all,
Looking at qemu, it seems as if it could be possible to allow it to
run Intel OS X apps on PowerPC OS X, much like a reverse Rosetta. The
x86 frameworks/libraries are included with Xcode, so possibly
everything else could run natively, just have the app itself emulated.
Is anybody willing
proof current Macs a little, as
developers won't offer Universal Binaries forever.
Steve
On 10/21/05, René Korthaus <[EMAIL PROTECTED]> wrote:
>
> Am 21.10.2005 um 22:16 schrieb Steven:
>
> > Hi all,
> >
> > Looking at qemu, it seems as if it could be possibl
On Thu, 2012-08-09 at 18:24 +0900, Masami Hiramatsu wrote:
> Yeah, it is really easy to fix that.
> But out of curiosity, would that be really a problem?
> I guess that host can access any guest page if need. If that
> is right, is that really insecure to leak randomly allocated
> unused page to t
On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote:
> From: Masami Hiramatsu
>
> Use TRACE_DIR environment variable for setting
TRACING_DIR would be better, as we are searching for /debug/tracing and
not /debug/trace. Perhaps DEBUG_TRACING_DIR would be even better as to
be less of a gene
On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote:
> From: Masami Hiramatsu
>
> Count debugfs/tracing/per_cpu/cpu* to determine the
> number of CPUs.
I'm curious, do you find that sysconf doesn't return the # of CPUs the
system has? I've had boxes where the per_cpu/cpu* had more cpus th
On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote:
> Add read path and control path to use trace-agent of virtio-trace.
> When we use trace-agent, trace-cmd will be used as follows:
> # AGENT_READ_DIR=/tmp/virtio-trace/tracing \
> AGENT_CTL=/tmp/virtio-trace/agent-ctl-path.in
On Thu, 2012-08-23 at 12:00 +0900, Masami Hiramatsu wrote:
> (2012/08/23 11:01), Masami Hiramatsu wrote:
> > (2012/08/22 22:41), Steven Rostedt wrote:
> >> On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote:
> >>> From: Masami Hiramatsu
> >>>
&
On Tue, Nov 08, 2011 at 10:32:25AM +0100, Ingo Molnar wrote:
>
> None of the perf developers with whom i'm working complained about
> the shared repo so far - publicly or privately. By all means they are
> enjoying it and if you look at the stats and results you'll agree
> that they are highly
From: Steven Noonan
Signed-off-by: Steven Noonan
Cc: Anthony Liguori
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index bdff4e4..807054b 100644
--- a/Makefile
+++ b/Makefile
@@ -290,7 +290,7 @@ common de-ch es fo fr-ca hu ja
From: Steven Noonan
This is caused by a linux/xattr.h and sys/xattr.h incompatibility:
In file included from
/home/snoonan/Development/qemu/include/qemu/xattr.h:27:0,
from fsdev/virtfs-proxy-helper.c:25:
/usr/include/sys/xattr.h:31:3: error: expected identifier
From: Steven Noonan
The -fstack-protector flag family is useful for ensuring safety and for
debugging, but has a performance impact. Here's a boot time comparison between
a QEMU build of qemu-system-arm with and without the -fstack-protector-all
flag:
# WITHOUT -fstack-protecto
option to disable the stack protector
entirely, and conditional stack protector flag selection (in order, based on
availability): -fstack-protector-strong, -fstack-protector, no stack protector.
Signed-off-by: Steven Noonan
---
configure | 18 +++---
1 file changed, 15 insertions
option to disable the stack protector
entirely, and conditional stack protector flag selection (in order, based on
availability): -fstack-protector-strong, -fstack-protector, no stack protector.
Signed-off-by: Steven Noonan
Cc: Anthony Liguori
Reviewed-by: Stefan Weil
---
configure | 18
Public bug reported:
I am running Ubuntu 15.10 (this issue also exists on 15.04) x64. Desktop
environment to re-produce is either GNOME 3.16 or OpenBox-3.
I have a Windows 8.1 VM that I run with QEMU and I will work out of that
for my job most of the day. When I am going to leave I like to just
c
On Tue, Nov 10, 2015 at 10:52 AM, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> On 10 November 2015 at 17:33, Paolo Bonzini wrote:
>>>
>>>
>>> On 10/11/2015 16:57, Stefan Hajnoczi wrote:
clang 3.7.0 on x86_64 warns about the following:
disas/arm.c:1782:17: warning: shift
On Tue, Nov 10, 2015 at 12:06 PM, Markus Armbruster wrote:
> Steven Noonan writes:
>
>> On Tue, Nov 10, 2015 at 10:52 AM, Markus Armbruster
>> wrote:
>>> Peter Maydell writes:
>>>
>>>> On 10 November 2015 at 17:33, Paolo Bonzini wrote:
>&g
re-worked, and re-based.
Signed-off-by: Steven Newbury
---
hw/acpi/aml-build.c | 19 ---
hw/acpi/core.c | 11 +++
hw/i386/acpi-build.c| 9 -
include/hw/acpi/acpi_slic.h | 11 +++
qemu-options.hx | 2 ++
5 files c
Cc: Igor Mammedov
> Cc: Michael Tokarev
> Cc: Paolo Bonzini
> Cc: Richard W.M. Jones
> Cc: Shannon Zhao
> Cc: Steven Newbury
> Cc: Xiao Guangrong
>
> Thanks
> Laszlo
>
> Laszlo Ersek (4):
> acpi: take oem_id in build_header(), optionally
> acpi: expose
On Tue Jan 19 07:35:27 2016 GMT, Steven Newbury wrote:
>
>
> On Mon Jan 18 14:12:09 2016 GMT, Laszlo Ersek wrote:
> > This is version 2 of
> > <http://thread.gmane.org/gmane.comp.emulators.qemu/386728>.
> >
> > Changes in v2 (also annotated per patch):
&
Thus, it is strongly recommended to assign the splicing
> thread to corresponding node.
>
> Signed-off-by: Masami Hiramatsu
Acked-by: Steven Rostedt
-- Steve
> Cc: Frederic Weisbecker
> Cc: Ingo Molnar
> ---
>
> kernel/trace/trace.c |8 +---
> 1 file
On Fri, 4 Mar 2016 11:19:33 +
Stefan Hajnoczi wrote:
> > 2. Build a trace-cmd-server
> >
> > Which does the following:
> >
> > 1. Receive trace-cmd record commands from a guest,
> > to be performed in the host
>
> Sometimes the opposite is desirable: the host control
On Mon, 7 Mar 2016 15:17:05 +
Stefan Hajnoczi wrote:
> qemu-guest-agent runs inside the guest and replies to RPC commands from
> the host. It is used for backups, shutdown, network configuration, etc.
> From time to time people have wanted the ability to execute an arbitrary
> command insid
On Mon, 7 Mar 2016 09:10:10 -0700
Eric Blake wrote:
> On 03/07/2016 08:49 AM, Steven Rostedt wrote:
> > On Mon, 7 Mar 2016 15:17:05 +
> > Stefan Hajnoczi wrote:
> >
> >
> >> qemu-guest-agent runs inside the guest and replies to RPC commands from
&g
On April 6, 2016 1:36:01 AM PDT, "Edgar E. Iglesias"
wrote:
>Hi Steven,
>
>I don't mind to leave it as is but you could also use the --author
>argument to git commit to keep the authorship as
>edgar.igles...@gmail.com
It looks like an intermediate mail ser
e "might have been removed"? tcp_sockclosed()
doesn't seem to call tcp_close() in every case, so we can get -1 from
soread() without the socket being freed.
> +continue;
> +}
> }
>
> /*
-Steven Luo
Changes from v1:
* added patch 2, a fix for an use-after-free exposed by this series
(thanks Samuel Thibault)
* incorporated Reviewed-by lines
* attributed patches correctly
-Steven Luo
===
QEMU's user-mode networking does not currently pass received TCP RSTs to
guests, meaning
From: Steven Luo
Signed-off-by: Steven Luo
Reviewed-by: Edgar E. Iglesias
---
v1->v2:
* added Reviewed-by line
slirp/tcp_subr.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c
index dbfd2c6..32ff452 100644
--- a/slirp/tcp_sub
From: Edgar E. Iglesias
When the host aborts (RST) it's side of a TCP connection we need to
propagate that RST to the guest. The current code can leave such guest
connections dangling forever. Spotted by Jason Wessel.
[ste...@steven676.net: coding style adjustments]
Signed-off-by: Steve
From: Steven Luo
slirp currently only handles ECONNREFUSED in the case where connect()
returns immediately with that error; since we use non-blocking sockets,
most of the time we won't receive the error until we later try to read
from the socket. Ensure that we deliver the appropriate R
From: Steven Luo
Samuel Thibault pointed out that it's possible that slirp_pollfds_poll()
will try to use a socket even after soread() returns an error, resulting
in an use-after-free if the socket was removed while handling the error.
Avoid this by refusing to continue to work with the s
From: Steven Luo
On my Debian jessie system, including nettle/pbkdf2.h does not cause
NULL to be defined, which causes the test to fail to compile. Include
stddef.h to bring in a definition of NULL.
Cc: qemu-triv...@nongnu.org
Cc: qemu-sta...@nongnu.org
Signed-off-by: Steven Luo
---
I suppose
This is a tested step by step enable the network and audio under vista32 on Xen.
1. Download latest Vista driver for the RTL8139 series cards from the
Realtek site. There is one dated 2007/4/26, version 6.103. I used
this file.
2. Install the files, follow setup. If your Vista crashed, please
Hello, all
Is there anyone interested in the performance of USB under QEMU?
I found that when use OHCI to replace UHCI in qemu, it will improve
the performance of USB storage device. I have tested it, the
performance is almost equal of a real usb device.
The way to do this is making
little change
On 7/26/2022 2:04 PM, John Snow wrote:
> On Tue, Jul 26, 2022 at 12:12 PM Steve Sistare
> wrote:
>>
>> Provide reopen_qmp_connection() to reopen a closed monitor connection.
>> This is needed by cpr, because qemu exec closes the monitor socket.
>>
>> Signed-off-by: Steve Sistare
>> ---
>> python
On 2/25/2024 9:40 PM, Peter Xu wrote:
> On Fri, Feb 23, 2024 at 09:13:24AM -0800, Steve Sistare wrote:
>> A small number of migration options are accessed by migration clients,
>> but to see them clients must include all of options.h, which is mostly
>> for migration core code. migrate_mode() in p
On 2/26/2024 4:01 AM, Peter Xu wrote:
> On Mon, Feb 26, 2024 at 09:49:46AM +0100, Cédric Le Goater wrote:
>> Go ahead. It will help me for the changes I am doing on error reporting
>> for VFIO migration. I will rebase on top.
>
> Thanks for confirming. I queued the migration patches then, but lea
On 2/26/2024 3:21 PM, Steven Sistare wrote:
> On 2/26/2024 4:01 AM, Peter Xu wrote:
>> On Mon, Feb 26, 2024 at 09:49:46AM +0100, Cédric Le Goater wrote:
>>> Go ahead. It will help me for the changes I am doing on error reporting
>>> for VFIO migration. I will reba
On 2/27/2024 3:08 AM, Peter Xu wrote:
> On Mon, Feb 26, 2024 at 09:41:15AM -0500, Steven Sistare wrote:
>> On 2/26/2024 2:40 AM, Markus Armbruster wrote:
>>> Steve Sistare writes:
>>>
>>>> A small number of migration options are accessed by migration cli
On 2/27/2024 10:28 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
>> Hi Markus,
>>
>> Here are the patches I queued until you told me you'd
>> object to the CamelCase filename strList.[ch].
>>
>> Steve, please take over ;)
>
> I'm going to post the part of the series I'm ready t
All the changes look good - steve
On 2/27/2024 10:33 AM, Markus Armbruster wrote:
> This is Steve's work (v1 to v5), tweaked by Philippe (v6), and now by
> me.
>
> v7:
> * Old PATCH 1 dropped
> The proposed str_split() is a composition of g_strsplit() and a
> conversion from char ** to strLis
Please ignore this solo message, I accidentally sent it alone - steve
On 2/27/2024 12:42 PM, Steve Sistare wrote:
> migration/migration.h is the private interface for code in the migration
> sub-directory, but many other clients include it because they need accessors
> that are not exported by the
On 2/28/2024 2:21 AM, Markus Armbruster wrote:
> Steve Sistare writes:
>
>> Fail the migration request if options are set that are incompatible
>> with cpr.
>>
>> Signed-off-by: Steve Sistare
>> ---
>> migration/migration.c | 17 +
>> qapi/migration.json | 2 ++
>> 2 files ch
On 2/28/2024 11:05 AM, Markus Armbruster wrote:
> Steven Sistare writes:
>
>> On 2/28/2024 2:21 AM, Markus Armbruster wrote:
>>> Steve Sistare writes:
>>>
>>>> Fail the migration request if options are set that are incompatible
>>>
Just a reminder, after our further discussion in the V1 thread,
this patch is still what I propose, no updates needed.
Markus, I think Peter is looking for your blessing on the new
file name: include/migration/client-options.h.
- Steve
On 2/26/2024 5:16 PM, Steve Sistare wrote:
> A small number
On 2/29/2024 3:35 AM, Cédric Le Goater wrote:
> Hello Steve,
>
> On 2/22/24 18:28, Steve Sistare wrote:
>> Define entry points to perform per-container cpr-specific initialization
>> and teardown.
>>
>> Signed-off-by: Steve Sistare
>> ---
>> hw/vfio/container.c | 11 ++-
>>
Please ignore this, I will send a V2 that incorporates additional comments from
Markus that I missed in my inbox.
- Steve
On 2/29/2024 9:15 AM, Steve Sistare wrote:
> Re-wrap the cpr-reboot documentation to 70 columns, use '@' for
> cpr-reboot references, and capitalize COLO.
>
> Suggested-by: M
On 2/29/2024 12:40 AM, Peter Xu wrote:
> On Thu, Feb 29, 2024 at 06:31:26AM +0100, Markus Armbruster wrote:
>> Hmm, perhaps Peter can still squash in the corrections before posting
>> his PR. Peter?
>
> The PR was sent yesterday, it's already in PeterM's -staging. I worry it's
> a bit late to ca
On 2/25/2024 9:08 PM, Peter Xu wrote:
> On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote:
>> When migration for cpr is initiated, stop the vm and set state
>> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the
>> possibility of ram and device state being out of sync, an
On 2/20/2024 2:12 AM, Peter Xu wrote:
> On Thu, Feb 08, 2024 at 10:54:02AM -0800, Steve Sistare wrote:
>> Check the status returned by migration notifiers and report errors.
>> If notifiers fail, call the notifiers again so they can clean up.
>> None of the notifiers return an error status at this
On 2/20/2024 2:33 AM, Peter Xu wrote:
> On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote:
>> When migration for cpr is initiated, stop the vm and set state
>> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the
>> possibility of ram and device state being out of sync, an
On 2/20/2024 2:49 AM, Peter Xu wrote:
> On Thu, Feb 08, 2024 at 10:53:53AM -0800, Steve Sistare wrote:
>> Allow cpr-reboot for vfio if the guest is in the suspended runstate. The
>> guest drivers' suspend methods flush outstanding requests and re-initialize
>> the devices, and thus there is no dev
On 2/21/2024 10:54 AM, Fabiano Rosas wrote:
> Fabiano Rosas writes:
>
>> Steve Sistare writes:
>>
>>> Simplify the exec migration code by using list utility functions.
>>>
>>> As a side effect, this also fixes a minor memory leak. On function return,
>>> "g_auto(GStrv) argv" frees argv and each
On 2/21/2024 8:29 AM, Markus Armbruster wrote:
> I apologize for the lateness of my review.
No problem. Thanks for the review.
> Steve Sistare writes:
>
>> Generalize hmp_split_at_comma() to take any delimiter string, rename
>> as strList_from_string(), and move it to util/strList.c.
>>
>> No
On 2/21/2024 8:19 AM, Markus Armbruster wrote:
> Steve Sistare writes:
>
>> Signed-off-by: Steve Sistare
>> Reviewed-by: Marc-André Lureau
>> ---
>> tests/unit/meson.build| 1 +
>> tests/unit/test-strList.c | 80
>> +++
>> 2 files changed, 81 i
On 2/21/2024 8:14 AM, Markus Armbruster wrote:
> Steve Sistare writes:
>
>> Signed-off-by: Steve Sistare
>> Reviewed-by: Marc-André Lureau
>> ---
>> include/qemu/strList.h | 6 ++
>> util/strList.c | 14 ++
>> 2 files changed, 20 insertions(+)
>>
>> diff --git a/includ
On 2/21/2024 8:29 AM, Markus Armbruster wrote:
> Steve Sistare writes:
>
>> Signed-off-by: Steve Sistare
>> Reviewed-by: Marc-André Lureau
>> ---
>> include/qapi/util.h | 13 +
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/include/qapi/util.h b/include/qapi/util.h
>> index
Hi Alex, any comments or RB on this or patch 11? The last few changes I am
making for Peter will not change this patch.
- Steve
On 2/8/2024 1:54 PM, Steve Sistare wrote:
> Allow cpr-reboot for vfio if the guest is in the suspended runstate. The
> guest drivers' suspend methods flush outstandin
On 2/20/2024 2:33 AM, Peter Xu wrote:
> On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote:
>> When migration for cpr is initiated, stop the vm and set state
>> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the
>> possibility of ram and device state being out of sync, an
On 2/20/2024 2:33 AM, Peter Xu wrote:
> On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote:
>> When migration for cpr is initiated, stop the vm and set state
>> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the
>> possibility of ram and device state being out of sync, an
On 2/22/2024 4:03 AM, Peter Xu wrote:
> On Wed, Feb 21, 2024 at 04:23:07PM -0500, Steven Sistare wrote:
>>> How about postcopy? I know it's nonsense to enable postcopy for cpr.. but
>>> iiuc we don't yet forbid an user doing so. Maybe
On 2/22/2024 4:30 AM, Peter Xu wrote:
> On Thu, Feb 22, 2024 at 05:12:53PM +0800, Peter Xu wrote:
>> On Wed, Feb 21, 2024 at 04:20:07PM -0500, Steven Sistare wrote:
>>> On 2/20/2024 2:33 AM, Peter Xu wrote:
>>>> On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sista
Peter (and David if interested): these patches still need RB:
migration: notifier error checking
migration: stop vm for cpr
migration: update cpr-reboot description
migration: options incompatible with cpr
Alex, these patches still need RB:
vfio: register container for cpr
vfio: allow
On 2/21/2024 12:01 PM, Steven Sistare wrote:
> On 2/21/2024 8:29 AM, Markus Armbruster wrote:
>> I apologize for the lateness of my review.
>
> No problem. Thanks for the review.
>
>> Steve Sistare writes:
>>
>>> Generalize hmp_split_at_comma() to t
On 2/23/2024 1:01 AM, Philippe Mathieu-Daudé wrote:
> On 22/2/24 22:47, Steve Sistare wrote:
>> Generalize hmp_split_at_comma() to take any delimiter string, rename
>> as str_split(), and move it to util/strList.c.
>>
>> No functional change.
>>
>> Signed-off-by: Steve Sistare
>> ---
>> include/
On 2/23/2024 12:41 PM, Philippe Mathieu-Daudé wrote:
> On 23/2/24 15:01, Steven Sistare wrote:
>> On 2/23/2024 1:01 AM, Philippe Mathieu-Daudé wrote:
>>> On 22/2/24 22:47, Steve Sistare wrote:
>>>> Generalize hmp_split_at_comma() to take any delimiter string, rename
On 2/26/2024 2:40 AM, Markus Armbruster wrote:
> Steve Sistare writes:
>
>> A small number of migration options are accessed by migration clients,
>> but to see them clients must include all of options.h, which is mostly
>> for migration core code. migrate_mode() in particular will be needed by
Thanks for trying a V6 Philippe. I'll take it from here. It helps to know
that someone besides me thinks these functions are worth having.
- Steve
On 2/26/2024 9:11 AM, Philippe Mathieu-Daudé wrote:
> Hi Markus,
>
> Here are the patches I queued until you told me you'd
> object to the CamelCas
On 2/12/2024 4:24 AM, David Hildenbrand wrote:
> On 08.02.24 19:54, Steve Sistare wrote:
>> Check the status returned by migration notifiers and report errors.
>> If notifiers fail, call the notifiers again so they can clean up.
>
> IIUC, if any of the notifiers will actually start to fail, say, d
1 - 100 of 945 matches
Mail list logo
