Re: [Qemu-devel] [PATCH v3 0/4] Convert to realize()

2016-01-06 Thread Stefano Stabellini
On Wed, 6 Jan 2016, Cao jin wrote: > v3 changelog: > 1. use following style when we want to check the returned error > > Error *err = NULL; > foo(arg, &err); > if (err) { > handle the error... > error_propagate(errp, err); > } > > Cao jin (4): > Add Error *

Re: [Qemu-devel] [PATCH 03/22] 9pfs: rename virtio-9p-handle.c to 9p-handle.c

2016-01-06 Thread Stefano Stabellini
Wrong subject line: you are renaming virtio-9p-local.c On Tue, 5 Jan 2016, Wei Liu wrote: > This file is not virtio specific. Rename it to use generic name. > > Fix comment and remove unneeded inclusion of virtio.h. > > Signed-off-by: Wei Liu > --- > hw/9pfs/{virtio-9p-local.c => 9p-local.c} |

[Qemu-devel] [PATCH] xenfb.c: avoid expensive loops when prod <= out_cons

2016-01-06 Thread Stefano Stabellini
If the frontend sets out_cons to a value higher than out_prod, it will cause xenfb_handle_events to loop about 2^32 times. Avoid that by using better checks at the beginning of the function. Signed-off-by: Stefano Stabellini diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 4e2a27a

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-06 Thread Stefano Stabellini
gt; let me introduce you to Xudong from Intel, who is willing to help out. > Best Regards > Lars > > > On 4 Jan 2016, at 15:41, Stefano Stabellini > > wrote: > > > > On Mon, 4 Jan 2016, Lars Kurth wrote: > >> On 04/01/2016 14:47, "Stefano Stabellini&quo

Re: [Qemu-devel] [Xen-devel] [PATCH] xenfb.c: avoid expensive loops when prod <= out_cons

2016-01-06 Thread Stefano Stabellini
On Wed, 6 Jan 2016, David Vrabel wrote: > On 06/01/16 12:08, Stefano Stabellini wrote: > > If the frontend sets out_cons to a value higher than out_prod, it will > > cause xenfb_handle_events to loop about 2^32 times. Avoid that by using > > better checks at the beginning of t

Re: [Qemu-devel] [Xen-devel] [PATCH v3 02/11] pc: remove has_igd_gfx_passthru global

2016-01-06 Thread Stefano Stabellini
On Tue, 5 Jan 2016, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Stefano Stabellini > hw/xen/xen_pt.h | 5 +++-- > vl.c| 10 -- > 2 files changed, 3 insertions(+), 12 deletions(-) > > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt

Re: [Qemu-devel] [PATCH v3 04/11] igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to realize

2016-01-06 Thread Stefano Stabellini
On Tue, 5 Jan 2016, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Stefano Stabellini > hw/pci-host/igd.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c > index ef0273b..d1eeafb 100

Re: [Qemu-devel] [PATCH v3 05/11] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize

2016-01-06 Thread Stefano Stabellini
On Tue, 5 Jan 2016, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/pci-host/igd.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c > index d1eeafb..6f52ab1 100644 > --- a/hw/pci-host/igd.c > +++ b/hw/pci-host/igd.c > @@ -53,1

Re: [Qemu-devel] [PATCH v3 06/11] igd: use defines for standard pci config space offsets

2016-01-06 Thread Stefano Stabellini
On Tue, 5 Jan 2016, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Stefano Stabellini > hw/pci-host/igd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c > index 6f52ab1..0784128 100

Re: [Qemu-devel] [PATCH v3 07/11] igd: revamp host config read

2016-01-06 Thread Stefano Stabellini
On Tue, 5 Jan 2016, Gerd Hoffmann wrote: > Move all work to the host_pci_config_copy helper function, > which we can easily reuse when adding q35 support. > Open sysfs file only once for all values. Use pread. > Proper error handling. Fix bugs: > > * Don't throw away results (like old host_pci_

Re: [Qemu-devel] [PATCH v3 10/11] igd: handle igd-passthrough-isa-bridge setup in realize()

2016-01-06 Thread Stefano Stabellini
On Tue, 5 Jan 2016, Gerd Hoffmann wrote: > That way a simple '-device igd-passthrough-isa-bridge,addr=1f' will > do the setup. Is this going to change the QEMU command line arguments to use it? > Also instead of looking up reasonable PCI IDs based on the graphic > device id simply copy over the

Re: [Qemu-devel] [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init

2016-01-06 Thread Stefano Stabellini
On Tue, 5 Jan 2016, Gerd Hoffmann wrote: > This patch moves igd-passthrough-isa-bridge creation out of the xen > passthrough code into machine init. It is triggered by the > igd-passthru=on machine option. Advantages: > > * This works for on both xen and kvm. > * It is activated for the pc mac

Re: [Qemu-devel] [PATCH v3 0/4] Convert to realize()

2016-01-06 Thread Stefano Stabellini
On Wed, 6 Jan 2016, Eric Blake wrote: > On 01/06/2016 04:08 AM, Stefano Stabellini wrote: > > On Wed, 6 Jan 2016, Cao jin wrote: > >> v3 changelog: > >> 1. use following style when we want to check the returned error > >> > >> Error *err = NULL

Re: [Qemu-devel] [Xen-devel] [PATCH v3 07/11] igd: revamp host config read

2016-01-06 Thread Stefano Stabellini
On Wed, 6 Jan 2016, Gerd Hoffmann wrote: > > > +for (i = 0; i < len; i++) { > > > +rc = pread(config_fd, guest->config + list[i].offset, > > > + list[i].len, list[i].offset); > > > +if (rc != list[i].len) { > > > > pread is allowed to return early, returning t

[Qemu-devel] [PATCH v2] xenfb.c: avoid expensive loops when prod <= out_cons

2016-01-06 Thread Stefano Stabellini
If the frontend sets out_cons to a value higher than out_prod, it will cause xenfb_handle_events to loop about 2^32 times. Avoid that by using better checks at the beginning of the function. Signed-off-by: Stefano Stabellini Reported-by: Ling Liu --- diff --git a/hw/display/xenfb.c b/hw

Re: [Qemu-devel] [PATCH 00/22] 9pfs: disentangling virtio and generic code

2016-01-07 Thread Stefano Stabellini
tests. > > Xen transport is still under development. I figure it would be better to post > this series as soon as possible because rebasing such huge series from time to > time is prone to error. > > Comments are welcome. Thanks! > > Wei. > --- > Cc: "Anee

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-07 Thread Stefano Stabellini
On Thu, 7 Jan 2016, Gerd Hoffmann wrote: > On Do, 2016-01-07 at 15:01 +0000, Stefano Stabellini wrote: > > Your patch is simpler and more mature. Maybe it should go in before Gerd's > > series? > > My series would throw away most of the error handling fixes here, so >

Re: [Qemu-devel] [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init

2016-01-08 Thread Stefano Stabellini
On Thu, 7 Jan 2016, Gerd Hoffmann wrote: > On Do, 2016-01-07 at 13:10 +0000, Stefano Stabellini wrote: > > CC'ing the Xen x86 maintainers > > > > On Thu, 7 Jan 2016, Gerd Hoffmann wrote: > > > Hi, > > > > > > > One thing I don&

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-08 Thread Stefano Stabellini
e need to provide to igd passthrough with the latest QEMU release (2.5). On Thu, 7 Jan 2016, Hao, Xudong wrote: > Sure. I'll test it soon. > > Thanks, > -Xudong > > > -----Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] >

Re: [Qemu-devel] [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init

2016-01-08 Thread Stefano Stabellini
On Fri, 8 Jan 2016, Stefano Stabellini wrote: > > > > xen_pt_initfn checks that igd-passthru=on is set in case it finds a igd > > > > device is assigned, that will make sure the igd-isa-bridge is present. > > > > > > > > But, yes, you can creat

Re: [Qemu-devel] [PATCH v3 11/11] igd: move igd-passthrough-isa-bridge creation to machine init

2016-01-08 Thread Stefano Stabellini
On Fri, 8 Jan 2016, Gerd Hoffmann wrote: > Hi, > > > > That is true. Given that the only qemu-xen codebase with igd support is > > > 4.7 and 4.7 hasn't been released yet, I am OK with changing the guest > > > visible PCI layout. I might ask for your help in backporting the patches > > > ;-) > >

Re: [Qemu-devel] [PULL 07/13] msix: fix msix_vector_masked

2016-02-19 Thread Stefano Stabellini
th pci_get_log > since the format is pci little-endian. > > Reported-by: "Daniel P. Berrange" > Cc: Stefano Stabellini > Signed-off-by: Michael S. Tsirkin the follow up patch is missing from the pull request: http://marc.info/?l=xen-devel&m=145553838801725&a

Re: [Qemu-devel] [PULL 07/13] msix: fix msix_vector_masked

2016-02-19 Thread Stefano Stabellini
On Fri, 19 Feb 2016, Peter Maydell wrote: > On 19 February 2016 at 12:18, Stefano Stabellini > wrote: > > On Fri, 19 Feb 2016, Michael S. Tsirkin wrote: > >> commit 428c3ece97179557f2753071fb0ca97a03437267 ("fix MSI injection on > >> Xen") > >

Re: [Qemu-devel] [PATCH RFC 1/6] xen/pt: Update comments with proper function name.

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > It has changed but the comments still refer to the old names. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Stefano Stabellini > hw/xen/xen_pt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [Qemu-devel] [PATCH RFC 2/6] xen/pt: Make xen_pt_msi_set_enable static

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > As we do not use it outside our code. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Stefano Stabellini > hw/xen/xen_pt.h | 1 - > hw/xen/xen_pt_msi.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH RFC 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure

2015-07-01 Thread Stefano Stabellini
Rzeszutek Wilk Reviewed-by: Stefano Stabellini > hw/xen/xen_pt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index 706e3d9..ea1ceda 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -716,7 +716,7 @

Re: [Qemu-devel] [PATCH RFC 4/6] xen: Print and use errno where applicable.

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > In Xen 4.6 commit cd2f100f0f61b3f333d52d1737dd73f02daee592 > "libxc: Fix do_memory_op to return negative value on errors" > made the libxc API less odd-ball: On errors, return value is > -1 and error code is in errno. On success the return value >

Re: [Qemu-devel] [PATCH RFC 6/6] xen: Add backtrace for serious issues.

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > When debugging issues that caused the emulator to kill itself > or skipping certain operations (unable to write to host > registers) an stack trace will most definitly aid in debugging > the problem. > > As such this patch uses the most basic bac

Re: [Qemu-devel] [PATCH RFC 1 1/8] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > During init time we treat the dev.config area as a cache > of the host view. However during execution time we treat it > as guest view (by the generic PCI API). We need to sync Xen's > code to the generic PCI API view. This is the first step > by

Re: [Qemu-devel] [PATCH RFC 1 2/8] xen/pt: Sync up the dev.config and data values.

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > For a passthrough device we maintain a state of emulated > registers value contained within d->config. We also consult > the host registers (and apply ro and write masks) whenever > the guest access the registers. This is done in xen_pt_pci_write_

Re: [Qemu-devel] [PATCH RFC 1 3/8] xen/pt: Check if reg->init is past the reg->size

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > It should never happen, but in case it does we want to > report. The code will only write up to reg->size so there > is no runtime danger. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > hw/xen/xen_pt_config_init.c | 8 ++-- > 1 file chang

Re: [Qemu-devel] [PATCH RFC 1 4/8] xen/pt: Log xen_host_pci_get in two init functions

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > To help with troubleshooting in the field. > > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini > hw/xen/xen_pt_config_init.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/hw/xen/x

Re: [Qemu-devel] [PATCH RFC 1 5/8] xen/pt: Log xen_host_pci_get/set errors in MSI code.

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > We seem to only use these functions when de-activating the > MSI - so just log errors. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Stefano Stabellini > hw/xen/xen_pt_msi.c | 18 ++ > 1 file chan

Re: [Qemu-devel] [PATCH RFC 1 6/8] xen/pt: Make xen_pt_unregister_device idempotent

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > To deal with xen_host_pci_[set|get]_ functions returning error values > and clearing ourselves in the init function we should make the > .exit (xen_pt_unregister_device) function be idempotent in case > the generic code starts calling .exit (or fo

Re: [Qemu-devel] [PATCH RFC 1 7/8] xen/pt: Move bulk of xen_pt_unregister_device in its own routine.

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > This way we can call it if we fail during init. > > This code movement introduces no changes. > > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini > hw/

Re: [Qemu-devel] [PATCH RFC 1 8/8] xen/pt: Check for return values for xen_host_pci_[get|set] in init

2015-07-01 Thread Stefano Stabellini
On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > and if we have failures we call xen_pt_destroy introduced in > 'xen/pt: Move bulk of xen_pt_unregister_device in its own routine.' > and free all of the allocated structures. > > Signed-off-by: Konrad Rzeszutek

Re: [Qemu-devel] [v8][RESEND][PATCH 05/10] xen, gfx passthrough: basic graphics passthrough support

2015-07-01 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Tiejun Chen wrote: > basic gfx passthrough support: > - add a vga type for gfx passthrough > - register/unregister legacy VGA I/O ports and MMIOs for passthrough GFX > > Signed-off-by: Tiejun Chen > Signed-off-by: Yang Zhang Acked-by: Stefano Stabel

Re: [Qemu-devel] [v8][RESEND][PATCH 06/10] xen, gfx passthrough: retrieve VGA BIOS to work

2015-07-01 Thread Stefano Stabellini
ff-by: Tiejun Chen Acked-by: Stefano Stabellini > hw/xen/xen_pt.c | 10 ++ > hw/xen/xen_pt.h | 5 +++ > hw/xen/xen_pt_graphics.c | 79 > > 3 files changed, 94 insertions(+) > > diff --git a/hw/xen/xen

Re: [Qemu-devel] [v8][RESEND][PATCH 08/10] xen, gfx passthrough: register a isa bridge

2015-07-01 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Tiejun Chen wrote: > Currently we just register this isa bridge when we use IGD > passthrough in Xen side. > > Signed-off-by: Tiejun Chen > --- > hw/xen/xen_pt.c | 18 ++ > include/hw/xen/xen.h | 1 + > 2 files changed, 19 insertions(+) > > diff --git a

Re: [Qemu-devel] [v8][RESEND][PATCH 10/10] xen, gfx passthrough: add opregion mapping

2015-07-01 Thread Stefano Stabellini
The original patch is from Jean Guyader > > Signed-off-by: Tiejun Chen > Signed-off-by: Yang Zhang Acked-by: Stefano Stabellini > hw/xen/xen_pt.h | 6 +++- > hw/xen/xen_pt_config_init.c | 51 ++-- > hw/xen/xen_pt_graphics.c| 82 >

Re: [Qemu-devel] [v8][RESEND][PATCH 09/10] xen, gfx passthrough: register host bridge specific to passthrough

2015-07-01 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Tiejun Chen wrote: > Just register that pci host bridge specific to passthrough. > > Signed-off-by: Tiejun Chen > --- > hw/i386/pc_piix.c | 27 +-- > 1 file changed, 25 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix

Re: [Qemu-devel] [v8][RESEND][PATCH 00/10] xen: add Intel IGD passthrough

2015-07-01 Thread Stefano Stabellini
Aside from a couple of really minor stylistic issues, I think the patch series can go in from my point of view. However it looks like you are still missing a few acked-by/reviewed-by on the non-xen patches. On Wed, 1 Jul 2015, Chen, Tiejun wrote: > Ping... > > Thanks > Tiejun > > On 2015/6/5 16:

Re: [Qemu-devel] [PATCH RFC 4/6] xen: Print and use errno where applicable.

2015-07-02 Thread Stefano Stabellini
On Wed, 1 Jul 2015, Konrad Rzeszutek Wilk wrote: > On Wed, Jul 01, 2015 at 02:01:07PM +0100, Stefano Stabellini wrote: > > On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: > > > In Xen 4.6 commit cd2f100f0f61b3f333d52d1737dd73f02daee592 > > > "libxc: Fix do_memor

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-13 Thread Stefano Stabellini
On Tue, 13 Nov 2012, Paolo Bonzini wrote: > Il 12/11/2012 20:12, Charles Arnold ha scritto: > > Ping? > > > > Any thoughts on whether this is acceptable? > > I would like to know what is done by other platforms. Stefano, any idea > about XenServer? > I am not sure, but maybe Thanos, that is wo

Re: [Qemu-devel] Question on Xen management of qemu ram blocks and memory regions

2012-11-15 Thread Stefano Stabellini
On Wed, 14 Nov 2012, Andres Lagar-Cavilla wrote: > Stefano, and Xen-qemu team, I have a question. > > The standard Xen-qemu workflow has Xen manage the physmap for a VM, and > allocate all the backing memory for valid pfns, regardless of whether they > are MMIO, RAM, etc. On save/migrate, when u

[Qemu-devel] [PATCH] inet_parse: fix ,to= parsing

2012-11-21 Thread Stefano Stabellini
Fix inet_parse to parse the ",to=" command line option correctly. Signed-off-by: Stefano Stabellini diff --git a/qemu-sockets.c b/qemu-sockets.c index cfed9c5..f8740dd 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -529,8 +529,9 @@ static InetSocketAddress *inet_parse(const

Re: [Qemu-devel] [PATCH 03/14] pixman: windup in configure & makefiles

2012-11-22 Thread Stefano Stabellini
I have just noticed that we haven't actually written anywhere what's the oldest version of pixman we support. Do you know which one it is? On Wed, 17 Oct 2012, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > Makefile |9 + > configure | 38 +++

[Qemu-devel] [PATCH] xen: implement support for secondary consoles in the console backend

2012-11-22 Thread Stefano Stabellini
This patch corresponds to commit 840184a106bc24e745beda5c77e392f6cecd2bc9 from git://xenbits.xensource.com/qemu-xen-unstable.git. Signed-off-by: Stefano Stabellini diff --git a/hw/xen_console.c b/hw/xen_console.c index 9426d73..1349881 100644 --- a/hw/xen_console.c +++ b/hw/xen_console.c

[Qemu-devel] qemu-xen update to QEMU 1.3.0-rc0

2012-11-23 Thread Stefano Stabellini
Hi all, I have just updated the qemu-xen tree (qemu-upstream-unstable.git) that we use with xen-unstable for QEMU development to QEMU 1.3.0-rc0 (plus a couple of commits). After the updated qemu-xen tree manages to pass the required automated tests, I'll send a patch to flip the switch in libxl to

Re: [Qemu-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-11-29 Thread Stefano Stabellini
On Thu, 29 Nov 2012, Xu, Dongxiao wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Tuesday, September 18, 2012 6:24 PM > > To: Xu, Dongxiao > > Cc: Stefano Stabellini; xen-de...@lists.xensource.co

Re: [Qemu-devel] [Xen-devel] [PATCH RFC 1/3] xen_disk: handle disk files on ramfs/tmpfs

2013-01-04 Thread Stefano Stabellini
store. Xen_disk would read the key and sets qflags accordingly. We could use the same cache parameters supported by QEMU, see bdrv_parse_cache_flags. As an alternative, we could reuse the already defined "access" key, like this: access=rw|nocache or access=rw|unsafe > > Signed-off-by

Re: [Qemu-devel] [PATCH RFC 2/3] xen_disk: fix memory leak

2013-01-04 Thread Stefano Stabellini
> Signed-off-by: Roger Pau Monné > Cc: xen-de...@lists.xen.org > Cc: Stefano Stabellini > Cc: Anthony PERARD > Nice catch! Acked-by: Stefano Stabellini > --- > hw/xen_disk.c | 28 ++-- > 1 files changed, 26 insertions(+), 2 deletions(

Re: [Qemu-devel] [Xen-devel] [PATCH RFC 1/3] xen_disk: handle disk files on ramfs/tmpfs

2013-01-04 Thread Stefano Stabellini
On Fri, 4 Jan 2013, Roger Pau Monne wrote: > On 04/01/13 15:54, Stefano Stabellini wrote: > > On Thu, 3 Jan 2013, Ian Campbell wrote: > >> On Mon, 2012-12-31 at 12:16 +, Roger Pau Monne wrote: > >>> Files that reside on ramfs or tmpfs cannot be opened with O_

Re: [Qemu-devel] [PATCH RFC 3/3] xen_disk: add persistent grant support to xen_disk backend

2013-01-04 Thread Stefano Stabellini
scription of the protocol can be found in > the public blkif.h header. it would be great if you could add a link to a webpage too > Speed improvement with 15 guests performing I/O is ~450%. > > Signed-off-by: Roger Pau Monné > Cc: xen-de...@lists.xen.org > Cc: Stefano St

Re: [Qemu-devel] [PATCH RFC 3/3] xen_disk: add persistent grant support to xen_disk backend

2013-01-04 Thread Stefano Stabellini
On Fri, 4 Jan 2013, Roger Pau Monne wrote: > On 04/01/13 17:42, Stefano Stabellini wrote: > > On Mon, 31 Dec 2012, Roger Pau Monne wrote: > >> This protocol extension reuses the same set of grant pages for all > >> transactions between the front/back drivers, avoiding

Re: [Qemu-devel] [PATCH v2] xen_disk: add persistent grant support to xen_disk backend

2013-01-09 Thread Stefano Stabellini
scription of the protocol can be found in > the public blkif.h header. > > http://xenbits.xen.org/gitweb/?p=xen.git;a=blob_plain;f=xen/include/public/io/blkif.h > > Speed improvement with 15 guests performing I/O is ~450%. > > Signed-off-by: Roger Pau Monné > Cc: x

Re: [Qemu-devel] [PATCH v2] xen_disk: add persistent grant support to xen_disk backend

2013-01-09 Thread Stefano Stabellini
On Wed, 9 Jan 2013, Roger Pau Monne wrote: > On 09/01/13 13:48, Stefano Stabellini wrote: > > On Tue, 8 Jan 2013, Roger Pau Monne wrote: > >> This protocol extension reuses the same set of grant pages for all > >> transactions between the front/back drivers, avoiding

[Qemu-devel] [PATCH v2] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2013-01-09 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini Changes in v2: - BLKIF_OP_FLUSH_DISKCACHE implies a preflush, not a postflush. diff --git a/hw/xen_disk.c b/hw/xen_disk.c index a6a64a2..2d0de09 100644 --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -182,12 +182,11 @@ static int ioreq_parse(struct ioreq *ioreq

Re: [Qemu-devel] [Xen-devel] [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2013-01-09 Thread Stefano Stabellini
On Wed, 19 Dec 2012, Konrad Rzeszutek Wilk wrote: > On Wed, May 09, 2012 at 01:42:41PM +0100, Stefano Stabellini wrote: > > On Thu, 26 Apr 2012, Konrad Rzeszutek Wilk wrote: > > > On Wed, Apr 25, 2012 at 01:23:35PM +0200, Christoph Hellwig wrote: > > > > On Wed, Ap

Re: [Qemu-devel] [PATCH] ui/vnc: VA API based H.264 encoding for VNC framebuffer updates

2013-01-10 Thread Stefano Stabellini
On Thu, 10 Jan 2013, Gerd Hoffmann wrote: > On 01/09/13 23:18, Alexander Graf wrote: > > > > On 09.01.2013, at 21:25, Anthony Liguori wrote: > > > >> > >> Since we really can't guarantee that libva will initialize okay, we > >> need to more gracefully handle falling back to another encoding > >>

[Qemu-devel] [PULL] xen_disk fixes and improvements 2013-01-14

2013-01-14 Thread Stefano Stabellini
pull from the following tree based on a507db9599599ce33007b524276a6ea88e521662: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-2013-01-14 Roger Pau Monne (2): xen_disk: fix memory leak xen_disk: add persistent grant support to xen_disk backend Stefano Stabelli

Re: [Qemu-devel] [PATCH 06/20] xen: Simplify halting of first CPU

2013-01-15 Thread Stefano Stabellini
ld in the reset handler. > > Signed-off-by: Andreas Färber Acked-by: Stefano Stabellini > xen-all.c |4 +--- > 1 Datei geändert, 1 Zeile hinzugefügt(+), 3 Zeilen entfernt(-) > > diff --git a/xen-all.c b/xen-all.c > index 19bcfd1..110f958 100644 > --- a/xen-all

Re: [Qemu-devel] [PATCH 06/20] xen: Simplify halting of first CPU

2013-01-15 Thread Stefano Stabellini
On Tue, 15 Jan 2013, Andreas Färber wrote: > Am 15.01.2013 12:03, schrieb Stefano Stabellini: > > On Tue, 15 Jan 2013, Andreas Färber wrote: > >> Use the global first_cpu variable to halt the CPU rather than using a > >> local first_cpu initialized from qemu_get_cpu(0)

Re: [Qemu-devel] [PATCH 05/10] xen_platform: do not use old_portio-style callbacks

2013-01-15 Thread Stefano Stabellini
On Tue, 15 Jan 2013, Andreas Färber wrote: > Stefano, > > Am 12.01.2013 17:06, schrieb Andreas Färber: > > Am 04.01.2013 22:29, schrieb Hervé Poussineau: > >> Signed-off-by: Hervé Poussineau > >> --- > >> hw/xen_platform.c | 21 ++--- > >> 1 file changed, 10 insertions(+), 11 d

Re: [Qemu-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly.

2013-03-19 Thread Stefano Stabellini
On Fri, 15 Mar 2013, Frediano Ziglio wrote: > Modern notebook support 136x768 resolution. The resolution width is ^this can't be right > not multiple of 16 causing some problems. > > Qemu VGA emulation require width resolution to be multiple of 8. > > VNC implementati

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-19 Thread Stefano Stabellini
On Tue, 19 Mar 2013, Paolo Bonzini wrote: > Il 19/03/2013 11:06, George Dunlap ha scritto: > > On Mon, Mar 18, 2013 at 6:00 PM, Paolo Bonzini wrote: > >> Il 18/03/2013 18:38, George Dunlap ha scritto: > > > This might be a difference between Xen and KVM. On Xen migration is > made to

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-19 Thread Stefano Stabellini
On Tue, 19 Mar 2013, Paolo Bonzini wrote: > Il 19/03/2013 16:13, Stefano Stabellini ha scritto: > > This patch only impacts the PV backend in QEMU, not the IDE interface. > > PV frontends and backends always disconnect and reconnect during > > save/restore. > >

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-20 Thread Stefano Stabellini
On Tue, 19 Mar 2013, Alex Bligh wrote: > Stefano, George, > > > This patch only impacts the PV backend in QEMU, not the IDE interface. > > PV frontends and backends always disconnect and reconnect during > > save/restore. > > So we can be *certain* that bdrv_close at the sender side is called > >

Re: [Qemu-devel] [Xen-devel] frequently ballooning results in qemu exit

2013-03-29 Thread Stefano Stabellini
On Mon, 25 Mar 2013, Hanweidong wrote: > We fixed this issue by below patch which computed the correct size for > test_bits(). qemu_get_ram_ptr() and qemu_safe_ram_ptr() will call > xen_map_cache() with size is 0 if the requested address is in the RAM. Then > xen_map_cache() will pass the size 0

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-29 Thread Stefano Stabellini
On Wed, 20 Mar 2013, Paolo Bonzini wrote: > Il 20/03/2013 09:33, Alex Bligh ha scritto: > > Stefano, > > > > --On 19 March 2013 15:13:29 +0000 Stefano Stabellini > > wrote: > > > >> Therefore I think that the current change is not safe, but it is prett

Re: [Qemu-devel] [Xen-devel] frequently ballooning results in qemu exit

2013-04-01 Thread Stefano Stabellini
On Sat, 30 Mar 2013, Hanweidong wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 2013年3月29日 20:37 > > To: Hanweidong > > Cc: Tim (Xen.org); George Dunlap; Andrew Cooper; Yanqiangjun; qemu

Re: [Qemu-devel] [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect

2013-04-01 Thread Stefano Stabellini
On Mon, 1 Apr 2013, Alex Bligh wrote: > This commit delays the point at which bdrv_new (and hence blk_open > on the underlying device) is called from blk_init to blk_connect. > This ensures that in an inbound live migrate, the block device is > not opened until it has been closed at the other end.

Re: [Qemu-devel] [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect

2013-04-02 Thread Stefano Stabellini
On Mon, 1 Apr 2013, Alex Bligh wrote: > Stefano, > > --On 1 April 2013 16:44:05 +0100 Stefano Stabellini > wrote: > > >> Note this patch is compile-tested only. > > > > I think the patch looks good, just a minor comment. > > Thanks. I gu

[Qemu-devel] [PATCH 2/2] xen-mapcache: pass the right size argument to test_bits

2013-04-02 Thread Stefano Stabellini
>> XC_PAGE_SHIFT as its size. Signed-off-by: Zhenguo Wang Signed-off-by: Weidong Han Signed-off-by: Stefano Stabellini --- xen-mapcache.c | 26 ++ 1 files changed, 22 insertions(+), 4 deletions(-) diff --git a/xen-mapcache.c b/xen-mapcache.c index a80cbdb..5a626cd

[Qemu-devel] [PATCH 1/2] xen-mapcache: replace last_address_index with a last_entry pointer

2013-04-02 Thread Stefano Stabellini
Replace last_address_index and last_address_vaddr with a single pointer to the last MapCacheEntry used. Signed-off-by: Stefano Stabellini --- xen-mapcache.c | 34 -- 1 files changed, 16 insertions(+), 18 deletions(-) diff --git a/xen-mapcache.c b/xen

Re: [Qemu-devel] [Xen-devel] frequently ballooning results in qemu exit

2013-04-02 Thread Stefano Stabellini
On Tue, 2 Apr 2013, Hanweidong wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 2013年4月1日 22:39 > > To: Hanweidong > > Cc: Stefano Stabellini; Tim (Xen.org); George Dunlap; Andrew Cooper; > >

Re: [Qemu-devel] [PATCH 5/5] configure: CONFIG_NO_XEN is duplicated

2013-04-02 Thread Stefano Stabellini
On Tue, 2 Apr 2013, Paolo Bonzini wrote: > We already define it in Makefile.target. But we need to avoid a > curious double negation in order to eliminate it. > > Signed-off-by: Paolo Bonzini Tested-by: Stefano Stabellini > configure | 3 --- > hw/xen.h | 2 +- >

Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2

2013-04-02 Thread Stefano Stabellini
On Tue, 2 Apr 2013, Paolo Bonzini wrote: > This is part 2 of the reorganization. Following the discussion > of March 18 between me and Peter, the ARM CPU cores are in hw/cpu > (the i386 ICC device will also go there). > > The following changes since commit 5d45de9796539f95eb6b1201588362981f8cb2d4

Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2

2013-04-02 Thread Stefano Stabellini
On Tue, 2 Apr 2013, Paolo Bonzini wrote: > Il 02/04/2013 19:01, Stefano Stabellini ha scritto: > > On Tue, 2 Apr 2013, Paolo Bonzini wrote: > >> This is part 2 of the reorganization. Following the discussion > >> of March 18 between me and Peter, the ARM CPU cores are i

Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2

2013-04-02 Thread Stefano Stabellini
On Tue, 2 Apr 2013, Paolo Bonzini wrote: > Il 02/04/2013 19:46, Stefano Stabellini ha scritto: > > This is what I get with the new branch: > > > > In file included from tpm/tpm_int.h:16, > > from tpm/tpm.c:19: > > ./tpm/tpm_tis.h:41: error: redefi

Re: [Qemu-devel] [Xen-devel] frequently ballooning results in qemu exit

2013-04-03 Thread Stefano Stabellini
On Wed, 3 Apr 2013, Hanweidong wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 2013年4月2日 21:28 > > To: Hanweidong > > Cc: Stefano Stabellini; Tim (Xen.org); George Dunlap; Andrew Cooper; > >

[Qemu-devel] [PULL] Xen mapcache fixes 2013-04-03

2013-04-03 Thread Stefano Stabellini
Hi Anthony, please pull from the following tree based on 162cbbd1736de2bca43fdefa7e98c54a361ee60d: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-2013-04-03 Hanweidong (1): xen-mapcache: pass the right size argument to test_bits Stefano Stabellini (1): xen-mapcache

Re: [Qemu-devel] [PATCH 1/2] Introduce 64 bit integer write interface to xenstore

2013-04-03 Thread Stefano Stabellini
t; This patch also fixes the size of the char arrays used to represent > these integers as strings (originally 32 bytes, however no more than > 12 bytes are needed for 32 bit integers and no more than 21 bytes are > needed for 64 bit integers). > > Signed-off-by: Felipe Francio

Re: [Qemu-devel] [PATCH 0/2] Allow xen guests to plug disks of 1 TiB or more

2013-04-03 Thread Stefano Stabellini
On Wed, 3 Apr 2013, Felipe Franciosi wrote: > This series fixes an issue where disks of 1 TiB or more cannot be added > to a xen guest. The problem lies in the xen backend driver using a 32 bit > integer xenstore interface to write the number of sectors corresponding > to the file or device that re

Re: [Qemu-devel] [PATCH 2/2] Allow xen guests to plug disks of 1 TiB or more

2013-04-03 Thread Stefano Stabellini
s (file_size/block_size) to xenstore, however, it > passes these values as 32 bit signed integers. This will cause an > overflow for any disk of 1 TiB or more. > > This patch changes the xen backend driver to use a 64 bit integer write > xenstore function. > > Signed-off-by: Fel

Re: [Qemu-devel] [PATCH 20/24] xen: re-enable refresh interval reporting for xenfb

2013-04-04 Thread Stefano Stabellini
On Thu, 4 Apr 2013, Gerd Hoffmann wrote: > xenfb informs the guest about the gui refresh interval so it can avoid > pointless work. That logic was temporarely disabled for the > DisplayState reorganization. Restore it now, with a proper interface > for it. > > Signed-off-by: Gerd Hoffmann > ---

Re: [Qemu-devel] [PATCH 20/24] xen: re-enable refresh interval reporting for xenfb

2013-04-05 Thread Stefano Stabellini
On Fri, 5 Apr 2013, Gerd Hoffmann wrote: > >> -#else > >>; /* nothing */ > >> -#endif > >> } else { > >>/* we don't get update notifications, thus use the > >> * sledge hammer approach ... */ > > > > You might as well remove the if () nothing; case. > > Yep, will do. > > >> @@ -

Re: [Qemu-devel] [PATCHv2 1/2] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect

2013-04-05 Thread Stefano Stabellini
On Fri, 5 Apr 2013, Alex Bligh wrote: > This commit delays the point at which bdrv_new (and hence blk_open > on the underlying device) is called from blk_init to blk_connect. > This ensures that in an inbound live migrate, the block device is > not opened until it has been closed at the other end.

[Qemu-devel] [PULL] xen_disk fixes 2013-04-05

2013-04-05 Thread Stefano Stabellini
Hi Anthony, please pull from the following tree based on d05ef160453e98546a4197496dc8a3cb2defac53: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-2013-04-05 Alex Bligh (2): Xen PV backend: Move call to bdrv_new from blk_init to blk_connect Xen PV backend: Disable use of O_D

Re: [Qemu-devel] [PULL] xen_disk fixes 2013-04-05

2013-04-05 Thread Stefano Stabellini
On Fri, 5 Apr 2013, Alex Bligh wrote: > Stefano, > > --On 5 April 2013 16:51:24 +0100 Stefano Stabellini > wrote: > > > Hi Anthony, > > please pull from the following tree based on > > d05ef160453e98546a4197496dc8a3cb2defac53: > > > > git://xenbi

Re: [Qemu-devel] [PATCH 0/2] Allow xen guests to plug disks of 1 TiB or more

2013-04-05 Thread Stefano Stabellini
Ian, you might want to apply these two fixes to qemu-xen-traditional. On Wed, 3 Apr 2013, Felipe Franciosi wrote: > This series fixes an issue where disks of 1 TiB or more cannot be added > to a xen guest. The problem lies in the xen backend driver using a 32 bit > integer xenstore interface to w

[Qemu-devel] [PATCH 0/3] Xen related fixes

2013-05-27 Thread Stefano Stabellini
two patches should be backported to older branches. Stefano Stabellini (3): qemu_chr_new_from_opts: do not overwrite existing chr->filename xen: simplify xen_enabled main_loop: do not set nonblocking if xen_enabled() include/hw/xen/xen.h |4 qemu-char.c |

[Qemu-devel] [PATCH 1/3] qemu_chr_new_from_opts: do not overwrite existing chr->filename

2013-05-27 Thread Stefano Stabellini
d-off-by: Stefano Stabellini --- qemu-char.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 4f8382e..06ffd93 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3276,7 +3276,6 @@ CharDriverState *qemu_chr_new_from_opts(QemuOpts

[Qemu-devel] [PATCH 3/3] main_loop: do not set nonblocking if xen_enabled()

2013-05-27 Thread Stefano Stabellini
Please backport this patch to stable branches. Signed-off-by: Stefano Stabellini CC: qemu-sta...@nongnu.org --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 510d2c2..47ab45d 100644 --- a/vl.c +++ b/vl.c @@ -2022,7 +2022,7 @@ static void

[Qemu-devel] [PATCH 2/3] xen: simplify xen_enabled

2013-05-27 Thread Stefano Stabellini
No need for preprocessor conditionals in xen_enabled: xen_allowed is always defined. Please backport this patch to stable branches (it is needed by the following patch to remove the dependency on a preprocessor identifier defined by config-target.h). Signed-off-by: Stefano Stabellini CC: qemu

[Qemu-devel] [PATCH 0/2] Xen cleanups

2013-05-27 Thread Stefano Stabellini
Hi all, just a couple of simple cleanups suggested by Paolo Bonzini: Stefano Stabellini (2): xen: remove xen_vcpu_init xen: use pc_init_pci instead of pc_init_pci_no_kvmclock hw/i386/pc_piix.c |5 ++--- xen-all.c | 23 --- 2 files changed, 2

[Qemu-devel] [PATCH 1/2] xen: remove xen_vcpu_init

2013-05-27 Thread Stefano Stabellini
No need for xen_vcpu_init anymore: - the RTC emulator doesn't have any periodic timers continuously running even in absence of guest interactions anymore; - qemu_dummy_start_vcpu takes care of disabling TCG for us, so we don't need to do it manually here. Signed-off-by: Stefano

[Qemu-devel] [PATCH 2/2] xen: use pc_init_pci instead of pc_init_pci_no_kvmclock

2013-05-27 Thread Stefano Stabellini
Call kvmclock_create only if kvmclock_enabled. Use pc_init_pci on Xen rather than pc_init_pci_no_kvmclock. Signed-off-by: Stefano Stabellini --- hw/i386/pc_piix.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 1ef4cbf

Re: [Qemu-devel] [PATCH 1/3] qemu_chr_new_from_opts: do not overwrite existing chr->filename

2013-05-28 Thread Stefano Stabellini
On Tue, 28 May 2013, Gerd Hoffmann wrote: > On 05/27/13 20:13, Stefano Stabellini wrote: > > Set the new filename only if it hasn't been already set (for example by > > qemu_chr_open_pty). > > > > This fixes a regression that prevents Xen HVM domains from b

Re: [Qemu-devel] [PATCH 1/3] qemu_chr_new_from_opts: do not overwrite existing chr->filename

2013-05-28 Thread Stefano Stabellini
On Mon, 27 May 2013, Stefano Stabellini wrote: > Set the new filename only if it hasn't been already set (for example by > qemu_chr_open_pty). > > This fixes a regression that prevents Xen HVM domains from booting. > It was introduced by: > > commit 2b220025993e76

<    5   6   7   8   9   10   11   12   13   14   >