Re: [Qemu-devel] Fix invalidate if memory requested was not bucket aligned

2012-08-07 Thread Stefano Stabellini
tual address (without bucket offset). > However when this entry is invalidated the virtual address saved in the > reverse mapping is used. This cause that the mapping is freed but the > last_address_vaddr is not reset. > > Signed-off-by: Frediano Ziglio Acked-by: Stefano Stabellin

Re: [Qemu-devel] [PATCH 0/3] net: add missing queue flush for e1000 and xen

2012-08-09 Thread Stefano Stabellini
On Thu, 9 Aug 2012, Stefan Hajnoczi wrote: > On Thu, Aug 09, 2012 at 04:45:54PM +0200, Paolo Bonzini wrote: > > Luigi reminded me of these patches... > > > > When the guests replenish the receive ring buffer, the network device > > should flush its queue of pending packets. This is done with > >

Re: [Qemu-devel] [PATCH] xen-all.c: fix multiply issue for int and uint types

2012-08-22 Thread Stefano Stabellini
; > Signed-off-by: Dongxiao Xu Acked-by: Stefano Stabellini > xen-all.c | 24 > 1 files changed, 16 insertions(+), 8 deletions(-) > > diff --git a/xen-all.c b/xen-all.c > index 61def2e..f76b051 100644 > --- a/xen-all.c > +++ b/xen-

[Qemu-devel] [PULL] Xen fixes 2012-08-22

2012-08-22 Thread Stefano Stabellini
Hi Anthony, please pull two fixes to xen-all.c: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-fixes-20120822 Dongxiao Xu (1): xen-all.c: fix multiply issue for int and uint types Frediano Ziglio (1): Fix invalidate if memory requested was not bucket aligned xen-all.c

Re: [Qemu-devel] [QEMU][RFC V2 01/10] xen: add new machine options to support QEMU disaggregation in Xen environment

2012-08-23 Thread Stefano Stabellini
On Wed, 22 Aug 2012, Julien Grall wrote: > - xen_dmid: specify the id of QEMU. It will be used to > retrieve/store information inside XenStore. > - xen_default_dev (on/off): as default devices need to be create in > each QEMU (due to code dependency), this option specifies if it wil

Re: [Qemu-devel] [QEMU][RFC V2 05/10] xen-memory: register memory/IO range in Xen

2012-08-23 Thread Stefano Stabellini
On Wed, 22 Aug 2012, Julien Grall wrote: > Add Memory listener on IO and modify the one on memory. > Becareful, the first listener is not called is the range is still register > with > register_ioport*. So Xen will never know that this QEMU is handle the range. I don't understand what you mean he

Re: [Qemu-devel] [QEMU][RFC V2 06/10] xen-pci: register PCI device in Xen and handle IOREQ_TYPE_PCI_CONFIG

2012-08-23 Thread Stefano Stabellini
On Wed, 22 Aug 2012, Julien Grall wrote: > With QEMU disaggregation QEMU needs to specify which PCI device it's able to > handle. It will use the device place in the topology (domain, bus, device, > function). > When Xen will trap an access for the config space, it will forge a new > ioreq and forw

Re: [Qemu-devel] [QEMU][RFC V2 07/10] xen: specify which device is part of default devices

2012-08-23 Thread Stefano Stabellini
On Wed, 22 Aug 2012, Julien Grall wrote: > One major problem of QEMU disaggregation is that some devices needs to > be "emulate" in each QEMU, but only one need to register it in Xen. > > This patch introduces helpers that can be used in QEMU code (for > instance hw/pc_piix.c) to specify if the de

Re: [Qemu-devel] [QEMU][RFC V2 08/10] xen: audio is not a part of default devices

2012-08-23 Thread Stefano Stabellini
On Wed, 22 Aug 2012, Julien Grall wrote: > Signed-off-by: Julien Grall > --- > arch_init.c |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 9b46bfc..1077b16 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -44,6 +44,7 @@ > #

Re: [Qemu-devel] [QEMU][RFC V2 10/10] xen: emulate IDE outside default device set

2012-08-23 Thread Stefano Stabellini
On Wed, 22 Aug 2012, Julien Grall wrote: > IDE can be emulate in a different QEMU that the default. > > This patch also fixes ide_get_geometry. When QEMU didn't emulate IDE, ^doesn't > it try to derefence a NULL bus. ^tries to dereference

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Mon, 23 Jan 2012, Jan Kiszka wrote: > On 2012-01-23 15:46, Stefano Stabellini wrote: > > On Mon, 23 Jan 2012, Jan Kiszka wrote: > >> On 2012-01-23 12:59, Stefano Stabellini wrote: > >>> On Mon, 23 Jan 2012, Jan Kiszka wrote: > >>>>>> Or what

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Mon, 23 Jan 2012, Anthony Liguori wrote: > On 01/23/2012 04:47 AM, Stefano Stabellini wrote: > > On Fri, 20 Jan 2012, Jan Kiszka wrote: > >> On 2012-01-20 18:20, Stefano Stabellini wrote: > >>> Hi all, > >>> this is the fourth version of the Xen sav

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Mon, 23 Jan 2012, Anthony Liguori wrote: > On 01/23/2012 10:46 AM, Stefano Stabellini wrote: > > On Mon, 23 Jan 2012, Anthony Liguori wrote: > >> On 01/23/2012 04:47 AM, Stefano Stabellini wrote: > >>> On Fri, 20 Jan 2012, Jan Kiszka wrote: > >>>>

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Stefano Stabellini
On Tue, 24 Jan 2012, Avi Kivity wrote: > On 01/24/2012 01:27 PM, Paolo Bonzini wrote: > > On 01/24/2012 12:10 PM, Avi Kivity wrote: > >>> But viewing RAM as just another device, having Xen only restore a > >>> subset of devices should be a reasonable thing to do moving forward. > >>> The main probl

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Stefano Stabellini
On Tue, 24 Jan 2012, Avi Kivity wrote: > On 01/24/2012 12:21 PM, Gerd Hoffmann wrote: > > >>> > > >>> But viewing RAM as just another device, having Xen only restore a > > >>> subset of > > >>> devices should be a reasonable thing to do moving forward. > > > > I don't think modeling device memory (

Re: [Qemu-devel] [Xen-devel] [PATCH v3 5/6] xen: record physmap changes to xenstore

2012-01-25 Thread Stefano Stabellini
On Wed, 25 Jan 2012, Avi Kivity wrote: > On 01/19/2012 04:16 PM, Stefano Stabellini wrote: > > > > > > If you are migrating to a newer qemu then the could in > > > principal change, I think. > > > > Not unless the implementation of qemu_ram_alloc_from_pt

[Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-25 Thread Stefano Stabellini
n the reset handler at all (tested on Win2K, where the problem was found in the first place). This is the list of patches with a diffstat: Anthony PERARD (2): xen mapcache: check if memory region has moved. xen: do not allocate RAM during INMIGRATE runstate Stefano Stabellini (4):

[Qemu-devel] [PATCH v4 1/6] cirrus_vga: do not reset videoram

2012-01-25 Thread Stefano Stabellini
There is no need to set the videoram to 0xff in cirrus_reset, because it is the BIOS' job. Signed-off-by: Stefano Stabellini --- hw/cirrus_vga.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index f7b1d3d..5564478 100644 ---

[Qemu-devel] [PATCH v4 5/6] Set runstate to INMIGRATE earlier

2012-01-25 Thread Stefano Stabellini
Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. Signed-off-by: Stefano Stabellini --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index c3a155f..9b9a4fb 100644 --- a/vl.c +++ b/vl.c @@ -2972,6 +2972,7 @@ int main(int argc, char

[Qemu-devel] [PATCH v4 4/6] xen mapcache: check if memory region has moved.

2012-01-25 Thread Stefano Stabellini
located to were the guest will look into. This help to have a succefull migration. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c | 18 +- xen-mapcache.c | 22 +++--- xen-mapcache.h |9 +++-- 3 files changed, 43 i

[Qemu-devel] [PATCH v4 2/6] Introduce "save_devices"

2012-01-25 Thread Stefano Stabellini
- add an "is_ram" flag to SaveStateEntry; - add an "is_ram" parameter to register_savevm_live; - introduce a "save_devices" monitor command that can be used to save the state of non-ram devices. Signed-off-by: Stefano Stabellini --- block-migration.c |

[Qemu-devel] [PATCH v4 6/6] xen: do not allocate RAM during INMIGRATE runstate

2012-01-25 Thread Stefano Stabellini
From: Anthony PERARD Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- xen-all.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index bb66c82..5b10d0c 100644 --- a/xen-all.c +++ b/xen-all.c @@ -190,6 +190,14 @@ void

[Qemu-devel] [PATCH v4 3/6] xen: record physmap changes to xenstore

2012-01-25 Thread Stefano Stabellini
Write to xenstore any physmap changes so that the hypervisor can be aware of them. Read physmap changes from xenstore on boot. Signed-off-by: Stefano Stabellini --- xen-all.c | 78 - 1 files changed, 77 insertions(+), 1 deletions

[Qemu-devel] [PATCH v2 0/5] prevent Qemu from waking up needlessly

2012-01-27 Thread Stefano Stabellini
eases the default select timeout to 1h: nothing should rely on the select timeout to be 1sec, so we might as well increase it to 1h. Shortlog and diffstat follow: Stefano Stabellini (5): xen: do not initialize the interval timer emulator xen: disable rtc_clock xen: introduce an

[Qemu-devel] [PATCH v2 1/5] xen: do not initialize the interval timer emulator

2012-01-27 Thread Stefano Stabellini
PIT is emulated by the hypervisor so we don't need to emulate it in Qemu: this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. Signed-off-by: Stefano Stabellini --- hw/pc.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/pc.c b/hw/pc.c

[Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-27 Thread Stefano Stabellini
rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini --- xen-all.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index d1fc597

[Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h

2012-01-27 Thread Stefano Stabellini
There is no reason why the minimum timeout should be 1sec, it could easily be 1h and we would save lots of cpu cycles. Signed-off-by: Stefano Stabellini --- qemu-timer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 648db1d..b792a32

[Qemu-devel] [PATCH v2 3/5] xen: introduce an event channel for buffered io event notifications

2012-01-27 Thread Stefano Stabellini
delete the timer. Signed-off-by: Stefano Stabellini --- xen-all.c | 42 -- 1 files changed, 36 insertions(+), 6 deletions(-) diff --git a/xen-all.c b/xen-all.c index bf183f7..bfec4c1 100644 --- a/xen-all.c +++ b/xen-all.c @@ -77,6 +77,8 @@ typedef struct

[Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-01-27 Thread Stefano Stabellini
Also delta in qemu_next_alarm_deadline is a 64 bit value so set the default to INT64_MAX instead of INT32_MAX. Signed-off-by: Stefano Stabellini --- qemu-timer.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index cd026c6..648db1d

Re: [Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-01-27 Thread Stefano Stabellini
On Fri, 27 Jan 2012, Paolo Bonzini wrote: > On 01/27/2012 01:26 PM, Stefano Stabellini wrote: > > Also delta in qemu_next_alarm_deadline is a 64 bit value so set the > > default to INT64_MAX instead of INT32_MAX. > > > > Signed-off-by: Stefano Stabellini > &

Re: [Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h

2012-01-27 Thread Stefano Stabellini
On Fri, 27 Jan 2012, Paolo Bonzini wrote: > On 01/27/2012 01:26 PM, Stefano Stabellini wrote: > > There is no reason why the minimum timeout should be 1sec, it could > > easily be 1h and we would save lots of cpu cycles. > > > > Signed-off-by: Stefano Stabellini > &

Re: [Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-01-27 Thread Stefano Stabellini
On Fri, 27 Jan 2012, Stefano Stabellini wrote: > On Fri, 27 Jan 2012, Paolo Bonzini wrote: > > On 01/27/2012 01:26 PM, Stefano Stabellini wrote: > > > Also delta in qemu_next_alarm_deadline is a 64 bit value so set the > > > default to INT64_MAX instead of INT32_MAX

[Qemu-devel] [PATCH v3 0/6] prevent Qemu from waking up needlessly

2012-01-27 Thread Stefano Stabellini
o fix win32_rearm_timer and mm_rearm_timer, that risk an overflow if INT64_MAX is passed as delta. Shortlog and diffstat follow: Stefano Stabellini (6): xen: do not initialize the interval timer emulator xen: disable rtc_clock xen: introduce an event channel for buffered io event notifica

[Qemu-devel] [PATCH v3 5/6] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-01-27 Thread Stefano Stabellini
Also delta in qemu_next_alarm_deadline is a 64 bit value so set the default to INT64_MAX instead of INT32_MAX. Signed-off-by: Stefano Stabellini --- qemu-timer.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index a9ba0eb..8c8bbc3

[Qemu-devel] [PATCH v3 1/6] xen: do not initialize the interval timer emulator

2012-01-27 Thread Stefano Stabellini
PIT is emulated by the hypervisor so we don't need to emulate it in Qemu: this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. Signed-off-by: Stefano Stabellini --- hw/pc.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/pc.c b/hw/pc.c

[Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-01-27 Thread Stefano Stabellini
There is no reason why the minimum timeout should be 1sec, it could easily be 1h and we would save lots of cpu cycles. Signed-off-by: Stefano Stabellini --- qemu-timer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 8c8bbc3..3207e40

[Qemu-devel] [PATCH v3 4/6] timers: the rearm function should be able to handle delta = INT64_MAX

2012-01-27 Thread Stefano Stabellini
unsigned long and timeSetEvent takes an unsigned int as delta, so cast the ms delta to the appropriate unsigned integer. Signed-off-by: Stefano Stabellini --- qemu-timer.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index

[Qemu-devel] [PATCH v3 3/6] xen: introduce an event channel for buffered io event notifications

2012-01-27 Thread Stefano Stabellini
delete the timer. Signed-off-by: Stefano Stabellini --- xen-all.c | 42 -- 1 files changed, 36 insertions(+), 6 deletions(-) diff --git a/xen-all.c b/xen-all.c index bf183f7..bfec4c1 100644 --- a/xen-all.c +++ b/xen-all.c @@ -77,6 +77,8 @@ typedef struct

[Qemu-devel] [PATCH v3 2/6] xen: disable rtc_clock

2012-01-27 Thread Stefano Stabellini
rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini --- xen-all.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index d1fc597

Re: [Qemu-devel] [PATCH v3 1/6] xen: do not initialize the interval timer emulator

2012-01-30 Thread Stefano Stabellini
On Fri, 27 Jan 2012, Jan Kiszka wrote: > On 2012-01-27 19:21, Stefano Stabellini wrote: > > PIT is emulated by the hypervisor so we don't need to emulate it in Qemu: > > this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. > > > > S

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-30 Thread Stefano Stabellini
On Fri, 27 Jan 2012, Paolo Bonzini wrote: > On 01/27/2012 01:26 PM, Stefano Stabellini wrote: > > rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen > > has its own RTC emulator in the hypervisor so we can disable it. > > > > Signed-off-by: Stefano S

Re: [Qemu-devel] [PATCH v3 2/6] xen: disable rtc_clock

2012-01-30 Thread Stefano Stabellini
On Fri, 27 Jan 2012, Paolo Bonzini wrote: > On 01/27/2012 07:21 PM, Stefano Stabellini wrote: > > rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen > > has its own RTC emulator in the hypervisor so we can disable it. > > > > Signed-off-by: Stefano S

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-30 Thread Stefano Stabellini
On Mon, 30 Jan 2012, Paolo Bonzini wrote: > On 01/30/2012 12:56 PM, Stefano Stabellini wrote: > >> > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true. > > > > Good point. > > I should check for rtc_clock == host_clock. >

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-31 Thread Stefano Stabellini
On Wed, 25 Jan 2012, Stefano Stabellini wrote: > Hi all, > this is the fourth version of the Xen save/restore patch series. > We have been discussing this issue for quite a while on #qemu and > qemu-devel: > > > http://marc.info/?l=qemu-devel&m=132346828427314&w

[Qemu-devel] [PATCH v4 0/6] prevent QEMU from waking up needlessly

2012-01-31 Thread Stefano Stabellini
n xen; - disable rtc_clock only when it points to the host_clock (the default); - make sure it compiles on older xen versions. Changes in v3: - added a new patch to fix win32_rearm_timer and mm_rearm_timer, that risk an overflow if INT64_MAX is passed as delta. Shortlog and diffstat follow: St

[Qemu-devel] [PATCH v4 4/6] timers: the rearm function should be able to handle delta = INT64_MAX

2012-01-31 Thread Stefano Stabellini
unsigned long and timeSetEvent takes an unsigned int as delta, so cast the ms delta to the appropriate unsigned integer. Signed-off-by: Stefano Stabellini --- qemu-timer.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index

[Qemu-devel] [PATCH v4 2/6] xen: disable rtc_clock

2012-01-31 Thread Stefano Stabellini
rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini --- xen-all.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index

[Qemu-devel] [PATCH v4 5/6] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-01-31 Thread Stefano Stabellini
Also delta in qemu_next_alarm_deadline is a 64 bit value so set the default to INT64_MAX instead of INT32_MAX. Signed-off-by: Stefano Stabellini --- qemu-timer.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 29410f1..de20852

[Qemu-devel] [PATCH v4 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-01-31 Thread Stefano Stabellini
There is no reason why the minimum timeout should be 1sec, it could easily be 1h and we would save lots of cpu cycles. Signed-off-by: Stefano Stabellini --- qemu-timer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index de20852..84b970e

[Qemu-devel] [PATCH v4 3/6] xen: introduce an event channel for buffered io event notifications

2012-01-31 Thread Stefano Stabellini
delete the timer. Signed-off-by: Stefano Stabellini --- xen-all.c | 45 +++-- 1 files changed, 39 insertions(+), 6 deletions(-) diff --git a/xen-all.c b/xen-all.c index 101c962..0ce8002 100644 --- a/xen-all.c +++ b/xen-all.c @@ -59,6 +59,9 @@ static

[Qemu-devel] [PATCH v4 1/6] xen: do not initialize the interval timer and PCSPK emulator

2012-01-31 Thread Stefano Stabellini
PIT and PCSPK are emulated by the hypervisor so we don't need to emulate them in Qemu: this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. Signed-off-by: Stefano Stabellini --- hw/pc.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/p

Re: [Qemu-devel] [PATCH] e1000: bounds packet size against buffer size

2012-02-02 Thread Stefano Stabellini
On Mon, 23 Jan 2012, Anthony Liguori wrote: > Otherwise we can write beyond the buffer and corrupt memory. This is tracked > as CVE-2012-0029. The stable-1.0 branch looks vulnerable too, shouldn't this patch be backported? > Signed-off-by: Anthony Liguori > --- > hw/e1000.c |3 +++ > 1 fi

Re: [Qemu-devel] [Xen-devel] [PATCH v3 2/6] suspend: switch acpi s3 to new infrastructure.

2012-02-09 Thread Stefano Stabellini
On Wed, 8 Feb 2012, Gerd Hoffmann wrote: > This patch switches pc s3 suspend over to the new infrastructure. > The cmos_s3 qemu_irq is killed, the new notifier is used instead. > The xen hack goes away with that too, the hypercall can simply be > done in a notifier function now. nice cleanup

Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-02-10 Thread Stefano Stabellini
On Fri, 10 Feb 2012, Paul Brook wrote: > > >> > At least the floppy DMA engine is fine with it, it uses idle bottom > > >> > halves (which are a hack and could be replaced by timers, but that's > > >> > not relevant now). > > > > > > I thought idle bottom halves were one of the things that made

Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-02-10 Thread Stefano Stabellini
On Fri, 10 Feb 2012, Jan Kiszka wrote: > On 2012-02-10 12:18, Paolo Bonzini wrote: > > On 02/10/2012 12:19 PM, Stefano Stabellini wrote: > >> I think you are right and the right thing to do would be blocking > >> indefinitely. > >> However if slirp doesn'

Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-02-13 Thread Stefano Stabellini
is no need for the !CONFIG_SLIRP dummy version of the function. --- commit 3a89477edc7e551c93b016940d2fdad9ebc22a84 Author: Stefano Stabellini Date: Mon Feb 13 11:25:03 2012 + main_loop_wait: block indefinitely - remove qemu_calculate_timeout; - explicitly size

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-02-13 Thread Stefano Stabellini
On Tue, 31 Jan 2012, Stefano Stabellini wrote: > On Wed, 25 Jan 2012, Stefano Stabellini wrote: > > Hi all, > > this is the fourth version of the Xen save/restore patch series. > > We have been discussing this issue for quite a while on #qemu and > > qemu-devel: > &

Re: [Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-02-14 Thread Stefano Stabellini
patch and hope we didn't miss anything. OK, thanks. I'll resend the patch as part of the series and ask for testing. > > Author: Stefano Stabellini > > Date: Mon Feb 13 11:25:03 2012 + > > > > main_loop_wait: block indefinitely > > &g

[Qemu-devel] [PATCH v5 0/6] prevent QEMU from waking up needlessly

2012-02-14 Thread Stefano Stabellini
tions(-) Stefano Stabellini (6): xen: do not initialize the interval timer and PCSPK emulator xen: disable rtc_clock xen: introduce an event channel for buffered io event notifications timers: the rearm function should be able to handle delta = INT64_MAX qemu_next_alarm_dea

[Qemu-devel] [PATCH v5 1/6] xen: do not initialize the interval timer and PCSPK emulator

2012-02-14 Thread Stefano Stabellini
PIT and PCSPK are emulated by the hypervisor so we don't need to emulate them in Qemu: this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. Signed-off-by: Stefano Stabellini --- hw/pc.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/p

[Qemu-devel] [PATCH v5 2/6] xen: disable rtc_clock

2012-02-14 Thread Stefano Stabellini
rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini --- xen-all.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index

[Qemu-devel] [PATCH v5 6/6] main_loop_wait: block indefinitely

2012-02-14 Thread Stefano Stabellini
- remove qemu_calculate_timeout; - explicitly size timeout to uint32_t; - introduce slirp_update_timeout; - pass NULL as timeout argument to select in case timeout is the maximum value; Signed-off-by: Stefano Stabellini Acked-by: Paul Brook --- async.c |2 +- main-loop.c

[Qemu-devel] [PATCH v5 3/6] xen: introduce an event channel for buffered io event notifications

2012-02-14 Thread Stefano Stabellini
delete the timer. Signed-off-by: Stefano Stabellini --- xen-all.c | 45 +++-- 1 files changed, 39 insertions(+), 6 deletions(-) diff --git a/xen-all.c b/xen-all.c index 101c962..0ce8002 100644 --- a/xen-all.c +++ b/xen-all.c @@ -59,6 +59,9 @@ static

[Qemu-devel] [PATCH v5 5/6] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-02-14 Thread Stefano Stabellini
Also delta in qemu_next_alarm_deadline is a 64 bit value so set the default to INT64_MAX instead of INT32_MAX. Signed-off-by: Stefano Stabellini --- qemu-timer.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 29410f1..de20852

[Qemu-devel] [PATCH v5 4/6] timers: the rearm function should be able to handle delta = INT64_MAX

2012-02-14 Thread Stefano Stabellini
unsigned long and timeSetEvent takes an unsigned int as delta, so cast the ms delta to the appropriate unsigned integer. Signed-off-by: Stefano Stabellini --- qemu-timer.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index

[Qemu-devel] Xen Hackathon hosted by Oracle, March 6-8, Santa Clara, CA, USA (fwd)

2012-02-15 Thread Stefano Stabellini
Hi all, I just want to let you know that Oracle is hosting a Xen Hackathon in Santa Clara at the beginning of March, so if any of you is interested in hacking on Xen, QEMU, or would just like to talk to the Xen maintainers, it is a good place to do it :-) Cheers, Stefano -- Forwarded m

[Qemu-devel] [PATCH] xen: detach the blkdev before bdrv_delete

2012-02-15 Thread Stefano Stabellini
We need to detach the blkdev from the BlockDriverState before calling bdrv_delete. Signed-off-by: Stefano Stabellini CC: Markus Armbruster --- hw/xen_disk.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 68fa36a..bf06fc1 100644

Re: [Qemu-devel] [PATCH 07/14] console: don't set PixelFormat alpha fields for 32bpp

2012-10-19 Thread Stefano Stabellini
On Wed, 17 Oct 2012, Gerd Hoffmann wrote: > Currently it is inconstent, PixelFormat->amask is left unset whereas > abits and amax and ashift are filled. As an alpha channel doesn't make > sense for the vga framebuffer leave all alpha fields clear. > > Signed-off-by: Gerd Hoffmann Actually the a

Re: [Qemu-devel] [PATCH 11/14] pixman/vnc: use pixman images in vnc.

2012-10-19 Thread Stefano Stabellini
On Wed, 17 Oct 2012, Gerd Hoffmann wrote: > The vnc code uses *three* DisplaySurfaces: > > First is the surface of the actual QemuConsole, usually the guest > screen, but could also be a text console (monitor/serial reachable via > Ctrl-Alt- keys). This is left as-is. > > Second is the current s

[Qemu-devel] [PULL] Xen PCI Passthrough

2012-06-21 Thread Stefano Stabellini
Anthony, please pull Anthony Perard's Xen PCI Passthrough series from: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-pt All the generic patches have been acked by Michael, the Xen patches have been reviewed by Konrad and me. Allen Kay (2): Introduce Xen PCI Passthrough, qdevic

[Qemu-devel] [PULL] Xen compile fixes

2012-06-21 Thread Stefano Stabellini
Anthony, please pull a couple of small Xen compile fixes to compile against xen-unstable: git://xenbits.xen.org/people/sstabellini/qemu-dm.git compile-xs Anthony PERARD (2): xen: Reorganize includes of Xen headers. xenstore: Use configure|2 +- hw/xen_backend.c |6

Re: [Qemu-devel] [PATCH stable-1.1 00/26] Initial tree and candidates for stable-1.1

2012-06-25 Thread Stefano Stabellini
On Sat, 23 Jun 2012, Michael Roth wrote: > Hi everyone, > > I've set up a tree for stable-1.1 at: > > git://github.com/mdroth/qemu.git stable-1.1 Thanks for doing this. > That is simply the initial commit for v1.1.0 > > I've set up a staging tree for the first batch of commits at: > > git://

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-12-10 Thread Stefano Stabellini
On Fri, 7 Dec 2012, Ian Jackson wrote: > Stefano Stabellini writes ("[Xen-devel] [PATCH 0/2] QEMU/xen: simplify > cpu_ioreq_pio and cpu_ioreq_move"): > > after reviewing the patch "fix multiply issue for int and uint types" > > with Ian Jackson, we realized

[Qemu-devel] [PATCH] xen: fix trivial PCI passthrough MSI-X bug

2012-12-10 Thread Stefano Stabellini
We are currently passing entry->data as address parameter. Pass entry->addr instead. Signed-off-by: Stefano Stabellini Tested-by: Sander Eikelenboom Xen-devel: http://marc.info/?l=xen-devel&m=135515462613715 diff --git a/hw/xen_pt_msi.c b/hw/xen_pt_msi.c index 6807672..db757cd 10064

Re: [Qemu-devel] [PATCH 1/2] cpu_ioreq_pio, cpu_ioreq_move: introduce read_phys_req_item, write_phys_req_item

2012-12-10 Thread Stefano Stabellini
t = (hwaddr)req->size * i; > +if (req->df) addr -= offset; > +else addr += offset; > +cpu_physical_memory_rw(addr, val, req->size, rw); > +} QEMU's code style is if (something) { you can also run the patch through scripts/checkpatch.pl. Aside from the code st

Re: [Qemu-devel] [PATCH] Fix compile errors when enabling Xen debug logging.

2012-12-13 Thread Stefano Stabellini
On Thu, 13 Dec 2012, Sander Eikelenboom wrote: > Signed-off-by: Sander Eikelenboom please wrap around the lines > 80 characters. > hw/xen_pt.c |4 ++-- > xen-all.c |4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/xen_pt.c b/hw/xen_pt.c > index 7a3846e.

Re: [Qemu-devel] [PATCH v2] Fix compile errors when enabling Xen debug logging.

2012-12-13 Thread Stefano Stabellini
On Thu, 13 Dec 2012, Sander Eikelenboom wrote: > v2: > - Wrap around > 80 characters > - Use %"HWADDR_PRIx" format for hwaddr > > Signed-off-by: Sander Eikelenboom Acked-by: Stefano Stabellini > hw/xen_pt.c |5 +++-- > xen-all.c |7 --- >

[Qemu-devel] [PULL] Xen fixes and multiple consoles

2012-12-17 Thread Stefano Stabellini
, cpu_ioreq_move: introduce read_phys_req_item, write_phys_req_item cpu_ioreq_pio, cpu_ioreq_move: i should be uint32_t rather than int Sander Eikelenboom (1): Fix compile errors when enabling Xen debug logging. Stefano Stabellini (2): xen: implement support for secondary consoles in

Re: [Qemu-devel] [PATCH 7/9] gtk: add translation support (v4)

2013-02-19 Thread Stefano Stabellini
On Tue, 19 Feb 2013, Paolo Bonzini wrote: > Il 19/02/2013 00:57, Anthony Liguori ha scritto: > > This includes a de_DE translation from Kevin Wolf and an it translation from > > Paolo Bonzini. > > > > Cc: Paolo Bonzini > > Cc: Kevin Wolf > > Cc: Stefan Hajnoczi > > Signed-off-by: Anthony Liguor

Re: [Qemu-devel] [PATCH v2] vga: fix byteswapping.

2013-02-20 Thread Stefano Stabellini
On Wed, 20 Feb 2013, Gerd Hoffmann wrote: > In case host and guest endianness differ the vga code first creates > a shared surface (using qemu_create_displaysurface_from), then goes > patch the surface format to indicate that the bytes must be swapped. > > The switch to pixman broke that hack as t

Re: [Qemu-devel] [PATCH 4/9] main-loop: refactor qemu_system_shutdown_request()

2013-02-20 Thread Stefano Stabellini
On Wed, 20 Feb 2013, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 20/02/2013 16:32, Anthony Liguori ha scritto: > >> +if (no_shutdown) { > >> +vm_stop(RUN_STATE_SHUTDOWN); > >> +} else { > >> +main_loop_quit(); > >> +} > > > > Would it make sense to call vm_

Re: [Qemu-devel] [PATCH 4/9] main-loop: refactor qemu_system_shutdown_request()

2013-02-21 Thread Stefano Stabellini
On Wed, 20 Feb 2013, Anthony Liguori wrote: > Stefano Stabellini writes: > > On Wed, 20 Feb 2013, Anthony Liguori wrote: > >> Paolo Bonzini writes: > >> > >> > Il 20/02/2013 16:32, Anthony Liguori ha scritto: > >> >> +if (no_s

Re: [Qemu-devel] [PATCH] qemu: define a TOM register to report the base of PCI

2013-02-22 Thread Stefano Stabellini
On Fri, 22 Feb 2013, Xudong Hao wrote: > Define a TOM(top of memory) register to report the base of PCI memory, update > memory region dynamically. > > The use case of this register defination is for Xen till now. > > Signed-off-by: Xudong Hao > Signed-off-by: Xiantao Zhang Thanks for the patc

Re: [Qemu-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-25 Thread Stefano Stabellini
On Mon, 25 Feb 2013, Xudong Hao wrote: > v2: > * Use "piix: " in the subject rather than "qemu: " > * Define TOM register as one byte > * Define default TOM value instead of hardcode 0xe000 in more that one > place > * Use API pci_set_byte for pci config access > * Use dev->config instead of t

Re: [Qemu-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-26 Thread Stefano Stabellini
vel-bounces+xiantao.zhang=intel@nongnu.org > > [mailto:qemu-devel-bounces+xiantao.zhang=intel@nongnu.org] On Behalf > > Of Hao, Xudong > > Sent: Tuesday, February 26, 2013 11:33 AM > > To: Stefano Stabellini; Ian Campbell > > Cc: aligu...@us.ibm.com; m...@redhat.com; q

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-09-20 Thread Stefano Stabellini
On Thu, 20 Sep 2012, Gerd Hoffmann wrote: > > Pixman or non-pixman, I still think that this could benefit from > > implementing a DisplayAllocator interface: it would avoid a memcpy > > whenever there is no need for scaling and pixel conversions. > > There is one more issue I didn't mention yet:

Re: [Qemu-devel] [PATCH V3 2/5] xen: Introduce xen_modified_memory.

2012-09-20 Thread Stefano Stabellini
On Thu, 20 Sep 2012, Anthony PERARD wrote: > This function is to be used during live migration. Every write access to the > guest memory should call this funcion so the Xen tools knows which pages are > dirty. > > Signed-off-by: Anthony PERARD > --- > hw/xen.h | 1 + > xen-all.c | 21 +++

Re: [Qemu-devel] [PATCH V3 5/5] xen: Set the vram dirty when an error occur.

2012-09-20 Thread Stefano Stabellini
On Thu, 20 Sep 2012, Anthony PERARD wrote: > If the call to xc_hvm_track_dirty_vram() fails, then we set dirtybit on all > the > video ram. This case happens during migration, but we don't need a special > case > for live migration with patch. Just as a reference, what is this special case for l

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-09-20 Thread Stefano Stabellini
On Thu, 20 Sep 2012, Gerd Hoffmann wrote: > Hi, > > > It might be a good idea to get rid > > of DisplayAllocator altogether. > > After some digging in the source code: Yes, I think so. > > Look, we have *two* concepts for avoiding memcpy: > > The first is the DisplayAllocator. Only implemen

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-09-20 Thread Stefano Stabellini
On Thu, 20 Sep 2012, Gerd Hoffmann wrote: > Hi, > > >> In any graphics mode relevant today vga emulation will use > >> qemu_create_displaysurface_from(). Whenever a DisplayAllocator is > >> present or not doesn't make any difference then. > > > > Unfortunately if my memory doesn't fail me, Win

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-09-20 Thread Stefano Stabellini
On Thu, 20 Sep 2012, Stefano Stabellini wrote: > On Thu, 20 Sep 2012, Gerd Hoffmann wrote: > > Hi, > > > > >> In any graphics mode relevant today vga emulation will use > > >> qemu_create_displaysurface_from(). Whenever a DisplayAllocator is > >

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-09-21 Thread Stefano Stabellini
On Fri, 21 Sep 2012, Gerd Hoffmann wrote: > On 09/20/12 17:33, Stefano Stabellini wrote: > > On Thu, 20 Sep 2012, Stefano Stabellini wrote: > >> On Thu, 20 Sep 2012, Gerd Hoffmann wrote: > >>> Hi, > >>> > >>>>>

Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-24 Thread Stefano Stabellini
On Fri, 21 Sep 2012, Gerd Hoffmann wrote: > Hi, > > >> +case FB_ACQ_REQ: > >> +fbdev_switch_acquire(); > >> +redraw_screen++; > > > > Rather than introducing redraw_screen, I would just call vga_hw_invalidate > > instead here. It is always a win if we can avoid to introduce

Re: [Qemu-devel] [RfC] using pixman in qemu for raster ops

2012-09-25 Thread Stefano Stabellini
On Tue, 25 Sep 2012, Gerd Hoffmann wrote: > Hi, > > While working with the pixman library in the fbdev branch and discussing > patches with Stefano Stabellini I came to the conclusion that it would > be a good idea to: > > (a) use the pixman library not just as vehicle

Re: [Qemu-devel] [PATCH v2] qemu/xen: Add 64 bits big bar support on qemu

2012-09-25 Thread Stefano Stabellini
On Tue, 25 Sep 2012, Xudong Hao wrote: > Changes from v1: > - Rebase to qemu upstream from qemu-xen Thanks. Please run scripts/checkpatch.pl on this patch, you'll find some cody style issues that need to be fixed. > Currently it is assumed PCI device BAR access < 4G memory. If there is such a >

Re: [Qemu-devel] [PATCH v2] qemu/xen: Add 64 bits big bar support on qemu

2012-09-26 Thread Stefano Stabellini
On Wed, 26 Sep 2012, Hao, Xudong wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Tuesday, September 25, 2012 6:52 PM > > To: Hao, Xudong > > Cc: Stefano Stabellini; xen-de...@lists.xen.org; qe

Re: [Qemu-devel] [PATCH v3] qemu/xen: Add 64 bits big bar support on qemu

2012-09-27 Thread Stefano Stabellini
I device BAR access < 4G memory. If there is such a > device whose BAR size is larger than 4G, it must access > 4G memory address. > This patch enable the 64bits big BAR support on qemu. > > Signed-off-by: Xudong Hao > Signed-off-by: Xiantao Zhang Acked-by: Stefano St

Re: [Qemu-devel] [PATCH V4 2/5] xen: Introduce xen_modified_memory.

2012-10-01 Thread Stefano Stabellini
On Thu, 27 Sep 2012, Anthony PERARD wrote: > This function is to be used during live migration. Every write access to the > guest memory should call this funcion so the Xen tools knows which pages are > dirty. > > Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini >

Re: [Qemu-devel] [PATCH V4 5/5] xen: Set the vram dirty when an error occur.

2012-10-01 Thread Stefano Stabellini
On Thu, 27 Sep 2012, Anthony PERARD wrote: > If the call to xc_hvm_track_dirty_vram() fails, then we set dirtybit on all > the > video ram. This case happens during migration. > > Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini > xen-all.c | 3 ++- > 1 file

Re: [Qemu-devel] [PATCH V4 4/5] exec, memory: Call to xen_modified_memory.

2012-10-01 Thread Stefano Stabellini
On Thu, 27 Sep 2012, Anthony PERARD wrote: > This patch add some calls to xen_modified_memory to notify Xen about dirtybits > during migration. > > Signed-off-by: Anthony PERARD If I am not mistaken, this is the last patch that needs reviewing. Avi, are you OK with it? > exec.c | 1 + > me

  1   2   3   4   5   6   7   8   9   10   >