Public bug reported:
Setting the CPU model to Westmere (Intel Xeon server CPU) is not
possible.
libvirt uses 'core2duo' as fallback:
https://bugzilla.redhat.com/show_bug.cgi?id=708927
$ qemu -cpu ?
x86 [n270]
x86 [athlon]
x86 [pentium3]
x86 [pentium2]
x86[p
ping
http://patchwork.ozlabs.org/project/qemu-devel/patch/60aa0765-53dd-43d1-a3d2-75f177852...@vodafonemail.de/#2615112
Hi!
I’d like to remind you to this trivial patch to get ioclt(…, SIOCGIFCONF, …)
working properly on 64 bit target architectures.
Bye
Stefan
ping
http://patchwork.ozlabs.org/project/qemu-devel/patch/60aa0765-53dd-43d1-a3d2-75f177852...@vodafonemail.de/
Hi!
I’d like to remind you to this trivial patch to get ioclt(…, SIOCGIFCONF, …)
working properly on 64 bit target architectures.
Bye
Stefan
pinghttp://patchwork.ozlabs.org/project/qemu-devel/patch/60aa0765-53dd-43d1-a3d2-75f177852...@vodafonemail.de/
Hi!I’d like to remind you to this trivial patch to get ioclt(…, SIOCGIFCONF, …) working properly on 64 bit target architectures.ByeStefan
rch64 with qemu, the
returned array size is only a multiple of 32 bytes, which is wrong. It is
enough to fill only 32 bytes with thunk_convert() and ifreq_arg_type is also
the proper type, but the array element increase has to be 40 bytes.
I hope this clarifies your question.
Bye
Stefan
Public bug reported:
Calling get-fsinfo on a virtual machine does not include ZFS
(zfsonlinux, debian guest tested) volumes. Calling on a system with a
single ZFS disk (ZFS as root fs) simply returns '[]', if other disks
exist on the guest it only shows these.
Expected behaviour: Show file system
biggest part of
the union, treating struct ifreq with the correct size.
Signed-off-by: Stefan
---
linux-user/syscall.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index d182890ff0..15a6abadc1 100644
--- a/linux-user/syscall.c
Public bug reported:
Enabling hv-tlbflush on older hosts using Intel CPUs supporting VT-x but
neither EPT nor VPID will lead to bluescreens on the guest.
It seems KVM only checks if EPT is available, and if it isn't it
forcibly uses VPID. If that's *also* not available, it defaults to
basically a
On Mon, Aug 6, 2012 at 3:18 AM, Dong Xu Wang wrote:
>
> Signed-off-by: Dong Xu Wang
> ---
> v1->v2: fix param leak.
>
> qemu-img.c | 28 +---
> 1 files changed, 17 insertions(+), 11 deletions(-)
Reviewed-by: Stefan Hajnoczi
for irqfd: add a parameter to
> virtio_queue_set_host_notifier_fd_handler and in that case only set
> the notifier, not the handler
>
> Cc: Stefan Hajnoczi
> Signed-off-by: Paolo Bonzini
> ---
> Interesting, I tested vhost (or thought so). Can you try this
> patc
On Mon, Aug 6, 2012 at 1:49 PM, Avi Kivity wrote:
> The scsi passthrough handler falls through after completing a
> request into the failure path, resulting in a use after free.
>
> Reprducible by running a guest with aio=native on a block device.
>
> Reported-by: Stefan Prieb
for irqfd: add a parameter to
> virtio_queue_set_host_notifier_fd_handler and in that case only set
> the notifier, not the handler.
>
> Cc: Stefan Hajnoczi
> Signed-off-by: Paolo Bonzini
> ---
> hw/virtio-pci.c | 14 +++---
> hw/virtio.c | 7 +--
> hw/virtio.
uct CPUX86State *) 0x7f8015b67450
(gdb) p first_cpu->next_cpu->next_cpu
$8 = (struct CPUX86State *) 0x0
(gdb) p first_cpu->stop
$9 = 1
(gdb) p first_cpu->stopped
$10 = 0
(gdb) p first_cpu->exit_request
$11 = 0
:(
This isn't easy to reproduce. I tried entering the GRUB boot menu
again and there was no deadlock.
Stefan
for irqfd: add a parameter to
> virtio_queue_set_host_notifier_fd_handler and in that case only set
> the notifier, not the handler.
>
> Cc: Stefan Hajnoczi
> Signed-off-by: Paolo Bonzini
> ---
> The patch is a bit different from what I posted before,
> so I di
Public bug reported:
qemu-kvm 1.1.1 stable is running fine for me with RHEL 6 2.6.32 based
kernel.
But with 3.5.0 kernel qemu-system-x86_64 segfaults while i'm trying to
install ubuntu 12.04 server reproducable.
You find three backtraces here:
http://pastebin.com/raw.php?i=xCy2pEcP
S
continue;
> +}
> +mon_fdset_fd->removed = true;
> +if (has_fd) {
> +break;
> +}
> +}
> +monitor_fdset_cleanup(mon_fdset);
> +return;
> +}
> +snprintf(fd_str, sizeof(fd_str), "%ld", fd);
> +qerror_report(QERR_FD_NOT_FOUND, fd_str);
Why use an fd_str instead of passing an int64_t into the error
message? This also assumed sizeof(long) == 8, which isn't true on
32-bit hosts, so %ld should be %"PRId64".
There is a new policy on error reporting. I think this patch series
may be affected/conflict, please qemu-devel to check. I think Luiz
can also help here.
Stefan
om, dberra...@redhat.com)
>
> v6:
> -No changes
>
> Signed-off-by: Corey Bryant
> ---
> monitor.c | 15 +++
> 1 file changed, 15 insertions(+)
The lifecycle of fdsets and fds isn't clear to me. It seems like just a
refcount in fdset should handle this without extra fields like in_use.
Stefan
Any news? Was this applied upstream?
Am 06.08.2012 14:37, schrieb Avi Kivity:
On 08/06/2012 03:12 PM, Avi Kivity wrote:
On 08/06/2012 11:46 AM, Stefan Priebe - Profihost AG wrote:
But still i got the segfault and core dump - this is my main problem? I
mean qemu-kvm master isn't declar
On Wed, Aug 08, 2012 at 07:51:07AM +0200, Stefan Priebe wrote:
> Any news? Was this applied upstream?
Kevin is ill. He has asked me to review and test patches in his
absence. When he gets back later this week this will get picked up (and
included in QEMU 1.2).
Here is the tree, it inclu
ah OK - thanks. Will there be a fixed 1.1.2 as well?
Stefan
Am 08.08.2012 10:06, schrieb Stefan Hajnoczi:
On Wed, Aug 08, 2012 at 07:51:07AM +0200, Stefan Priebe wrote:
Any news? Was this applied upstream?
Kevin is ill. He has asked me to review and test patches in his
absence. When he
On Tue, Aug 7, 2012 at 8:59 PM, Corey Bryant wrote:
>
>
> On 08/07/2012 02:16 PM, Stefan Hajnoczi wrote:
>>
>> On Fri, Aug 3, 2012 at 6:28 PM, Corey Bryant
>> wrote:
>>> +snprintf(fd_str, sizeof(fd_str), "%ld", fd);
>>> +qerror
On Tue, Aug 07, 2012 at 11:58:28AM -0400, Corey Bryant wrote:
> @@ -2566,6 +2567,92 @@ FdsetInfoList *qmp_query_fdsets(Error **errp)
> return fdset_list;
> }
>
> +int monitor_fdset_get_fd(int64_t fdset_id, int flags)
> +{
> +mon_fdset_t *mon_fdset;
> +mon_fdset_fd_t *mon_fdset_fd;
>
set until explicitly removed by the
remove-fd command or when all monitor clients have disconnected. This
ensures that file descriptors are not leaked after a monitor client
crashes. Automatic removal on monitor close is postponed until all
duped fds have been fd - this means QEMU can still reopen an in-use fd
after a client disconnects.
Does this sound right?
Please do the QEMU coding style naming of MonFdset/MonFdsetFd mentioned in v6.
Stefan
of the (variously busted) versions we had previously.
>
> If you absolutely must use atomic ops, use the gcc builtins. For
> preference, stick to higher level and less error-prone abstractions.
We're spoilt for choice here:
1. Atomic built-ins from gcc
2. glib atomics
No need to roll our own or copy the implementation from the kernel.
Stefan
his is
> optional and if not specified, socket transport is used.
>
> Examples:
>
> file=gluster://1.2.3.4/testvol/a.img
> file=gluster://1.2.3.4:5000/testvol/dir/a.img?transport=socket
> file=gluster://[1:2:3:4:5:6:7:8]/testvol/dir/a.img
> file=gluster://[1:2:3:4:5:
On Wed, Aug 8, 2012 at 2:54 PM, Corey Bryant wrote:
>
>
> On 08/08/2012 09:02 AM, Stefan Hajnoczi wrote:
>>
>> On Tue, Aug 07, 2012 at 11:58:28AM -0400, Corey Bryant wrote:
>>>
>>> @@ -2566,6 +2567,92 @@ FdsetInfoList *qmp_query_fdsets(Er
place
blkverify. n=2 is blkverify, n=3 is your current patch series, n/m is
also possible where n=number of mirrors and m=threshold needed to
achieve quorum.
Stefan
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 62
>
> 1 file changed, 62 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index e0405b6..de58ab8 100644
> --- a
On Tue, Aug 7, 2012 at 9:30 PM, Blue Swirl wrote:
> On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet wrote:
>> +static void quorum_close(BlockDriverState *bs)
>> +{
>> +BDRVQuorumState *s = bs->opaque;
>> +int i;
>> +
>> +/* Ensure writes reach stable storage */
>> +for (i = 0; i <= 2
iops=44792, runt= 10001msec
read : io=1388MB, bw=142073KB/s, iops=35518, runt= 10006msec
seq 4m:
write: io=9776MB, bw=984522KB/s, iops=240, runt= 10168msec
read : io=2980MB, bw=288970KB/s, iops=70, runt= 10560msec
Any ideas?
Greets,
Stefan
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 17 +
> 1 file changed, 17 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 9da0432..5cd7083 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> +static int quorum_check_ret(QuorumAIOCB *acb)
> +{
> +int i, j;
> +
> +for (i = 0, j = 0; i <= 2; i++) {
> +if (acb->aios[0].ret) {
> +j++;
> +}
> +}
> +
> +if (j > 1) {
> +return -EIO;
> +
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/blkverify.c |8 ++--
> block/quorum.c|4
> 2 files changed, 10 insertions(+), 2 deletions(-)
Perhaps these should be in cutils.c with the other iovec functions.
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 35 +++
> 1 file changed, 35 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 2df3ae6..13804c1 100644
> --- a/block/quorum.c
> +++ b/
On Wed, Aug 8, 2012 at 4:44 PM, Stefan Hajnoczi wrote:
> On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
>> @@ -224,6 +232,32 @@ static void quorum_aio_cb(void *opaque, int ret)
>> }
>> }
>>
>> +static BlockDriverAIOCB *quor
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> +static void quorum_copy_qiov(QEMUIOVector *dest, QEMUIOVector *source)
> +{
> +int i;
> +for (i = 0; i < source->niov; i++) {
> +memcpy(dest->iov[i].iov_base,
> + source->iov[i].iov_base,
> + source-
On Wed, Aug 8, 2012 at 3:54 PM, Corey Bryant wrote:
>
>
> On 08/08/2012 09:04 AM, Stefan Hajnoczi wrote:
>>
>> On Tue, Aug 7, 2012 at 4:58 PM, Corey Bryant
>> wrote:
>>>
>>> libvirt's sVirt security driver provides SELinux MAC isolation for
>
Yes cache none. Is there a bugfix for 1.1.1?
Stefan
Am 08.08.2012 um 18:17 schrieb Paolo Bonzini :
> Il 08/08/2012 17:21, Stefan Priebe ha scritto:
>> Hello list,
>>
>> i wanted to start using virtio-scsi instead of virtio-blk, cause it
>> offers the possibility to
i really would like to test with actual git. But my VMs run awfully SLOW
with actual git version. Boot process prints one line every two seconds.
So i can't test. Is there a patch or backport for this problem?
Thanks,
Stefan
Am 08.08.2012 18:17, schrieb Paolo Bonzini:
Il 08/08/2012
Yes should be possible. guest is Debian or Ubuntu. I couldn't find a tag for
V1.1.1 which I ran from source. So where to start bisect?
Stefan
Am 09.08.2012 um 09:01 schrieb Paolo Bonzini :
> Il 09/08/2012 08:13, Stefan Priebe ha scritto:
>> i really would like to test with actu
:3A,netdev=net0,bus=pci.0,addr=0x12,id=net0,bootindex=300
I've also needed this patch:
https://github.com/stefanha/qemu/commit/d3e3082e6fe63d45cea2d92c41ad148dccf1b63e
otherwise kvm crash while hardware detection of ubuntu / debian.
Greets,
Stefan
Am 09.08.2012 09:19, schrieb Paolo Bonzini
@writethrough: why not?
@libiscsi Same speed problem with cache=none and with just local lvm disks.
Stefan
Am 09.08.2012 um 09:53 schrieb Paolo Bonzini :
> Il 09/08/2012 09:41, Stefan Priebe ha scritto:
>> -drive
>> file=iscsi://10.0.255.100/iqn.1986-03.com.sun:02:8a9019a4
off-by: Dunrong Huang
> ---
> vl.c | 10 +-
> 1 files changed, 5 insertions(+), 5 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
On Wed, Aug 8, 2012 at 7:51 PM, Corey Bryant wrote:
>
>
> On 08/08/2012 11:58 AM, Stefan Hajnoczi wrote:
>>
>> On Wed, Aug 8, 2012 at 3:54 PM, Corey Bryant
>> wrote:
>>>
>>>
>>>
>>> On 08/08/2012 09:04 AM, Stefan Hajnoczi wro
Why are refcount and in_use exposed? How will applications use them?
This seems like internal state to me.
Should add-fd allow the application to associate an opaque string with
the fdset? This could be used to recover after crash. Otherwise the
application needs to store the fdset_id -> filename mapping in a file
on disk and hope it was safely stored before crash. It seems like the
best place to keep this info is with the fdset.
Stefan
orage controller (e.g. IDE
CD-ROM) can be closed by blockdev.c:eject_device() and left as an
empty BlockDriverState with ->drv == NULL.
I think we don't need to worry about this in a block filter like
quorum because all child BlockDriverStates will not be ejected.
Stefan
vl.c | 10 +-
> 1 files changed, 5 insertions(+), 5 deletions(-)
Applied to the trivial-patches tree in the other email thread.
Stefan
On Thu, Aug 9, 2012 at 10:24 AM, Benoît Canet wrote:
> Le Wednesday 08 Aug 2012 ŕ 16:37:13 (+0100), Stefan Hajnoczi a écrit :
>> On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
>> > +static int quorum_check_ret(QuorumAIOCB *acb)
>> > +{
>> > +int i, j
On Thu, Aug 9, 2012 at 8:41 AM, Stefan Priebe wrote:
> starting line:
> /usr/bin/qemu-x86_64 -chardev
> socket,id=qmp,path=/var/run/qemu-server/103.qmp,server,nowait -mon
> chardev=qmp,mode=control -pidfile /var/run/qemu-server/103.pid -daemonize
> -usbdevice tablet -name kvmcrash
On Thu, Aug 9, 2012 at 11:17 AM, Stefan Priebe - Profihost AG
wrote:
> That looks better - thanks for the hint. But now network isn't working at
> all ;-(
You need to have commit 26b9b5fe17cc1b6be2e8bf8b9d16094f420bb8ad
("virtio: fix vhost handling"). Pull the latest qemu.
memory directly (for some reason
I assumed ccw always copies or send messages)?
Stefan
When the qemu-io --nocache option is used the 039 test case cannot abort
QEMU at a point where the image is dirty. Skip the test case.
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/039 |1 +
tests/qemu-iotests/common.rc | 14 ++
2 files changed, 15 insertions
The dirty bit is cleared after image repair succeeds in qed_open().
Move this into qed_check() so that all callers benefit from this
behavior when fix=true.
This is necessary so qemu-img check can call .bdrv_check() and mark the
image clean.
Signed-off-by: Stefan Hajnoczi
---
block/qed-check.c
image during
bdrv_open() before qemu-img.c can call bdrv_check().
v2:
* Fail when qcow2 check finds corruptions [Kevin]
Stefan Hajnoczi (4):
qed: mark image clean after repair succeeds
qcow2: mark image clean after repair succeeds
block: add BLOCK_O_CHECK for qemu-img check
qemu-iotests
-img check output.
Signed-off-by: Stefan Hajnoczi
---
block.h|1 +
block/qcow2.c |4 ++--
block/qed.c|2 +-
qemu-img.c |2 +-
tests/qemu-iotests/039.out |6 ++
5 files changed, 11 insertions(+), 4 deletion
The dirty bit is cleared after image repair succeeds in qcow2_open().
Move this into qcow2_check() so that all callers benefit from this
behavior when fix mode is enabled.
This is necessary so qemu-img check can call .bdrv_check() and mark the
image clean.
Signed-off-by: Stefan Hajnoczi
On Thu, Aug 9, 2012 at 1:12 PM, Cornelia Huck wrote:
> On Thu, 9 Aug 2012 12:34:04 +0100
> Stefan Hajnoczi wrote:
>
>> On Tue, Aug 7, 2012 at 3:52 PM, Cornelia Huck
>> wrote:
>> > Add a new virtio transport that uses channel commands to perform
>> >
t; net.c | 7 ++-
> net/queue.c | 5 +++--
> net/queue.h | 2 +-
> 6 file modificati, 15 inserzioni(+), 8 rimozioni(-)
Looks good for QEMU 1.2. I'll give Jan and Stefano time to respond, if
they want.
Stefan
Hello list,
i tried to find out how to be able to use trim / discard. So my storage
can free unusedblocks.
But i wasn't able to find out which virtio block devices support trim /
discard and what else is needed.
Thanks and Greets,
Stefan
On Thu, Aug 09, 2012 at 10:10:44PM -0400, Corey Bryant wrote:
> +void qmp_remove_fd(int64_t fdset_id, bool has_fd, int64_t fd, Error **errp)
> +{
> +MonFdset *mon_fdset;
> +MonFdsetFd *mon_fdset_fd;
> +char fd_str[20];
> +
> +QLIST_FOREACH(mon_fdset, &mon_fdsets, next) {
> +
_flush(NetQueue *queue)
> >
> > g_free(packet);
> > }
> > + return 1;
>
> return true;
Will fix these up when merging. I think it's clearer to use bool too.
Stefan
ed:
net/slirp.c: In function ‘net_init_slirp’:
net/slirp.c:721:50: error: ‘NetdevUserOptions’ has no member named
‘q_restrict’
Fix this issue by adding the missing qapi.py dependencies.
Signed-off-by: Stefan Hajnoczi
---
Makefile | 14 --
1 file changed, 8 insertions(+), 6
qemu/commits/trivial-patches
Also congrats on getting two Reviewed-bys. That's a rate of 1
Reviewed-by per changed character and the most thorough review a QEMU
patch has ever had! :)
Stefan
Paolo's fixes to resume rx when buffers have been replenished on e1000 and
xen_nic. virtio-net does not have this bug.
The following changes since commit 3d1d9652978ac5a32a0beb4bdf6065ca39440d89:
handle device help before accelerator set up (2012-08-09 19:53:01 +)
are available in the git
e trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
are at it we can add a little smartness:
if some of the queued packets already could not be delivered,
there is no need to notify the iothread.
Reported-by: Luigi Rizzo
Cc: Stefan Hajnoczi
Cc: Jan Kiszka
Signed-off-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
hw/virtio-net.c |4
}
> -*sizep = dt_size;
> +if (sizep) {
> +*sizep = dt_size;
> +}
What can the caller do with this void* buffer without knowing its size?
They cannot hand the buffer to the guest unless they duplicate the
get_image_size() call, which is pointless, or we're assuming a fixed
size, which is unsafe. I'm asking what the legitimate use case for
sizep == NULL is?
Stefan
Stabellini
Cc: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
hw/xen_nic.c |1 +
1 file changed, 1 insertion(+)
diff --git a/hw/xen_nic.c b/hw/xen_nic.c
index 8b79bfb..cf7d559 100644
--- a/hw/xen_nic.c
+++ b/hw/xen_nic.c
@@ -415,6 +415,7 @@ static void net_event
From: Paolo Bonzini
When the guests replenish the receive ring buffer, the network device
should flush its queue of pending packets. This is done with
qemu_flush_queued_packets.
e1000's can_receive can go from false to true when RCTL or RDT are
modified.
Reported-by: Luigi Rizzo
Cc: S
The following changes since commit 3d1d9652978ac5a32a0beb4bdf6065ca39440d89:
handle device help before accelerator set up (2012-08-09 19:53:01 +)
are available in the git repository at:
git://github.com/stefanha/qemu.git trivial-patches
for you to fetch changes up to b90372ad2a69a9cdad2
From: "Peter A. G. Crosthwaite"
Signed-off-by: Peter A. G. Crosthwaite
Reviewed-by: Andreas Färber
Reviewed-by: Peter Maydell
Signed-off-by: Stefan Hajnoczi
---
target-arm/translate.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-arm/translate.c b/
: Dunrong Huang
Reviewed-by: Markus Armbruster
Signed-off-by: Stefan Hajnoczi
---
vl.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/vl.c b/vl.c
index a4a520f..4871428 100644
--- a/vl.c
+++ b/vl.c
@@ -3204,6 +3204,11 @@ int main(int argc, char **argv, char **envp
From: Peter Maydell
Fix a variety of typos in comments in target-arm files.
Signed-off-by: Peter Maydell
Reviewed-by: Peter Crosthwaite
Signed-off-by: Stefan Hajnoczi
---
target-arm/arm-semi.c|2 +-
target-arm/cpu.h |2 +-
target-arm/helper.c |6 +++---
target
On Wed, Aug 8, 2012 at 9:29 AM, Stefan Priebe wrote:
> ah OK - thanks. Will there be a fixed 1.1.2 as well?
mdroth: Kevin has the fix in his block branch, which means qemu.git
will get it soon. Here's the commit:
http://repo.or.cz/w/qemu/kevin.gi
Glib2 uses __printf__ in macro G_GNUC_PRINTF for printf like
functions. For MinGW, we want __gnu_printf__ because we use
POSIX format specifiers instead of the MS format specifiers.
Signed-off-by: Stefan Weil
---
configure |2 ++
1 file changed, 2 insertions(+)
diff --git a/configure b
One more...
Signed-off-by: Stefan Weil
---
scripts/simpletrace.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py
index 1e74e75..9fce4bb 100755
--- a/scripts/simpletrace.py
+++ b/scripts/simpletrace.py
@@ -71,7 +71,7 @@ def
It's still not good, but hopefully better than before.
Signed-off-by: Stefan Weil
---
ui/vnc-enc-zywrle.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/vnc-enc-zywrle.h b/ui/vnc-enc-zywrle.h
index 188e247..addee55 100644
--- a/ui/vnc-enc-zywrle.h
+++ b/ui/vn
Signed-off-by: Stefan Weil
---
docs/bootindex.txt |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/bootindex.txt b/docs/bootindex.txt
index 16083b3..803ebfc 100644
--- a/docs/bootindex.txt
+++ b/docs/bootindex.txt
@@ -1,4 +1,4 @@
-= Bootindex propery =
+= Bootindex
Signed-off-by: Stefan Weil
---
hw/versatilepb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/versatilepb.c b/hw/versatilepb.c
index 4fd5d9b..7a92034 100644
--- a/hw/versatilepb.c
+++ b/hw/versatilepb.c
@@ -162,7 +162,7 @@ static int vpb_sic_init(SysBusDevice *dev
The patch also fixes the case of "written".
Signed-off-by: Stefan Weil
---
hw/imx_avic.c |4 ++--
hw/imx_timer.c |4 ++--
hw/kzm.c |2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/imx_avic.c b/hw/imx_avic.c
index 4f010e8..b1a8fe6 10064
These wrong spellings were detected by codespell:
* successully -> successfully
* alot -> a lot
* wanna -> want to
* infomation -> information
* occured -> occurred
Signed-off-by: Stefan Weil
---
docs/specs/ppc-spapr-hcalls.txt |2 +-
docs/usb2.txt
QEMU_PACKED results in a MinGW compiler warning when it is
used for single structure elements:
warning: 'gcc_struct' attribute ignored
Using QEMU_PACKED for the whole structure avoids the compiler warning
without changing the memory layout.
Signed-off-by: Stefan Weil
---
hw/sr
On Sat, Aug 11, 2012 at 12:11 AM, Peter Crosthwaite
wrote:
> On Fri, Aug 10, 2012 at 11:42 PM, Stefan Hajnoczi wrote:
>> On Fri, Aug 10, 2012 at 01:54:26PM +1000, Peter A. G. Crosthwaite wrote:
>>> The sizep arg is populated with the size of the loaded device tree. Since
>
obs=32. At numjobs=16 here
> with vhost the 16x LUN configuration ends up being in the range of ~310K
> IOPs for the current sweet spot..
This makes me wonder what a comparison against baremetal looks like
and the perf top, mpstat, and kvm_stat results on the host.
Stefan
Am 11.08.2012 16:42, schrieb Blue Swirl:
On Fri, Aug 10, 2012 at 7:45 PM, Stefan Weil wrote:
Glib2 uses __printf__ in macro G_GNUC_PRINTF for printf like
functions. For MinGW, we want __gnu_printf__ because we use
POSIX format specifiers instead of the MS format specifiers.
I get these
oticed some messages from checkpatch.pl.
Some (but not all) of them were caused by the renamed file.
Maybe this file should be fixed before it is renamed.
Regards,
Stefan
Signed-off-by: Stefan Weil
---
hw/framebuffer.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/framebuffer.c b/hw/framebuffer.c
index f4747cd..85a00a5 100644
--- a/hw/framebuffer.c
+++ b/hw/framebuffer.c
@@ -28,7 +28,7 @@ void framebuffer_update_display
Paolo Bonzini.
qcow2 marks the discarded blocks as free and will reuse them in future
allocations. It does *not* discard at the OS level.
For raw files you can get discard to work on an xfs host file system.
In the future ext4 support can also be added.
Stefan
Am 12.08.2012 00:03, schrieb Anthony Liguori:
Peter Maydell writes:
On 18 July 2012 10:28, Peter Maydell wrote:
On 12 March 2012 20:12, Stefan Weil wrote:
We also need more resources for technical maintenance of the
QEMU infrastructure. For example, the official mirror of the
QEMU git
memory_region_init(&dev->msix_exclusive_bar, name,
MSIX_EXCLUSIVE_BAR_SIZE);
-
-free(name);
+g_free(name);
ret = msix_init(dev, nentries, &dev->msix_exclusive_bar, bar_nr,
MSIX_EXCLUSIVE_BAR_TABLE_OFFSET, &dev->msix_exclusive_bar,
Reviewed-by: Stefan Weil
Am 11.08.2012 21:27, schrieb Stefan Weil:
Am 07.08.2012 13:17, schrieb Paolo Bonzini:
This patch series is part 2 in my EventNotifier/AIO improvements
for QEMU 1.2. It extends use of EventNotifier to the main loop
and AIO subsystems. A new API using EventNotifier is added to aio.c
and a new
asprintf is not available for all hosts. g_strdup_printf is
more portable and simplifies the code because if does not
need error handling.
The static variable does not need an explicit assignment to be NULL.
Cc: Stefan Hajnoczi
Signed-off-by: Stefan Weil
---
trace/simple.c | 14
gcc complains when a 32 bit pointer is casted to a 64 bit integer.
Cc: Stefan Hajnoczi
Signed-off-by: Stefan Weil
---
scripts/tracetool/backend/simple.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/tracetool/backend/simple.py
b/scripts/tracetool/backend
From: spriebe
---
block/iscsi.c | 36
1 files changed, 20 insertions(+), 16 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 12ca76d..257f97f 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -76,6 +76,10 @@ static void
iscsi_abort_task_cb(st
or:$device PCI adapter is hotplugged into
the host?
Is there a way to bind vfio-pci on a per-adapter basis instead of a
per-$vendor:$device?
Stefan
Switch to my personal email address.
Signed-off-by: Stefan Hajnoczi
---
Access to the IBM email address ceases from September 2012.
Keeping qemu-trivial moving during September should be no problem. I'll be
back 100% and continuing to contribute to QEMU in October again.
MAINTAINERS |
On Tue, Aug 14, 2012 at 08:44:46AM +0200, Stefan Priebe wrote:
> From: spriebe
CCing Ronnie, iSCSI block driver author.
>
> ---
> block/iscsi.c | 36
> 1 files changed, 20 insertions(+), 16 deletions(-)
>
> diff --git a/block/is
On Tue, Aug 14, 2012 at 1:09 PM, ronnie sahlberg
wrote:
> Is a reply with the text
>
> Acked-by: Ronnie Sahlberg
>
> sufficient ?
Yes
On Mon, Aug 13, 2012 at 09:50:56PM +0200, Stefan Weil wrote:
> gcc complains when a 32 bit pointer is casted to a 64 bit integer.
>
> Cc: Stefan Hajnoczi
> Signed-off-by: Stefan Weil
> ---
> scripts/tracetool/backend/simple.py |2 +-
> 1 files changed, 1 inser
On Mon, Aug 13, 2012 at 09:51:16PM +0200, Stefan Weil wrote:
> asprintf is not available for all hosts. g_strdup_printf is
> more portable and simplifies the code because if does not
> need error handling.
>
> The static variable does not need an explicit assignment to be NULL.
1 - 100 of 34926 matches
Mail list logo
