On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet <benoit.ca...@gmail.com> wrote:
> Signed-off-by: Benoit Canet <ben...@irqsave.net>
> ---
> block/quorum.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 9da0432..5cd7083 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -118,12 +118,29 @@ static void quorum_close(BlockDriverState *bs)
> }
> }
>
> +static int64_t quorum_getlength(BlockDriverState *bs)
> +{
> + BDRVQuorumState *s = bs->opaque;
> + int i;
> + int64_t ret;
> +
> + /* return the length of the first available quorum file */
> + for (i = 0, ret = bdrv_getlength(s->bs[i]);
> + ret == -ENOMEDIUM && i <= 2;
> + i++, ret = bdrv_getlength(s->bs[i])) {
> + }
Why is -ENOMEDIUM an expected error value?
IMO a for loop with a body or a do while loop would make this easier to read.
