[PATCH v1 05/12] qht: call qemu_spin_destroy for head buckets

2020-05-29 Thread Robert Foley
From: "Emilio G. Cota" Signed-off-by: Robert Foley --- util/qht.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/qht.c b/util/qht.c index aa51be3c52..67e5d5b916 100644 --- a/util/qht.c +++ b/util/qht.c @@ -348,6 +348,7 @@ static inline void qht_chain_destroy(const struct

[PATCH v1 01/12] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

2020-05-29 Thread Robert Foley
+-9 --disable-werror' configure flags. Signed-off-by: Lingfeng Yang Signed-off-by: Emilio G. Cota [cota: minor modifications + configure changes] Signed-off-by: Robert Foley [RF: Error out in configure if tsan not available, fix checkpatch warnings] --- configure | 41

[PATCH v1 09/12] tests/docker: Added docker build support for TSan.

2020-05-29 Thread Robert Foley
TSAN suppresion file to disable certain cases of TSAN warnings. Cc: Fam Zheng Cc: Philippe Mathieu-Daudé Signed-off-by: Robert Foley --- tests/docker/Makefile.include | 2 + tests/docker/common.rc | 19 +++ tests/docker/dockerfiles/ubuntu2004.docker | 65

[PATCH v1 03/12] thread: add qemu_spin_destroy

2020-05-29 Thread Robert Foley
From: "Emilio G. Cota" It will be used for TSAN annotations. Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- include/qemu/thread.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/qemu/thread.h b/include/qemu/thread.h index d22848138e..e50a073889 10

[PATCH v1 06/12] tcg: call qemu_spin_destroy for tb->jmp_lock

2020-05-29 Thread Robert Foley
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley [RF: Minor changes to fix some checkpatch errors] --- accel/tcg/translate-all.c | 10 +- include/tcg/tcg.h | 3 ++- tcg/tcg.c | 19 --- 3 files c

[PATCH v1 08/12] thread: add tsan annotations to QemuSpin

2020-05-29 Thread Robert Foley
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- include/qemu/thread.h | 39 --- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/include/qemu/thread.h b/include/qemu/thread.h index e50a073889..

[PATCH v1 07/12] translate-all: call qemu_spin_destroy for PageDesc

2020-05-29 Thread Robert Foley
From: "Emilio G. Cota" The radix tree is append-only, but we can fail to insert a PageDesc if the insertion races with another thread. Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/translate-all.c | 9 + 1 file changed, 9 insertions(+) diff --g

[PATCH v1 10/12] include/qemu: Added tsan.h for annotations.

2020-05-29 Thread Robert Foley
These annotations will allow us to give tsan additional hints. For example, we can inform tsan about reads/writes to ignore to silence certain classes of warnings. We can also annotate threads so that the proper thread naming shows up in tsan warning results. Signed-off-by: Robert Foley

[PATCH v1 11/12] util: Added tsan annotate for thread name.

2020-05-29 Thread Robert Foley
This allows us to see the name of the thread in tsan warning reports such as this: Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at: Signed-off-by: Robert Foley --- util/qemu-thread-posix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/qemu-thread

[PATCH v1 12/12] docs: Added details on TSan to testing.rst

2020-05-29 Thread Robert Foley
Adds TSan details to testing.rst. This includes background and reference details on TSan, and details on how to build and test with TSan both with and without docker. Signed-off-by: Robert Foley Reviewed-by: Emilio G. Cota --- docs/devel/testing.rst | 113

Re: [PATCH v1 01/12] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

2020-05-29 Thread Robert Foley
On Fri, 29 May 2020 at 09:51, Eric Blake wrote: > > On 5/29/20 8:23 AM, Robert Foley wrote: > > From: Lingfeng Yang > > > > We tried running QEMU under tsan in 2016, but tsan's lack of support for > > longjmp-based fibers was a blocker: > >https

ia-32/ia-64 fxsave64 instruction behavior when saving mmx

2020-05-29 Thread Robert Henry
Background: The ia-32/ia-64 fxsave64 instruction saves fp80 or legacy SSE mmx registers. The mmx registers are saved as if they were fp80 values. The lower 64 bits of the constructed fp80 value is the mmx register. The upper 16 bits of the constructed fp80 value are reserved; see the last row o

[PATCH v8 00/12] tests/vm: Add support for aarch64 VMs

2020-05-29 Thread Robert Foley
--build-path argument instead. Robert Foley (12): tests/vm: pass args through to BaseVM's __init__ tests/vm: Add configuration to basevm.py tests/vm: Added configuration file support tests/vm: Pass --debug through for vm-boot-ssh. tests/vm: Add ability to select QEMU from current

[PATCH v8 01/12] tests/vm: pass args through to BaseVM's __init__

2020-05-29 Thread Robert Foley
Adding the args parameter to BaseVM's __init__. We will shortly need to pass more parameters to the class so let's just pass args rather than growing the parameter list. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée --- tests/vm/basevm.py | 13 ++--- 1 file changed, 6

[PATCH v8 07/12] tests/vm: Add common Ubuntu python module

2020-05-29 Thread Robert Foley
Add a common Ubuntu python module and make use of it with the ubuntu.i386 script. This is preparation for adding an Ubuntu script ubuntu.aarch64. Splitting out the common logic such as build_image() will reduce duplication. Signed-off-by: Robert Foley --- tests/vm/ubuntu.i386 | 46

[PATCH v8 03/12] tests/vm: Added configuration file support

2020-05-29 Thread Robert Foley
.yml. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- configure | 9 ++ tests/vm/Makefile.include | 6 tests/vm/basevm.py| 40 +++- tests/vm/conf_example_aarch64.yml | 51

[PATCH v8 02/12] tests/vm: Add configuration to basevm.py

2020-05-29 Thread Robert Foley
to vary on the VM being created or launched. This will for example allow for creating an aarch64 vm. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/basevm.py | 172 +++-- 1 file changed, 133 insertions(+), 39

[PATCH v8 04/12] tests/vm: Pass --debug through for vm-boot-ssh.

2020-05-29 Thread Robert Foley
This helps debug issues that occur during the boot sequence. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/Makefile.include | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index d9b34eae63

[PATCH v8 05/12] tests/vm: Add ability to select QEMU from current build.

2020-05-29 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 23 --- 2 files

[PATCH v8 06/12] tests/vm: allow wait_ssh() to specify command

2020-05-29 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index

[PATCH v8 09/12] tests/vm: Added a new script for centos.aarch64.

2020-05-29 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm

[PATCH v8 08/12] tests/vm: Added a new script for ubuntu.aarch64.

2020-05-29 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- configure

[PATCH v8 10/12] tests/vm: change scripts to use self._config

2020-05-29 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Ro

[PATCH v8 11/12] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-05-29 Thread Robert Foley
basevm.py since there is a known issue where QEMU will hang waiting for console characters to be consumed. Cc: Eduardo Habkost Cc: Cleber Rosa Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Acked-by: Alex Bennée --- python/qemu/console_socket.py | 118 ++ python

[PATCH v8 12/12] tests/vm: Add workaround to consume console

2020-05-29 Thread Robert Foley
characters to be consumed. We also added the option of logging the console to a file. LOG_CONSOLE=1 will now log the output to a file. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Acked-by: Alex Bennée --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 17 +++-- 2

Re: ia-32/ia-64 fxsave64 instruction behavior when saving mmx

2020-05-31 Thread Robert Henry
in the SSE_HELPER_B macro which takes a MMXREG which is an MMREG_UNION which does not provide, to the extent that I can figure this out, a handle to bits 79:64 of the aliased-with x87 register. I find it hard to believe that an apparent bug like this has been here "forever". Am I mi

Re: [PATCH v8 07/12] tests/vm: Add common Ubuntu python module

2020-06-01 Thread Robert Foley
On Sun, 31 May 2020 at 06:37, Philippe Mathieu-Daudé wrote: > > On 5/29/20 10:34 PM, Robert Foley wrote: > > Add a common Ubuntu python module and make use of > > it with the ubuntu.i386 script. > > This is preparation for adding an Ubuntu script > > ubuntu.aarc

Re: [PATCH v8 12/12] tests/vm: Add workaround to consume console

2020-06-01 Thread Robert Foley
On Sun, 31 May 2020 at 07:27, Philippe Mathieu-Daudé wrote: > > On 5/29/20 10:34 PM, Robert Foley wrote: > > @@ -271,7 +276,9 @@ class BaseVM(object): > > args += self._data_args + extra_args + self._config['extra_args'] > > logging.de

Re: [PATCH v8 11/12] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-06-01 Thread Robert Foley
Hi Philippe, On Sun, 31 May 2020 at 07:22, Philippe Mathieu-Daudé wrote: > > On 5/29/20 10:34 PM, Robert Foley wrote: > > We add the ConsoleSocket object, which has a socket interface > > and which will consume all arriving characters on the > > socket, placing them

Re: [PATCH v8 08/12] tests/vm: Added a new script for ubuntu.aarch64.

2020-06-01 Thread Robert Foley
On Sun, 31 May 2020 at 06:54, Alex Bennée wrote: > > > Philippe Mathieu-Daudé writes: > > > Hi Robert, > > > > On 5/29/20 10:34 PM, Robert Foley wrote: > > >> diff --git a/configure b/configure > >> index d82de47fdd..8a286e75a5 100755 >

[PATCH v9 1/9] tests/vm: pass args through to BaseVM's __init__

2020-06-01 Thread Robert Foley
Adding the args parameter to BaseVM's __init__. We will shortly need to pass more parameters to the class so let's just pass args rather than growing the parameter list. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mat

[PATCH v9 0/9] tests/vm: Add support for aarch64 VMs

2020-06-01 Thread Robert Foley
indentation of efi-aarch64 code in configure. - Updated file header for ubuntuvm.py - Few minor changes in ConsoleSocket - Updated some comments in basevm.py around the call to QEMUMachine regarding drain_console=True. Robert Foley (9): tests/vm: pass args through to BaseVM's __init__

[PATCH v9 5/9] tests/vm: Added a new script for ubuntu.aarch64.

2020-06-01 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- configure

[PATCH v9 2/9] tests/vm: Add configuration to basevm.py

2020-06-01 Thread Robert Foley
to vary on the VM being created or launched. This will for example allow for creating an aarch64 vm. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/basevm.py | 172 +++-- 1 file changed, 133 insertions(+), 39

[PATCH v9 7/9] tests/vm: change scripts to use self._config

2020-06-01 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Ro

[PATCH v9 4/9] tests/vm: Add common Ubuntu python module

2020-06-01 Thread Robert Foley
Add a common Ubuntu python module and make use of it with the ubuntu.i386 script. This is preparation for adding an Ubuntu script ubuntu.aarch64. Splitting out the common logic such as build_image() will reduce duplication. Signed-off-by: Robert Foley Tested-by: Philippe Mathieu-Daudé

[PATCH v9 3/9] tests/vm: Added configuration file support

2020-06-01 Thread Robert Foley
.yml. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- configure | 9 ++ tests/vm/Makefile.include | 6 tests/vm/basevm.py| 40 +++- tests/vm/conf_example_aarch64.yml | 51

[PATCH v9 8/9] python/qemu: Add ConsoleSocket for optional use in QEMUMachine

2020-06-01 Thread Robert Foley
basevm.py since there is a known issue where QEMU will hang waiting for console characters to be consumed. Cc: Eduardo Habkost Cc: Cleber Rosa Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Acked-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé --- python/qemu/console_socket.py | 110

[PATCH v9 6/9] tests/vm: Added a new script for centos.aarch64.

2020-06-01 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm

[PATCH v9 9/9] tests/vm: Add workaround to consume console

2020-06-01 Thread Robert Foley
characters to be consumed. We also added the option of logging the console to a file. LOG_CONSOLE=1 will now log the output to a file. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Acked-by: Alex Bennée --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 21

plugin order of registration and order of callback

2020-01-06 Thread Robert Henry
The documentation on the new plugin capabilities of qemu is silent about the order call back registration should be done, and is also silent on the order in which call backs are fired. Case in point: The callback registered by qemu_plugin_register_vcpu_mem_cb is called after the call back regis

Re: [EXTERNAL] Re: Range of vcpu_index to plugin callbacks

2021-09-20 Thread Robert Henry
: Sunday, September 19, 2021 10:54 AM To: rrh.henry ; qemu-disc...@nongnu.org Cc: Alex Bennée ; qemu-devel Subject: [EXTERNAL] Re: Range of vcpu_index to plugin callbacks (Cc'ing qemu-devel@ mailing list since this is a development question). On 9/19/21 19:44, Robert Henry wrote: > What is t

[Qemu-devel] [Bug 1823169] [NEW] qemu displays message "Setup failed, please check external storage is available and has enough room."

2019-04-04 Thread Robert Uomini
Public bug reported: I tried to launch the Android app PokerStarsFR, and after it began initialization, the launch failed with the above error. I'm running qemu on a Dell XPS 13 (9370) laptop running Ubuntu 16.04 LTS. The standard apps launch OK, but this one does not. I had downloaded it from the

Re: [Qemu-devel] [Bug 1823169] Re: qemu displays message "Setup failed, please check external storage is available and has enough room."

2019-04-04 Thread Robert Uomini
Thanks, Thomas. I know that qemu 3.0 is out now, but when I tried to update qemu on my system, I only got the following: ruomini@ruomini-XPS-13-9370:~/Downloads$ sudo apt-get install qemu Reading package lists... Done Building dependency tree Reading state information... Done qemu is already the n

Re: [Qemu-devel] [Bug 1823169] Re: qemu displays message "Setup failed, please check external storage is available and has enough room."

2019-04-05 Thread Robert Uomini
On Fri, Apr 5, 2019 at 8:05 AM Christian Ehrhardt  < 1823...@bugs.launchpad.net> wrote: > I agree to Thomas, and in that case referring to your comment #2 - qemu > versions in Ubuntu are associated with the base Ubuntu version - so Ubuntu > 16.04 will stick to qemu 2.5 + fixes. > Ubuntu 19.10 rel

Re: [Qemu-devel] [PATCH] i386: Disable OSPKE on CPU model definitions

2019-03-21 Thread Robert Hoo
ible > impact. > > Include a test case that should detect the problem if we introduce > a similar bug again. > > Fixes: c7a88b52f62b ("i386: Add new model of Cascadelake-Server") > Fixes: 8a11c62da914 ("i386: Add new CPU model Icelake- > {Server,Clien

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-10 Thread Robert Hoo
On Wed, 2020-09-09 at 14:15 -0400, Eduardo Habkost wrote: > Hi, > > Thanks for the patch, and sorry for taking so long to review > this. I'm finally getting to the patches that were postponed to > 5.2. > > Comments and questions below: > > On Thu, Jun 11, 2020

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-14 Thread Robert Hoo
On Fri, 2020-09-11 at 10:00 -0400, Eduardo Habkost wrote: > On Fri, Sep 11, 2020 at 02:22:51PM +0800, Robert Hoo wrote: > > On Wed, 2020-09-09 at 14:15 -0400, Eduardo Habkost wrote: > > > Hi, > > > > > > > > > > @@ -1129,6 +1130,12 @@ void mach

Re: [PATCH v2 1/2] Introduce (x86) CPU model deprecation API

2020-09-14 Thread Robert Hoo
On Mon, 2020-09-14 at 13:38 +, Eduardo Habkost wrote: > On Mon, Sep 14, 2020 at 06:50:09PM +0800, Robert Hoo wrote: > > On Fri, 2020-09-11 at 10:00 -0400, Eduardo Habkost wrote: > > > On Fri, Sep 11, 2020 at 02:22:51PM +0800, Robert Hoo wrote: > > > > On Wed, 2020

[PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-16 Thread Robert Hoo
x86_cpu_list_entry(), e.g. '-cpu help'. QMP 'query-cpu-definitions' will also return a bool value indicating the deprecation status. Signed-off-by: Robert Hoo --- Changelog v3: Make the deprecation implementation CPUClass generic. v2: Move deprecation check from parse_cpu_option() to ma

[PATCH v3 2/2] Mark Icelake-Client CPU models deprecated

2020-09-16 Thread Robert Hoo
Going to obsolete Icelake-Client CPU models in the future. Signed-off-by: Robert Hoo --- Change log v3: Obsolete in v5.2 --> v5.3. target/i386/cpu.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 9cb82b7..15c1c00 100

Re: [PATCH v3 2/2] Mark Icelake-Client CPU models deprecated

2020-09-17 Thread Robert Hoo
On Thu, 2020-09-17 at 14:01 -0400, Eduardo Habkost wrote: > On Wed, Sep 16, 2020 at 04:37:14PM +0800, Robert Hoo wrote: > > Going to obsolete Icelake-Client CPU models in the future. > > > > Signed-off-by: Robert Hoo > > --- > > Change log > > v3: > >

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-17 Thread Robert Hoo
On Thu, 2020-09-17 at 14:18 -0400, Eduardo Habkost wrote: > I think the patch looks better now, thanks! > > Just a few minor questions and suggestions: > > On Wed, Sep 16, 2020 at 04:37:13PM +0800, Robert Hoo wrote: > > Complement versioned CPU model framework with the a

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-18 Thread Robert Hoo
On Fri, 2020-09-18 at 16:42 +, Eduardo Habkost wrote: > ... > > > > --- > > > > Changelog > > > > v3: > > > > Make the deprecation implementation CPUClass generic. > > > > > > > > v2: > > > > Move deprecation check from parse_cpu_option() to > > > > machine_run_board_init(), so > > > > that it

Re: [PATCH v3 2/2] Mark Icelake-Client CPU models deprecated

2020-09-21 Thread Robert Hoo
On Fri, 2020-09-18 at 00:20 -0400, Eduardo Habkost wrote: > On Fri, Sep 18, 2020 at 10:18:56AM +0800, Robert Hoo wrote: > > On Thu, 2020-09-17 at 14:01 -0400, Eduardo Habkost wrote: > > > On Wed, Sep 16, 2020 at 04:37:14PM +0800, Robert Hoo wrote: > > > > Going

Re: [PATCH v3 1/2] Introduce (x86) CPU model deprecation API

2020-09-21 Thread Robert Hoo
On Mon, 2020-09-21 at 11:37 -0400, Eduardo Habkost wrote: > > ... > > Yes. Trying as less refactor as possible. I think my changes even > > cannot be called refactor at all. :) > > My idea is to make unversioned CPU model virtual. I did some patch, > > doable: > > 1) in x86_register_cpudef_types()

[PATCH v4 1/2] Introduce (x86) CPU model deprecation API

2020-09-22 Thread Robert Hoo
x86_cpu_list_entry(), e.g. '-cpu help'. QMP 'query-cpu-definitions' will also return a bool value indicating the deprecation status. Signed-off-by: Robert Hoo --- Changelog v4: Move deprecation_note from X86CPUModel to X86CPUDefinition, to make it simple. Also, simplify 2 fields (

[PATCH v4 2/2] Mark Icelake-Client CPU models deprecated

2020-09-22 Thread Robert Hoo
Going to obsolete Icelake-Client CPU models in the future. Signed-off-by: Robert Hoo --- Change log v4: Deprecation note is general now. More detailed information is moved to docs/system/deprecated.rst. v3: Obsolete in v5.2 --> v5.3. --- docs/system/deprecated.rst | 6 ++ target/i

Re: [PATCH v4 1/2] Introduce (x86) CPU model deprecation API

2020-10-02 Thread Robert Hoo
On Wed, 2020-09-30 at 17:56 -0400, Eduardo Habkost wrote: > On Tue, Sep 22, 2020 at 03:14:14PM +0800, Robert Hoo wrote: > > Complement versioned CPU model framework with the ability of > > marking some > > versions deprecated. When that CPU model is chosen, get some > &g

[Bug 1898490] Re: gtk with virtio and opengl black screen

2020-10-07 Thread Olivier Robert
Hello Christian, I should have pointed that the log is from the Android system, not Qemu or my host system ! I got the failure message running the following command in an Android shell : logcat '*:F' (which means display log entries from all facilities (*), with the Fatal (F) severity) It seem

[Bug 1898490] Re: gtk with virtio and opengl black screen

2020-10-07 Thread Olivier Robert
Oops sorry, I misposted, is there any way to remove this ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1898490 Title: gtk with virtio and opengl black screen Status in QEMU: New Bug descripti

Re: [PATCH-for-5.2] exec: Remove MemoryRegion::global_locking field

2020-08-23 Thread Robert Foley
On Sat, 22 Aug 2020 at 16:13, Philippe Mathieu-Daudé wrote: > > +Robert > > On 8/7/20 12:16 PM, Paolo Bonzini wrote: > > On 07/08/20 12:02, Stefan Hajnoczi wrote: > >> On Thu, Aug 06, 2020 at 05:07:26PM +0200, Philippe Mathieu-Daudé wrote: > >>> Last use

Re: [PATCH v2 0/7] accel/tcg: remove implied BQL from cpu_handle_interrupt/exception path

2020-08-27 Thread Robert Foley
On Fri, 21 Aug 2020 at 06:56, Cornelia Huck wrote: > > > > As the first step in removing the BQL from this path, we will make > > changes to the core/common functions of cpu_handle_interrupt/exception > > to drop the holding of the BQL. The holding of the BQL is pushed down > > to the per-arch imp

Re: [PATCH v2 2/6] plugins: new lockstep plugin for debugging TCG changes

2020-06-11 Thread Robert Foley
Reviewed-by: Robert Foley Tested-by: Robert Foley The testing was mostly bringing up pairs of aarch64 VMs and either waiting for the divergence or exiting out before divergence with ctrl-a x at various stages of boot. When we exit from the VM before divergence, we observe the below: we seem to

[PATCH v10 14/73] cpu: define cpu_halted helpers

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" cpu->halted will soon be protected by cpu->lock. We will use these helpers to ease the transition, since right now cpu->halted has many direct callers. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-o

[PATCH v10 00/73] per-CPU locks

2020-06-17 Thread Robert Foley
L Paolo Bonzini (4): ppc: use cpu_reset_interrupt i386: use cpu_reset_interrupt s390x: use cpu_reset_interrupt openrisc: use cpu_reset_interrupt Robert Foley (1): hw/semihosting: convert to cpu_halted_set accel/tcg/cpu-exec.c| 40 ++- accel/tcg/cputlb.c |

[PATCH v10 01/73] cpu: rename cpu->work_mutex to cpu->lock

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" This lock will soon protect more fields of the struct. Give it a more appropriate name. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 14 +++-

[PATCH v10 04/73] cpu: move run_on_cpu to cpus-common

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" We don't pass a pointer to qemu_global_mutex anymore. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 2 +- cpus.c| 5 - include/hw/

[PATCH v10 02/73] cpu: introduce cpu_mutex_lock/unlock

2020-06-17 Thread Robert Foley
vCPUs are locked by the same thread, which explains why the bitmap is introduced here. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota [RF: Add assert in smp_parse. Make cpu_mutex_lock stub empty] Signed-off-by: Robert Foley --- cpus.c

[PATCH v10 03/73] cpu: make qemu_work_cond per-cpu

2020-06-17 Thread Robert Foley
f-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 72 ++- cpus.c| 2 +- hw/core/cpu.c | 1 + include/hw/core/cpu.h | 6 ++-- 4 files changed, 63 insertions(+), 18 deletions(-) diff --git a/cpus-comm

[PATCH v10 05/73] cpu: introduce process_queued_cpu_work_locked

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" This completes the conversion to cpu_mutex_lock/unlock in the file. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 17 +++-- 1 file changed, 11 insert

[PATCH v10 19/73] sh4: convert to cpu_halted

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Cc: Aurelien Jarno Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sh4/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sh4/op_helper.c b/

[PATCH v10 10/73] hppa: convert to helper_cpu_halted_set

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/hppa/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/transla

[PATCH v10 07/73] tcg-runtime: define helper_cpu_halted_set

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/tcg-runtime.c | 7 +++ accel/tcg/tcg-runtime.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/accel/tcg/tcg-runtime

[PATCH v10 20/73] i386: convert to cpu_halted

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Cc: Eduardo Habkost Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted new code in i386/hax-all.c to cpu_halted] Signed-off-by: Robert Foley --- target/i386/cpu.c | 2 +- target/i386/cpu.h

[PATCH v10 06/73] cpu: make per-CPU locks an alias of the BQL in TCG rr mode

2020-06-17 Thread Robert Foley
ex_destroy, and call from cpu_common_finalize, to avoid destroying qemu_global_mutex, when cpu mutex is destroyed. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota [RF: Fixed destroy issue, added cpu_mutex_destroy.] Signed-off-by: Robert Foley ---

[PATCH v10 09/73] cris: convert to helper_cpu_halted_set

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" And fix the temp leak along the way. Reviewed-by: Edgar E. Iglesias Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/cris/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH v10 24/73] riscv: convert to cpu_halted

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Cc: Sagar Karandikar Cc: Bastian Koppelmann Reviewed-by: Palmer Dabbelt Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/riscv/op_helper.c | 2 +- 1 file changed, 1 inser

[PATCH v10 21/73] lm32: convert to cpu_halted

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Cc: Michael Walle Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/lm32/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/lm32/op_helper.

[PATCH v10 08/73] ppc: convert to helper_cpu_halted_set

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Acked-by: David Gibson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/ppc/translate.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) di

[PATCH v10 11/73] m68k: convert to helper_cpu_halted_set

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Laurent Vivier Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/m68k/translate.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/t

[PATCH v10 22/73] m68k: convert to cpu_halted

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/m68k/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/op_

[PATCH v10 18/73] ppc: convert to cpu_halted

2020-06-17 Thread Robert Foley
f not already held) from cpu_has_work. Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: hw/ppc/spapr_hcall.c, spapr_rtas.c more conversions] Signed-off-by: Robert Foley --- hw/ppc/e500.c | 4 ++-- hw/ppc/ppc.c

[PATCH v10 26/73] sparc: convert to cpu_halted

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Cc: Fabien Chouteau Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/sparc/leon3.c | 2 +- hw/sparc/sun4m.c | 8

[PATCH v10 12/73] alpha: convert to helper_cpu_halted_set

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/alpha/translate.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/t

[PATCH v10 27/73] xtensa: convert to cpu_halted

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Cc: Max Filippov Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/xtensa/cpu.c| 2 +- target/xtensa/exc_helper.c | 2 +- target/xtensa/helper.c | 2 +- 3 files

[PATCH v10 36/73] s390x: use cpu_reset_interrupt

2020-06-17 Thread Robert Foley
From: Paolo Bonzini Cc: qemu-s3...@nongnu.org Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson Reviewed-by: Cornelia Huck Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/s390x/excp_helper.c | 2 +- 1

[PATCH v10 23/73] mips: convert to cpu_halted

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted code in target/mips/kvm.c to cpu_halted.] Signed-off-by: Robert Foley --- hw/mips/cps.c| 2 +- hw/misc/mips_itu.c | 4 ++-- target/mips/cp

[PATCH v10 13/73] microblaze: convert to helper_cpu_halted_set

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Edgar E. Iglesias Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/microblaze/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/

[PATCH v10 33/73] ppc: use cpu_reset_interrupt

2020-06-17 Thread Robert Foley
From: Paolo Bonzini Cc: qemu-...@nongnu.org Acked-by: David Gibson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/ppc/excp_helper.c | 2 +- 1

[PATCH v10 39/73] i386: convert to cpu_interrupt_request

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/cpu.c| 2 +- target/i386/helper.c | 4 ++-- target/i386/svm_helper.c | 4 ++-- 3 files changed, 5 insertions(+), 5

[PATCH v10 25/73] s390x: convert to cpu_halted

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Cc: Christian Borntraeger Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Cornelia Huck Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/intc/s390_flic.c| 2

[PATCH v10 40/73] i386/kvm: convert to cpu_interrupt_request

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/kvm.c | 58 --- 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/t

[PATCH v10 16/73] hw/semihosting: convert to cpu_halted_set

2020-06-17 Thread Robert Foley
Signed-off-by: Robert Foley Reviewed-by: Alex Bennée --- hw/semihosting/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c index 22e7827824..01cafa4bca 100644 --- a/hw/semihosting/console.c +++ b/hw/semihosting

[PATCH v10 28/73] gdbstub: convert to cpu_halted

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 6950fd243f..b25796b33d 10

[PATCH v10 34/73] exec: use cpu_reset_interrupt

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index d6712fba7e..58fc928801 100644 --- a/ex

[PATCH v10 35/73] i386: use cpu_reset_interrupt

2020-06-17 Thread Robert Foley
From: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/hax-all.c| 4 ++-- target/i386/hvf/x86hvf.c | 8 target/i386/kvm.c| 14

[PATCH v10 15/73] tcg-runtime: convert to cpu_halted_set

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/tcg-runtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runti

[PATCH v10 46/73] cris: convert to cpu_interrupt_request

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Edgar E. Iglesias Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/cris/cpu.c| 2 +- target/cris/helper.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletion

[PATCH v10 31/73] cpu: convert to cpu_halted

2020-06-17 Thread Robert Foley
From: "Emilio G. Cota" This finishes the conversion to cpu_halted. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 2 +- cpus.c | 4 ++-- hw/core/cpu.c

<    5   6   7   8   9   10   11   >