characters to be consumed.
We also add the option of logging the console to a file.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
---
python/qemu/console_socket.py | 162 ++
python/qemu/machine.py| 23 -
tests/vm/Makefile.include | 4 +
tests/vm
This change converts existing scripts to using for example self.ROOT_PASS,
to self._config['root_pass'].
We made similar changes for GUEST_USER, and GUEST_PASS.
This allows us also to remove the change in basevm.py,
which adds __getattr__ for backwards compatibility.
Signed-off-by: Ro
A simpler case seems to produce the same error. See
https://bugs.launchpad.net/qemu/+bug/1824344
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1866892
Title:
guest OS catches a page fault bug whe
This appears to be similar to
https://bugs.launchpad.net/qemu/+bug/1866892 (and much simpler)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1824344
Title:
x86: retf or iret pagefault sets wrong err
I have confirmed that the dotnet guest application is executing a
"iretq" instruction when this guest kernel bug is hit. A first round of
analysis shows nothing unreasonable at the point the iretq is executed.
The $rsp points into the middle of a mapped in page, the returned-to
$rip looks reasonabl
yes, it is intentional. I don't yet understand why, but am talking to
those who do.
https://github.com/dotnet/runtime/blob/1b02665be501b695b9c22c1ebd69148c07a225f6/src/coreclr/src/pal/src/arch/amd64/context2.S#L183
--
You received this bug notification because you are a member of qemu-
devel-ml,
On Fri, 15 May 2020 at 13:28, Alex Bennée wrote:
>
> Hi Robert,
>
> Here are a couple of patches you might want to add to the start of
> your vm build series that deal with the fact genisoimage might not
> exist or have a different name.
Hi Alex,
Sounds good. I will add them t
Hi Alex,
These are all good points. I will make these changes.
Thanks & Regards,
-Rob
On Fri, 15 May 2020 at 11:42, Alex Bennée wrote:
>
>
> Robert Foley writes:
>
> > ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM.
> > Another new file is also ad
On Fri, 15 May 2020 at 13:23, Alex Bennée wrote:
>
>
> Robert Foley writes:
>
> > Added use of a configuration to tests/vm/basevm.py.
> > The configuration provides parameters used to configure a VM.
> > This allows for providing alternate configurations to the VM b
with the final two results
(unix bench and boot times).
Regards,
-Rob
On Tue, 12 May 2020 at 15:26, Robert Foley wrote:
>
> On Tue, 12 May 2020 at 12:27, Alex Bennée wrote:
> > Robert Foley writes:
> >
> > > From: "Emilio G. Cota"
> > >
> >
: Robert Foley
---
tests/vm/Makefile.include | 1 +
tests/vm/basevm.py| 16 ++--
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index 1bf9693d19..74ab522c55 100644
--- a/tests/vm/Makefile.include
+++ b/tests/vm
From: Alex Bennée
Not all distros ship genisoimage which is a Debian fork from the
original cdrtools. As the options are pretty much the same support it
as a fallback binary.
Signed-off-by: Alex Bennée
Signed-off-by: Robert Foley
---
configure | 2 +-
1 file changed, 1 insertion(+), 1
genisoimage.
Alex Bennée (2):
configure: add alternate binary for genisoimage
tests/vm: pass --genisoimage to basevm script
Robert Foley (10):
tests/vm: pass args through to BaseVM's __init__
tests/vm: Add configuration to basevm.py
tests/vm: Added configuration file support
tes
to vary on the VM being created
or launched.
This will for example allow for creating an aarch64 vm.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
---
tests/vm/basevm.py | 170 ++---
1 file changed, 131 insertions(+), 39 deletions(-)
diff --git a
Signed-off-by: Robert Foley
---
tests/vm/basevm.py | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index a2d4054d72..fbefda0595 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -61,9 +61,9 @@ class BaseVM(object
.yml.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
---
configure | 9 ++
tests/vm/Makefile.include | 6
tests/vm/basevm.py| 40 +++-
tests/vm/conf_example_aarch64.yml | 51 +++
tests
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM.
Another new file is also added aarch64vm.py, which is a module with
common methods used by aarch64 VMs, such as how to create the
flash images.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
---
configure
This helps debug issues that occur during the boot sequence.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
---
tests/vm/Makefile.include | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index d9b34eae63..e22c391a2a 100644
--- a
Added a new special variable QEMU_LOCAL=1, which
will indicate to take the QEMU binary from the current
build.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
---
tests/vm/Makefile.include | 4
tests/vm/basevm.py| 25 ++---
2 files changed, 26 insertions
centos.aarch64 creates a CentOS 8 image.
Also added a new kickstart script used to build the centos.aarch64 image.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
---
tests/vm/Makefile.include| 3 +-
tests/vm/centos-8-aarch64.ks | 51
tests/vm/centos.aarch64 | 227
characters to be consumed.
We also add the option of logging the console to a file.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
---
python/qemu/console_socket.py | 162 ++
python/qemu/machine.py| 23 -
tests/vm/Makefile.include | 4 +
tests/vm
This change converts existing scripts to using for example self.ROOT_PASS,
to self._config['root_pass'].
We made similar changes for GUEST_USER, and GUEST_PASS.
This allows us also to remove the change in basevm.py,
which adds __getattr__ for backwards compatibility.
Signed-off-by: Ro
This allows for waiting for completion of arbitrary commands.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
tests/vm/basevm.py | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index
On Wed, 20 May 2020 at 00:46, Emilio G. Cota wrote:
>
> On Mon, May 18, 2020 at 09:46:36 -0400, Robert Foley wrote:
>
> Thanks for doing these tests. I know from experience that benchmarking
> is hard and incredibly time consuming, so please do not be discouraged by
> my com
On Wed, 2020-05-20 at 10:17 +0100, Daniel P. Berrangé wrote:
> On Wed, May 20, 2020 at 10:10:07AM +0800, Chenyi Qiang wrote:
> > There are no Icelake Desktop products in the market. Remove the
> > Icelake-Client CPU model.
>
> QEMU has been shipping this CPU model for 2 years now. Regardless
> of
152025 3035
Guest vCPUs
https://drive.google.com/file/d/1ASg5XyP9hNfN9VysXC3qe5s9QSJlwFAt/view?usp=sharing
Thanks & Regards,
-Rob
On Wed, 20 May 2020 at 11:01, Robert Foley wrote:
>
>
GIN_MEM_R;
> +} else if (g_strcmp0(opt, "write") == 0) {
> +rw = QEMU_PLUGIN_MEM_W;
> + } else if (g_strcmp0(opt, "detail") == 0) {
When testing out the options, I noticed that
if we supply arguments of "read", and &quo
Going to obsolete Icelake-Client CPU models in the future.
Signed-off-by: Robert Hoo
---
target/i386/cpu.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index d7ac22f..6c34ea3 100644
--- a/target/i386/cpu.c
+++ b/target/i386
x86_cpu_list_entry(), e.g. '-cpu
help'.
QMP 'query-cpu-definitions' will also return a bool value indicating the
deprecation status.
Signed-off-by: Robert Hoo
---
exec.c | 3 +++
include/hw/core/cpu.h| 1 +
qapi/machine-target.json | 3 ++-
target/i3
On Wed, 3 Jun 2020 at 07:43, Alex Bennée wrote:
>
>
> Robert Foley writes:
>
> >
> > When testing out the options, I noticed that
> > if we supply arguments of "read", and "write", then we will only get
> > the last one set, "write&
On Tue, 2 Jun 2020 at 16:21, Alex Bennée wrote:
>
>
> Robert Foley writes:
> >
> > configure_qemu()
> > {
> > +if test -z "$TSAN"; then
> > +requires clang tsan
> > +echo "Including TSan Support"
> >
On Tue, 2 Jun 2020 at 15:22, Alex Bennée wrote:
>
>
> Robert Foley writes:
>
> > From: Lingfeng Yang
> >
> > +# Thread sanitizer is, for now, much noisier than the other sanitizers;
> > +# keep it separate until that is not the case.
>
> I think we al
On Wed, 2020-06-03 at 09:11 -0500, Eric Blake wrote:
> On 6/3/20 6:47 AM, Robert Hoo wrote:
> > Complement versioned CPU model framework with the ability of
> > marking some
> > versions deprecated. When that CPU model is chosen, get some
> > warning. The
> > w
On Thu, 2020-06-04 at 06:59 -0500, Eric Blake wrote:
> On 6/4/20 3:07 AM, Robert Hoo wrote:
>
> > > > +++ b/qapi/machine-target.json
> > > > @@ -309,7 +309,8 @@
> > > >'static': 'bool',
> > > >
tions to QemuSpin
Lingfeng Yang (1):
configure: add --enable-tsan flag + fiber annotations for
coroutine-ucontext
Robert Foley (5):
tests/docker: Added docker build support for TSan.
include/qemu: Added tsan.h for annotations.
util: Added tsan annotate for thread name.
docs: Added de
+-9 --disable-werror'
configure flags.
Signed-off-by: Lingfeng Yang
Signed-off-by: Emilio G. Cota
[cota: minor modifications + configure changes]
Signed-off-by: Robert Foley
[RF: configure changes for warnings, erorr handling + minor modifications]
---
configure | 47 ++
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
cpus-common.c | 25 -
cpus.c| 14 --
hw/core/cpu.c | 1 +
include/hw/core/cpu.h | 6 +++---
4 files changed, 24 insertions(+), 22 deletions(-)
diff --git a/cpus-
Adds TSan details to testing.rst.
This includes background and reference details on TSan,
and details on how to build and test with TSan
both with and without docker.
Signed-off-by: Robert Foley
Reviewed-by: Emilio G. Cota
---
docs/devel/testing.rst | 107
From: "Emilio G. Cota"
I was after adding qemu_spin_destroy calls, but while at
it I noticed that we are leaking some memory.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
accel/tcg/cputlb.c | 15 +++
exec.c
These annotations will allow us to give tsan
additional hints. For example, we can inform
tsan about reads/writes to ignore to silence certain
classes of warnings.
We can also annotate threads so that the proper thread
naming shows up in tsan warning results.
Signed-off-by: Robert Foley
From: "Emilio G. Cota"
It will be used for TSAN annotations.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
include/qemu/thread.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/qemu/thread.h b/include/qemu/thread.h
index
Disable a few tests under CONFIG_TSAN, which
run into a known TSan issue that results in a hang.
https://github.com/google/sanitizers/issues/1116
The disabled tests under TSan include all the qtests as well as
the test-char, test-qga, and test-qdev-global-props.
Signed-off-by: Robert Foley
From: "Emilio G. Cota"
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
util/qht.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/qht.c b/util/qht.c
index aa51be3c52..67e5d5b916 100644
--- a/util/qht.c
+++ b/util/qht.c
@@ -348,6 +348,7 @@ static inline void qht_cha
This allows us to see the name of the thread in tsan
warning reports such as this:
Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at:
Signed-off-by: Robert Foley
Reviewed-by: Emilio G. Cota
---
util/qemu-thread-posix.c | 2 ++
1 file changed, 2 insertions(+)
di
From: "Emilio G. Cota"
The radix tree is append-only, but we can fail to insert
a PageDesc if the insertion races with another thread.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
accel/tcg/translate-all.c | 9 +
1 file changed, 9 insertions(+)
diff --g
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
[RF: Minor changes to fix some checkpatch errors]
---
accel/tcg/translate-all.c | 10 +-
include/tcg/tcg.h | 3 ++-
tcg/tcg.c | 19 ---
3 files c
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
include/qemu/thread.h | 39 ---
1 file changed, 36 insertions(+), 3 deletions(-)
diff --git a/include/qemu/thread.h b/include/qemu/thre
suppresion file to disable certain
cases of TSAN warnings.
Cc: Fam Zheng
Cc: Philippe Mathieu-Daudé
Signed-off-by: Robert Foley
---
tests/docker/dockerfiles/ubuntu2004.docker | 65 ++
tests/docker/test-tsan | 44 +++
tests/tsan/blacklist.tsan
On Fri, 2020-06-05 at 08:47 -0500, Eric Blake wrote:
> On 6/4/20 9:47 PM, Robert Hoo wrote:
> > On Thu, 2020-06-04 at 06:59 -0500, Eric Blake wrote:
> > > On 6/4/20 3:07 AM, Robert Hoo wrote:
> > >
> > > > > > +++ b/qapi/mac
On Mon, 8 Jun 2020 at 09:39, Alex Bennée wrote:
> > -static void finish_switch_fiber(void *fake_stack_save)
> > +/* QEMU_ALWAYS_INLINE only does so if __OPTIMIZE__, so we cannot use it. */
> > +static inline __attribute__((always_inline))
> > +void on_new_fiber(CoroutineUContext *co)
> > +{
>
> W
On Mon, 8 Jun 2020 at 10:44, Alex Bennée wrote:
> > +static void tcg_region_tree_reset_all(tb_destroy_func tb_destroy)
> > {
> > size_t i;
> >
> > @@ -510,6 +519,10 @@ static void tcg_region_tree_reset_all(void)
> > for (i = 0; i < region.n; i++) {
> > struct tcg_region_tree *
or tb->jmp_lock
translate-all: call qemu_spin_destroy for PageDesc
thread: add tsan annotations to QemuSpin
Lingfeng Yang (1):
configure: add --enable-tsan flag + fiber annotations for
coroutine-ucontext
Robert Foley (5):
tests/docker: Added docker build support for TSan.
include/qem
+-9 --disable-werror'
configure flags.
Signed-off-by: Lingfeng Yang
Signed-off-by: Emilio G. Cota
[cota: minor modifications + configure changes]
Signed-off-by: Robert Foley
[RF: configure changes, coroutine fix + minor modifications]
Reviewed-by: Alex Bennée
---
confi
From: "Emilio G. Cota"
It will be used for TSAN annotations.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
include/qemu/thread.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/qemu/thread.h b/include/qemu/thread.h
index
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
include/qemu/thread.h | 39 ---
1 file changed, 36 insertions(+), 3 deletions(-)
diff --git a/include/qemu/thread.h b/include/qemu/thre
From: "Emilio G. Cota"
The radix tree is append-only, but we can fail to insert
a PageDesc if the insertion races with another thread.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
accel/tcg/translate-all.c | 9 +
1 file changed, 9
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
cpus-common.c | 25 -
cpus.c| 14 --
hw/core/cpu.c | 1 +
include/hw/core/cpu.h | 6 +++---
4 files changed, 24 insertions(+), 22 deletions(-)
diff --git a/cpus-
suppresion file to disable certain
cases of TSAN warnings.
Cc: Fam Zheng
Cc: Philippe Mathieu-Daudé
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
tests/docker/dockerfiles/ubuntu2004.docker | 65 ++
tests/docker/test-tsan | 44
From: "Emilio G. Cota"
I was after adding qemu_spin_destroy calls, but while at
it I noticed that we are leaking some memory.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
accel/tcg/cputlb.c | 15 +++
exec.c
Disable a few tests under CONFIG_TSAN, which
run into a known TSan issue that results in a hang.
https://github.com/google/sanitizers/issues/1116
The disabled tests under TSan include all the qtests as well as
the test-char, test-qga, and test-qdev-global-props.
Signed-off-by: Robert Foley
From: "Emilio G. Cota"
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
util/qht.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/qht.c b/util/qht.c
index aa51be3c52..67e5d5b916 100644
--- a/util/qht.c
+++ b/util/qht.c
@@ -348,6 +348,7 @@ static inline void qht_cha
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
[RF: minor changes + remove tb_destroy_func]
---
accel/tcg/translate-all.c | 8
include/tcg/tcg.h | 1 +
tcg/tcg.c | 9 +
3 files changed, 18 insertions(+)
di
These annotations will allow us to give tsan
additional hints. For example, we can inform
tsan about reads/writes to ignore to silence certain
classes of warnings.
We can also annotate threads so that the proper thread
naming shows up in tsan warning results.
Signed-off-by: Robert Foley
This allows us to see the name of the thread in tsan
warning reports such as this:
Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at:
Signed-off-by: Robert Foley
Reviewed-by: Emilio G. Cota
---
util/qemu-thread-posix.c | 2 ++
1 file changed, 2 insertions(+)
di
Adds TSan details to testing.rst.
This includes background and reference details on TSan,
and details on how to build and test with TSan
both with and without docker.
Signed-off-by: Robert Foley
Reviewed-by: Emilio G. Cota
Reviewed-by: Alex Bennée
---
docs/devel/testing.rst | 107
The newish test 'basic gdbstub support' fails for me on an out-of-the-box
build on a host x86_64. (See below for the config.log head.)
Is this failure expected? If so, where can I see that in the various CI
engines you have running them?
In digging through the test driver python code in
tes
Add qapi new member documentation. Thanks Eric for comment and guidance on qapi.
Signed-off-by: Robert Hoo
---
hw/core/machine.c| 11 +--
include/hw/core/cpu.h| 1 +
qapi/machine-target.json | 7 ++-
target/i386/cpu.c| 45 +++--
Going to obsolete Icelake-Client CPU models in the future.
(No changes in v2)
Signed-off-by: Robert Hoo
---
target/i386/cpu.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 0d8638a..47a11b5 100644
--- a/target/i386
On Mon, 27 Jan 2020 at 06:06, Alex Bennée wrote:
> > Allow wait_ssh to wait for root user to be ready.
> > This solves the issue where we perform a wait_ssh()
> > successfully, but the root user is not yet ready
> > to be logged in.
>
> So in the case it's the root user we care about...
We care ab
On Mon, 27 Jan 2020 at 07:26, Alex Bennée wrote:
> > -SSH_KEY = open(os.path.join(os.path.dirname(__file__),
> > - "..", "keys", "id_rsa")).read()
> > -SSH_PUB_KEY = open(os.path.join(os.path.dirname(__file__),
> > - "..", "keys", "id_rsa.pub")).read()
> > -
> > +SS
On Mon, 27 Jan 2020 at 07:56, Alex Bennée wrote:
> > @@ -523,6 +525,10 @@ def main(vmcls, config=None):
> > if args.snapshot:
> > img += ",snapshot=on"
> > vm.boot(img)
> > +wait_boot = getattr(vm, "wait_boot", None)
>
> Didn't we add a __getattr method, so w
On Mon, 27 Jan 2020 at 07:38, Alex Bennée wrote:
> > +if 'password' in target_dict:
> > +config['root_pass'] = target_dict['password']
> > +config['guest_pass'] = target_dict['password']
>
> This seems like impedance matching between two dictionaries. Surely it
> wo
On Mon, 27 Jan 2020 at 10:01, Alex Bennée wrote:
> > vm-boot-ssh-%: $(IMAGES_DIR)/%.img
> > $(call quiet-command, \
> > - $(SRC_PATH)/tests/vm/$* \
> > + $(PYTHON) $(SRC_PATH)/tests/vm/$* \
>
> This seems like it should be in a different patch.
Good point, will move
Hi Drew,
On Mon, 27 Jan 2020 at 12:27, Andrew Jones wrote:
> >
> > I suppose we could check the version of QEMU and use the above
> > defaults only for earlier versions of QEMU.
> > This is something we will probably move to aarch64vm.py since it is common.
>
> What versions of QEMU do these tes
On Mon, 27 Jan 2020 at 15:07, Alex Bennée wrote:
> Robert Foley writes:
>
> > Hi Drew,
> >
> > On Mon, 27 Jan 2020 at 12:27, Andrew Jones wrote:
> >
> >> >
> >> > I suppose we could check the version of QEMU and use the above
> >&g
or 3 days on
qemu+plugins and only observed a tolerable growth in qemu's memory consumption.
From: Alex Bennée
Sent: Friday, January 24, 2020 11:44 AM
To: Robert Henry
Cc: Laurent Desnogues ; qemu-devel@nongnu.org
Subject: Re: [EXTERNAL] Re: QEMU for aarch
Thanks for the details on the failure. I have not been able to
reproduce it yet, but digging into it further.
On Tue, 28 Jan 2020 at 12:52, Alex Bennée wrote:
>
>
> Robert Foley writes:
>
> > This patch adds support for 2 aarch64 VMs.
> > - Ubuntu 18.04 aarch64 VM
&g
Hi,
I was looking at this patch and have a comment about the number of
groups that are expected to be found by this regex.
It seems like the old code expected two groups to be found otherwise
it will not append the library to the found libs.
def _get_so_libs(executable):
libs = []
ldd_re =
I run git blame in the capstone repository, and cs_free has been around
for at least 4 years in the capstone ABI. I can not tell if the need to
call cs_free is a (new) requirement. Documentation capstone is a little
informal...
--
You received this bug notification because you are a member of qem
Thanks Richard:-)
Sorry for late reply.
On Thu, 2020-02-13 at 10:20 -0800, Richard Henderson wrote:
> On 2/12/20 11:52 PM, Robert Hoo wrote:
> > And initialize buffer_is_zero() with it, when Intel AVX512F is
> > available on host.
> >
> > This function utiliz
On Mon, 2020-02-24 at 08:13 -0800, Richard Henderson wrote:
> On 2/23/20 11:07 PM, Robert Hoo wrote:
> > Inspired by your suggestion, I'm thinking go further: use immediate
> > rather than a global variable, so that saves 1 memory(/cache)
> > access.
> >
is not bigger than before and
> also dump the values in the report.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Robert Foley
: handle the case in select_accel_fn(), and have a
global variable alongside buffer_accel)
3. Changes avx512f configuration option's default status to disabled.
4. Ran 'make check-unit' on this patch, on both a Ivybridge machine and a
CascadeLake machine.
Robert Hoo (2):
configur
/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf
Signed-off-by: Robert Hoo
---
configure | 41 +
1 file changed, 41 insertions(+)
diff --git a/configure b/configure
index d57261e..a0b41ce 100755
--- a
.
buffer_zero_avx2()).
Signed-off-by: Robert Hoo
---
include/qemu/cpuid.h | 3 +++
util/bufferiszero.c | 64
2 files changed, 58 insertions(+), 9 deletions(-)
diff --git a/include/qemu/cpuid.h b/include/qemu/cpuid.h
index 6930170..09fc245
anges avx512f configuration option's default status to disabled.
4. Ran 'make check-unit' on this patch, on both a Ivybridge machine and a
CascadeLake machine.
Robert Hoo (2):
configure: add configure option avx512f_opt
util: add util function buffer_zero_avx512()
-programming-reference.pdf
Signed-off-by: Robert Hoo
---
configure | 41 +
1 file changed, 41 insertions(+)
diff --git a/configure b/configure
index d57261e..a0b41ce 100755
--- a/configure
+++ b/configure
@@ -1395,6 +1395,11 @@ for opt do
;;
--enable-avx2
.
buffer_zero_avx2()).
Signed-off-by: Robert Hoo
---
include/qemu/cpuid.h | 3 +++
util/bufferiszero.c | 67 +---
2 files changed, 61 insertions(+), 9 deletions(-)
diff --git a/include/qemu/cpuid.h b/include/qemu/cpuid.h
index 6930170..09fc245 100644
--- a
From: "Emilio G. Cota"
Instead of open-coding it.
While at it, make sure that all accesses to the list are
performed while holding the list's lock.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
From: "Emilio G. Cota"
This completes the conversion to cpu_mutex_lock/unlock in the file.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
cpus-common.c | 17 +++--
1 file changed, 11 insert
_reset_interrupt
s390x: use cpu_reset_interrupt
openrisc: use cpu_reset_interrupt
Robert Foley (1):
hw/semihosting: convert to cpu_halted_set
accel/tcg/cpu-exec.c| 40 ++-
accel/tcg/cputlb.c | 10 +-
accel/tcg/tcg-all.c | 12 +-
accel/tcg/tcg-runtime.
From: "Emilio G. Cota"
This lock will soon protect more fields of the struct. Give
it a more appropriate name.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
cpus-common.c | 14 +++-
vCPUs are locked by the same thread, which
explains why the bitmap is introduced here.
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
[RF: Add assert in smp_parse. Make cpu_mutex_lock stub empty]
Signed-off-by: Robert Foley
---
cpus.c
From: "Emilio G. Cota"
We don't pass a pointer to qemu_global_mutex anymore.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
cpus-common.c | 2 +-
cpus.c| 5 -
include/hw/
ex_destroy, and call from cpu_common_finalize,
to avoid destroying qemu_global_mutex, when cpu mutex is destroyed.
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
[RF: Fixed destroy issue, added cpu_mutex_destroy.]
Signed-off-by: Robert Foley
---
f-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
cpus-common.c | 72 ++-
cpus.c| 2 +-
hw/core/cpu.c | 1 +
include/hw/core/cpu.h | 6 ++--
4 files changed, 63 insertions(+), 18 deletions(-)
diff --git a/cpus-comm
From: "Emilio G. Cota"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
accel/tcg/tcg-runtime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runti
From: "Emilio G. Cota"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/hppa/translate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/hppa/translate.c b/target/hppa/transla
From: "Emilio G. Cota"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
accel/tcg/tcg-runtime.c | 7 +++
accel/tcg/tcg-runtime.h | 2 ++
2 files changed, 9 insertions(+)
diff --git a/accel/tcg/tcg-runtime
From: "Emilio G. Cota"
And fix the temp leak along the way.
Cc: "Edgar E. Iglesias"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/cris/translate.c | 5 +++--
1 file changed, 3 insert
701 - 800 of 1052 matches
Mail list logo
