On Wed, 2020-05-20 at 10:17 +0100, Daniel P. Berrangé wrote: > On Wed, May 20, 2020 at 10:10:07AM +0800, Chenyi Qiang wrote: > > There are no Icelake Desktop products in the market. Remove the > > Icelake-Client CPU model. > > QEMU has been shipping this CPU model for 2 years now. Regardless > of what CPUs Intel are selling, it is possible for users to be > running VMs with Icelake-Client CPU if their host satisfies the > listed features. So I don't think it is valid to remove this. > This 'Icelake-Client' actually doesn't exist. How do we define its feature list? and who will be using it? If any special feature tailor requirement, it can be simply achieved by '-cpu Icelake,+/-' features, this is the correct way.
I think we should remove it. When we realize something's not correct, we should fix it ASAP. Leaving it there will only cause more serious issue in the future. > Regards, > Daniel
