Re: [Qemu-devel] How to capture guest %rip from a qemu process without monitor?

2011-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2011 at 10:49:20AM +0200, Jan Kiszka wrote: > On 2011-09-30 09:42, Richard W.M. Jones wrote: > > > > I've finally managed to reproduce a very infrequent kernel boot hang > > by forcing TCG (so it runs slower, bug seems to be timing sensitive) > > a

[Qemu-devel] qemu.git hangs booting Linux after insmod virtio_blk.ko

2011-09-30 Thread Richard W.M. Jones
I've not looked into this at all, it's just a report that something seems to be "up". I will try to git bisect this later if no one spots anything obvious. The next operation after insmod virtio_blk would be insmod_virtio_net. Guest kernel is a Fedora kernel, version 3.1.0-0.rc6.git0.3.fc16.x86

[Qemu-devel] git-bisect results (was: Re: qemu.git hangs booting Linux after insmod virtio_blk.ko)

2011-09-30 Thread Richard W.M. Jones
On Fri, Sep 30, 2011 at 02:11:48PM +0100, Richard W.M. Jones wrote: > > I've not looked into this at all, it's just a report that something > seems to be "up". I will try to git bisect this later if no one spots > anything obvious. > > The next oper

Re: [Qemu-devel] Hang when using 9p mounts after last Seabios update

2011-10-01 Thread Richard W.M. Jones
On Sat, Oct 01, 2011 at 12:50:43PM -0400, Kevin O'Connor wrote: > On Thu, Sep 22, 2011 at 12:45:11PM +0100, Daniel P. Berrange wrote: > > On 0.14, 0.15 releaes, this all works just fine. On current GIT master, > > the guest OS will hang during boot. > [...] > > To reproduce this you will need my cu

[Qemu-devel] [Bug 865518] [NEW] qemu segfaults when writing to very large qcow2 disk

2011-10-03 Thread Richard W.M. Jones
Public bug reported: Create a ridiculously large qcow2 disk: qemu-img create -f qcow2 test1.img $((2**63-513)) Attach it to a guest and try to use parted to partition it. This is easy with virt-rescue: you just do: virt-rescue test1.img > parted /dev/vda mklabel gpt <-- bang! qemu segfaults he

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-08 Thread Richard W.M. Jones
On Fri, Oct 07, 2011 at 12:16:07PM +0200, Jan Kiszka wrote: > On 2011-10-07 11:46, Wen Congyang wrote: > > Currently, virsh dump uses monitor command migrate to dump guest's memory > > to file, and we can use crash to analyze the file. > > > > Unfortunately, virsh dump can not work if guest uses h

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-09 Thread Richard W.M. Jones
On Sun, Oct 09, 2011 at 10:49:57AM +0200, Jan Kiszka wrote: > As explained in the other replies: It is way more future-proof to use an > interface for this which was designed for it (remote gdb) instead of > artificially relaxing reasonable constraints of the migration mechanism > plus having to fo

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-10 Thread Richard W.M. Jones
On Mon, Oct 10, 2011 at 10:10:21AM +0100, Daniel P. Berrange wrote: > On Mon, Oct 10, 2011 at 10:08:26AM +0100, Daniel P. Berrange wrote: > > On Mon, Oct 10, 2011 at 10:21:02AM +0800, Wen Congyang wrote: > > > At 10/09/2011 06:23 PM, Richard W.M. Jones Write: > > > >

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-11 Thread Richard W.M. Jones
On Tue, Oct 11, 2011 at 09:23:15AM +0100, Daniel P. Berrange wrote: > - libguestfs directly boots its appliance using the regular host's >kernel image and a custom built initrd image. The initrd does >not contain the entire appliance, just enough to boot up and >dynamically read files

Re: [Qemu-devel] Slow kernel/initrd loading via fw_cfg; Was Re: Hack integrating SeaBios / LinuxBoot option rom with QEMU trace backends

2011-10-15 Thread Richard W.M. Jones
On Sat, Oct 15, 2011 at 10:00:02AM +, Blue Swirl wrote: > I don't understand why PC can't use the same way of loading initrd by > QEMU to guest memory before boot as Sparc32 uses. It should even be > possible to deduplicate the kernel and initrd images: improve the > loader to use mmap() for lo

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-18 Thread Richard W.M. Jones
On Tue, Oct 18, 2011 at 10:31:10AM +0200, Jan Kiszka wrote: > On 2011-10-18 10:31, Wen Congyang wrote: > > At 10/18/2011 04:26 PM, Jan Kiszka Write: > >> On 2011-10-18 10:25, Wen Congyang wrote: > >>> At 10/18/2011 04:19 PM, Jan Kiszka Write: > On 2011-10-18 09:58, Wen Congyang wrote: > >

Re: [Qemu-devel] [Question] dump memory when host pci device is used by guest

2011-10-18 Thread Richard W.M. Jones
On Tue, Oct 18, 2011 at 12:47:23PM +0200, Jan Kiszka wrote: > On 2011-10-18 12:41, Paolo Bonzini wrote: > > On 10/18/2011 10:39 AM, Jan Kiszka wrote: > > Yeah, I see. Could also be solved via gdb scripts, but crash is already > there. > >> [ BTW, crash is for the dead. But having t

Re: [Qemu-devel] Enhancing qemu-img convert format compatibility

2011-04-18 Thread Richard W.M. Jones
On Mon, Apr 18, 2011 at 11:18:42AM +0100, Stefan Hajnoczi wrote: > qemu-img is a pretty good Rosetta stone for image formats but it is > missing support some format versions. In order to bring qemu-img > up-to-date with the latest disk image formats we will need to find > specific image files and/

[Qemu-devel] Virt Tools Survey: What to do about virt-clone

2011-05-10 Thread Richard W.M. Jones
I've volunteered for the task of fixing virt-clone[0]. There are a number of bugs which need to be addressed. Unfortunately the current virt-clone is broken-by-design since it cannot make changes inside the guest. [0] http://linux.die.net/man/1/virt-clone The bugs boil down to what Microsoft

Re: [Qemu-devel] wiki summary

2011-11-24 Thread Richard W.M. Jones
On Thu, Nov 24, 2011 at 02:40:07PM +0200, Dor Laor wrote: > Using QMP is an advantage, I agree. > However it can be used by another option - move the QMP schema out > of qemu.git so all projects like libvirt, agents, vdsm, etc will be > able to consume it directly. > > This way, adding a new (agen

Re: [Qemu-devel] Qemu stable releases

2011-12-09 Thread Richard W.M. Jones
On Mon, Dec 05, 2011 at 02:08:03PM -0600, Justin M. Forbes wrote: > The stable tree for 1.0 has now been created and the mailing list > exists. I am curious as to people's thoughts on how we should proceed. > There was discussion of setting up a predictable time table for stable > releases, say mon

Re: [Qemu-devel] Qemu stable releases

2011-12-09 Thread Richard W.M. Jones
On Fri, Dec 09, 2011 at 10:39:37AM +, Richard W.M. Jones wrote: > FWIW in libguestfs we have such a policy. Every few weeks I evaluate > _all_ commits along the development branch and cherry pick those that > meet this policy back to the stable branch, followed by making a new

Re: [Qemu-devel] Qemu stable releases

2011-12-09 Thread Richard W.M. Jones
On Fri, Dec 09, 2011 at 07:25:39AM -0600, Anthony Liguori wrote: > On 12/09/2011 06:01 AM, Richard W.M. Jones wrote: > >On Fri, Dec 09, 2011 at 10:39:37AM +, Richard W.M. Jones wrote: > >>FWIW in libguestfs we have such a policy. Every few weeks I evaluate > >

Re: [Qemu-devel] git-bisect results (was: Re: qemu.git hangs booting Linux after insmod virtio_blk.ko)

2011-12-16 Thread Richard W.M. Jones
On Fri, Sep 30, 2011 at 05:51:52PM +0100, Richard W.M. Jones wrote: > On Fri, Sep 30, 2011 at 02:11:48PM +0100, Richard W.M. Jones wrote: > > > > I've not looked into this at all, it's just a report that something > > seems to be "up". I will try

[Qemu-devel] insmod virtio-blk is broken in qemu 1.0 (was: Re: git-bisect results (was: Re: qemu.git hangs booting Linux after insmod virtio_blk.ko))

2011-12-16 Thread Richard W.M. Jones
git bisect says this. I didn't believe it first time, so I ran it twice with a few modifications, and it pointed to the same commit both times ... 67882fd177389527510eb36b3f7712011a835545 is the first bad commit commit 67882fd177389527510eb36b3f7712011a835545 Author: Max Filippov Date: Tue Se

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0 (was: Re: git-bisect results

2011-12-17 Thread Richard W.M. Jones
On Fri, Dec 16, 2011 at 07:44:10PM -0600, Anthony Liguori wrote: > On 12/16/2011 06:53 PM, Max Filippov wrote: > >>>git bisect says this. I didn't believe it first time, so I ran it > >>>twice with a few modifications, and it pointed to the same commit both > >>>times ... > >> > >>Richard, > >>cou

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0 (was: Re: git-bisect results

2011-12-17 Thread Richard W.M. Jones
On Fri, Dec 16, 2011 at 07:44:10PM -0600, Anthony Liguori wrote: > Fairly certain this bisect is a red herring. > > tglx reported this the other day in IRC. He narrowed it down to > virtio-serial. He was able to reproduce it both with kvm tools and > QEMU. I looked at this a bit more closely, a

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Richard W.M. Jones
On Sat, Dec 17, 2011 at 09:13:52AM -0600, Anthony Liguori wrote: > Okay, I can reproduce this now with a F15 guest. > > I've narrowed it down to '-nodefaults -serial stdio'. Can you > confirm that if you remove those options it works for you? Confirmed: removing those options allows it to boot n

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Richard W.M. Jones
On Sat, Dec 17, 2011 at 09:22:45AM -0600, Anthony Liguori wrote: > I've even further narrowed it down to the presents or lack of '-vga > cirrus'. If you add '-vga cirrus' to the above command line, the > guest will boot successfully. Confirmed: Adding -vga cirrus to the command line cures it too.

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Richard W.M. Jones
On Sat, Dec 17, 2011 at 10:24:07AM -0600, Anthony Liguori wrote: > On 12/17/2011 09:25 AM, Richard W.M. Jones wrote: > >On Sat, Dec 17, 2011 at 09:22:45AM -0600, Anthony Liguori wrote: > >>I've even further narrowed it down to the presents or lack of '-vga > >>

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-17 Thread Richard W.M. Jones
On Sat, Dec 17, 2011 at 11:49:56AM -0500, Kevin O'Connor wrote: > On Sat, Dec 17, 2011 at 10:24:07AM -0600, Anthony Liguori wrote: > > On 12/17/2011 09:25 AM, Richard W.M. Jones wrote: > > >On Sat, Dec 17, 2011 at 09:22:45AM -0600, Anthony Liguori wrote: > > >>I&

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-19 Thread Richard W.M. Jones
On Mon, Dec 19, 2011 at 12:02:59PM -0600, Anthony Liguori wrote: > I would like to point out that August -> October is a pretty long > time period for a regression like this to exist. I think that > really indicates that the primary problem is testing, not frequency > of SeaBIOS updates. Fair poi

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-19 Thread Richard W.M. Jones
On Mon, Dec 19, 2011 at 07:16:02PM +, Daniel P. Berrange wrote: > On Mon, Dec 19, 2011 at 07:04:54PM +0000, Richard W.M. Jones wrote: > > On Mon, Dec 19, 2011 at 12:02:59PM -0600, Anthony Liguori wrote: > > > I would like to point out that August -> October is a pretty l

Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-19 Thread Richard W.M. Jones
On Mon, Dec 19, 2011 at 07:40:05PM +, Richard W.M. Jones wrote: > In reply to Anthony: the reason Fedora does this is because > binary blobs aren't permitted, no matter what the origin. We > have to build SeaBIOS from source, and the choice is made to > build from the upstre

Re: [Qemu-devel] [PATCH v5 3/4] pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt

2015-10-16 Thread Richard W.M. Jones
On Fri, Oct 16, 2015 at 01:54:48PM +0300, Michael S. Tsirkin wrote: > On Fri, Oct 16, 2015 at 11:56:39AM +0200, Knut Omang wrote: > > But feel free to just skip this patch, the most important is to get the > > generic SR/IOV code in there for others to use. > > That's my question. Is it for others

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Richard W.M. Jones
On Mon, Aug 03, 2015 at 04:28:14PM +0200, Laurent Vivier wrote: > > > On 03/08/2015 15:52, Laurent Vivier wrote: > > Originally, qemu_mod_timer() was using ticks to count time. > > And i6300esb was converting internal clock ticks (33 MHz) to > > QEMU timer ticks. > > > > The timer has been chang

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-04 Thread Richard W.M. Jones
On Mon, Aug 03, 2015 at 03:52:28PM +0200, Laurent Vivier wrote: > +/* A 33 Mhz clock gives a 30 ns tick, > + * convert timeout from ticks to ns > */ > -timeout = muldiv64(get_ticks_per_sec(), timeout, 3300); > +timeout *= 30; I see that you've just posted a v2 of this pat

Re: [Qemu-devel] [PATCH][TRIVIAL] i6300esb: fix timer overflow

2015-08-04 Thread Richard W.M. Jones
On Tue, Aug 04, 2015 at 10:27:31AM +0200, Laurent Vivier wrote: > --- a/hw/watchdog/wdt_i6300esb.c > +++ b/hw/watchdog/wdt_i6300esb.c > @@ -136,7 +136,7 @@ static void i6300esb_restart_timer(I6300State *d, int > stage) > * multiply here can exceed 64-bits, before we divide by 33MHz, so >

Re: [Qemu-devel] [PATCH] qemu-sanity-check.in: Use '-display none' instead of '-nographic'

2015-06-08 Thread Richard W.M. Jones
On Mon, Jun 08, 2015 at 06:47:00PM +0200, Kashyap Chamarthy wrote: > Upstream QEMU recommends to use '-display none' as opposed to > '-nographic' -- which is a "legacy option that does a whole bunch of > confusing stuff" (thanks Peter Maydell). > > Upstream libguestfs already made the switch [1] i

Re: [Qemu-devel] [PATCH 2/2] target-ppc: fix xscmpodp and xscmpudp decoding

2015-09-20 Thread Richard W.M. Jones
), > +GEN_XX2IFORM(xscmpudp, 0x0C, 0x04, PPC2_VSX), > GEN_XX3FORM(xsmaxdp, 0x00, 0x14, PPC2_VSX), > GEN_XX3FORM(xsmindp, 0x00, 0x15, PPC2_VSX), > GEN_XX2FORM(xscvdpsp, 0x12, 0x10, PPC2_VSX), This particular patch fixed a number of crashes I was experiencing in libm in Fedora 22

Re: [Qemu-devel] [PATCH 1/2] acpi: Allow ACPI default OEM ID and OEM table ID fields to be set.

2015-09-03 Thread Richard W.M. Jones
Long comment from the bug reporter in case anyone isn't following that bug: https://bugzilla.redhat.com/show_bug.cgi?id=1248758#c15 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt

Re: [Qemu-devel] [PATCH] block/ssh: remove dead code

2015-09-14 Thread Richard W.M. Jones
On Mon, Sep 14, 2015 at 01:12:34PM +0200, Paolo Bonzini wrote: > The "err" label cannot be reached with qp != NULL. Remove the free-ing > of qp and avoid future regressions by removing the initializer. > > Signed-off-by: Paolo Bonzini > --- > block/ssh.c | 5 + > 1 file changed, 1 insertion

[Qemu-devel] qemu-system-s390x command line

2015-08-30 Thread Richard W.M. Jones
Hi Alex, Do you or anyone have a working qemu-system-s390x command line I can use as a starting point to boot a [TCG] guest? So far I have tried variations of: ~/d/qemu/s390x-softmmu/qemu-system-s390x -M s390-ccw-virtio -m 1024 -smp 1 -drive file=s390x.img,if=none,id=disk0 -device virtio-blk-c

Re: [Qemu-devel] qemu-system-s390x command line

2015-08-30 Thread Richard W.M. Jones
On Sun, Aug 30, 2015 at 11:02:17PM +0200, Alexander Graf wrote: > > > > Am 30.08.2015 um 22:11 schrieb Richard W.M. Jones : > > > > Hi Alex, > > > > Do you or anyone have a working qemu-system-s390x command line I can > > use as a starting point to

Re: [Qemu-devel] qemu-system-s390x command line

2015-08-31 Thread Richard W.M. Jones
On Mon, Aug 31, 2015 at 07:09:34PM +0200, Thomas Huth wrote: > On 30/08/15 23:27, Richard W.M. Jones wrote: > > On Sun, Aug 30, 2015 at 11:02:17PM +0200, Alexander Graf wrote: > >> > >> > >>> Am 30.08.2015 um 22:11 schrieb Richard W.M. Jones : > >>&g

[Qemu-devel] [PATCH 1/2] acpi: Allow ACPI default OEM ID and OEM table ID fields to be set.

2015-09-02 Thread Richard W.M. Jones
A couple of patches allowing two default fields in the ACPI table headers to be set. The motivation for this is to avoid the need for the following patch which Debian is carrying downstream to fix some Windows guests that have been converted to KVM using virt-p2v (or direct copy of disks): Patch

[Qemu-devel] [PATCH 2/2] acpi: Remove unused definition.

2015-09-02 Thread Richard W.M. Jones
Signed-off-by: Richard W.M. Jones --- include/hw/acpi/aml-build.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h index 85a3c2c..7392aca 100644 --- a/include/hw/acpi/aml-build.h +++ b/include/hw/acpi/aml-build.h @@ -9,8 +9,6

[Qemu-devel] [PATCH 1/2] acpi: Allow ACPI default OEM ID and OEM table ID fields to be set.

2015-09-02 Thread Richard W.M. Jones
he ACPI table name. This does not affect the -acpitable option (for user-defined ACPI tables), which has its own method for setting these fields. Signed-off-by: Richard W.M. Jones BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1248758 --- hw/acpi/aml-build.c | 44 +

Re: [Qemu-devel] [PATCH 1/2] acpi: Allow ACPI default OEM ID and OEM table ID fields to be set.

2015-09-02 Thread Richard W.M. Jones
On Wed, Sep 02, 2015 at 08:03:37PM +0100, Richard W.M. Jones wrote: > When using qemu's internal ACPI table generation, qemu sets the fields > OEM ID and OEM table ID to arbitrary default values. OEM ID is set to > "BOCHS " and OEM table ID is set to "BXPC"

Re: [Qemu-devel] [PATCH v2] block/curl: Don't lose original error when a connection fails.

2015-07-08 Thread Richard W.M. Jones
On Wed, Jul 08, 2015 at 12:23:37PM +0200, Kevin Wolf wrote: > Am 03.07.2015 um 14:35 hat Markus Armbruster geschrieben: > > "Richard W.M. Jones" writes: > > > > > Currently if qemu is connected to a curl source (eg. web server), and > > > the web server

Re: [Qemu-devel] [PATCH v2] block/curl: Don't lose original error when a connection fails.

2015-07-08 Thread Richard W.M. Jones
On Wed, Jul 08, 2015 at 02:01:30PM +0200, Kevin Wolf wrote: > The guest can't cause it, but once the connection is down, I expect > every request to fail. You don't have to have a malicious guest for > filling up the log file, it just needs to be careless enough to continue > trying new requests in

[Qemu-devel] [PATCH v3 2/2] block/curl: Don't lose original error when a connection fails.

2015-07-08 Thread Richard W.M. Jones
sed with 469989 bytes remaining to read qemu-img: error while reading sector 16384: Protocol error Signed-off-by: Richard W.M. Jones Reviewed-by: Stefan Hajnoczi --- block/curl.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.

[Qemu-devel] [PATCH v3 1/2] Add a simple mechanism to protect against error message floods.

2015-07-08 Thread Richard W.M. Jones
imes, followed by the "further errors suppressed" message once, and then nothing else. Signed-off-by: Richard W.M. Jones --- include/qemu/no-flood.h | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 include/qemu/no-flood.h diff --git a/i

[Qemu-devel] [PATCH v3 0/2] block/curl: Don't lose original error when a connection fails.

2015-07-08 Thread Richard W.M. Jones
Since v2: This adds a generalized anti-flooding mechanism, and then uses it to ensure that curl errors wouldn't flood the log files. Rich.

[Qemu-devel] [PATCH v4] block/curl: Don't lose original error when a connection fails.

2015-07-08 Thread Richard W.M. Jones
sed with 469989 bytes remaining to read qemu-img: error while reading sector 16384: Protocol error Signed-off-by: Richard W.M. Jones Reviewed-by: Stefan Hajnoczi --- block/curl.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.

[Qemu-devel] [PATCH v4] block/curl: Don't lose original error when a connection

2015-07-08 Thread Richard W.M. Jones
Since v3: Ditch the generalized anti-flood protection, and just use a simple variable. Rich.

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-14 Thread Richard W.M. Jones
On Mon, Jul 13, 2015 at 04:09:37PM -0400, Gabriel L. Somlo wrote: > 3. I'm currently only handling x86 and I/O ports. I could drop the >fw_cfg_dmi_whitelist and just check the signature, using mmio where >appropriate, but I don't have a handy-dandy set of VMs for those >architectures on

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-14 Thread Richard W.M. Jones
On Tue, Jul 14, 2015 at 02:23:14PM -0400, Gabriel L. Somlo wrote: > On Tue, Jul 14, 2015 at 10:43:46AM +0100, Richard W.M. Jones wrote: > > On Mon, Jul 13, 2015 at 04:09:37PM -0400, Gabriel L. Somlo wrote: > > > 3. I'm currently only handling x86 and I/O

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-14 Thread Richard W.M. Jones
On Tue, Jul 14, 2015 at 07:48:29PM +0100, Richard W.M. Jones wrote: > On aarch64 kernel loading is really slow because it can only transfer > (IIRC) 8 bytes at a time, and there are no string instructions we can > use to speed it up. I should note here I'm talking about AAVMF (

[Qemu-devel] [PATCH] crypto/cipher-nettle.c: Pass correct function type to cbc_encrypt and cbc_decrypt.

2015-07-16 Thread Richard W.M. Jones
‘void (*)(void *, size_t, uint8_t *, const uint8_t *) {aka void (*)(void *, long unsigned int, unsigned char *, const unsigned char *)}’ cbc_decrypt(const void *ctx, nettle_cipher_func *f, Signed-off-by: Richard W.M. Jones --- crypto/cipher-nettle.c | 12 ++-- 1 file changed, 6 i

Re: [Qemu-devel] [PATCH] crypto/cipher-nettle.c: Pass correct function type to cbc_encrypt and cbc_decrypt.

2015-07-16 Thread Richard W.M. Jones
On Thu, Jul 16, 2015 at 11:04:15AM +0100, Peter Maydell wrote: > Is this the same issue that Radim's patchset from a few days > back is addressing? Yes, looks like it, so ignore this patch. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programmin

Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-16 Thread Richard W.M. Jones
Sorry for the very long delay in replying to this. I wanted to be absolutely sure I was reproducing the bug. Unfortunately I'm only able to reproduce the bug with qemu 2.3.0 (both the version in Fedora Rawhide, or the tagged v2.3.0 from git). I cannot currently reproduce it at all with upstream

Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-16 Thread Richard W.M. Jones
Sorry to spoil things, but I'm still seeing this bug, although it is now a lot less frequent with your patch. I would estimate it happens more often than 1 in 5 runs with qemu.git, and probably 1 in 200 runs with qemu.git + the v2 patch series. It's the exact same hang in both cases. Is it poss

Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-17 Thread Richard W.M. Jones
On Fri, Jul 17, 2015 at 11:30:38AM +0200, Paolo Bonzini wrote: > error: kvm run failed Function not implemented > PC=bf671210 SP=c1f0 > X00=0a003e70 X01= X02=bf680548 > X03=0030 > X04=bbb5fc18 X05=004b7770 X06=000

Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-17 Thread Richard W.M. Jones
On Fri, Jul 17, 2015 at 02:48:40PM +0100, Marc Zyngier wrote: > Still: there is nothing in the registers that remotely points to that > area. X0 is the closest, but it'd take a big negative offset to get > there. > > Is that a Linux kernel? or something else? You're sure it's not this one? https:

Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-19 Thread Richard W.M. Jones
I tested this patch series, plus 'AioContext: fix missing wakeups due to event_notifier_test_and_clear' overnight, and there were no failures after something like 2500 iterations. So: Tested-by: Richard W.M. Jones Rich. -- Richard Jones, Virtualization Group, Re

[Qemu-devel] ANNOUNCE: libguestfs 1.30 released

2015-07-21 Thread Richard W.M. Jones
nial of service problems when using qemu-img info When using the American Fuzzy Lop fuzzer (afl-fuzz) on the qemu-img info command, Richard W.M. Jones found that certain files can cause the qemu-img program to use lots of memory and time (for example 6GB of heap and 14

Re: [Qemu-devel] [PATCH v4 0/6] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-22 Thread Richard W.M. Jones
ifier_test_and_clear I ran this overnight through many iterations with no problems seen. Therefore: Tested-by: Richard W.M. Jones Rich. -- $ while true; do echo -n .; LIBGUESTFS_HV=/home/rjone

[Qemu-devel] [PATCH] block/ssh: Avoid segfault if inet_connect doesn't set errno.

2015-07-22 Thread Richard W.M. Jones
create -f qcow2 overlay -b ssh://xen/ qemu-img: overlay: address resolution failed for xen:22: No address associated with hostname BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1147343 Signed-off-by: Richard W.M. Jones --- block/ssh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[Qemu-devel] [PATCH v2] block/ssh: Avoid segfault if inet_connect doesn't set errno.

2015-07-22 Thread Richard W.M. Jones
v2: I fixed several mistakes in the commit message. The code change is the same as before. Rich.

[Qemu-devel] [PATCH v2] block/ssh: Avoid segfault if inet_connect doesn't set errno.

2015-07-22 Thread Richard W.M. Jones
s printed correctly: $ ./qemu-img create -f qcow2 overlay -b ssh://xen/ qemu-img: overlay: address resolution failed for xen:22: No address associated with hostname Signed-off-by: Richard W.M. Jones Reported-by: Jun Li BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1147343 --- block/ssh.c | 2

Re: [Qemu-devel] [PATCH] block/ssh: Avoid segfault if inet_connect doesn't set errno.

2015-07-22 Thread Richard W.M. Jones
On Wed, Jul 22, 2015 at 01:07:53PM +0100, Richard W.M. Jones wrote: > On some (but not all) systems: > > $ qemu-img create -f qcow2 overlay -b ssh://xen/ > Segmentation fault > > It turns out this happens when inet_connect returns NULL in the > following code, bu

Re: [Qemu-devel] [PATCH v2] block/ssh: Avoid segfault if inet_connect doesn't set errno.

2015-07-22 Thread Richard W.M. Jones
On Wed, Jul 22, 2015 at 02:10:51PM +0100, Daniel P. Berrange wrote: > There are a reasonable number of other uses of inet_connect() in QEMU, > so can't we fix inet_connect() itself to set EINVAL in the error case > instead of just fixing one caller. The only users I can find are block/nbd.c and bl

Re: [Qemu-devel] [PATCH v2] block/ssh: Avoid segfault if inet_connect doesn't set errno.

2015-07-22 Thread Richard W.M. Jones
On Wed, Jul 22, 2015 at 09:17:49AM -0400, Jeff Cody wrote: > Both nbd and sheepdog handle it in a similar fashion (i.e. not relying > on errno being set on inet_connect failure). However, both nbd and > sheepdog use -EIO as the error return, and I think that makes more > sense. What do you think?

[Qemu-devel] [PATCH v3] block/ssh: Avoid segfault if inet_connect doesn't set errno.

2015-07-22 Thread Richard W.M. Jones
v3: Same as v2 but set the return value to -EIO.

[Qemu-devel] [PATCH v3] block/ssh: Avoid segfault if inet_connect doesn't set errno.

2015-07-22 Thread Richard W.M. Jones
d in the Error** errp struct, so it is printed correctly: $ ./qemu-img create -f qcow2 overlay -b ssh://xen/ qemu-img: overlay: address resolution failed for xen:22: No address associated with hostname Signed-off-by: Richard W.M. Jones Reported-by: Jun Li BZ: https://bugzilla.redhat.com/sh

[Qemu-devel] Super nested KVM

2014-07-03 Thread Richard W.M. Jones
If you have odd Intel or AMD hardware, I'd appreciate if you could test my disk image which recursively launches nested KVM until something breaks: http://rwmj.wordpress.com/2014/07/03/super-nested-kvm/#content FWIW: * AMD FX(tm)-8320 Eight-Core Processor: L3 guest fails to boot with [ 30

Re: [Qemu-devel] Super nested KVM

2014-07-03 Thread Richard W.M. Jones
On Thu, Jul 03, 2014 at 06:34:33PM +0100, Richard W.M. Jones wrote: > There's also a TCG-only mode, but the test ran so slowly as to be > inconclusive. I might leave it going overnight. Well I got bored with the TCG test after about 4 hours. It appears to hang launching t

Re: [Qemu-devel] Super nested KVM

2014-07-04 Thread Richard W.M. Jones
On Fri, Jul 04, 2014 at 04:17:11PM +0400, Vasiliy Tolstov wrote: > 2014-07-04 1:00 GMT+04:00 Richard W.M. Jones : > > Well I got bored with the TCG test after about 4 hours. It appears to > > hang launching the L3 guest, reproducible on two different hosts both > > running q

[Qemu-devel] [PATCH] Detect zero writes (for discussion only, not to be applied)

2012-07-26 Thread Richard W.M. Jones
[Applies against qemu 1.1.0, not HEAD, because qemu from git seems to be broken at the moment. But the patch is easy to rebase.] This patch adds a -drive detect_zero=on|off flag (defaults to "off"). Setting this on causes the write path to detect all zero byte writes and, for block device driver

[Qemu-devel] [PATCH] block: Add -drive detect_zero=on|off option to detect all zero writes.

2012-07-26 Thread Richard W.M. Jones
From: "Richard W.M. Jones" This change adds a new block device option, "detect_zero=on|off". If "detect_zero=on" then when a guest writes sectors that contain all zero bytes, we call the internal "bdrv_co_write_zeroes" function instead of the standard

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Richard W.M. Jones
On Thu, Jul 26, 2012 at 01:22:15PM -0500, anth...@codemonkey.ws wrote: > We had a violent^Wheated discussion on IRC about how to move forward > with Luiz's proposed error series. I think we reached consensus. This > note attempts to outline that. > > Principles > -- > 1. Errors should be

Re: [Qemu-devel] [PATCH] Detect zero writes (for discussion only, not to be applied)

2012-07-27 Thread Richard W.M. Jones
On Fri, Jul 27, 2012 at 08:55:31AM -0500, Anthony Liguori wrote: > "Richard W.M. Jones" writes: > > > [Applies against qemu 1.1.0, not HEAD, because qemu from git seems to > > be broken at the moment. But the patch is easy to rebase.] > > How's it broken

Re: [Qemu-devel] [PATCH] block: Add -drive detect_zero=on|off option to detect all zero writes.

2012-07-30 Thread Richard W.M. Jones
On Fri, Jul 27, 2012 at 09:01:38PM +0200, Paolo Bonzini wrote: > Or just finish up discard support and use the existing fstrim command of > qemu-ga. :) What's actually involved to do this? I noticed that a virtio-scsi on qcow2 v3 device exported to the guest does not appear to support TRIM at al

Re: [Qemu-devel] [PATCH] block: Add -drive detect_zero=on|off option to detect all zero writes.

2012-07-30 Thread Richard W.M. Jones
On Mon, Jul 30, 2012 at 04:38:25PM +0200, Kevin Wolf wrote: > Am 30.07.2012 16:09, schrieb Paolo Bonzini: > > Il 30/07/2012 16:03, Eric Blake ha scritto: > >> Ooh, nice bullet point to add to my upcoming presentation at Linux > >> Plumber's Conference in a month: > >> http://summit.linuxplumberscon

Re: [Qemu-devel] 9p broken?

2012-07-30 Thread Richard W.M. Jones
On Mon, Jul 30, 2012 at 03:35:39PM +0300, Avi Kivity wrote: > Having an annoying bug on i386 kvm I decided to debug it buy running an > i386 guest on my x86_64 host, use 9p to access a guest image, and run it > using nested kvm. > > However, 9p appears to be broken: first, the configure test fails

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-30 Thread Richard W.M. Jones
On Mon, Jul 30, 2012 at 02:41:33PM +0300, Avi Kivity wrote: > - avoid assigned-but-not-used error > - avoid missing return error > > Signed-off-by: Avi Kivity > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 7767aca..5fb4

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-03-31 Thread Richard W.M. Jones
[This time without the massive attachment] On Thu, Mar 31, 2016 at 12:22:23PM -0400, Kevin O'Connor wrote: > On Thu, Mar 31, 2016 at 10:21:25AM +0100, Stefan Hajnoczi wrote: > > On Sat, Mar 19, 2016 at 08:31:24PM +0000, Richard W.M. Jones wrote: > > > Is there something I&

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Thu, Mar 31, 2016 at 06:44:32PM -0400, Kevin O'Connor wrote: > On Thu, Mar 31, 2016 at 11:17:30PM +0100, Richard W.M. Jones wrote: > > I'd dearly love to get rid of the sgabios option ROM. It looks like > > SeaBIOS nearly supports a full serial console now? >

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Thu, Mar 31, 2016 at 06:44:32PM -0400, Kevin O'Connor wrote: > I think you'll find that if you compile out some features from > SeaBIOS, it will be of a similar speed to that "minimal BIOS". Try > this: > > cd /path/to/seabios/ > echo -e > 'CONFIG_USB=n\nCONFIG_DRIVES=n\nCONFIG_KEYBOARD=n\nCO

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 10:11:46AM +0200, Paolo Bonzini wrote: > > > On 01/04/2016 10:02, Richard W.M. Jones wrote: > >> > echo -e > >> > 'CONFIG_USB=n\nCONFIG_DRIVES=n\nCONFIG_KEYBOARD=n\nCONFIG_MOUSE=n\nCONFIG_WRITABLE_UPPERMEMORY=y\nCONFIG_TCGBIOS=

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
Minimal SeaBIOS (+ CONFIG_MPTABLE): http://oirase.annexia.org/tmp/min-seabios.txt Stock SeaBIOS from qemu: http://oirase.annexia.org/tmp/stock-seabios.txt Both files best viewed with `less -r'. It does appear to considerably reduce SeaBIOS time. Rich. -- Richard Jones, Virtualization Group,

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 10:24:37AM +0200, Paolo Bonzini wrote: > On 01/04/2016 10:14, Richard W.M. Jones wrote: > > Found it: only CONFIG_MPTABLE=y was necessary. It boots with: > > > > # CONFIG_PIRTABLE is not set > > CONFIG_MPTABLE=y > > # CONFIG_SMBIOS is not

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 10:03:10AM +0200, Paolo Bonzini wrote: > > > On 01/04/2016 09:55, Richard W.M. Jones wrote: > >>> > > I'd dearly love to get rid of the sgabios option ROM. It looks like > >>> > > SeaBIOS nearly supports a full serial con

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 10:51:31AM +0200, Paolo Bonzini wrote: > > > On 01/04/2016 10:47, Richard W.M. Jones wrote: > > It's so we can handle error reports. When someone reports that > > libguestfs "hangs", it's sometimes useful to know if the BIOS wa

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 11:18:30AM +0200, Gerd Hoffmann wrote: > Hi, > > > I wonder how we can make use of this in qemu and downstream distros? > > Can we have a bios-min.bin which is used with -kernel boots? > > We already build two seabios roms: one full featued and one slightly > stripped do

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 01:07:55PM +0200, Gerd Hoffmann wrote: > On Fr, 2016-04-01 at 11:17 +0100, Richard W.M. Jones wrote: > > On Fri, Apr 01, 2016 at 11:18:30AM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > I wonder how we can make use

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
tion blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html >From 28a442fdf8036bde075c75088f8dae8d8568243a Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Fri, 1 Apr 2016 11:35:09 +0100 Subject: [PATCH] bios: Add fast var

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 01:21:38PM +0200, Paolo Bonzini wrote: > > > On 01/04/2016 13:20, Richard W.M. Jones wrote: > > +# MPTABLE is required by Linux kernel, the others add only a > > +# couple of milliseconds so we might as well have them > > +CONFIG_PIRTA

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
oup, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html >From 8cdf91f13949ab46c6a5804b968400d404c4e00e Mon Sep 17 00:00:00 2001 From: "Richard W.M.

[Qemu-devel] [PATCH v4.1] Add optionrom compatible with fw_cfg DMA version

2016-04-01 Thread Richard W.M. Jones
This is an updated version of Marc Marí's Linux DMA patch, based on version 4 from: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg05891.html All I have done for my "4.1" version is: - Modify it so it compiles against the latest qemu. There was a change to how fw_cfg.h is split (6

[Qemu-devel] [PATCH v4.1] Add optionrom compatible with fw_cfg DMA version

2016-04-01 Thread Richard W.M. Jones
From: Marc Marí This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí Signed-off-by: Richard W.M. Jones --- .gitignore| 4 + hw/i386/pc.c | 9 +- hw/nvram/fw_cfg.c | 2 +- include/hw/nvram/fw_cfg.h | 1

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 10:58:19AM -0400, Kevin O'Connor wrote: > On Fri, Apr 01, 2016 at 09:44:56AM +0100, Richard W.M. Jones wrote: > > On Fri, Apr 01, 2016 at 10:24:37AM +0200, Paolo Bonzini wrote: > > > On 01/04/2016 10:14, Richard W.M. Jones wrote: > > > >

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 11:35:40AM -0400, Kevin O'Connor wrote: > > +# general stuff > > +CONFIG_QEMU=y > > +CONFIG_ROM_SIZE=128 > > Why force a size of 128K - I would think 64K would be fine. Agreed. Setting this to =0 seems the best thing, and it does fit fine inside 64K. > > +# no input, no

Re: [Qemu-devel] Why is SeaBIOS used with -kernel?

2016-04-01 Thread Richard W.M. Jones
On Fri, Apr 01, 2016 at 07:41:31PM +0100, Richard W.M. Jones wrote: > Below are some benchmarks of the other things you mentioned. These > are complete appliance boot-to-shutdown times [*not* just SeaBIOS]. > All debugging has been disabled, and I'm using a slightly different > k

<    1   2   3   4   5   6   7   8   9   10   >