Re: [Qemu-devel] [PATCH v3 0/5] add support for spice migration v3

2012-08-21 Thread Michal Privoznik
On 21.08.2012 10:51, Yonit Halperin wrote: > v3: > patch 2: hold a global variable for the state of spice display, instead of > one per > device. > > v2: > Notify spice about vm state changes only via spice_server_vm_start/stop > spice repo: > http://cgit.freedesktop.org/~yhalperi/spic

[Qemu-devel] [PATCH] qemu-ga: report success-response field in guest-info

2012-08-21 Thread Michal Privoznik
This is a useful hint for users (or libvirt) whether a command returns anything success and hence wait for reply or not. --- qapi-schema-guest.json |6 +- qapi/qmp-core.h|1 + qapi/qmp-registry.c| 12 qga/commands.c |1 + 4 files changed, 19 inser

[Qemu-devel] [PATCH v2] qemu-ga: report success-response field in guest-info

2012-08-21 Thread Michal Privoznik
This is a useful hint for users (or libvirt) whether a command returns anything success and hence wait for reply or not. --- diff to v1: -changed condition in qmp_command_reports_success per Paolo's advice qapi-schema-guest.json |6 +- qapi/qmp-core.h|1 + qapi/qmp-registry.c

[Qemu-devel] [PATCH for-1.2 v3] qemu-ga: report success-response field in guest-info

2012-08-21 Thread Michal Privoznik
This is a useful hint for users (or libvirt) whether a command returns anything success and hence wait for reply or not. --- diff to v2: -fixed typo and field description diff to v1: -changed condition in qmp_command_reports_success per Paolo's advice qapi-schema-guest.json |6 +- qapi/q

Re: [Qemu-devel] [PATCH for-1.2 v3] qemu-ga: report success-response field in guest-info

2012-08-21 Thread Michal Privoznik
On 21.08.2012 14:39, Michal Privoznik wrote: > This is a useful hint for users (or libvirt) whether a command returns > anything success and hence wait for reply or not. Signed-off-by: Michal Privoznik > --- > diff to v2: > -fixed typo and field description > > diff to v1:

Re: [Qemu-devel] [PATCH 0/5] support guest agent general command

2012-08-21 Thread Michal Privoznik
On 08.08.2012 16:36, Eric Blake wrote: > [adding qemu-devel, for a qemu-ga question] > > On 08/07/2012 06:04 PM, MATSUDA, Daiki wrote: >> Hi, All. >> >> I rewrote the patches as Eric suggested. >> >> >> >> virsh # help qemu-agent-command >> NAME >> qemu-agent-command - Qemu Guest Agent Comma

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Michal Privoznik
On 26.01.2012 20:35, Luiz Capitulino wrote: > On Thu, 26 Jan 2012 08:18:03 -0700 > Eric Blake wrote: > >> [adding qemu-devel] >> >> On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing, that you'll probably notice is this 'set-support-level' command. Basically, it tells GA what q

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Michal Privoznik
On 30.01.2012 15:44, Luiz Capitulino wrote: > On Mon, 30 Jan 2012 07:54:56 -0600 > Anthony Liguori wrote: > >> On 01/30/2012 06:57 AM, Luiz Capitulino wrote: >>> On Thu, 26 Jan 2012 16:57:01 -0600 >>> Anthony Liguori wrote: >>> On 01/26/2012 01:35 PM, Luiz Capitulino wrote: > On Thu, 26

Re: [Qemu-devel] [PATCH v2] qemu-ga: add guest-sync-delimited

2012-02-07 Thread Michal Privoznik
On 07.02.2012 02:09, Michael Roth wrote: > guest-sync leaves it as an exercise to the user as to how to reliably > obtain the response to guest-sync if the client had previously read in a > partial response (due qemu-ga previously being restarted mid-"sentence" > due to reboot, forced restart, etc)

[Qemu-devel] [PATCH] qemu-ga: Add guest-getip command

2012-02-16 Thread Michal Privoznik
This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik --- qapi-schema-guest.json | 16 + qga/guest-agent-commands.c

Re: [Qemu-devel] [PATCH] qemu-ga: Add guest-getip command

2012-02-17 Thread Michal Privoznik
On 16.02.2012 21:10, Michael Roth wrote: > On Thu, Feb 16, 2012 at 06:25:03PM +0100, Michal Privoznik wrote: >> This command returns an array of: >> >> [ifname, ipaddr, ipaddr_family, prefix, hwaddr] >> >> for each interface in the system that has an IP address.

[Qemu-devel] [PATCH v2] qemu-ga: Add guest-network-info command

2012-02-17 Thread Michal Privoznik
This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik --- diff to v1: -move from guest-getip to guest-network-info -replace black

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add guest-network-info command

2012-02-17 Thread Michal Privoznik
On 17.02.2012 12:35, Michal Privoznik wrote: > This command returns an array of: > > [ifname, ipaddr, ipaddr_family, prefix, hwaddr] > > for each interface in the system that has an IP address. > Currently, only IPv4 and IPv6 are supported. > > Signed-off-by: Michal Pr

[Qemu-devel] [PATCH v3] qemu-ga: Add guest-network-info command

2012-02-17 Thread Michal Privoznik
This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik --- diff to v2: -Properly set IP addr family for IPv6 diff to v1: -move from

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Michal Privoznik
On 19.12.2012 16:58, Gerd Hoffmann wrote: > Hi, > > Chardev hotplug patch series reloaded. Not finished yet, commit > messages not finalized yet, totally untested other than building on > linux+windows. > > I doubt I manage to finish (and test!) it before xmas. Nevertheless I > wanna get the

[Qemu-devel] [PATCH] qemu-ga: Extend guest-network-get-interfaces

2012-12-21 Thread Michal Privoznik
Nowadays only basic information is reported. However, with the current implementation much more can be exposed to users. like broadcast/destination address (the former in case of standard ethernet device, the latter in case of PPP interface), if the interface is up, of type loopback, in promisc mod

Re: [Qemu-devel] [PATCH] qemu-ga: Extend guest-network-get-interfaces

2013-01-02 Thread Michal Privoznik
On 21.12.2012 19:43, Eric Blake wrote: > On 12/21/2012 05:59 AM, Michal Privoznik wrote: >> Nowadays only basic information is reported. However, with the >> current implementation much more can be exposed to users. like >> broadcast/destination address (the former in case of

Re: [Qemu-devel] [PATCH] build: remove *.lo, *.a, *.la files from all subdirectories on make clean

2013-01-25 Thread Michal Privoznik
3 deletions(-) Reviewed-by: Michal Privoznik

[Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-25 Thread Michal Privoznik
Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly using the HMP version. --- qmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index cbf1280..870ee54 100644 --- a/qmp-

Re: [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-25 Thread Michal Privoznik
On 25.01.2013 14:55, Markus Armbruster wrote: > Michal Privoznik writes: > >> Currently, we are using 'tray_open' in QMP and 'tray-open' in >> HMP. However, the QMP documentation was mistakenly using the >> HMP version. > > Could you point me to

[Qemu-devel] [PATCH v2] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-29 Thread Michal Privoznik
Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly using the HMP version. Signed-off-by: Michal Privoznik --- diff to v1: -add S-o-b line qmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[Qemu-devel] [PATCH] configure: Undefine _FORTIFY_SOURCE prior using it

2013-01-31 Thread Michal Privoznik
Currently, we are enforcing the _FORTIFY_SOURCE=2 without any previous detection if the macro has been already defined, e.g. by environment, or is just enabled by compiler by default. Signed-off-by: Michal Privoznik --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH] configure: Undefine _FORTIFY_SOURCE prior using it

2013-02-01 Thread Michal Privoznik
On 01.02.2013 10:54, Andreas Färber wrote: > Am 31.01.2013 11:15, schrieb Michal Privoznik: >> Currently, we are enforcing the _FORTIFY_SOURCE=2 without any >> previous detection if the macro has been already defined, e.g. >> by environment, or is just enabled by compiler by

[Qemu-devel] [PATCH] sandbox: Report error on forbidden system call

2013-02-05 Thread Michal Privoznik
Currently, it we call a not white listed system call, we get killed immediately without reporting any error. It would be far more useful, if we can at least shout something on stderr just before dying, so users know it is because of sandbox, not just random quit. Signed-off-by: Michal Privoznik

Re: [Qemu-devel] [PATCH] sandbox: Report error on forbidden system call

2013-02-06 Thread Michal Privoznik
On 05.02.2013 15:28, Corey Bryant wrote: > > On 02/05/2013 06:02 AM, Michal Privoznik wrote: >> Currently, it we call a not white listed system call, we get killed >> immediately without reporting any error. It would be far more useful, >> if we can at least shout somethi

Re: [Qemu-devel] [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-26 Thread Michal Privoznik
On 25.09.2012 19:08, Doug Goldstein wrote: > On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange > wrote: >> On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: >>> On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: >>>> On Tue, Sep 25, 2012 at 02:49:0

Re: [Qemu-devel] [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-26 Thread Michal Privoznik
On 26.09.2012 22:46, Anthony Liguori wrote: > Michal Privoznik writes: > >> On 25.09.2012 19:08, Doug Goldstein wrote: >>> On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange >>> wrote: >>>> On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wro

Re: [Qemu-devel] [libvirt] [PATCH v2 1/4] config: Introduce for SPICE graphics

2012-09-19 Thread Michal Privoznik
On 15.09.2012 17:10, Daniel P. Berrange wrote: > On Fri, Sep 14, 2012 at 05:23:16PM -0600, Eric Blake wrote: >> [adding qemu] >> >> On 09/14/2012 11:47 AM, Daniel P. Berrange wrote: >>> On Fri, Sep 14, 2012 at 07:34:50PM +0200, Michal Privoznik wrote: >>>>

Re: [Qemu-devel] [libvirt] [PATCH v2 1/4] config: Introduce for SPICE graphics

2012-09-19 Thread Michal Privoznik
On 19.09.2012 16:25, Daniel P. Berrange wrote: > On Wed, Sep 19, 2012 at 03:26:49PM +0200, Michal Privoznik wrote: >> On 15.09.2012 17:10, Daniel P. Berrange wrote: >>> On Fri, Sep 14, 2012 at 05:23:16PM -0600, Eric Blake wrote: >>>> [adding qemu] >>>

[Qemu-devel] [PATCH] configure: Require at least spice-protocol-0.12.3

2013-02-28 Thread Michal Privoznik
As of 5a49d3e9 we assume SPICE_PORT_EVENT_BREAK to be defined. However, it is defined not in 0.12.2 what we require now, but in 0.12.3. Therefore in order to prevent build failure we must adjust our minimal requirements. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [Qemu-devel] [libvirt] [PATCH] qemu: Drop qemuDomainMemoryLimit

2013-08-19 Thread Michal Privoznik
On 09.08.2013 18:29, Daniel P. Berrange wrote: > On Fri, Aug 09, 2013 at 10:58:55AM -0500, Anthony Liguori wrote: >> Michal Privoznik writes: >> >>> [CC'ing qemu-devel list] >>> On 09.08.2013 15:17, Daniel P. Berrange wrote: >>>> On Fri,

Re: [Qemu-devel] [libvirt] [PATCH] qemu: Drop qemuDomainMemoryLimit

2013-08-19 Thread Michal Privoznik
On 19.08.2013 11:06, Daniel P. Berrange wrote: > On Mon, Aug 19, 2013 at 10:29:10AM +0200, Michal Privoznik wrote: >> On 09.08.2013 18:29, Daniel P. Berrange wrote: >>> On Fri, Aug 09, 2013 at 10:58:55AM -0500, Anthony Liguori wrote: >>>> Michal Privoznik writes:

[Qemu-devel] [PATCH RESEND] configure: Undefine _FORTIFY_SOURCE prior using it

2013-09-05 Thread Michal Privoznik
Currently, we are enforcing the _FORTIFY_SOURCE=2 without any previous detection if the macro has been already defined, e.g. by environment, or is just enabled by compiler by default. Signed-off-by: Michal Privoznik --- The issue still happens thus the patch is still valid. configure | 2

Re: [Qemu-devel] GSoC 2013, "Introduce API to query IP addresses for given domain" Libvirt project

2013-04-10 Thread Michal Privoznik
On 10.04.2013 11:12, Stefan Hajnoczi wrote: > On Wed, Apr 10, 2013 at 04:46:45AM +0200, Tabibel Sami wrote: >> I am doing master degree of Cryptology and information security >> I have good C and Python skills, and i am interested to work on >> "Introduce API to query IP addresses for given domain"

Re: [Qemu-devel] [PATCH] tap: properly initialize vhostfds

2013-04-19 Thread Michal Privoznik
> check > also. > > Reportyed-by: Michal Privoznik Typo > Cc: Michal Privoznik > Cc: qemu-sta...@nongnu.org > Signed-off-by: Jason Wang > --- > net/tap.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/tap.c b/net/tap.c > index

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Undefine _FORTIFY_SOURCE prior using it

2013-04-23 Thread Michal Privoznik
On 06.02.2013 16:09, Paolo Bonzini wrote: > Il 06/02/2013 15:49, Stefan Hajnoczi ha scritto: I don't think that's necessary. The 2nd level is the highest one [1] or [2]. It seems like in my case it's compiler who's defining the macro: $ echo "int main() {return 0;}" | gcc

[Qemu-devel] Virtioserial changed behavior after f7f7464afdb9f

2013-04-25 Thread Michal Privoznik
I've noticed some strange behavior after the commit from $subj: $ qemu-system-x86_64 -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x7 \ -device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel0,id=channel0,name=org.qemu.guest_agent.0 qemu-system-x86_64: -device virts

Re: [Qemu-devel] [libvirt] [PATCHv2 libvirt] qemu: Issue rtc-reset-reinjection command after guest-set-time

2014-08-18 Thread Michal Privoznik
On 18.08.2014 17:28, Eric Blake wrote: On 08/14/2014 02:24 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1103245 An advice appeared there on the qemu-devel list [1]. When a domain is suspended and then resumed guest kernel is not aware of this. So we've intro

Re: [Qemu-devel] [libvirt] [PATCHv2 libvirt] qemu: Issue rtc-reset-reinjection command after guest-set-time

2014-08-20 Thread Michal Privoznik
On 19.08.2014 19:23, Marcelo Tosatti wrote: On Tue, Aug 19, 2014 at 11:00:26AM -0600, Eric Blake wrote: On 08/19/2014 10:57 AM, Marcelo Tosatti wrote: rtc-reset-reinjection has been introduced because certain Windows versions will advance the guest system time (via rtc interrupt reinjection).

Re: [Qemu-devel] [libvirt] [PATCH] qemu: Drop qemuDomainMemoryLimit

2013-08-09 Thread Michal Privoznik
[CC'ing qemu-devel list] On 09.08.2013 15:17, Daniel P. Berrange wrote: > On Fri, Aug 09, 2013 at 07:13:58AM -0600, Eric Blake wrote: >> On 08/09/2013 06:56 AM, Michal Privoznik wrote: >>> This function is to guess the correct limit for maximal memory >>> usage by

[Qemu-devel] [PATCH] util: Improve os_mem_prealloc error message

2014-10-16 Thread Michal Privoznik
>From the error message it's not clear at the first glance where the problem lies. However, changing the error message might give uses a clue. Signed-off-by: Michal Privoznik --- util/oslib-posix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/oslib-posix.

Re: [Qemu-devel] is qemu-2.1 support 1G hugepage

2014-10-26 Thread Michal Privoznik
On 24.10.2014 10:22, Linhaifeng wrote: Hi, I run qemu2.1 with 1G hugepage and found that VM can't start (too slowly?) but can start with 2M hugepage quickly. kernel version:3.10.0-123.6.3.el7.x86_64 command:qemu-kvm -name vm1 -enable-kvm -smp 2 -m 2048 -object memory-backend-file,id=mem,size

Re: [Qemu-devel] [libvirt] NBD TLS support in QEMU

2014-09-04 Thread Michal Privoznik
On 03.09.2014 18:44, Stefan Hajnoczi wrote: Hi, QEMU offers both NBD client and server functionality. The NBD protocol runs unencrypted, which is a problem when the client and server communicate over an untrusted network. This is not problem for NBD only, but for the rest of data that qemu se

[Qemu-devel] Is guest agent socket being closed upon reboot?

2012-01-16 Thread Michal Privoznik
Hi, I'd like you to ask if/why is guest agent socked being closed upon guest reboot. I am using virtserialport to talk to guest agent: -chardev socket,id=charchannel0,path=/var/lib/libvirt/qemu/f16x86_64.agent,server,nowait -device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel0,id=

[Qemu-devel] Is guest agent socket being closed upon reboot?

2012-01-16 Thread Michal Privoznik
Hi, I'd like you to ask if/why is guest agent socked being closed upon guest reboot. I am using virtserialport to talk to guest agent: -chardev socket,id=charchannel0,path=/var/lib/libvirt/qemu/f16x86_64.agent,server,nowait -device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel0,id=

[Qemu-devel] Guest-sync-delimited and sentinel issue

2012-03-16 Thread Michal Privoznik
Hi guys, I was just implementing support for guest-sync-delimited into libvirt. My intent is to issue this command prior any other command to determine if GA is available or not. The big advantage is - it doesn't change the state of the guest so from libvirt POV it's harmless. The other big adv

Re: [Qemu-devel] Guest-sync-delimited and sentinel issue

2012-03-16 Thread Michal Privoznik
On 16.03.2012 15:49, Michael Roth wrote: > On Fri, Mar 16, 2012 at 01:47:42PM +0100, Michal Privoznik wrote: >> Hi guys, >> >> I was just implementing support for guest-sync-delimited into libvirt. My >> intent is to issue this command prior any other command to deter

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-20 Thread Michal Privoznik
On 18.03.2012 02:09, Brad Smith wrote: > Michal, > > http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 > > > This broke the build. Un-break the tree. > Can you please be more specific? It works for me so I don't have a clue what are you referring to. I mean,

[Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only

2012-03-20 Thread Michal Privoznik
Currently, the implementation of that command is full of Linux specific code. Before any brave man will step into and port it to other OSes, make this function Linux only. Signed-off-by: Michal Privoznik --- qga/commands-posix.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions

Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only

2012-03-20 Thread Michal Privoznik
On 20.03.2012 17:10, Michael Roth wrote: > On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote: >> Currently, the implementation of that command is full of >> Linux specific code. Before any brave man will step into >> and port it to other OSes, make thi

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Michal Privoznik
On 25.03.2012 03:19, Brad Smith wrote: > On 20/03/12 9:28 AM, Brad Smith wrote: >> On 20/03/12 6:14 AM, Michal Privoznik wrote: >>> On 18.03.2012 02:09, Brad Smith wrote: >>>> Michal, >>>> >>>> http://git.qemu.org/?p=qemu.g

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Michal Privoznik
On 26.03.2012 17:18, Anthony Liguori wrote: > On 03/26/2012 10:15 AM, Michael Roth wrote: >> On Mon, Mar 26, 2012 at 09:55:15AM -0500, Anthony Liguori wrote: >> >> Yup, I can't confirm the BSD fix atm though, only that it doesn't >> break builds >> on linux/w32. Send anyway or wait for confirmation

Re: [Qemu-devel] [PATCH v2 1/2] qemu-ga: make names more generic for mount list functions

2012-06-13 Thread Michal Privoznik
On 13.06.2012 07:41, Paolo Bonzini wrote: > We will use these functions and types for more than FSFREEZE, so rename them. > > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Michal Privoznik > qga/commands-posix.c | 36 ++-- > 1 file chan

Re: [Qemu-devel] [PATCH v2 2/2] qemu-ga: add guest-fstrim command

2012-06-13 Thread Michal Privoznik
# dd if=/dev/zero of=/run/media/pbonzini/test/file > # cat map > 1-616,645-1588,1599-4026,4029-16383 > # rm /run/media/pbonzini/test/file > # ./qemu-ga /dev/fd/0 > {"execute":"guest-fstrim"} > {"return": {}} > # cat

[Qemu-devel] [PATCH 0/2] qemu_agent: Switch to event driven impl

2012-06-15 Thread Michal Privoznik
on of success. Michal Privoznik (2): qemu_agent: Add some more debug prints qemu_agent: Wait for events instead of agent response src/qemu/qemu_agent.c | 52 +- src/qemu/qemu_agent.h |9 src/qemu/qemu_process.c |9 3

[Qemu-devel] [PATCH 2/2] qemu_agent: Wait for events instead of agent response

2012-06-15 Thread Michal Privoznik
With latest changes to qemu-ga success on some commands is not reported anymore, e.g. guest-shutdown or guest-suspend-*. However, errors are still being reported. Therefore, we need to find different source of indication if operation was successful. Events. --- src/qemu/qemu_agent.c | 49 +

[Qemu-devel] [PATCH 1/2] qemu_agent: Add some more debug prints

2012-06-15 Thread Michal Privoznik
for agent ref count and qemuProcessHandleAgentDestroy --- src/qemu/qemu_agent.c |3 ++- src/qemu/qemu_process.c |2 ++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index bc4ceff..36610c2 100644 --- a/src/qemu/qemu_agent.c ++

Re: [Qemu-devel] [libvirt] [PATCH 2/2] qemu_agent: Wait for events instead of agent response

2012-06-16 Thread Michal Privoznik
On 15.06.2012 19:16, Eric Blake wrote: > On 06/15/2012 10:10 AM, Michal Privoznik wrote: >> With latest changes to qemu-ga success on some commands is not reported >> anymore, e.g. guest-shutdown or guest-suspend-*. However, errors are >> still being reported. Therefore, we n

Re: [Qemu-devel] [libvirt] [PATCH 7/8] block: add witness argument to drive-reopen

2012-04-17 Thread Michal Privoznik
On 17.04.2012 14:09, Eric Blake wrote: > [adding libvir-list for some interesting discussions on potential > libvirt design issues] > > On 04/17/2012 12:47 AM, Paolo Bonzini wrote: >> Il 16/04/2012 23:55, Eric Blake ha scritto: Do transient guests have persistent storage for them in /var whil

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-20 Thread Michal Privoznik
On 19.04.2012 21:34, Luiz Capitulino wrote: > On Thu, 19 Apr 2012 13:57:48 -0500 > Michael Roth wrote: > >> On Thu, Apr 19, 2012 at 02:36:53PM -0300, Luiz Capitulino wrote: >>> Michael, >>> >>> I'm going to revive this topic one more time. I was working on v2 of my >>> fixes >>> to the suspend r

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-23 Thread Michal Privoznik
On 20.04.2012 15:36, Luiz Capitulino wrote: > On Fri, 20 Apr 2012 14:07:16 +0200 > Michal Privoznik wrote: > >>>> But, I think if we tell users we'll *only* send response on error, >>>> we should do our part to *not* send the responses, rather than relyi

[Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-19 Thread Michal Privoznik
This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik --- diff to v3: -use ctpop32() instead of separate count_one_bits() diff to

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-22 Thread Michal Privoznik
On 19.02.2012 12:15, Michal Privoznik wrote: > This command returns an array of: > > [ifname, ipaddr, ipaddr_family, prefix, hwaddr] > > for each interface in the system that has an IP address. > Currently, only IPv4 and IPv6 are supported. > > Signed-off-by: Michal Pr

[Qemu-devel] qemu-ga error reporting

2012-02-23 Thread Michal Privoznik
Hi guys, I ran into weird issue. Issuing unknown-command on qemu monitor gives this: {"error": {"class": "CommandNotFound", "desc": "The command unknown-command has not been found", "data": {"name": "unknown-command"}}} However, issuing the very same on GA socket gets me: {"error": {"class": "

Re: [Qemu-devel] [libvirt] Add GSoC project ideas to the wiki!

2012-02-24 Thread Michal Privoznik
On 24.02.2012 10:19, Stefan Hajnoczi wrote: > This is a reminder that QEMU will apply for Google Summer of Code 2012 and we > need project ideas and mentors. Libvirt and kvm.ko projects are also welcome! > > http://wiki.qemu.org/Google_Summer_of_Code_2012 > > Please add yourself to the wiki now

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-27 Thread Michal Privoznik
On 23.02.2012 15:20, Luiz Capitulino wrote: > On Sun, 19 Feb 2012 12:15:43 +0100 > Michal Privoznik wrote: > >> This command returns an array of: >> >> [ifname, ipaddr, ipaddr_family, prefix, hwaddr] >> >> for each interface in the system that has an IP ad

[Qemu-devel] [PATCH v5] qemu-ga: Add guest-network-info command

2012-02-28 Thread Michal Privoznik
This command returns an array of: [ifname, hwaddr, [ipaddr, ipaddr_family, prefix] ] for each interface in the system. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik --- diff to v4: -change return type diff to v3: -use ctpop32() instead of separate

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-29 Thread Michal Privoznik
On 28.02.2012 18:41, Luiz Capitulino wrote: >> Hmm, I know Michal already sent a new version with my suggestions, but >> > you're right, splitting out the commands simplified both the responses, >> > and makes it easier to discover whether or not that information is >> > available, since you can lo

[Qemu-devel] [PATCH v6] qemu-ga: Add guest-network-get-interfaces command

2012-02-29 Thread Michal Privoznik
This command returns an array of: [ifname, hwaddr, [ipaddr, ipaddr_family, prefix] ] for each interface in the system. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik --- diff to v5: -another change of command diff to v4: -change return type diff to v3: -use

Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-05 Thread Michal Privoznik
On 02.03.2012 16:49, Hans de Goede wrote: > VCARD_ATR_PREFIX is used as part of an array initializer so it should > not have () around it, so far this happened to work, but gcc-4.7 does > not like it. Neither do gcc-4.6.2.

Re: [Qemu-devel] [PATCH v6] qemu-ga: Add guest-network-get-interfaces command

2012-03-06 Thread Michal Privoznik
On 29.02.2012 17:02, Michal Privoznik wrote: > This command returns an array of: > > [ifname, hwaddr, [ipaddr, ipaddr_family, prefix] ] > > for each interface in the system. > Currently, only IPv4 and IPv6 are supported. > > Signed-off-by: Michal Privoznik > -

Re: [Qemu-devel] [PATCH] qga: trivial fix for unclear document of guest-set-time

2014-04-03 Thread Michal Privoznik
On 04.04.2014 02:53, Amos Kong wrote: We mixedly used "guest time", "system time", "hardware time", "RTC" in document, it's unclear. This patch just added two remarks of RTC and replace two "guest time" by "guest's system

Re: [Qemu-devel] [PATCH v2] qga: Don't require 'time' argument in guest-set-time command

2014-02-13 Thread Michal Privoznik
On 31.01.2014 19:12, Eric Blake wrote: On 01/31/2014 03:29 AM, Michal Privoznik wrote: As the description to the guest-set-time states, the command is there to ease time synchronization after resume. If guest was suspended for longer period of time, its system time can go off so badly, that

Re: [Qemu-devel] [libvirt-users] Adjust disk image migration (NBD)

2014-02-14 Thread Michal Privoznik
On 14.02.2014 10:40, Joaquim Barrera wrote: > Hi all, > > As I am doing some tests with qemu, I realized that the way it does > 'migrate -i tcp:DEST:444' is not the same as 'libvirt migrate > --copy-storage-inc'. Basically qemu uses the same stream as RAM > migration and libvirt takes advantage

[Qemu-devel] [PATCH] qga: Don't require 'time' argument in guest-set-time command

2014-01-28 Thread Michal Privoznik
e($now_from_rtc) Signed-off-by: Michal Privoznik --- Notes: I wasn't sure about enforcing Windows to fetch time from RTC. But I've found this site [1] which seems to presume that GetSystemTime() reads RTC. Although within the page you'll find GetSystemTimeAsFileTi

[Qemu-devel] [PATCH v2] qga: Don't require 'time' argument in guest-set-time command

2014-01-31 Thread Michal Privoznik
e($now_from_rtc) Signed-off-by: Michal Privoznik --- diff to v1: -Fix checkpatch.pl warnings qga/commands-posix.c | 41 + qga/commands-win32.c | 34 +++--- qga/qapi-schema.json | 9 + 3 files changed, 53 insertions(+

Re: [Qemu-devel] [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-04 Thread Michal Privoznik
On 03.02.2014 08:45, Stefan Hajnoczi wrote: KVM & libvirt: you are welcome to join the QEMU umbrella organization like last year. I've updated wiki with a libvirt idea. But I can sense more to come later as I have some time to think about it :) Michal

[Qemu-devel] [PATCH 1/3] qapi-schema: Make @password in set_password optional

2015-02-17 Thread Michal Privoznik
w this will work, is: if user issues the command without the password field, it means they want to disable the ticketing. Any subsequent call to the call with password field filled in, will enable the ticketing again. Signed-off-by: Michal Privoznik --- hmp-commands.hx | 2 +- hmp.c

[Qemu-devel] [PATCH 3/3] vnc: Implement set_password without password

2015-02-17 Thread Michal Privoznik
provided, the old method is restored. But, what happens if there's no old method? What if no authentication method was provided at the command line? Well, in that case the VNC_AUTH_VNC is set, which boils down to the same state as if the password was put onto command line. Signed-off-by: M

[Qemu-devel] [PATCH 0/3] SPICE/VNC: Allow ticketing on the fly

2015-02-17 Thread Michal Privoznik
dents, but has to set up the environment firstly. So he starts with a password, and then remove it and let students in. Michal Privoznik (3): qapi-schema: Make @password in set_password optional spice: Implement set_password without password vnc: Implement set_password without password hmp-c

[Qemu-devel] [PATCH 2/3] spice: Implement set_password without password

2015-02-17 Thread Michal Privoznik
This is quite easy. SPICE has a function to disable ticketing. So, if no password was provided, call the function, and if a password was provided, call another function to actually set it. Signed-off-by: Michal Privoznik --- ui/spice-core.c | 15 +-- 1 file changed, 13 insertions

Re: [Qemu-devel] unable to set SATA serial with a spaces

2015-02-23 Thread Michal Privoznik
On 23.02.2015 11:18, Markus Armbruster wrote: > Alan Latteri writes: > >> The left padding is important and necessary to keep for my particular >> application. This is broken in libvirt, but works fine with direct >> Qemu invocation. >> >> Thank you for the help. > > Please file a bug against

[Qemu-devel] [PATCH] qemu_opt_get_bool_helper: Fix option handling

2015-01-08 Thread Michal Privoznik
rguments evaluation fails with: qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed. Fix this by dropping the assert() which is useless after the mentioned commit anyway. Signed-off-by: Michal Privoznik --- util/qemu-opt

Re: [Qemu-devel] [libvirt] should active block commit ever be allowed to show 0 total progress?

2015-01-13 Thread Michal Privoznik
On 12.01.2015 23:31, Eric Blake wrote: I was trying to work on a libvirt bug, when I discovered the following: $ qemu-img create -f qcow2 a.qcow2 10M Formatting 'a.qcow2', fmt=qcow2 size=10485760 encryption=off cluster_size=65536 lazy_refcounts=off $ qemu-img create -f qcow2 \ -obacking_file=

[Qemu-devel] [PATCH] qemu-ga-win: Document 'guest-set-time' limitation

2015-01-20 Thread Michal Privoznik
1: http://msdn.microsoft.com/en-us/library/aa908981.aspx Signed-off-by: Michal Privoznik --- qga/qapi-schema.json | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 376e79f..91821ef 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-sc

[Qemu-devel] [PATCH] qemu-ga-win: Fail loudly on bare 'set-time'

2015-01-21 Thread Michal Privoznik
ff-by: Michal Privoznik --- qga/commands-win32.c | 44 ++-- qga/qapi-schema.json | 5 - 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 3bcbeae..4fe45f0 100644 --- a/qga/commands-win32.c +++

[Qemu-devel] Qemu binary and list of supported arches

2015-04-09 Thread Michal Privoznik
Dear list, when trying to solve this bug [1] I've realized qemu is not reporting a list of supported architectures for given binary. I mean, we do have 'query-target' but as I understand it it merely reports only the default architecture. For instance for qemu-system-i386 I get 'i386', for -x86_64

[Qemu-devel] [PATCH 2/2] SMBIOS: Allow users to chose base board type

2015-05-20 Thread Michal Privoznik
So far we only mistakenly claimed support for selecting base board type. This patch finally implements it. There's an enum in SMBIOS specification that lays out all the possible values. Therefore, the type is taken as an integer of the corresponding string value. Signed-off-by: Michal Priv

[Qemu-devel] [PATCH 1/2] pc_init1: Don't misuse int for holding up a bool

2015-05-20 Thread Michal Privoznik
When going through code I realized, that the pc_init1() has this two arguments @pci_enabled and @kvmclock_enabled which despite used as booleans are of int type. Signed-off-by: Michal Privoznik --- hw/i386/pc_piix.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a

[Qemu-devel] [PATCH 0/2] Couple of SMBIOS fixes

2015-05-20 Thread Michal Privoznik
Well, strictly speaking the first is a code cleanup, the second one implements the feature we claimed to have but it wasn't implemented. Michal Privoznik (2): pc_init1: Don't misuse int for holding up a bool SMBIOS: Allow users to chose base board type hw/i386/pc_piix.c | 10

Re: [Qemu-devel] [PATCH 2/2] SMBIOS: Allow users to chose base board type

2015-05-20 Thread Michal Privoznik
On 20.05.2015 11:24, Paolo Bonzini wrote: > > > On 20/05/2015 11:15, Michal Privoznik wrote: >> So far we only mistakenly claimed support for selecting base >> board type. This patch finally implements it. There's an enum in >> SMBIOS specification that

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Michal Privoznik
On 28.05.2015 05:36, Jason Wang wrote: > > > On 05/28/2015 11:21 AM, Jason Wang wrote: >> >> On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote: >>> On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote: > > On 05/27/2015 02:26 PM, Pankaj Gupta wrote: >>> Ping. >>> >>> Can

Re: [Qemu-devel] [RFC 4/7] qemu-agent: add qemuAgentCreateBond interface

2015-05-29 Thread Michal Privoznik
On 17.04.2015 10:53, Chen Fan wrote: > via initialize callback to create bond device. > > Signed-off-by: Chen Fan > --- > src/qemu/qemu_agent.c | 118 > > src/qemu/qemu_agent.h | 10 > src/qemu/qemu_domain.c | 70 +

Re: [Qemu-devel] [patch 0/2] add QMP command to reset rtc interrupt backlog

2014-06-02 Thread Michal Privoznik
On 30.05.2014 16:05, Marcelo Tosatti wrote: It is necessary to reset RTC interrupt backlog if guest time is synchronized via a different mechanism, such as QGA's guest-set-time command. Failing to do so causes both corrections to be applied (summed), resulting in an incorrect guest time. Mar

[Qemu-devel] [PATCH] linux-user: Rework __put_user and __get_user

2014-06-03 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- linux-user/qemu.h | 10 +- linux-user/signal.c | 651 2 files changed, 310 insertions(+), 351 deletions(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 36d4a73..c932abf 100644 --- a/linux-user/qemu.

Re: [Qemu-devel] [libvirt] Call for mentors and project ideas for Google Summer of Code 2016

2016-01-26 Thread Michal Privoznik
On 25.01.2016 18:28, Stefan Hajnoczi wrote: > The QEMU wiki page for Google Summer of Code 2016 is now available here: > > http://qemu-project.org/Google_Summer_of_Code_2016 > > QEMU will apply for Google Summer of Code 2016 (https://g.co/gsoc/). > If QEMU is accepted there will be funding for st

Re: [Qemu-devel] [libvirt] Call for mentors and project ideas for Google Summer of Code 2016

2016-01-27 Thread Michal Privoznik
On 27.01.2016 11:56, Stefan Hajnoczi wrote: > On Tue, Jan 26, 2016 at 11:13:16AM +0100, Michal Privoznik wrote: >> On 25.01.2016 18:28, Stefan Hajnoczi wrote: >>> The QEMU wiki page for Google Summer of Code 2016 is now available here: >>> >>> http://qemu-pr

[Qemu-devel] [PATCH] virtio-blk: Allow startup of empty cdroms

2016-01-06 Thread Michal Privoznik
from virtio_blk_device_realize() where we check if virtio block device has a media inserted. This should, however, be not required for cdroms. Signed-off-by: Michal Privoznik --- hw/block/virtio-blk.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/v

[Qemu-devel] [PATCH] spice/gl: Enable dmabuf only for spice >= 0.13.1

2016-02-24 Thread Michal Privoznik
been released yet, but for sure they are not going to be part of 0.13.0 release (for the ABI stability sake). Signed-off-by: Michal Privoznik --- include/ui/spice-display.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h

[Qemu-devel] Libvirt accepted to GSoC

2016-03-01 Thread Michal Privoznik
Dear community, let me announce great news: Libvirt applied for this year's Google Summer of Code and got accepted [1]! You may recall that in previous years we created a joint organisation with QEMU/KVM folks and participated that way. However, since the number of libvirt students was growing an

  1   2   3   4   >