Re: [PATCH] tests/x86: Add 'q35' machine type to hotplug tests

On 8/26/22 15:39, Denis V. Lunev wrote: On 26.08.2022 13:41, Michael Labiuk wrote: +static void test_q35_pci_unplug_request(void) that seems a little bit wrong. we have pcie test and thus the naming should be appropriate. What about test_pcie_unplug_request()? I don't think so. Device

Re: [PATCH v4 5/7] tests/x86: Add 'q35' machine type to override-tests in hd-geo-test

Thanks for spotting the typo! It should be "q35". On 9/27/22 16:00, Thomas Huth wrote: On 20/09/2022 12.48, Michael Labiuk wrote: Signed-off-by: Michael Labiuk diff --git a/tests/qtest/hd-geo-test.c b/tests/qtest/hd-geo-test.c index 413cf964c0..58b1107d64 100644 --- a/tests/qt

Re: [PATCH v3 2/5] tests/x86: Add 'q35' machine type to ivshmem-test

On 9/19/22 16:13, Denis V. Lunev wrote: On 9/15/22 15:14, Michael Labiuk wrote: diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c index 9611d05eb5..0f9755abc6 100644 --- a/tests/qtest/ivshmem-test.c +++ b/tests/qtest/ivshmem-test.c @@ -378,6 +378,32 @@ static void

[PING PATCH v5] Add 'q35' machine type to hotplug tests

I would like to ping a patch https://patchew.org/QEMU/20220929223547.1429580-1-michael.lab...@virtuozzo.com/ On 9/30/22 01:35, Michael Labiuk via wrote: Add pci bridge setting to run hotplug tests on q35 machine type. Hotplug tests was bounded to 'pc' machine type by commit 7b172

[PATCH] tests/x86: Add 'q35' machine type to hotplug tests

Add pci bridge setting to run hotplug tests on q35 machine type. Hotplug tests was bounded to 'pc' machine type by commit 7b172333f1b Signed-off-by: Michael Labiuk --- tests/qtest/device-plug-test.c | 26 ++ tests/qtest/drive_del-test.c | 111 + tests/qt

[PATCH v2 0/4] Add 'q35' machine type to hotplug tests

Add pci bridge setting to run hotplug tests on q35 machine type. Hotplug tests was bounded to 'pc' machine type by commit 7b172333f1b Michael Labiuk (4): tests/x86: Add subtest with 'q35' machine type to device-plug-test tests/x86: Add 'q35' machine type to ivsh

[PATCH v2 4/4] tests/x86: Add 'q35' machine type to drive_del-test

Configure pci bridge setting Also run tests on 'q35' machine type. Signed-off-by: Michael Labiuk --- tests/qtest/drive_del-test.c | 111 +++ 1 file changed, 111 insertions(+) diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-te

[PATCH v2 1/4] tests/x86: Add subtest with 'q35' machine type to device-plug-test

Configure pci bridge setting to plug pci device and unplug. Signed-off-by: Michael Labiuk --- tests/qtest/device-plug-test.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c index 2e3137843e

[PATCH v2 3/4] tests/x86: Add 'q35' machine type to hd-geo-test

Add pci bridge setting to test hotplug. Duplicate tests for plugging scsi and virtio devices for q35 machine type. Signed-off-by: Michael Labiuk --- tests/qtest/hd-geo-test.c | 148 ++ 1 file changed, 148 insertions(+) diff --git a/tests/qtest/hd-geo-test.c b

[PATCH v2 2/4] tests/x86: Add 'q35' machine type to ivshmem-test

Configure pci bridge setting to test ivshmem on 'q35'. Signed-off-by: Michael Labiuk --- tests/qtest/ivshmem-test.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c index e23a97fa8e..c4ca7ef

[PATCH v5 9/9] tests/x86: Add 'q35' machine type to ivshmem-test

Configure pci bridge setting to test ivshmem on 'q35'. Signed-off-by: Michael Labiuk --- tests/qtest/ivshmem-test.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c index 9611d05eb5..cd550c8935 100644 -

[PATCH v5 3/9] tests/x86: Refactor hot unplug hd-geo-test

Moving common code to function. Signed-off-by: Michael Labiuk --- tests/qtest/hd-geo-test.c | 144 +++--- 1 file changed, 57 insertions(+), 87 deletions(-) diff --git a/tests/qtest/hd-geo-test.c b/tests/qtest/hd-geo-test.c index ba772f4d7a..61f4c24b81 100644

[PATCH v5 7/9] tests/x86: replace snprint() by g_strdup_printf() in drive_del-test

Using g_autofree char* and g_strdup_printf(...) instead of ugly snprintf on stack array. Signed-off-by: Michael Labiuk --- tests/qtest/drive_del-test.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-test.c

[PATCH v5 5/9] tests/x86: Add 'q35' machine type to hotplug hd-geo-test

Add pci bridge setting to test hotplug. Duplicate tests for plugging scsi and virtio devices for q35 machine type. Signed-off-by: Michael Labiuk --- tests/qtest/hd-geo-test.c | 76 ++- 1 file changed, 75 insertions(+), 1 deletion(-) diff --git a/tests/qtest

[PATCH v5 2/9] tests/x86: Add subtest with 'q35' machine type to device-plug-test

Configure pci bridge setting to plug pci device and unplug. Signed-off-by: Michael Labiuk --- tests/qtest/device-plug-test.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c index 3841de1b8c

[PATCH v5 8/9] tests/x86: Add 'q35' machine type to drive_del-test

Configure pci bridge setting to run tests on 'q35' machine type. Signed-off-by: Michael Labiuk --- tests/qtest/drive_del-test.c | 107 +++ 1 file changed, 107 insertions(+) diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-test.c index

[PATCH v5 0/9] Add 'q35' machine type to hotplug tests

-> v3: * Moving helper function process_device_remove() to separate commit. * Refactoring hd-geo-test to avoid code duplication. Michael Labiuk (9): tests/x86: add helper qtest_qmp_device_del_send() tests/x86: Add subtest with 'q35' machine type to device-plug-test tests/x86: Refacto

[PATCH v5 1/9] tests/x86: add helper qtest_qmp_device_del_send()

Move sending 'device_del' command to separate function. Function can be used in case of addition action is needed to start actual removing device after sending command. Signed-off-by: Michael Labiuk --- tests/qtest/device-plug-test.c | 15 ++- tests/qtest/drive_del-tes

[PATCH v5 6/9] tests/x86: Fix comment typo in drive_del-test

Signed-off-by: Michael Labiuk --- tests/qtest/drive_del-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-test.c index 467e752b0d..44b9578801 100644 --- a/tests/qtest/drive_del-test.c +++ b/tests/qtest/drive_del-test.c

[PATCH v5 4/9] tests/x86: Add 'q35' machine type to override-tests in hd-geo-test

Signed-off-by: Michael Labiuk --- tests/qtest/hd-geo-test.c | 97 +++ 1 file changed, 97 insertions(+) diff --git a/tests/qtest/hd-geo-test.c b/tests/qtest/hd-geo-test.c index 61f4c24b81..278464c379 100644 --- a/tests/qtest/hd-geo-test.c +++ b/tests/qtest/hd

[PATCH v3 3/5] tests/x86: Add 'q35' machine type to drive_del-test

Configure pci bridge setting Also run tests on 'q35' machine type. Signed-off-by: Michael Labiuk --- tests/qtest/drive_del-test.c | 111 +++ 1 file changed, 111 insertions(+) diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-te

[PATCH v3 4/5] tests/x86: Add 'q35' machine type to hotplug hd-geo-test

Add pci bridge setting to test hotplug. Duplicate tests for plugging scsi and virtio devices for q35 machine type. Signed-off-by: Michael Labiuk --- tests/qtest/hd-geo-test.c | 148 ++ 1 file changed, 148 insertions(+) diff --git a/tests/qtest/hd-geo-test.c b

[PATCH v3 5/5] tests/x86: Add 'q35' machine type to override-tests in hd-geo-test

Signed-off-by: Michael Labiuk --- tests/qtest/hd-geo-test.c | 105 +++--- 1 file changed, 98 insertions(+), 7 deletions(-) diff --git a/tests/qtest/hd-geo-test.c b/tests/qtest/hd-geo-test.c index 19354690ae..61a92bdbe1 100644 --- a/tests/qtest/hd-geo-test.c +++ b

[PATCH v3 0/5] Add 'q35' machine type to hotplug tests

Add pci bridge setting to run hotplug tests on q35 machine type. Hotplug tests was bounded to 'pc' machine type by commit 7b172333f1b Michael Labiuk (5): tests/x86: Add subtest with 'q35' machine type to device-plug-test tests/x86: Add 'q35' machine type to ivsh

[PATCH v3 1/5] tests/x86: Add subtest with 'q35' machine type to device-plug-test

Configure pci bridge setting to plug pci device and unplug. Move common code for device removing to function. Signed-off-by: Michael Labiuk --- tests/qtest/device-plug-test.c | 83 -- 1 file changed, 58 insertions(+), 25 deletions(-) diff --git a/tests/qtest

[PATCH v3 2/5] tests/x86: Add 'q35' machine type to ivshmem-test

Configure pci bridge setting to test ivshmem on 'q35'. Signed-off-by: Michael Labiuk --- tests/qtest/ivshmem-test.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c index 9611d05eb5..0f9755a

[PATCH v4 4/7] tests/x86: Add 'q35' machine type to drive_del-test

Configure pci bridge setting to run tests on 'q35' machine type. Signed-off-by: Michael Labiuk --- tests/qtest/drive_del-test.c | 111 +++ 1 file changed, 111 insertions(+) diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-test.c index

[PATCH v4 6/7] tests/x86: Refactor hot unplug hd-geo-test

Moving common code to function. Signed-off-by: Michael Labiuk --- tests/qtest/hd-geo-test.c | 133 +++--- 1 file changed, 53 insertions(+), 80 deletions(-) diff --git a/tests/qtest/hd-geo-test.c b/tests/qtest/hd-geo-test.c index 58b1107d64..d488ad9ac0 100644

[PATCH v4 0/7] Add 'q35' machine type to hotplug tests

Add pci bridge setting to run hotplug tests on q35 machine type. Hotplug tests was bounded to 'pc' machine type by commit 7b172333f1b Changes from v3: * Moving helper function process_device_remove() to separate commit. * Refactoring hd-geo-test to avoid code duplication. Michael

[PATCH v4 7/7] tests/x86: Add 'q35' machine type to hotplug hd-geo-test

Add pci bridge setting to test hotplug. Duplicate tests for plugging scsi and virtio devices for q35 machine type. Signed-off-by: Michael Labiuk --- tests/qtest/hd-geo-test.c | 76 +++ 1 file changed, 76 insertions(+) diff --git a/tests/qtest/hd-geo-test.c b

[PATCH v4 2/7] tests/x86: Add subtest with 'q35' machine type to device-plug-test

Configure pci bridge setting to plug pci device and unplug. Signed-off-by: Michael Labiuk --- tests/qtest/device-plug-test.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c index e595b45b66

[PATCH v4 1/7] tests/x86: Move common code to function in device-plug-test

Move common code for device removing to function. Signed-off-by: Michael Labiuk --- tests/qtest/device-plug-test.c | 42 ++ 1 file changed, 17 insertions(+), 25 deletions(-) diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c index

[PATCH v4 3/7] tests/x86: Add 'q35' machine type to ivshmem-test

Configure pci bridge setting to test ivshmem on 'q35'. Signed-off-by: Michael Labiuk --- tests/qtest/ivshmem-test.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-test.c index 9611d05eb5..0f9755a

[PATCH v4 5/7] tests/x86: Add 'q35' machine type to override-tests in hd-geo-test

Signed-off-by: Michael Labiuk --- tests/qtest/hd-geo-test.c | 105 +++--- 1 file changed, 98 insertions(+), 7 deletions(-) diff --git a/tests/qtest/hd-geo-test.c b/tests/qtest/hd-geo-test.c index 413cf964c0..58b1107d64 100644 --- a/tests/qtest/hd-geo-test.c +++ b